Skip to main content
Bumped by Community user
Bumped by Community user
Bumped by Community user
Bumped by Community user
deleted 26 characters in body
Source Link
Toby Speight
  • 81.7k
  • 15
  • 32

I'm preparing to write a question for Code Review (SE) (Thanks, Laurel).

I've written a generic GNU makefile, with the idea that it can be applied to all kinds of C++ projects with different directory structures, etc.

My, hopefully different ;-) , question:

The makefile works. However due to...

(a) The makefile's inherent "genericness"

(b) My possible style errors.

For example, (different context but to illuminate the point) there's a right way to do OOP, some of my early code is a mixture of OOP and imperative, which would be considered 'wrong', but it still compiles and works.

(c) Actual errors (it still works, but this is a fluke)

...there are multiple types of questions I could ask about the same piece of code. For example,

  • Style questions
  • Functionality questions
  • Development questions
  • Best practice questions

Should I ask a separate "code review question" for each 'set of my questions' and post the same code, or just post the code and organise the questions into various 'departments'?

The code itself is small (< 100 lines), but because of its flexible nature (and my possible style/implementation mistakes), the possible questions and solutions it generates is may be larger than one question.

Or should I break the code up into small parts and ask about each section? (I'm guessing the answer is 'No' to that, because context is very useful, plus then the code wouldn't work, it has to be working code.)

The makefile does work, and compiles and links my project fine.

To summarise: If there's a lot of questions about one piece of code, should I ask all the questions in one post, or create many posts with different questions, but all containing the same code?

I'm preparing to write a question for Code Review (SE) (Thanks, Laurel)

I've written a generic GNU makefile, with the idea that it can be applied to all kinds of C++ projects with different directory structures, etc.

My, hopefully different ;-) , question:

The makefile works. However due to...

(a) The makefile's inherent "genericness"

(b) My possible style errors.

For example, (different context but to illuminate the point) there's a right way to do OOP, some of my early code is a mixture of OOP and imperative, which would be considered 'wrong', but it still compiles and works.

(c) Actual errors (it still works, but this is a fluke)

...there are multiple types of questions I could ask about the same piece of code. For example,

  • Style questions
  • Functionality questions
  • Development questions
  • Best practice questions

Should I ask a separate "code review question" for each 'set of my questions' and post the same code, or just post the code and organise the questions into various 'departments'?

The code itself is small (< 100 lines), but because of its flexible nature (and my possible style/implementation mistakes), the possible questions and solutions it generates is may be larger than one question.

Or should I break the code up into small parts and ask about each section? (I'm guessing the answer is 'No' to that, because context is very useful, plus then the code wouldn't work, it has to be working code.)

The makefile does work, and compiles and links my project fine.

To summarise: If there's a lot of questions about one piece of code, should I ask all the questions in one post, or create many posts with different questions, but all containing the same code?

I'm preparing to write a question for Code Review.

I've written a generic GNU makefile, with the idea that it can be applied to all kinds of C++ projects with different directory structures, etc.

My, hopefully different ;-) , question:

The makefile works. However due to...

(a) The makefile's inherent "genericness"

(b) My possible style errors.

For example, (different context but to illuminate the point) there's a right way to do OOP, some of my early code is a mixture of OOP and imperative, which would be considered 'wrong', but it still compiles and works.

(c) Actual errors (it still works, but this is a fluke)

...there are multiple types of questions I could ask about the same piece of code. For example,

  • Style questions
  • Functionality questions
  • Development questions
  • Best practice questions

Should I ask a separate "code review question" for each 'set of my questions' and post the same code, or just post the code and organise the questions into various 'departments'?

The code itself is small (< 100 lines), but because of its flexible nature (and my possible style/implementation mistakes), the possible questions and solutions it generates is may be larger than one question.

Or should I break the code up into small parts and ask about each section? (I'm guessing the answer is 'No' to that, because context is very useful, plus then the code wouldn't work, it has to be working code.)

The makefile does work, and compiles and links my project fine.

To summarise: If there's a lot of questions about one piece of code, should I ask all the questions in one post, or create many posts with different questions, but all containing the same code?

Yes, Meta is the right place to ask about asking questions
Source Link
Toby Speight
  • 81.7k
  • 15
  • 32

Background:

Having been on the Code Review (SE) I then click on the blue box that says it's the Meta Code Review SE:

Link from Code Review SE

And that brings me here, to this site, thus I believe this is the appropriate site, but as it's my first question, perhaps I've made a mistake.

Web site that hosts above link

In summary, go to Code Review SE, click on a meta link. That brings the user here. (Java API, is one subject, which is another indicator, right?)

Reading Robert Longson's link, it's about generic questions. I have specific questions, but due to the nature of the code there are many questions, but pertaining to one piece of code. I can see a subtle difference, and I apologise if I'm not able to explain myself well enough to get that difference over..

Thank you Robert Longson, noob mistake, (although given the above 'evidence' a reasonable mistake !). However, I can't ask the following question, I don't have enough rep...

I'm preparing to write a question for Code Review (SE) (Thanks, LaurelThanks, Laurel)

I've written a generic GNU makefile, with the idea that it can be applied to all kinds of C++ projects with different directory structures, etc.

My, hopefully different ;-) , question:

The makefile works. However due to...

(a) The makefile's inherent "genericness"

(b) My possible style errors.

For example, (different context but to illuminate the point) there's a right way to do OOP, some of my early code is a mixture of OOP and imperative, which would be considered 'wrong', but it still compiles and works.

(c) Actual errors (it still works, but this is a fluke)

...there are multiple types of questions I could ask about the same piece of code. For example,

  • Style questions
  • Functionality questions
  • Development questions
  • Best practice questions

Should I ask a separate "code review question" for each 'set of my questions' and post the same code, or just post the code and organise the questions into various 'departments'?

The code itself is small <(< 100 lines), but because of it'sits flexible nature (and my possible style/implementation mistakes), the possible questions and solutions it generates is maybemay be larger than one question.

Or should I break the code up into small parts and ask about each section? (I'm guessing the answer is 'No' to that, because context is very useful, plus then the code wouldn't work, it has to be working code.)

The makefile does work, and compiles and links my project fine.

To summarise: If there's a lot of questions about one piece of code, should I ask all the questions in one post, or create many posts with different questions, but all containing the same code?

Background:

Having been on the Code Review (SE) I then click on the blue box that says it's the Meta Code Review SE:

Link from Code Review SE

And that brings me here, to this site, thus I believe this is the appropriate site, but as it's my first question, perhaps I've made a mistake.

Web site that hosts above link

In summary, go to Code Review SE, click on a meta link. That brings the user here. (Java API, is one subject, which is another indicator, right?)

Reading Robert Longson's link, it's about generic questions. I have specific questions, but due to the nature of the code there are many questions, but pertaining to one piece of code. I can see a subtle difference, and I apologise if I'm not able to explain myself well enough to get that difference over..

Thank you Robert Longson, noob mistake, (although given the above 'evidence' a reasonable mistake !). However, I can't ask the following question, I don't have enough rep...

I'm preparing to write a question for Code Review (SE) (Thanks, Laurel)

I've written a generic GNU makefile, with the idea that it can be applied to all kinds of C++ projects with different directory structures, etc.

My, hopefully different ;-) , question:

The makefile works. However due to...

(a) The makefile's inherent "genericness"

(b) My possible style errors.

For example, (different context but to illuminate the point) there's a right way to do OOP, some of my early code is a mixture of OOP and imperative, which would be considered 'wrong', but it still compiles and works.

(c) Actual errors (it still works, but this is a fluke)

...there are multiple types of questions I could ask about the same piece of code. For example,

  • Style questions
  • Functionality questions
  • Development questions
  • Best practice questions

Should I ask a separate "code review question" for each 'set of my questions' and post the same code, or just post the code and organise the questions into various 'departments'?

The code itself is small < 100 lines, but because of it's flexible nature (and my possible style/implementation mistakes), the possible questions and solutions it generates is maybe larger than one question.

Or should I break the code up into small parts and ask about each section? (I'm guessing the answer is 'No' to that, because context is very useful, plus then the code wouldn't work, it has to be working code.)

The makefile does work, and compiles and links my project fine.

To summarise: If there's a lot of questions about one piece of code, should I ask all the questions in one post, or create many posts with different questions, but all containing the same code?

I'm preparing to write a question for Code Review (SE) (Thanks, Laurel)

I've written a generic GNU makefile, with the idea that it can be applied to all kinds of C++ projects with different directory structures, etc.

My, hopefully different ;-) , question:

The makefile works. However due to...

(a) The makefile's inherent "genericness"

(b) My possible style errors.

For example, (different context but to illuminate the point) there's a right way to do OOP, some of my early code is a mixture of OOP and imperative, which would be considered 'wrong', but it still compiles and works.

(c) Actual errors (it still works, but this is a fluke)

...there are multiple types of questions I could ask about the same piece of code. For example,

  • Style questions
  • Functionality questions
  • Development questions
  • Best practice questions

Should I ask a separate "code review question" for each 'set of my questions' and post the same code, or just post the code and organise the questions into various 'departments'?

The code itself is small (< 100 lines), but because of its flexible nature (and my possible style/implementation mistakes), the possible questions and solutions it generates is may be larger than one question.

Or should I break the code up into small parts and ask about each section? (I'm guessing the answer is 'No' to that, because context is very useful, plus then the code wouldn't work, it has to be working code.)

The makefile does work, and compiles and links my project fine.

To summarise: If there's a lot of questions about one piece of code, should I ask all the questions in one post, or create many posts with different questions, but all containing the same code?

Post Migrated Here from meta.stackexchange.com (revisions)
Source Link

Asking multiple questions about the same code

Background:

Having been on the Code Review (SE) I then click on the blue box that says it's the Meta Code Review SE:

Link from Code Review SE

And that brings me here, to this site, thus I believe this is the appropriate site, but as it's my first question, perhaps I've made a mistake.

Web site that hosts above link

In summary, go to Code Review SE, click on a meta link. That brings the user here. (Java API, is one subject, which is another indicator, right?)

Reading Robert Longson's link, it's about generic questions. I have specific questions, but due to the nature of the code there are many questions, but pertaining to one piece of code. I can see a subtle difference, and I apologise if I'm not able to explain myself well enough to get that difference over..

Thank you Robert Longson, noob mistake, (although given the above 'evidence' a reasonable mistake !). However, I can't ask the following question, I don't have enough rep...

I'm preparing to write a question for Code Review (SE) (Thanks, Laurel)

I've written a generic GNU makefile, with the idea that it can be applied to all kinds of C++ projects with different directory structures, etc.

My, hopefully different ;-) , question:

The makefile works. However due to...

(a) The makefile's inherent "genericness"

(b) My possible style errors.

For example, (different context but to illuminate the point) there's a right way to do OOP, some of my early code is a mixture of OOP and imperative, which would be considered 'wrong', but it still compiles and works.

(c) Actual errors (it still works, but this is a fluke)

...there are multiple types of questions I could ask about the same piece of code. For example,

  • Style questions
  • Functionality questions
  • Development questions
  • Best practice questions

Should I ask a separate "code review question" for each 'set of my questions' and post the same code, or just post the code and organise the questions into various 'departments'?

The code itself is small < 100 lines, but because of it's flexible nature (and my possible style/implementation mistakes), the possible questions and solutions it generates is maybe larger than one question.

Or should I break the code up into small parts and ask about each section? (I'm guessing the answer is 'No' to that, because context is very useful, plus then the code wouldn't work, it has to be working code.)

The makefile does work, and compiles and links my project fine.

To summarise: If there's a lot of questions about one piece of code, should I ask all the questions in one post, or create many posts with different questions, but all containing the same code?