Skip to main content
Spelling and grammar; slight wording change
Source Link
Toby Speight
  • 81.7k
  • 15
  • 32
  • if the design changes, the code changes, and
  • if the design is not 'fixed', then the code is not 'fixed'.
  • ifIf the design is still to be reviewed, it is logical that the design is not stable.stable;
  • ifIf the design is not stable, then the code is not stable.stable;
  • additionallyAdditionally, if the design is not stable, then the code is off-topic because one of the on-topic questionsrequirements is: To the best of my knowledge, does the code work?
  • If you don't know the design, then you don't know what the code is supposed to do.
  • If you don't know what the code is supposed to do, how can you possibly know that it works?
  • theThe code is not ready for review if the design is not agreed.
  1. Programmers.se - for when you want to discuss general programming concepts and methodologies
  2. AppDesign.se - for when you want help designing what your application should do, how the parts should fit together, and deciding what the code should do in various conditions.
  3. StackOverflow.se - for when you know what youryou want, and your program is not quite working yet, and you have a really good idea of where it is going wrong, but not why.
  4. CodeReview.se - for when everything is working as intended, but you think the implementation could be improved.

Further, The a working design always precedes working code. If you don't know that your design works, then you don't know if your code works.

  • if the design changes, the code changes
  • if the design is not 'fixed', then the code is not 'fixed'.
  • if the design is still to be reviewed, it is logical that the design is not stable.
  • if the design is not stable, then the code is not stable.
  • additionally, if the design is not stable, then the code is off-topic because one of the on-topic questions is: To the best of my knowledge, does the code work?
  • If you don't know the design, then you don't know what the code is supposed to do.
  • If you don't know what the code is supposed to do, how can you possibly know that it works?
  • the code is not ready for review if the design is not agreed.
  1. Programmers.se - for when you want to discuss general programming concepts and methodologies
  2. AppDesign.se - for when you want help designing what your application should do, how the parts should fit together, and deciding what the code should do in various conditions.
  3. StackOverflow.se - for when you know what your want, and your program is not quite working yet, and you have a really good idea of where it is going wrong, but not why.
  4. CodeReview.se - for when everything is working as intended, but you think the implementation could be improved.

Further, The a working design always precedes working code. If you don't know that your design works, then you don't know if your code works.

  • if the design changes, the code changes, and
  • if the design is not 'fixed', then the code is not 'fixed'.
  • If the design is still to be reviewed, it is logical that the design is not stable;
  • If the design is not stable, then the code is not stable;
  • Additionally, if the design is not stable, then the code is off-topic because one of the on-topic requirements is: To the best of my knowledge, does the code work?
  • If you don't know the design, then you don't know what the code is supposed to do.
  • If you don't know what the code is supposed to do, how can you possibly know that it works?
  • The code is not ready for review if the design is not agreed.
  1. Programmers.se - for when you want to discuss general programming concepts and methodologies
  2. AppDesign.se - for when you want help designing what your application should do, how the parts should fit together, and deciding what the code should do in various conditions.
  3. StackOverflow.se - for when you know what you want, and your program is not quite working yet, and you have a really good idea of where it is going wrong, but not why.
  4. CodeReview.se - for when everything is working as intended, but you think the implementation could be improved.

Further, a working design always precedes working code. If you don't know that your design works, then you don't know if your code works.

Commonmark migration
Source Link

#Off-Topic

Off-Topic

#On-Topic

On-Topic

#Using Examples

Using Examples

#AppDesign.se

AppDesign.se

#Conclusion

Conclusion

#Off-Topic

#On-Topic

#Using Examples

#AppDesign.se

#Conclusion

Off-Topic

On-Topic

Using Examples

AppDesign.se

Conclusion

clarify last point.
Source Link
rolfl Mod
  • 97.5k
  • 4
  • 116
  • 237
  • Code Review is not the right place to perform "design only" reviews.
  • If the system is still at the stage of design review, then any code is not yet ready for a code review (you have to know what the code is supposed to do before you can tell if it is doing it right).
  • when the design is 'finalized' then the code that implements that design is ready for review
  • if the design forces the code couldto be improved by changing the designinefficient or 'ugly', then that should/could be brought to the attention of the asker.
  • Code Review is not the right place to perform "design only" reviews.
  • If the system is still at the stage of design review, then any code is not yet ready for a code review (you have to know what the code is supposed to do before you can tell if it is doing it right).
  • when the design is 'finalized' then the code that implements that design is ready for review
  • if the code could be improved by changing the design, then that should/could be brought to the attention of the asker.
  • Code Review is not the right place to perform "design only" reviews.
  • If the system is still at the stage of design review, then any code is not yet ready for a code review (you have to know what the code is supposed to do before you can tell if it is doing it right).
  • when the design is 'finalized' then the code that implements that design is ready for review
  • if the design forces the code to be inefficient or 'ugly', then that should/could be brought to the attention of the asker.
Added AppDesign
Source Link
rolfl Mod
  • 97.5k
  • 4
  • 116
  • 237
Loading
change summary to 'using examples'.
Source Link
rolfl Mod
  • 97.5k
  • 4
  • 116
  • 237
Loading
edited body
Source Link
rolfl Mod
  • 97.5k
  • 4
  • 116
  • 237
Loading
Added Summary and Conclusion sections.
Source Link
rolfl Mod
  • 97.5k
  • 4
  • 116
  • 237
Loading
Source Link
rolfl Mod
  • 97.5k
  • 4
  • 116
  • 237
Loading