Skip to main content
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

From Remove Nth Node from End of Linked ListRemove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

From Remove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

From Remove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

edited body; edited tags; edited title
Source Link
Jamal Mod
  • 34.9k
  • 2
  • 53
  • 106

How tocan I be a nice reviewer?

fromFrom Remove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

How to be a nice reviewer?

from Remove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

How can I be a nice reviewer?

From Remove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

Tweeted twitter.com/#!/StackCodeReview/status/512756502424088576
code highlighing for 5 characters of code
Source Link
Pimgd
  • 22.3k
  • 12
  • 37

from Remove Nth Node from End of Linked List:

Bug: n < 0n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

from Remove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

from Remove Nth Node from End of Linked List:

Bug: n < 0 leads to you removing the last node.

Your solution should have comments: I have NO idea how it works. And that's after reading it a couple times. If this was production code, I'd have wrapped it with unit-tests, thrown the implementation away and rewrote it.

How do I review honestly, without being overly harsh? I have a tendency to post an answer like that, and it's only after rolfl mentions it (@Pimgd - not a bit harsh, is it?) that I notice.

tags, and context.
Source Link
rolfl Mod
  • 97.5k
  • 4
  • 116
  • 237
Loading
Source Link
Pimgd
  • 22.3k
  • 12
  • 37
Loading