Skip to main content
Code Review

Return to Answer

added 4 characters in body; edited body
Source Link
Robert Cartaino
Robert Cartaino
  • 465
  • 4
  • 13

Knowing when to say "That code is done, move on" is just as important a skill as finding fault.

If the code is "fine" someone should say so (as an answer) which can then be voted up (or down) by the community. Why force users to only provide criticism where there may simply be none to be had?

Knowing when to say "That code is done, move on" is just as important a skill as finding fault.

Part of a code review is verifying the implementation and correctness of a code block. Code review is an iterative process. How will users know when their code is "done" if praise is verboten? The suggestion that "It's fine" posts should be discouraged makes little sense.

If the code is "fine" someone should say so (as an answer) which can then be voted up (or down) by the community. Why force users to only provide criticism where there may simply be none to be had?

Knowing when to say "That code is done, move on" is just as important a skill as finding fault.

Part of a code review is verifying the implementation and correctness of a code block. Code review is an iterative process. How will users know when their code is "done" if praise is verboten? The suggestion that "It's fine" posts should be discouraged makes little sense.

Knowing when to say "That code is done, move on" is just as important a skill as finding fault.

If the code is "fine" someone should say so (as an answer) which can then be voted up (or down) by the community. Why force users to only provide criticism where there may simply be none to be had?

Part of a code review is verifying the implementation and correctness of a code block. Code review is an iterative process. How will users know when their code is "done" if praise is verboten? The suggestion that "It's fine" posts should be discouraged makes little sense.

added 22 characters in body; added 7 characters in body; added 95 characters in body; deleted 75 characters in body; added 5 characters in body; deleted 1 characters in body
Source Link
Robert Cartaino
Robert Cartaino
  • 465
  • 4
  • 13

If the code is "fine" someone should say so (as an answer) which can then be voted up (or down) by the community. Why force users to only provide criticism where there may simply be none to be had?

Knowing when to say "That code is done, move on" is just as important a skill as finding fault.

Part of a code review is verifying the implementation and correctness of a code block. Code review is an iterative process. How will users know when their code is "done" if praise is verboten? The suggestion that "It's fine" posts will simply censor an essential part of this process… creating correct codeshould be discouraged makes little sense.

If the code is "fine" someone should say so (as an answer) which can then be voted up (or down) by the community. Why force users to only provide criticism where there may simply be none to be had?

Part of a code review is verifying the implementation and correctness of a code block. Code review is an iterative process. How will users know when their code is "done" if praise is verboten? The suggestion that "It's fine" posts will simply censor an essential part of this process… creating correct code.

If the code is "fine" someone should say so (as an answer) which can then be voted up (or down) by the community. Why force users to only provide criticism where there may simply be none to be had?

Knowing when to say "That code is done, move on" is just as important a skill as finding fault.

Part of a code review is verifying the implementation and correctness of a code block. Code review is an iterative process. How will users know when their code is "done" if praise is verboten? The suggestion that "It's fine" posts should be discouraged makes little sense.

Source Link
Robert Cartaino
Robert Cartaino
  • 465
  • 4
  • 13

If the code is "fine" someone should say so (as an answer) which can then be voted up (or down) by the community. Why force users to only provide criticism where there may simply be none to be had?

Part of a code review is verifying the implementation and correctness of a code block. Code review is an iterative process. How will users know when their code is "done" if praise is verboten? The suggestion that "It's fine" posts will simply censor an essential part of this process… creating correct code.