0
\$\begingroup\$

Good code reviews are the bar that all of us should strive for. They cover common and easy to follow best practices that any team can get started with, while ensuring high-quality and helpful reviews for the long term.

code review says about clean code (readability, easy to understand,care about names,...) and performant code (Levels of optimization, Design level, When to optimize, Trade-offs, Strength reduction, Run time, Assembly level, Compile level, Build level, Source code level,...)
How to Make Good Code Reviews Better, Gergely Orosz

When I asked about performance of some code or ask about best practice of some code the community said to me Code Review is not about asking for how to implementation best practices.

enter image description here

As you can see above, the community said to me that generic best practices are outside the scope of this site! Why then is the name of this site Code Review? When one items of a code review is about best practice of code.

| |
\$\endgroup\$
  • 1
    \$\begingroup\$ Where did you find that quote? I don't think you've found that quote on this site, but elsewhere on the internet. It's quite common for different people to have slightly different interpretations of words... \$\endgroup\$ – Vogel612 Jun 2 at 11:40
  • \$\begingroup\$ stackoverflow.blog/2019/09/30/… you can see one of above quote here :) and if you want see all of that things, search in net, it is very clear all of that things are for code review \$\endgroup\$ – Mehrdad Kiani Anbohi Jun 2 at 11:48
  • 2
    \$\begingroup\$ Either remove the specific-question tag or add a/the links back into the question. \$\endgroup\$ – Peilonrayz Jun 2 at 13:46
7
\$\begingroup\$

Note, your question in this meta post is about why asking about best-practices in general are off topic, and you provide some example questions which were closed.

Note, those questions were not (necessarily) closed because they were about best practices in general. The close reason covers a number of different possible reasons for the closure. The first linked question (Date convert) for example, has no context describing what the conversion is, or should do. It's hard to review code if you don't know the purpose of the code. The "best practices" in the close banner is superfluous to the actual reason, and is only there because it's boilerplate text that covers a number of close reasons.

So, you cannot use one small part of the close-banner to cover the entire close-reason for the question.

Now, as for the general question about why best-practice as a general topic is off-topic, it's for a few reasons:

  1. It's highly opinionated, and dynamic. It's one thing to have a question "Does this code follow best practices?", and quite another to say "what are the best practices?"
  2. There's the Software Engineering site where such questions are on-topic, and specifically on topic there.
  3. This is Code Review, and we review code.

In real life, when doing a code review, there is a lot of lattitude for various discussions, what the best practices may be is part of that. But, on this site in particular, it's all about the real code, as presented.

| |
\$\endgroup\$
  • \$\begingroup\$ "and you provide some example questions which were closed." No, I did. \$\endgroup\$ – Peilonrayz Jun 2 at 12:59

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .