4
\$\begingroup\$

In C++ PEXT/PDEP implementations

I believe that significant changes were made. But there was a comment stating that modifying is off topic.

As this code is public, then modifications should be considered maintaining the code. And it should be clear that I do understand how it works.

In fact, unless there is something I missed, I plan on making a pull request to update the git repository.

The assembly is significantly different, enough that most programmers would take a good while to assert they are functionally equivent.So it is not just changing variable names, or trivially rearranging the code.

I will of course remove the post if the consensus is that it is off topic.

\$\endgroup\$
5
  • 3
    \$\begingroup\$ One person has commented on your question with a concern. The concern seems to be a misrepresentation of the provided link "Am I an author or maintainer of the code?" not "if you are not the author of the code you post, it's not considered on-topic for CodeReview". I don't think discussing whether your question is on/off topic will be beneficial at the moment. Once more people step forward and vote your question as off-topic, I think there'd be a point to the discussion. \$\endgroup\$
    – Peilonrayz Mod
    Aug 19, 2022 at 13:10
  • \$\begingroup\$ One of the things you seem to be miss understanding is that there are copyright laws involved. If you do a pull request and the owner of the repository merges the code in yes you become a maintainer of that code. Until that happens you are not a maintainer of the original code. \$\endgroup\$
    – pacmaninbw
    Aug 19, 2022 at 13:19
  • 4
    \$\begingroup\$ Glenn, I don't think there is anything wrong with your code, but apart from the authorship requirement making it possibly off-topic, I also don't know what you expect out of this review? You clearly know it's about the performance of this code, and you probably already measured yourself what the gain is. And the code style was chosen so it conforms to the rest of the original bitops.hh, so I don't think there's much useful to say about that either. \$\endgroup\$
    – G. Sliepen
    Aug 19, 2022 at 17:07
  • 2
    \$\begingroup\$ To me, it seems that what's reviewable is the delta between the original and modified versions (as that's the part that's the asker's work), so it's worth looking at Is a changeset reviewable? and Is asking for code review on a patch file OK? for some advice. In this case, given that the intention is to make a pull-request, that is obviously inviting a code review from the project maintainer(s) (who will certainly want consistency with the project's existing style, layout and architecture), so asking here is probably unnecessary at best. \$\endgroup\$
    – Toby Speight
    Aug 20, 2022 at 8:26
  • 3
    \$\begingroup\$ I'm disturbed to see that "most programmers would take a good while to assert they are functionally [equivalent]". Is there some reason that the unit tests don't provide the required confidence? Perhaps they should be improved before changing the implementation? \$\endgroup\$
    – Toby Speight
    Aug 20, 2022 at 8:28

0

Reset to default

You must log in to answer this question.

Browse other questions tagged .