12
\$\begingroup\$

I think that code review, especially peer review, is essential in improving quality, decreasing maintenance costs, etc. So, should this site strive to help people promote this philosophy or merely provide free code reviews?

(I think both, but focus on the first part).

Thoughts?

\$\endgroup\$
  • 1
    \$\begingroup\$ I guess the result should be used in the "what not to ask" faq since this will come up often \$\endgroup\$ – edorian Jan 21 '11 at 17:11
21
\$\begingroup\$

The Code Review Stack Exchange is for sharing code from projects you're working on to get peer feedback and review. This site is not for discussions about the discipline and practice of code reviews.

If you see any questions about conducting code reviews (best practices, techniques, etc), those questions should be closed and the author kindly directed to the Programmers Stack Exchange site.

\$\endgroup\$
  • 2
    \$\begingroup\$ Agreed. It would help if we had an explicit migration path (right now, there's no "Belongs on Programmers.SE" reason, only "Off Topic") \$\endgroup\$ – Inaimathi Jan 21 '11 at 16:16
  • 2
    \$\begingroup\$ @Inaimathi: Migration paths cannot be set up until the site is out of beta. In the meantime, properly closing and kindly asking the author to redirect their question is a matter of community self-moderation. That's a big part of defining and developing this site. \$\endgroup\$ – Robert Cartaino Jan 21 '11 at 17:05
  • \$\begingroup\$ Thanks for restateing that fact Robert, i read through most of meta and i haven't understood that until now. (Mostly because i misread the top rated answer on this question). \$\endgroup\$ – edorian Jan 21 '11 at 17:10
16
\$\begingroup\$

I agree that both aspects are important. Although, one could learn how to code review by simply reading through this site. It seems that questions about code reviews are better asked on Programmers.SE.

\$\endgroup\$
  • 4
    \$\begingroup\$ This is what I assumed; questions about programming/related practices => Programmers.SE (or possible SO, I guess). "please review this code" => CodeReview.SE \$\endgroup\$ – Inaimathi Jan 19 '11 at 23:46
  • \$\begingroup\$ I guess it is inevitable that there will be a lot of overlap between CR.se and both P.se and SO. \$\endgroup\$ – LRE Jan 21 '11 at 4:01
9
\$\begingroup\$

Based on a quick review of Code Review site proposal, I think both are legit.

\$\endgroup\$
  • 2
    \$\begingroup\$ Possibly too legit.:) \$\endgroup\$ – David Weiser Jan 19 '11 at 21:54
  • \$\begingroup\$ I'd agree. Since the purpose is code review, I think it would benefit users to at the same time here, learn how to review code. Likely you won't see many questions after the initial "how do I review code", but at least when they're starting a new post, they get to see the link right there to the question already asked. \$\endgroup\$ – bob-the-destroyer Jan 30 '11 at 1:26
  • \$\begingroup\$ we seem to do a dismal job at telling folks what a good review is, or how to write one. \$\endgroup\$ – konijn Nov 18 '14 at 15:07

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .