11
\$\begingroup\$

I have written a small application in Haskell and I wish to get a code review. Since I'm inexperienced, I cannot really write a bullet list of things I'm not satisfied with in my code. It would just be helpful for someone to review the entire application, as any kind advice is welcome.

Is it appropriate to post such a question on Code Review?

\$\endgroup\$

migrated from meta.stackexchange.com Jan 13 '14 at 18:55

This question came from our discussion, support, and feature requests site for meta-discussion of the Stack Exchange family of Q&A websites.

  • 3
    \$\begingroup\$ What size are we talking? From their help center: If you want a code review, you must post the relevant snippets of code in your question. It is fine to post a "see more" link (though, do be careful — very few reviewers will be willing to click through and read thousands of lines of your code), but the most important parts of the code must be placed directly in the question.. \$\endgroup\$ – Jeroen Vannevel Jan 13 '14 at 18:30
  • \$\begingroup\$ @JeroenVannevel - github.com/r-darwish/gameoflife - This is the entire application. It's not a large one. \$\endgroup\$ – darwish Jan 13 '14 at 18:41
  • 1
    \$\begingroup\$ @darwish: that's not a problem at all, they're used to a lot more. \$\endgroup\$ – Jeroen Vannevel Jan 13 '14 at 18:42
12
\$\begingroup\$

It depends. Remember that reviewers are not paid to review your code, so write out your post, then sit back and look at the preview before hitting that Post Question button. Put yourself in the reviewers' shoes. Would you review this?

If you feel it's too much, it probably is. There's nothing wrong with breaking it down into multiple questions.

I haven't looked at your code, but one of the commenters made an interesting comment: "that's not a problem at all, they're used to a lot more." - it's probably true.

Take a look at our posts, they're all "complete" applications, of reasonable reviewing length.

\$\endgroup\$
  • 5
    \$\begingroup\$ I did take a look at the code. A total of approximately 120 lines as far as I could see. Piece of cake! \$\endgroup\$ – Simon Forsberg Jan 13 '14 at 19:08
  • 2
    \$\begingroup\$ +1 for breaking code down into multiple questions. \$\endgroup\$ – syb0rg Jan 30 '14 at 0:49

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .