11
\$\begingroup\$

The tag was recently created. There are now three questions carrying the tag.

Its intended purpose is described in its tag wiki:

Much like the [beginner] tag, this tag should call out that extra care should be taken reviewing the code. Your code review might impact how students learn about programming.

Should it stay or should it go?

\$\endgroup\$
8
\$\begingroup\$

I agree with 200's answer.

All reviews should be implicitly 'teaching': teaching the OP.

In contexts where 'teaching' might be useful (e.g. "we can't use exceptions here because we haven't covered those in class yet"), that fact can be a comment (the mere presence of the 'teaching' tag doesn't convey such sufficient/accurate/useful information).

Here is an example of a teaching question without the teaching tag. The several sentences to that effect in the OP were necessary and sufficient.

\$\endgroup\$
12
\$\begingroup\$

I'm not convinced that the tag should stay, because:

  1. is a meta-tag, describing the status of the question being asked, rather than the content. On Stack Overflow, they have been deprecating meta-tags. I realize that we still have meta-tags like and , and I'm not currently pushing to eliminate them from Code Review, but I'm reluctant to introduce another.

  2. Does that imply that we're normally a careless bunch?

  3. Code Review, like anything on the Internet, relies on the collective wisdom of the crowd. We all give dubious advice from time to time. Some reviewers are more skilled than others. Admonitions to be extra careful are unlikely to raise the quality of any answer. However, reviewers correct each other, and good advice generally emerges from the variety of opinions. That's how the process normally works; why should it be any different for questions?

For those reasons, I propose removing the tag from all three questions.

\$\endgroup\$
1
\$\begingroup\$

I really liked the teaching flag, it's a shame it's gone.

  1. I am aware that it's a meta flag, I think a number of them are useful. This one could be too.

  2. answers should prefer low tech solutions ( It does not matter how beautiful functional code is, yet. )

  3. commenting will be different, you might actually have valid 'obvious' comments

    //add 1 to x with an addition assignment.
    x += 1;
    
  4. Terribly personal, but this kind of questions interest me in any programming language. They are geared towards students, I might actually learn something new on CR. I for one welcome our new teaching overlords, would track questions.
\$\endgroup\$

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .