As a piece of code is subjected to peer review, the author should also be looking at ways to improve his code. Sometimes a problem pointed out by others will direct his attention to another issue in the code. On Code Review, should he edit that suggestion/edit into his question (as an edit to keep continuity), or should he submit it as an answer?
\$\begingroup\$
\$\endgroup\$
2
-
\$\begingroup\$ This might be relevant \$\endgroup\$– Aseem BansalJul 29, 2013 at 9:51
-
\$\begingroup\$ Does this answer your question? Should I answer my own question with the improved code? \$\endgroup\$– starballJan 4 at 11:30
Add a comment
|
2 Answers
\$\begingroup\$
\$\endgroup\$
I think he should post it as an answer unless it was a very minor thing, then reference the person who indirectly brought it up. If it was a minor thing, he should probably just comment on the person's answer and update my question.
I would imagine either way would work, though.
\$\begingroup\$
\$\endgroup\$
I think answer will be better, as significant question edits might be disruptive to others who already answered.
(trivial or minor question edits are of course always ok)
