Code submitted for review is supposed to be "working code". I imagine this to be for 2 reasons:
- We are not looking to fix broken code
- Being able to run the code allows deeper review
Is this correct? Does (2) apply?
When reviewing for style or readability it is less important but questions like this that want performance improvements really suffer from not being able to run the code.
In this case a non standard module is imported by the Python code but is not made available to reviewers. I added a comment back in April to point out that we cannot profile without the module, but there has been no response and the question has received no answers.
I am disinclined to suggest closing a question just because the code cannot be run if it is just asking for feedback (provided it isn't obviously broken). However, when the question specifically asks for performance improvements are there any other options?
I'm hoping to see any other possibilities before resorting to suggesting closing.