This question is intended to be the counterpart of Checklist for how to write a good Code Review question.
Getting started with Code Review:
New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stack Overflow, others maybe from Software Engineering.
These sites favor a different kind of answer than Code Review. I'd suggest providing a guideline or even checklist for new users on how we like our answers best ;)
Some of the most common "mistakes" that new users make:
- SO-ish flavoring: alternative code (mostly without explanation)
- Software Engineering flavoring: much much explanation, but missing relation to the code at hand.
- Trying to go over every Issue in code and then resign over the sheer amount. --> no answer posted
- Only "reviewing" the algorithm and not the style (probably also coming from SO), and not posting an answer, because no optimization can be found :(
There already has been a question on what makes a good answer. There was only one answer to that. The problem I have with that answer is, that it only states what a good answer has and not how to write an answer so it becomes good ;)