39
\$\begingroup\$

Nhgrif pointed out a great idea: Teamwork

"I think it's probably best if the question instead has several good answers that each address a specific topic. The result will be that no single answer is complete, but every problem is addressed between all the answers."

enter image description here

Alright, so that may not be the kind of "teamwork" we're looking for, but seriously guys and gals:

enter image description here

Reviews take a long time...

I'd say that so far roughly 90% of the great reviewers here spend nearly 40 minutes or even an hour per review giving great, positive feedback, touching on all the aspects of the code.

Even smaller code, which we should promote, requires lots of time and effort to touch on everything fully. This has two results:

  1. When potential answerers see a question that is either too long, too complex, they skip it.

  2. It takes too long to cover a single review, reviewers don't always get rewarded properly for it, and the huge effort needed turns away would-be-active-reviewers.

But together, we can each achieve more, faster

If each reviewer sees the question and grabs one aspect of the code that they're interested in improving, and spends just 15 minutes on their review, they can post a kick-*ss review that will get the same amount of upvotes, and allow other users to share the rep, and post their own kick-*ss reviews of different aspects of the code.

Things like:

  • Structure

  • Formatting & Comments

  • Suggesting an OOP design

  • Single Function Function

  • Decoupling and all of the great strategies that promote it

  • better ways to write a function, and why

Each of these aspects of a code review can take up 3-5 paragraphs alone and there's no reason for that not to be considered a good review. Together, by each focusing one one Trade, we avoid becoming Master of None in our reviews.


Code review is the perfect community for teamwork!

Instead of everyone trying to spend a monster amount of time, stretching their focus thin on huge, Jack of All Trade reviews, we can work together to touch on everything more fully, sharing the rep, allowing us to handle questions faster, and ultimately making it funner to review peoples code.

Share the rep! Team up on a review!

\$\endgroup\$
  • 7
    \$\begingroup\$ Related post: Short answers are OK! \$\endgroup\$ – 200_success Jul 21 '14 at 16:55
  • 2
    \$\begingroup\$ So if we get five answers on one question, and they all point out excellent things, then who should the asker give the accepted answer to? \$\endgroup\$ – Alex L Jul 21 '14 at 23:47
  • 7
    \$\begingroup\$ The one that the asker deems most helpful, as usual. Who gets it when multiple answers that touch on everything are given? @AlexL \$\endgroup\$ – Viziionary Jul 22 '14 at 1:36
  • 2
    \$\begingroup\$ In the future... if you're going to feature me, could someone @ me in a comment? \$\endgroup\$ – nhgrif Jul 26 '14 at 0:30
  • 3
    \$\begingroup\$ The big dog could have reached those burgers himself \$\endgroup\$ – Dagg Aug 4 '14 at 20:46
13
\$\begingroup\$

Collecting some useful resources as part of the teamwork approach:

Bottom line, teamwork approach is fine, common, and well-documented as being "allowed". If you want to contribute a portion of an answer, feel free to be part of the team.

\$\endgroup\$
3
\$\begingroup\$

I often mention other answers (if I think they are good) in my own answer. Sometimes I may use a point or piece of code from their answer (always saying so and giving credit).

From my own experience, there are several ways to collaborate in reviews without sharing an answer.

  1. Comment on other answers, praising good points.
  2. Comment on other answers, asking follow up questions which may lead them to expand their answer. They may pass the baton on to you, of course.
  3. Comment on the question, asking for clarification of constraints and input/output examples, particularly where existing answers show a need for them
  4. Be willing to concentrate on as-yet undiscussed aspects of the problem rather than compete over the main points of existing good answers. Explain this in your answer.
  5. If you do post alternative solutions, be generous in reference to existing ones and explain the shortcomings (as well as the benefits) of your own solution in comparison.
  6. Don't be afraid to answer if you can only answer one aspect of the problem, even if it is. The advice is often still very welcome. Somebody who is expert on the main problem may be less adept in your area and find it boosts their answer.

There is absolutely no point getting hung up on not being the accepted answer. If questioners all had good judgement in choosing the best answer, they would probably not need to post here in the first place.

I feel rather lonely in my pet areas, which seem to be relatively niche and have a very small number of reviewers. We'd all benefit from more answers, no matter how narrowly-focused and succinct.

\$\endgroup\$

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .