8
\$\begingroup\$

I think that we should amend our FAQ to say:

Reviewers may comment on any part of the code.
Feel free to call attention to specific areas you are concerned about (performance, formatting, etc). However, any aspect of the code posted is fair game for criticism.

Find the non repeating number in the integer array is the question that prompted this edit. It asks specifically for a way to increase the efficiency of the code. The question I had was if it was on topic, since it asked for specific code.

This answer does not address that need, but still is a good "code review" answer. I think that the question is good, but that the scope of the answers shouldn't be limited to only what the OP had in mind.

There is not a problem now per se, but sepp2k and I believe that it would be good to clarify this.

Any opinions or edits?

\$\endgroup\$
  • \$\begingroup\$ I don't oppose this at all, but I'm curious -- can you provide links that prompted it? I would like to see evidence / background. \$\endgroup\$ – Jeff Atwood Mar 28 '11 at 23:30
  • \$\begingroup\$ @Jeff - I've edited the context into the question. I noticed it because it was asking for a specific answer - using hashmaps to achieve greater efficiency. The consensus between sepp2k and I was that it was fine to ask that sort of question here, but the reviewers shouldn't be limited in scope to that request. \$\endgroup\$ – Michael K Mar 28 '11 at 23:59
4
\$\begingroup\$

OK, I didn't see any harm in this, so I edited it into the FAQ.

This is something you can do as a diamond mod as well, just click edit there.

\$\endgroup\$
  • \$\begingroup\$ Yes, I just wanted to try and get some feedback on it :) \$\endgroup\$ – Michael K Mar 29 '11 at 13:15

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .