There are a number of questions of similar type that get asked here:

My read on Best practice questions and the FAQ is that none of these questions are on-topic for code review. However, at least one of the questions was migrated to code review after asking a mod who indicated it was acceptable.

So questions:

  1. Are these on-topic for Code Review?
  2. If not, do they belong on StackOverflow or Programmers?
  3. Do we want to go back and move all of these questions to the appropriate site, or leave well enough alone and only apply the policy to newer questions.

For the most part the the FAQ seems a bit fuzzy on this matter, but I think the telling line is the first.

Code Review - Stack Exchange is for sharing code from projects you are working on for peer review.

(emphasis existing)

If the question is using example/place holder, then I would say it's off topic. If the question is using actual code and just asking if it complies with best practice then I would say on topic.

Compliance with best practice is in the list of things that may be commented on and the OP is allowed to ask for a focus on a particular type of critique, though the answer may still comment on other aspects.

Your third example seems on-topic based on my interpretation of the FAQ. If we decide that we don't want such questions then we should probably update the FAQ to be a little clearer on the matter.


You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .