3
\$\begingroup\$

As code edits are reviewed by peers, anyone who has rights to review the edits can approve or reject edits. I suggested this edit and, AFAIK, my edits are correct. But this got rejected.

I know this sound harsh and arrogant, but I think non-specific-language programmers shouldn't approve or reject specific language programs. For instance, a non-Java programmer shouldn't approve/reject any edit on Java program. I don't mean to attack personally; sorry if I did.

\$\endgroup\$
  • 1
    \$\begingroup\$ Since Lstor is familiar with Java, I'll take his word for it that the rejection was justified. In general, though, anyone reviewing a specific code edit should be familiar with that language, otherwise that review should be skipped. Not doing so would cause something like this (if it happened that Lstor knew nothing of Java). \$\endgroup\$ – Jamal Jul 30 '13 at 12:34
  • 3
    \$\begingroup\$ @WilliamMorris points out the reason for rejection: Would it not be better to explain the problem in a comment rather than just changing the code? For more details, see this question on Meta. \$\endgroup\$ – Lstor Jul 30 '13 at 17:05
  • 2
    \$\begingroup\$ To clarify: The (pre-defined) reason I chose was: This edit is incorrect or an attempt to reply to or comment on the existing post. The incorrect here means "not a reason to edit the code", not that the code in the edit was invalid. The last part is the key part: an attempt to reply to or comment on the existing post. In other words, your edit would be better suited as a comment to the question. I'll make sure to state that more clearly the next time, like William Morris did. \$\endgroup\$ – Lstor Jul 30 '13 at 17:14
  • 3
    \$\begingroup\$ @Lstor that meta topic isn't relevant here. That discussion is about editing questions, but this edit was to an answer. \$\endgroup\$ – Winston Ewert Jul 31 '13 at 3:30
  • 2
    \$\begingroup\$ @WinstonEwert Oh. You are right, of course. Then I must apologize, tintinmj. I made a mistake. I still think it's generally more useful to comment and clarify than to simply edit, but if I had realized it was an answer, I would have voted approve. \$\endgroup\$ – Lstor Jul 31 '13 at 5:27

You must log in to answer this question.

Browse other questions tagged .