What are your thoughts on writing reviews fully as inline code? We all take time out of our day to do these reviews but writing good reviews takes time, looking at the posted code, switching editors, etc.
I just posted a review by reposting the OPs code with my comments inline:
unsigned char buffer_lname, buffer_fname, buffer; unsigned int count_students = 0, successfully_read = 0 // if you have it size_t is the type to use for all indices while (fscanf(p_file,"%s",buffer)==1) // Assuming memory size: // if you're line is longer than 256 this will overwrite ... // fscanf use: // if there is a space in the line the %s will stop parsing, this of course
Does this work? What upsides and downsides do you see with this? Any better ways to do this kind of review?
The full review is here.