The question Does this method guarantee that cells in a CSV will be correctly partitioned? is a duplicate of this one (10k+ and mods only) which asks whether a singular function properly 'escapes' bits of text from a CSV when handed to the function.

My personal opinion is that it does not meet the criterion to stand on its own, namely that the following close reason would apply:

Lacks concrete context: Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site. I merely provided the question as contextual reference as it's the catalyst that prompted my posting this question about the close reason.

The code is placed, and the user says "This is the proper output: [examples]" but there is no other context for the question - not context of usage beyond "This function does [purpose]'". It also explicitly asks "Does this method guarantee that the cells in a CSV will be properly formatted and data values properly processed" (my interpretation), which falls into the "generic best practices" category of this close reason as well.

To clarify my understanding of the close reasons, and my interpretations, is my interpretation valid? Or is the scope of what that close reason broad enough that it needs refined because of cases like this?

If my interpretations are not valid, then please explain why so I can alter my interpretations in the future.


To be clear: I am not questioning the validity of the question that was posted already. I'm questioning the scope and therefore my interpretation of the close reason of "Lacks Concrete Context", and at what point a question drifts into "generic best practices".

I see context for the original question post, namely that it's trying to scrub CSVs of invalid contents so that the CSV structure is properly kept. But whether or not this is scrubbing in a valid way, in my opinion, drifts into "generic best practices" rather than a concrete-context question. This is solely based on the interpretation of the close vote.

Therefore, the focus of this Meta post is the clarification on the close reason's scope and at what point any given question drifts into the "generic best practices" category, not whether the question I linked to is inherently on or off topic.

  • This is my question. I don't want to be rude but I have a very hard time understanding how it lacks context. csv's can take this form, right? "this","is"\r\n"a","csv". In my case the text in each cell is dynamic and I am trying to make sure that it doesn't break the csv format that I am going with . That is, var foo=' "csv" '; "this","is"\r\n"a",foo should not be able to break out of its cell. This is a concrete implementation of a method that requires more thought than usual. I'm not really interested in discussing my question bureaucratically like this but I felt I should say something. – user875234 Aug 9 at 18:45
  • 3
    @user875234 I think Malachi made a failure, I'm not questioning the validity of your question per se, I'm questioning my interpretation of the close reasons available on the site after Malachi asked me for clarification on why I claimed your first, now deleted, question was seen as "lacks context" by me. That is, I'm looking for community guidance with regards to the close reason and at what point code becomes "generic best practices" or "stub code" or "code without sufficient context to understand how it's used" - your question just happened to be the catalyst for this question to be posted – Thomas Ward Aug 9 at 18:49
  • I apologize, I should have made that clear – Malachi Aug 9 at 18:54
  • 1
    What surprises me is how many down and close votes that question got before someone finally asked the OP for more context. That seems rather unfriendly to me. Or was that already attempted with the OP's first (closed) question? – Pieter Witvoet Aug 10 at 11:15
  • 2
    @PieterWitvoet To fill in the blank. Thomas and another user commented to that effect on the first question. I have also seen what you describe on a lot of questions, which doesn't seem too friendly. – Peilonrayz Aug 10 at 11:29
  • Related: --> How much context is the required minimum? – Malachi Aug 14 at 14:12

My opinion on the close reason, is that the code must work, it must be real code, and there must be enough context to understand what the code does.

The Question in Question has all of these and even has another aspect I failed to mention which is required in some fashion: a way to run the code.

This can be demonstrated several ways

  • an example
  • input/output
  • method parameters (This can be somewhat of a gray area)

The Close Reason brings up 5 distinct things that make the question off-topic, of which I don't believe that this question falls into, let me elaborate

  • Psuedocode is not runnable.
  • Stub code has pieces of the real code missing.
  • Hypothetical code is not real code.
  • obfuscated code is also not real code.

The code that the OP has posted is real, complete, running code that is clear about what it is doing

While I don't think that this question fits into the General Practice clause of this close reason, I do note that the question posed is broader than the code provided and asks about functionality of a third party application.


That being said, I think that we can still give a review of the code that is presented to prevent certain characters from being entered into cells in a specific way.


The Last Piece of the puzzle

Context.

This seems to be where most of our contention is when closing questions, we need the Context thing nailed down a bit more.

My thoughts are that if there is enough, for someone who knows the language and the libraries that are being used, to understand what the OP is trying to accomplish and the post fits all the other on-topic reasons, then let's review it.

  • How very strange, +3/-2 on both our answers. I don't even know what we've done wrong. – Peilonrayz Aug 11 at 21:08
  • 1
    @Peilonrayz it would be nice for some comments about what is wrong with our answers, or what the downvoters disagree on. – Malachi Aug 13 at 13:42

Context in this context is just about the code, if there is missing context in the text then you should use the Unclear What You're Asking (UWYA) close reason.

This is as 200 based the new close reasons on-top of my suggestion, and so this reason was originally a merger of "Pseudocode, etc. | Code not written yet | No code". However 200 thought that we should move the no-code reason into the first close reason, and move the code not written yet reason into the third. Leaving just "Pseudocode, etc." on it's own.

T3chb0t also asked about the difference about UWYA and this close reason, because they read the same way now-a-days. Where my answer saying UWYA is about the text in the question and Lacks Concrete Context is about the code, was heavily upvoted and accepted.


The code is placed, and the user says "This is the proper output: [examples]" but there is no other context for the question - not context of usage beyond "This function does [purpose]'".

Since you think the text of the question is unclear, if you think it's unanswerable then please vote to close it as UWYA.

It also explicitly asks "Does this method guarantee that the cells in a CSV will be properly formatted and data values properly processed" (my interpretation), which falls into the "generic best practices" category of this close reason as well.

If we go through the close reasons assuming your interpretation is correct (I don't think it is):

  • Authorship of code:

    You could probably push that that the poster doesn't know why the code is written the way it is.

    However, they know how it's working they're asking at worst if it works ok.

  • Lacks Concrete Context:

    There is enough context in the code to understand what it is doing. So it'd fall in this if the code were example code, with a small snippet just containing the generic best practice.

    Since they're asking if it works in unforseen circumstances, and it's not missing context. Then it's not off topic here, as that's one of the reasons to come to get your code reviewed.

  • Code not Implemented or Not Working as Intended:

    You could try push that if there is a problem then there is a bug, and you can close it.

    However, part of Code Review is to find and address bugs, and so doing this goes against the spirit of the site and the close reason. And is one of the reasons to ask on this site according to the help-center:

    If you have a working piece of code from your project and are looking for open-ended feedback in the following areas:

    … Correctness in unanticipated cases

    … then you are in the right place!

  • "Lacks Concrete Context: The question is actual code, and so doesn't fall under this." That's not how it works. Code can be real and still lack context if the context is not provided. – Mast Aug 18 at 7:40
  • @Mast But I think in the context of this answer, Peilonrayz's point is that generically lacking context is not necessarily a reason to flag with "Lacks Concrete Context" (LCC). As they mentioned, a previous meta answer (of theirs) was relatively upvoted and demarcated LCC as being a code issue and UWYA as a text issue. This is the paradigm they're operating under in this explanation; I think to make a clear argument, you have to disagree with that paradigm, not just an individual sentence that summarizes a part of it. – Graham Aug 21 at 2:45
  • As I interpret this, for a textual context issue where there's some context missing, it can either be egregious enough to warrant flagging as UWYA, or minor enough simply to leave a comment. – Graham Aug 21 at 2:45
  • @Mast That was a rushed sentance, I'll try write it a little cleaner. – Peilonrayz Aug 21 at 7:00

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .