0
\$\begingroup\$

In other words: if a CR question asks only for performance feedback, or only for OOP structure feedback, etc., is that valid? And would answers providing review feedback on other aspects of the code be off-topic?

For example, Time and space complexity of base conversion code . Is it possible to constrain this question only to algorithmic feedback?

\$\endgroup\$
3
  • \$\begingroup\$ I don't have time to look for a duplicate, but we've had the answer to this question for years. Why the need for a stand alone question? 1, 2, 3, 4 or 5. \$\endgroup\$
    – Peilonrayz Mod
    Commented Aug 26, 2019 at 18:01
  • \$\begingroup\$ I couldn't find the answer on a meta search and a read through the help. @rolfl's citation is the correct one. If you think this needs to be closed as a dupe, go for it. \$\endgroup\$
    – Reinderien
    Commented Aug 26, 2019 at 18:03
  • \$\begingroup\$ Rolfl's citation isn't a post. \$\endgroup\$
    – Peilonrayz Mod
    Commented Aug 26, 2019 at 18:04

1 Answer 1

4
\$\begingroup\$

Questions can certainly request specific insights areas of focus. But that does not mean that other areas have to be ignored.

If you have insights or observations in to other areas that were not specifically requested, then you are free to answer on those other issues.

Obviously, your feedback may not be as valuable to the question asker as they may want, and they will likely accept a different answer that covers their most significant concerns.

Part of the basic premise of Code Review as a site, is that any and all feedback is, or should be welcome. See the help center "On topic" page for that:

  • Do I want feedback about any or all facets of the code?

    Feel free to call attention to specific areas you are concerned about (performance, formatting, etc). However, any aspect of the code posted is fair game for feedback and criticism.

\$\endgroup\$

Not the answer you're looking for? Browse other questions tagged .