7
\$\begingroup\$

I noticed this suggest edit:

the suggested edit in question

This suggested edit does two things:

  • Replace using namespace std;, which is considered bad practice in C++, with std::.

  • Fix a divide-by-zero bug by special-casing zero.

This edit was rejected by πάντα ῥεῖ, and then approved by Mathieu Guindon ♦.

I disagree with this edit. We do not generally allow editing someone else's code in a question because editing the post is not constructive and it is much more helpful to leave a comment or answer that points out the shortcomings. Code Review is a question and answer site for seeking peer review of your code. An edit with the summary "updated code" is not a review in my opinion. Therefore, this edit kinda defeats the purpose of code reviewing. Therefore, I rolled back the edit as soon as I saw it.

However, I am not 100% sure my action was appropriate. This edit was approved by a moderator, so there has to be a reason. Was my rollback correct? If not, why not?

| |
\$\endgroup\$
12
\$\begingroup\$

This specific case is a bit unusual in that the edit was "suggested" by a user with the same username as the original author. Note also that the original author's account is unregistered, which unfortunately makes it really easy to lose access to the account.

Unregistered users are basically identified through their cookies making it impossible to use that login across different devices. I assume that's what made Mat take a closer look at the users.

With moderator-only information I'm confident that these two users are in fact the same person, so the suggested edit should be treated as an edit by the OP (which implies that the edit is perfectly fine, so long as it doesn't invalidate an answer). At the time of writing no answer has been given, so I've rolled back the rollback.

| |
\$\endgroup\$
  • \$\begingroup\$ Thank you. I completely missed the fact that the two users have the same name. Now everything makes perfect sense! \$\endgroup\$ – L. F. Nov 22 '19 at 9:54
  • \$\begingroup\$ @L.F. Keep in mind that "so the suggested edit should be treated as an edit by the OP" is from a moderator's standpoint. From a normal user's standpoint, we can't verify based on username alone so we usually reject the edit as 'causes harm', which has a nifty textbox where we explain why we reject the edit. \$\endgroup\$ – Mast Nov 25 '19 at 9:48
  • \$\begingroup\$ You should merge the accounts so the user can get their question back and remove the rep if needed. \$\endgroup\$ – S.S. Anne Nov 26 '19 at 0:26
  • 1
    \$\begingroup\$ @JL2210 moderators are not able to merge user accounts. That has been changed even before I was elected... We did get the ball rolling on that, though. \$\endgroup\$ – Vogel612 Nov 26 '19 at 10:52
  • \$\begingroup\$ Really? I've seen it done before... Is it the staff that can do it? \$\endgroup\$ – S.S. Anne Nov 26 '19 at 11:55
  • \$\begingroup\$ @JL2210 Community moderators do that, that's a special kind of moderator that has nothing to do with the normal kind. Those are staff, yes. \$\endgroup\$ – Mast Dec 1 '19 at 20:54
  • \$\begingroup\$ Another edit by the OP was also rejected. \$\endgroup\$ – S.S. Anne Dec 1 '19 at 21:02

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .