Stack Exchange Network

Stack Exchange network consists of 174 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [answers]

This tag is for questions about answers: how to answer, whether specific answers are appropriate, and so forth.

2
votes
2answers
91 views

I broke your code, therefore your code doesn't work: NAA discussion

Let's say the OP had code like this (imagine there's actual code here, I'm just making a generalized example for meta): ...
0
votes
2answers
124 views

Accepting without upvoting

What could be the reason for accepting an answer but not upvoting it? Situations: Accepting own answer - ok, no upvote on self-answers OP not having 15 reputation cannot upvote. I think that OP shold ...
3
votes
2answers
91 views

How to prevent people from answering off-topic questions?

Assume a person is asking about their broken code and someone suffering from FGITW-syndrome immediately answers it. Then maybe the answer and/or even the question gets upvoted. This completely ...
12
votes
3answers
177 views

Why should I be able to answer my own question in the question's editor on Code Review?

I don't get why I am allowed to post an answer to my question in the question's editor: I know from Stack Overflow that this feature exists on Stack Exchange websites. It seems relevant for Stack ...
14
votes
3answers
236 views

Making great content more visible

I often browse older questions on CR and while there are many good and helpful answers, every so often I come across great answers. Those are eloquent and full of helpful tips and general information. ...
2
votes
4answers
85 views

Should answers refrain from referring to other answers on the same question?

Reviews don't pile up at the same time. Whereas Alice was already awake when Charlie's question was posted and wrote an excellent review first, Bob took a longer nap, had a coffee, and then noticed ...
2
votes
5answers
81 views

Inline review format

What are your thoughts on writing reviews fully as inline code? We all take time out of our day to do these reviews but writing good reviews takes time, looking at the posted code, switching editors, ...
31
votes
6answers
390 views

On the huge amount of work needed for a CR answer

I'm a regular at Stack Overflow, and I just recently discovered Code Review, where I answered some questions with the d3.js tag. We all know that CR is quite different from SO: by its very nature, ...
8
votes
2answers
179 views

How should we handle answers on non-code questions?

Recently I've come across a question that didn't contain any code. The questioner instead asked for code, as some new users do. So far same business as usual, but a user went ahead and posted a ...
-4
votes
3answers
130 views

What about questions which demands expert opinion and design feedback

This has been an issue here since a long time and I see a lot of people just to get brownie points jump in and copy paste the answers which can be as generic as possible for example: Use linter Bad ...
2
votes
0answers
26 views

Is proposing an alternative approach instead of code improvements a valid answer? [duplicate]

I remember seeing a question which caused me to ask myself: "Why even bother writing all that code if XYZ would reliably solve that problem in a few lines?" Would it be a relevant answer if I ...
7
votes
0answers
49 views

Never received notification that an answer to my question was posted

I just happened to look at a question I asked a month ago and noticed that an answer was posted a week after I asked the question. I was surprised to see an answer since I didn't recall ever receiving ...
21
votes
6answers
407 views

Is there a limit to the number of answers a user can post to one single question?

Example situation1 We have a user that finds a question and posts an answer for each and every change they would make - commonly being a single low-hanging fruit point, but not limited to it. It ...
8
votes
1answer
194 views

Peer review a code review?

I recently made a for me, somewhat extensive code review and going through all the details I am unsure if I didn't lose myself a bit to much in reviewing. Can we ask in someway to peer review a code ...
14
votes
2answers
435 views

Why are alternative solutions not welcome?

I skipped reviewing this answer because I am not sure what to do with it after I read the comment posted below it: Welcome to Code Review! You have presented an alternative solution, but haven't ...
2
votes
1answer
80 views

Text minimum in questions

On all Stack Exchange sites, you can't post answers or questions that are mostly code. You always have to include some text minimum, otherwise you can't post the question. I do understand why this is ...
0
votes
2answers
73 views

Why has my suggested edit to rename some variables in an answer been rejected?

I have made an edit to this answer about 'Lissajous pattern simulator' to replace misleading names of two varables xStart and ...
11
votes
2answers
149 views

Respond to an answer?

I've asked a question and someone answered it. But inside the answer, there are some questionings, like "I'm not sure I understand your code here...". Should I attempt to answer the questions of the ...
11
votes
2answers
162 views

Indentation in answers

I've noticed that on three occasions now (1, 2, 3) people have edited my answers and removed the indentation that I had left in quotes from OP's code and in suggested replacements. One went so far as ...
6
votes
2answers
140 views

Is an answer not discussing the code at all on-topic?

I came across the question: Single-page personal portfolio website It has an answer, that doesn't review the code at all. It only comments: […] I can tell you there is not many things you can ...
5
votes
3answers
101 views

Is it OK to put a lengthy comment on an answer in another answer?

I posted some code the other week, and got a very good answer. Some of the answer was totally new to me, some of it I found difficult at first sight. So, I went googling to try and understand. In ...
0
votes
2answers
28 views

Answer deleted/converted to comment- can't fathom why

This is on the Code Review site. Someone posted their code for building a SQL Connection String. My answer points them to the Microsoft class whose purpose is to do this exactly: Prompting user for ...
1
vote
4answers
259 views

Is it really necessary to explain trivial answers? [closed]

OP: How do I rewrite x = a + 1 + b - 1? Me: x = a + b. Community: hey, you didn't explain how you did that! Take 5 ...
2
votes
3answers
158 views

Preventing the ability to re-open off-topic questions by explaining how it's broken in an answer

Earlier this year I posted an answer to a question, saying that it's broken in a way that OP don't think, explaining it a bit, and then wrote a comment saying it's off-topic, and voted to close. ...
8
votes
2answers
158 views

If my review includes code, must it be a perfectly working solution to the OP's problem?

Often when I write an answer I write some code to go with it, ie "this method is written a little weird, you could simplify it as X, Y, Z, example". This code is ...
-8
votes
2answers
102 views

Code Score Cards

I'm trying out a new type of review, which includes a score card at the top in addition to the rest of the review to summarize how the code shapes up. I would like to standardize the scores within ...
11
votes
3answers
261 views

Is it acceptable for an answer to contain fully rewritten code?

Often when I am reviewing code on Code Review I focus on readability of code, SRP, testing and things of that nature. For example, as I am writing an answer, I point out bad variable, function and/or ...
7
votes
0answers
66 views

Would it be possible to have the question closer to the answer field?

I find that when answering a question on Code Review, I'm constantly scrolling to the top of the page, copying some code, scrolling to the bottom, pasting it, then editing it. I do this over and over. ...
23
votes
4answers
658 views

Should pedantry be discouraged?

I'm taking about this answer which is essentially pedantry about two variable names, which seems to be meant as a funny remark. I mentioned (in the first comment) that such an answer contributes far ...
2
votes
0answers
35 views

How do we feel about canonical post for repeat review concepts? [duplicate]

I had started to write a question where I felt I was just going to repeat myself in reviews. Well I've been in the city since I was two and I certainly wouldn't say that I was stuck in a rut... ...
3
votes
2answers
55 views

Dynamic editor width when answering

After answering a few questions on Code Review and Stack Overflow, I noticed that the editor allows you to resize vertically, but not horizontally. The width seems to allow 80 characters. My ...
13
votes
6answers
166 views

Is nitpicking worthy of a full answer?

Sometimes, others have already pointed out the obvious flaws in a review. What is left after that are details: naming conventions, style conventions, things that are not bugs that affect results, ...
13
votes
1answer
189 views

Is the automatic low quality answer comment unfit for Code Review?

This is the comment made on my behalf when I recommended deletion on an answer in the VLQ queue: This does not provide an answer to the question. To critique or request clarification from an author,...
17
votes
3answers
178 views

What are our answer editing guidelines?

On this site, we have a well-known policy on editing code in questions: Don't. After all, that code is up for review, in all its glorious ugliness and buginess. But clearly, such reasoning cannot ...
12
votes
5answers
213 views

Downvoting trivial answers

I think the most important question when reading an answer is: Will this answer make the code better? If the answer is yes!, that merits an upvote. But if the answer is meh??, I think the answer needs ...
10
votes
1answer
80 views

Upon finding a bug, should you continue reviewing? [duplicate]

Occasionally, when I am writing a review, I'll notice that the OP's code has a small typo in it that renders that part of their code broken. Should I stop, delete my review, and leave them a comment ...
9
votes
3answers
89 views

Should I cast a VLQ flag on an answer that has a moderator notice on it?

This question has arisen from a discussion on the following question: https://codereview.stackexchange.com/questions/98669/best-way-to-work-with-async The answer posted was flagged as a Very Low ...
15
votes
5answers
154 views

Do you have to speak the language to answer the question?

I frequently read in chat users saying things about not being able to answer this question or that because they don't know the language used in the question. Is this true? What knowledge level is ...
2
votes
0answers
41 views

When is it okay to post multiple answers? [duplicate]

Recently, I decided to look over this post again. As I was reading all the answers, I started to get the feeling that I had seen an answerer's name more than once. Scrolling back up the page, I found ...
7
votes
1answer
72 views

Is it okay to give a review without actually answering some of the OP's requests?

I sometimes find questions that look interesting, or badly need a review, but sometimes the OP requests certain things to be reviewed, like "algorithm correctness", or "performance help". Sometimes I ...
12
votes
5answers
103 views

Answering a JavaScript question with jQuery

Say someone writes a question about some JavaScript code that does not use jQuery. Then, someone comes along to write a review. In their review, the first thing they write is that the OP should use ...
7
votes
2answers
53 views

Using another answer's improvement in your own answer

Hypothetical scenario: Person A writes a review for a question. He writes a improvement X. Person B also writes a review for the question, after person A does. Person B has something to add to ...
3
votes
3answers
80 views

Is it appropriate to reveal solutions to public challenges in comments and answers?

I've seen a question that asks for a review of a piece of code that solves a public coding challenge (linked in the question). The first comment just discloses the optimal solution without actually ...
10
votes
3answers
69 views

Should you write the code for the OP?

I've seen a couple of answers have sections at the end of the post where it brings together all of the recommendations that have been mentioned in that post and re-writes the code using those ...
20
votes
3answers
174 views

A code review without the code

Recently, I wrote a review that discussed certain points in the OP's code, but did not contain any code in the review itself. Are answers like these discouraged?
12
votes
6answers
122 views

Performance checking tools

Performance checkers: What tools are available for attaining the metrics necessary to perform a performance review? Bench-marking is often not easily done by hand after all. This is a follow-up to ...
24
votes
26answers
1k views

Tools for format and error checking in your programming language

Lints and Hints: What tools are available for checking and correcting the conventions, style and common errors in my language (lint tools), and are there tools that can automatically fix them (hint ...
12
votes
2answers
129 views

Is there a place for automated code reviews?

What I'd wish for is that I wouldn't have to be a human lint tool. — Pimgd There are questions on CR where running the code through lint or a similar tool could give useful tips to the poster, ...
20
votes
4answers
238 views

Justify your review!

The same problems come up over and over again in code reviews and it can get a bit tiresome wheeling out the same basic items of advice. If it were a code review at work, you'd be quite within your ...
6
votes
1answer
84 views

To what extent should a recorded Excel macro be rewritten (removing .Select)?

I'm just feeling my way around here, having had a post recently moved over from another site together with its question. While I like the idea of a place to ask specifically for improvements to ...