Questions tagged [answers]

This tag is for questions about answers: how to answer, whether specific answers are appropriate, and so forth.

Filter by
Sorted by
Tagged with
11
votes
4answers
187 views

Reviewing Programming Challenge requirements and givens

As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions ...
20
votes
5answers
378 views

What IS a Code Review?

So, this site is called "Code Review"... What we do here is... ask for and write Code Reviews, naturally. However, I feel that there are a whole bunch of different thoughts floating around about ...
5
votes
1answer
116 views

Alternate solution - what counts as an insightful observation?

One of our latest HNQ's has drawn the attention of alternate solutions. Soon after the question was posted I answered it with an alternate solution, and got quite a few upvotes. My first version ...
16
votes
1answer
128 views

Is simply telling someone to use an API an appropriate code review?

I recently viewed a question where the only answer was simply telling the OP to use a provided API instead of scraping data themselves. Is this considered an appropriate answer on Code Review? My ...
16
votes
2answers
131 views

Advice without knowledge of specific language

I'm here for a little more than one year now but still very new to the how-to of the place, and a recent comment in this post made me think that maybe I was ...
0
votes
2answers
53 views

Add a link as an answer to myself

I asked a question here a couple of days ago and I just found an excellent video on YouTube (Computerphile channel) that has a direct connection with the code I posted in my question, and could help ...
11
votes
2answers
156 views

Reviewing non-working code when author thinks it's working?

I came across a pretty simple question where the author explicitly states: The function returns the correct output, and all known edge cases have been accounted for. I took this at face value and ...
3
votes
1answer
47 views

Code following bulleted list not formatting

I encountered this bug a few minutes ago, and decided to bring it up here. It happens when both asking and answering a question. Steps to reproduce 1. Create bulleted list with a couple/few items. I ...
0
votes
2answers
37 views

Are mods allowed to answer non-meta questions?

This may seem like a very simple question with a very simple answer, but it’s been bugging me. Having looked through hundreds of answers on questions on the regular site, I only see answers from ...
28
votes
26answers
2k views

Tools for format and error checking in your programming language

Lints and Hints: What tools are available for checking and correcting the conventions, style and common errors in my language (lint tools), and are there tools that can automatically fix them (hint ...
5
votes
2answers
132 views

Is an answer that doesn't provide any code review, only how to unit test on-topic?

I ran across this answer which gives no code review feedback only how to write unit tests. If there were some unit tests provided, then they would be fair game for a code review also. In this case it ...
21
votes
1answer
210 views

Complete code rewrite

I came across this question today: Count the ways to partition an array into two equal sets This question can be interpreted in a way, that it asks for a complete rewrite of the code, and indeed ...
15
votes
2answers
247 views

Can answers to questions contain only code not the same language?

This is in regards to Solving the Lazy Hobo Riddle. Is it acceptable to have answers that have code written in a different language than the OP's? The OP has since accepted an answer, but others are ...
0
votes
2answers
144 views

Accepting without upvoting

What could be the reason for accepting an answer but not upvoting it? Situations: Accepting own answer - ok, no upvote on self-answers OP not having 15 reputation cannot upvote. I think that OP shold ...
3
votes
2answers
101 views

I broke your code, therefore your code doesn't work: NAA discussion

Let's say the OP had code like this (imagine there's actual code here, I'm just making a generalized example for meta): ...
3
votes
2answers
114 views

How to prevent people from answering off-topic questions?

Assume a person is asking about their broken code and someone suffering from FGITW-syndrome immediately answers it. Then maybe the answer and/or even the question gets upvoted. This completely ...
12
votes
6answers
133 views

Performance checking tools

Performance checkers: What tools are available for attaining the metrics necessary to perform a performance review? Bench-marking is often not easily done by hand after all. This is a follow-up to ...
12
votes
3answers
178 views

Why should I be able to answer my own question in the question's editor on Code Review?

I don't get why I am allowed to post an answer to my question in the question's editor: I know from Stack Overflow that this feature exists on Stack Exchange websites. It seems relevant for Stack ...
15
votes
3answers
244 views

Making great content more visible

I often browse older questions on CR and while there are many good and helpful answers, every so often I come across great answers. Those are eloquent and full of helpful tips and general information. ...
2
votes
4answers
88 views

Should answers refrain from referring to other answers on the same question?

Reviews don't pile up at the same time. Whereas Alice was already awake when Charlie's question was posted and wrote an excellent review first, Bob took a longer nap, had a coffee, and then noticed ...
2
votes
5answers
98 views

Inline review format

What are your thoughts on writing reviews fully as inline code? We all take time out of our day to do these reviews but writing good reviews takes time, looking at the posted code, switching editors, ...
31
votes
6answers
409 views

On the huge amount of work needed for a CR answer

I'm a regular at Stack Overflow, and I just recently discovered Code Review, where I answered some questions with the d3.js tag. We all know that CR is quite different from SO: by its very nature, ...
8
votes
2answers
184 views

How should we handle answers on non-code questions?

Recently I've come across a question that didn't contain any code. The questioner instead asked for code, as some new users do. So far same business as usual, but a user went ahead and posted a ...
-5
votes
3answers
146 views

What about questions which demands expert opinion and design feedback

This has been an issue here since a long time and I see a lot of people just to get brownie points jump in and copy paste the answers which can be as generic as possible for example: Use linter Bad ...
2
votes
0answers
27 views

Is proposing an alternative approach instead of code improvements a valid answer? [duplicate]

I remember seeing a question which caused me to ask myself: "Why even bother writing all that code if XYZ would reliably solve that problem in a few lines?" Would it be a relevant answer if I ...
7
votes
0answers
49 views

Never received notification that an answer to my question was posted

I just happened to look at a question I asked a month ago and noticed that an answer was posted a week after I asked the question. I was surprised to see an answer since I didn't recall ever receiving ...
16
votes
2answers
549 views

Why are alternative solutions not welcome?

I skipped reviewing this answer because I am not sure what to do with it after I read the comment posted below it: Welcome to Code Review! You have presented an alternative solution, but haven't ...
21
votes
6answers
425 views

Is there a limit to the number of answers a user can post to one single question?

Example situation1 We have a user that finds a question and posts an answer for each and every change they would make - commonly being a single low-hanging fruit point, but not limited to it. It ...
8
votes
1answer
195 views

Peer review a code review?

I recently made a for me, somewhat extensive code review and going through all the details I am unsure if I didn't lose myself a bit to much in reviewing. Can we ask in someway to peer review a code ...
19
votes
1answer
363 views

Checklist or general directions on how to write a good CR-ish answer

This question is intended to be the counterpart of Checklist for how to write a good Code Review question. Getting started with Code Review: New users often seem to have problems to understand, what ...
3
votes
1answer
93 views

Text minimum in questions

On all Stack Exchange sites, you can't post answers or questions that are mostly code. You always have to include some text minimum, otherwise you can't post the question. I do understand why this is ...
0
votes
2answers
76 views

Why has my suggested edit to rename some variables in an answer been rejected?

I have made an edit to this answer about 'Lissajous pattern simulator' to replace misleading names of two varables xStart and ...
12
votes
2answers
157 views

Respond to an answer?

I've asked a question and someone answered it. But inside the answer, there are some questionings, like "I'm not sure I understand your code here...". Should I attempt to answer the questions of the ...
11
votes
2answers
165 views

Indentation in answers

I've noticed that on three occasions now (1, 2, 3) people have edited my answers and removed the indentation that I had left in quotes from OP's code and in suggested replacements. One went so far as ...
1
vote
0answers
35 views

How do we feel about canonical post for repeat review concepts? [duplicate]

I had started to write a question where I felt I was just going to repeat myself in reviews. Well I've been in the city since I was two and I certainly wouldn't say that I was stuck in a rut... ...
12
votes
3answers
158 views

Duplicated answers for duplicate patterns/subroutines

Question 1 - Answer 1 Question 2 - Answer 2 Question 3 - Answer 3 More duplicates of this pattern from the same user: Iterator for binary tree - pre, in, and post order iterators Isomorphic trees ...
6
votes
2answers
148 views

Is an answer not discussing the code at all on-topic?

I came across the question: Single-page personal portfolio website It has an answer, that doesn't review the code at all. It only comments: […] I can tell you there is not many things you can ...
0
votes
2answers
31 views

Answer deleted/converted to comment- can't fathom why

This is on the Code Review site. Someone posted their code for building a SQL Connection String. My answer points them to the Microsoft class whose purpose is to do this exactly: Prompting user for ...
4
votes
3answers
103 views

Is it OK to put a lengthy comment on an answer in another answer?

I posted some code the other week, and got a very good answer. Some of the answer was totally new to me, some of it I found difficult at first sight. So, I went googling to try and understand. In ...
1
vote
4answers
280 views

Is it really necessary to explain trivial answers? [closed]

OP: How do I rewrite x = a + 1 + b - 1? Me: x = a + b. Community: hey, you didn't explain how you did that! Take 5 ...
2
votes
3answers
204 views

Preventing the ability to re-open off-topic questions by explaining how it's broken in an answer

Earlier this year I posted an answer to a question, saying that it's broken in a way that OP don't think, explaining it a bit, and then wrote a comment saying it's off-topic, and voted to close. ...
8
votes
2answers
164 views

If my review includes code, must it be a perfectly working solution to the OP's problem?

Often when I write an answer I write some code to go with it, ie "this method is written a little weird, you could simplify it as X, Y, Z, example". This code is ...
32
votes
4answers
1k views

How can I be a nice reviewer?

From Remove Nth Node from End of Linked List: Bug: n < 0 leads to you removing the last node. Your solution should have comments: I have NO idea how it ...
13
votes
1answer
192 views

Is the automatic low quality answer comment unfit for Code Review?

This is the comment made on my behalf when I recommended deletion on an answer in the VLQ queue: This does not provide an answer to the question. To critique or request clarification from an author,...
-9
votes
2answers
108 views

Code Score Cards

I'm trying out a new type of review, which includes a score card at the top in addition to the rest of the review to summarize how the code shapes up. I would like to standardize the scores within ...
11
votes
3answers
266 views

Is it acceptable for an answer to contain fully rewritten code?

Often when I am reviewing code on Code Review I focus on readability of code, SRP, testing and things of that nature. For example, as I am writing an answer, I point out bad variable, function and/or ...
7
votes
0answers
67 views

Would it be possible to have the question closer to the answer field?

I find that when answering a question on Code Review, I'm constantly scrolling to the top of the page, copying some code, scrolling to the bottom, pasting it, then editing it. I do this over and over. ...
6
votes
1answer
149 views

Is solely suggesting another solution a bad answer?

Related to Is a bad approach for a problem a good reason to close a question?, this question is about the opposite instead: Is solely suggesting another solution a bad answer? We've been over this ...
24
votes
4answers
744 views

Should pedantry be discouraged?

I'm taking about this answer which is essentially pedantry about two variable names, which seems to be meant as a funny remark. I mentioned (in the first comment) that such an answer contributes far ...
3
votes
2answers
55 views

Dynamic editor width when answering

After answering a few questions on Code Review and Stack Overflow, I noticed that the editor allows you to resize vertically, but not horizontally. The width seems to allow 80 characters. My ...