Questions tagged [answers]

This tag is for questions about answers: how to answer, whether specific answers are appropriate, and so forth.

Filter by
Sorted by
Tagged with
40
votes
8answers
1k views

Short answers and code-only answers

What should we do with: Short answers (for example, "I suggest you use [hyperlink to this standard API] instead.") Code-only answers (for example, an improved version of the code in the OP) Such ...
38
votes
2answers
2k views

Jack of All Trades, Master of None - Let's work together to offer ultimately better content, faster

Nhgrif pointed out a great idea: Teamwork "I think it's probably best if the question instead has several good answers that each address a specific topic. The result will be that no single ...
12
votes
2answers
328 views

Answering Guidelines (answer length)

From Grace Note's CR review (emphasis mine): Time to Answer Jon Ericson, another Community Manager, ran some numbers on the site and discovered that the average time it takes for a question to ...
21
votes
4answers
277 views

Justify your review!

The same problems come up over and over again in code reviews and it can get a bit tiresome wheeling out the same basic items of advice. If it were a code review at work, you'd be quite within your ...
16
votes
2answers
364 views

How much can an answer be subject to opinion?

I am new to this site, but love reviewing code and having my code reviewed. One thing that is always difficult for me when I'm reviewing code is to determine whether some of the points I'm making ...
41
votes
5answers
870 views

Should “your code seems fine” answers be acceptable?

I want to ask your opinion on how we should handle submitted question with code that is "fine". I assume that will be the case for very view of the submitted review requests since everyone likes and ...
26
votes
4answers
605 views

Is “just reviewing the code” good enough of an answer?

Looking back at some of my last few answers (here and especially here), I started wondering if these answers were good enough. Allow me to expand: in these answers I went through the code almost line ...
22
votes
3answers
288 views

Should one person have multiple answers?

This question came up in regards to my comment on this post. If somebody has two different approaches for reviewing a piece of code, should they combine them into one answer, or have separate answers?...
18
votes
1answer
391 views

Checklist or general directions on how to write a good CR-ish answer

This question is intended to be the counterpart of Checklist for how to write a good Code Review question. Getting started with Code Review: New users often seem to have problems to understand, what ...
3
votes
3answers
230 views

Preventing the ability to re-open off-topic questions by explaining how it's broken in an answer

Earlier this year I posted an answer to a question, saying that it's broken in a way that OP don't think, explaining it a bit, and then wrote a comment saying it's off-topic, and voted to close. ...
28
votes
26answers
2k views

Tools for format and error checking in your programming language

Lints and Hints: What tools are available for checking and correcting the conventions, style and common errors in my language (lint tools), and are there tools that can automatically fix them (hint ...
7
votes
1answer
108 views

Is it okay to give a review without actually answering some of the OP's requests?

I sometimes find questions that look interesting, or badly need a review, but sometimes the OP requests certain things to be reviewed, like "algorithm correctness", or "performance help". Sometimes I ...
19
votes
5answers
399 views

What IS a Code Review?

So, this site is called "Code Review"... What we do here is... ask for and write Code Reviews, naturally. However, I feel that there are a whole bunch of different thoughts floating around about ...
8
votes
1answer
614 views

Guidelines for new users + proposal tag

When asking a question on code-review, the goal is clear: To get a second opinion on your code. By peers, or by people with more experience ("experts", some might say). If you post a ton of ...
6
votes
1answer
155 views

Is solely suggesting another solution a bad answer?

Related to Is a bad approach for a problem a good reason to close a question?, this question is about the opposite instead: Is solely suggesting another solution a bad answer? We've been over this ...
14
votes
2answers
164 views

Is there a place for automated code reviews?

What I'd wish for is that I wouldn't have to be a human lint tool. — Pimgd There are questions on CR where running the code through lint or a similar tool could give useful tips to the poster, ...
13
votes
6answers
146 views

Performance checking tools

Performance checkers: What tools are available for attaining the metrics necessary to perform a performance review? Bench-marking is often not easily done by hand after all. This is a follow-up to ...
18
votes
2answers
364 views

Should code block(s) as answers always require an explanation?

Here is a great example of this. Granted, that was that user's first post, but this is still common. UPDATE: That example has since been updated, so consult the original version. This type of ...
11
votes
1answer
169 views

What makes for a good answer?

I found myself looking for some place to point a new user on why his answer wasn't a good answer. I couldn't find anything except the fairly unhelpful Help page's "How do I write a good answer". So, ...
20
votes
9answers
257 views

Help spot deficiencies in our Help Center

Regular participants will be familiar with procedures and practices on Code Review. For example, we have rules against asking hypothetical questions appending to or modifying the question after ...
11
votes
8answers
311 views

Best of Code Review 2014 - Exterminator category

Please post your nominations for the Best of Code Review 2014 - Exterminator category. Answer that points out the most interesting obscure bug in the original code. In your nomination post, please ...
10
votes
5answers
173 views

Should we merge multiple answers from the same person? [duplicate]

Today, I ran across this question which had already been answered by Malachi 3 times before I looked at it. I decided that since he answered in multiple answers, I might as well do the same thing. I ...
19
votes
3answers
182 views

A code review without the code

Recently, I wrote a review that discussed certain points in the OP's code, but did not contain any code in the review itself. Are answers like these discouraged?
8
votes
1answer
204 views

Peer review a code review?

I recently made a for me, somewhat extensive code review and going through all the details I am unsure if I didn't lose myself a bit to much in reviewing. Can we ask in someway to peer review a code ...
3
votes
1answer
108 views

Should quick fixes to non-working code go into comments only?

I've started thinking about this after seeing the answer for this question. Of course, non-working code shouldn't be posted here. However, there are times where someone addresses such issues in an ...
3
votes
1answer
110 views

Text minimum in questions

On all Stack Exchange sites, you can't post answers or questions that are mostly code. You always have to include some text minimum, otherwise you can't post the question. I do understand why this is ...
30
votes
6answers
423 views

On the huge amount of work needed for a CR answer

I'm a regular at Stack Overflow, and I just recently discovered Code Review, where I answered some questions with the d3.js tag. We all know that CR is quite different from SO: by its very nature, ...
10
votes
7answers
520 views

Best of Code Review 2014 - Lots of Laughs category

Please post your nominations for the Best of Code Review 2014 - Lots of Laughs category. Answer that makes the best use of humor to illustrate a point. In your nomination post, please make sure to ...
31
votes
4answers
2k views

How can I be a nice reviewer?

From Remove Nth Node from End of Linked List: Bug: n < 0 leads to you removing the last node. Your solution should have comments: I have NO idea how it ...
17
votes
2answers
672 views

Why are alternative solutions not welcome?

I skipped reviewing this answer because I am not sure what to do with it after I read the comment posted below it: Welcome to Code Review! You have presented an alternative solution, but haven't ...
18
votes
3answers
219 views

What are our answer editing guidelines?

On this site, we have a well-known policy on editing code in questions: Don't. After all, that code is up for review, in all its glorious ugliness and buginess. But clearly, such reasoning cannot ...
16
votes
2answers
290 views

Can answers to questions contain code written in a different language?

This is in regards to Solving the Lazy Hobo Riddle. Is it acceptable to have answers that have code written in a different language than the OP's? The OP has since accepted an answer, but others are ...
12
votes
1answer
94 views

Tips for writing better answers

I was writing an answer to a question the other day and after I had finished it I wished I had some feedback as to what could make the answer better. How could I write it better. What headings could ...
12
votes
3answers
252 views

So votes are good for us. How can I find answers/reviews to vote for?

In fall 2013, we went on a mission, and bumped the site's answered% from 88% to 93%. As new questions flow in, the answered% has been remaining steady at 93% for several weeks, we're doing good (...
8
votes
9answers
308 views

Best of Code Review 2014 - Night and Day category

Please post your nominations for the Best of Code Review 2014 - Night and Day category. The most dramatic improvement (nominate both the question with the most hopeless code and the answer that ...
5
votes
3answers
165 views

Best of Code Review 2013 — Diplomat category

Please post your nominations for Best of Code Review 2013 — Diplomat category: Tough advice in an answer, delivered in the most tactful manner. In your nomination post, be sure to include a link to ...
3
votes
4answers
151 views

Best of Code Review 2013 — Exterminator category

Please post your nominations for Best of Code Review 2013 — Exterminator category: Answer that points out the most interesting obscure bug in the original code. In your nomination post, be sure to ...
3
votes
3answers
116 views

Best of Code Review 2013 — Gordian Knot Untied category

Please post your nominations for Best of Code Review 2013 — Gordian Knot Untied category: Most justified advice in an answer for taking a completely different approach from the code in the original ...
2
votes
5answers
202 views

Best of Code Review 2013 — Night and Day category

Please post your nominations for Best of Code Review 2013 — Night and Day category: The most dramatic improvement. In your nomination post, be sure to include a link to the answer, as well as a short ...
12
votes
1answer
111 views

Self-answers that re-write code with little/no explanation

I came across this self-answer today: https://codereview.stackexchange.com/a/10844/46800 It had no explanation or evaluation of the code in question, just a code rewrite. This seems to me to not ...
12
votes
3answers
165 views

Duplicated answers for duplicate patterns/subroutines

Question 1 - Answer 1 Question 2 - Answer 2 Question 3 - Answer 3 More duplicates of this pattern from the same user: Iterator for binary tree - pre, in, and post order iterators Isomorphic trees ...
12
votes
3answers
196 views

Why should I be able to answer my own question in the question's editor on Code Review?

I don't get why I am allowed to post an answer to my question in the question's editor: I know from Stack Overflow that this feature exists on Stack Exchange websites. It seems relevant for Stack ...
12
votes
2answers
165 views

Respond to an answer?

I've asked a question and someone answered it. But inside the answer, there are some questionings, like "I'm not sure I understand your code here...". Should I attempt to answer the questions of the ...
12
votes
1answer
194 views

Multiple answers and unanswerable questions

I have a concern regarding the Code Review site: It seems to me that when a question is posted for code review that there really can be multiple correct answers. In fact, the FAQ states: You ...
11
votes
2answers
229 views

Are encrypted answers acceptable?

In these sorts of problems you can't take the simple approach, you've got to come up with a clever way to avoid actually simulating the eating of the candy bars. Some hints (in rot13), for ...
3
votes
4answers
171 views

Best of Code Review 2013 — Thousand Words category

Please post your nominations for Best of Code Review 2013 — Thousand Words category: Most effective use of images in a question or answer. In your nomination post, be sure to include a link to the ...
3
votes
2answers
133 views

How to prevent people from answering off-topic questions?

Assume a person is asking about their broken code and someone suffering from FGITW-syndrome immediately answers it. Then maybe the answer and/or even the question gets upvoted. This completely ...
2
votes
1answer
58 views

Request to add answer structure close to the answering field

Coming from this post, I'd like to address this as a feature request. What is it about? Lowering the threshold that people might experience when wanting to answer new questions. I have the feeling, ...