The Stack Overflow podcast is back! Listen to an interview with our new CEO.

Questions tagged [answers]

This tag is for questions about answers: how to answer, whether specific answers are appropriate, and so forth.

Filter by
Sorted by
Tagged with
42
votes
5answers
817 views

Should “your code seems fine” answers be acceptable?

I want to ask your opinion on how we should handle submitted question with code that is "fine". I assume that will be the case for very view of the submitted review requests since everyone likes and ...
38
votes
8answers
1k views

Short answers and code-only answers

What should we do with: Short answers (for example, "I suggest you use [hyperlink to this standard API] instead.") Code-only answers (for example, an improved version of the code in the OP) Such ...
38
votes
2answers
1k views

Jack of All Trades, Master of None - Let's work together to offer ultimately better content, faster

Nhgrif pointed out a great idea: Teamwork "I think it's probably best if the question instead has several good answers that each address a specific topic. The result will be that no single ...
32
votes
4answers
1k views

How can I be a nice reviewer?

From Remove Nth Node from End of Linked List: Bug: n < 0 leads to you removing the last node. Your solution should have comments: I have NO idea how it ...
31
votes
6answers
409 views

On the huge amount of work needed for a CR answer

I'm a regular at Stack Overflow, and I just recently discovered Code Review, where I answered some questions with the d3.js tag. We all know that CR is quite different from SO: by its very nature, ...
28
votes
26answers
2k views

Tools for format and error checking in your programming language

Lints and Hints: What tools are available for checking and correcting the conventions, style and common errors in my language (lint tools), and are there tools that can automatically fix them (hint ...
25
votes
4answers
554 views

Is “just reviewing the code” good enough of an answer?

Looking back at some of my last few answers (here and especially here), I started wondering if these answers were good enough. Allow me to expand: in these answers I went through the code almost line ...
24
votes
4answers
745 views

Should pedantry be discouraged?

I'm taking about this answer which is essentially pedantry about two variable names, which seems to be meant as a funny remark. I mentioned (in the first comment) that such an answer contributes far ...
22
votes
3answers
278 views

Should one person have multiple answers?

This question came up in regards to my comment on this post. If somebody has two different approaches for reviewing a piece of code, should they combine them into one answer, or have separate answers?...
21
votes
9answers
254 views

Help spot deficiencies in our Help Center

Regular participants will be familiar with procedures and practices on Code Review. For example, we have rules against asking hypothetical questions appending to or modifying the question after ...
21
votes
6answers
425 views

Is there a limit to the number of answers a user can post to one single question?

Example situation1 We have a user that finds a question and posts an answer for each and every change they would make - commonly being a single low-hanging fruit point, but not limited to it. It ...
21
votes
4answers
253 views

Justify your review!

The same problems come up over and over again in code reviews and it can get a bit tiresome wheeling out the same basic items of advice. If it were a code review at work, you'd be quite within your ...
21
votes
1answer
210 views

Complete code rewrite

I came across this question today: Count the ways to partition an array into two equal sets This question can be interpreted in a way, that it asks for a complete rewrite of the code, and indeed ...
20
votes
3answers
176 views

A code review without the code

Recently, I wrote a review that discussed certain points in the OP's code, but did not contain any code in the review itself. Are answers like these discouraged?
20
votes
5answers
379 views

What IS a Code Review?

So, this site is called "Code Review"... What we do here is... ask for and write Code Reviews, naturally. However, I feel that there are a whole bunch of different thoughts floating around about ...
19
votes
1answer
363 views

Checklist or general directions on how to write a good CR-ish answer

This question is intended to be the counterpart of Checklist for how to write a good Code Review question. Getting started with Code Review: New users often seem to have problems to understand, what ...
18
votes
2answers
354 views

Should code block(s) as answers always require an explanation?

Here is a great example of this. Granted, that was that user's first post, but this is still common. UPDATE: That example has since been updated, so consult the original version. This type of ...
17
votes
3answers
194 views

What are our answer editing guidelines?

On this site, we have a well-known policy on editing code in questions: Don't. After all, that code is up for review, in all its glorious ugliness and buginess. But clearly, such reasoning cannot ...
16
votes
2answers
550 views

Why are alternative solutions not welcome?

I skipped reviewing this answer because I am not sure what to do with it after I read the comment posted below it: Welcome to Code Review! You have presented an alternative solution, but haven't ...
16
votes
2answers
342 views

How much can an answer be subject to opinion?

I am new to this site, but love reviewing code and having my code reviewed. One thing that is always difficult for me when I'm reviewing code is to determine whether some of the points I'm making ...
16
votes
1answer
131 views

Is simply telling someone to use an API an appropriate code review?

I recently viewed a question where the only answer was simply telling the OP to use a provided API instead of scraping data themselves. Is this considered an appropriate answer on Code Review? My ...
16
votes
2answers
131 views

Advice without knowledge of specific language

I'm here for a little more than one year now but still very new to the how-to of the place, and a recent comment in this post made me think that maybe I was ...
16
votes
2answers
179 views

Check list for formatting questions and answers

I have seen that moderators work hard to format questions and answers. Is there a check list they use (specially for CR), so others can also contribute by editing or properly formatting their own ...
15
votes
5answers
158 views

Do you have to speak the language to answer the question?

I frequently read in chat users saying things about not being able to answer this question or that because they don't know the language used in the question. Is this true? What knowledge level is ...
15
votes
5answers
202 views

What are the correct actions to take when there is a 'bad' answer?

When there is an answer you feel is 'bad', what are the correct actions to take? For example, the question: Similar methods using loops has an answer: If you always use both functions together ...
15
votes
3answers
244 views

Making great content more visible

I often browse older questions on CR and while there are many good and helpful answers, every so often I come across great answers. Those are eloquent and full of helpful tips and general information. ...
15
votes
2answers
247 views

Can answers to questions contain only code not the same language?

This is in regards to Solving the Lazy Hobo Riddle. Is it acceptable to have answers that have code written in a different language than the OP's? The OP has since accepted an answer, but others are ...
13
votes
6answers
185 views

Is nitpicking worthy of a full answer?

Sometimes, others have already pointed out the obvious flaws in a review. What is left after that are details: naming conventions, style conventions, things that are not bugs that affect results, ...
13
votes
3answers
116 views

What do you do when an answer is upvoted but is broken?

This answer: File Async writer using Tasks or new features of .Net 4.5? The code in the answer doesn't log until program termination -> lost items in the log. You cannot execute parallel code ...
13
votes
2answers
148 views

Is there a place for automated code reviews?

What I'd wish for is that I wouldn't have to be a human lint tool. — Pimgd There are questions on CR where running the code through lint or a similar tool could give useful tips to the poster, ...
13
votes
2answers
73 views

Reviewing reviews

If I find a review that seems to have a lot wrong with it, as in, I want to go through the review line by line and review it as if it had been a question, what action should I take? A downvote is a ...
13
votes
1answer
192 views

Is the automatic low quality answer comment unfit for Code Review?

This is the comment made on my behalf when I recommended deletion on an answer in the VLQ queue: This does not provide an answer to the question. To critique or request clarification from an author,...
12
votes
5answers
218 views

Downvoting trivial answers

I think the most important question when reading an answer is: Will this answer make the code better? If the answer is yes!, that merits an upvote. But if the answer is meh??, I think the answer needs ...
12
votes
3answers
140 views

Is the SE voting system insufficient for CR answers?

The question that prompted this is Add or view pattern with MVVM (but I think this situation is pretty common). There, you have two answers: one is long, thorough and overall great; the other is much ...
12
votes
5answers
110 views

Answering a JavaScript question with jQuery

Say someone writes a question about some JavaScript code that does not use jQuery. Then, someone comes along to write a review. In their review, the first thing they write is that the OP should use ...
12
votes
6answers
133 views

Performance checking tools

Performance checkers: What tools are available for attaining the metrics necessary to perform a performance review? Bench-marking is often not easily done by hand after all. This is a follow-up to ...
12
votes
2answers
112 views

Should we encourage deliberately incomplete answers?

Let's say you have 5 ideas to criticize in a question. I see some advantages in including only 3 of them in your answer: Other answerers will have more things to say, making it easier to join in: ...
12
votes
3answers
245 views

So votes are good for us. How can I find answers/reviews to vote for?

In fall 2013, we went on a mission, and bumped the site's answered% from 88% to 93%. As new questions flow in, the answered% has been remaining steady at 93% for several weeks, we're doing good (...
12
votes
3answers
178 views

Why should I be able to answer my own question in the question's editor on Code Review?

I don't get why I am allowed to post an answer to my question in the question's editor: I know from Stack Overflow that this feature exists on Stack Exchange websites. It seems relevant for Stack ...
12
votes
3answers
158 views

Duplicated answers for duplicate patterns/subroutines

Question 1 - Answer 1 Question 2 - Answer 2 Question 3 - Answer 3 More duplicates of this pattern from the same user: Iterator for binary tree - pre, in, and post order iterators Isomorphic trees ...
12
votes
2answers
316 views

Answering Guidelines (answer length)

From Grace Note's CR review (emphasis mine): Time to Answer Jon Ericson, another Community Manager, ran some numbers on the site and discovered that the average time it takes for a question to ...
12
votes
1answer
106 views

Self-answers that re-write code with little/no explanation

I came across this self-answer today: https://codereview.stackexchange.com/a/10844/46800 It had no explanation or evaluation of the code in question, just a code rewrite. This seems to me to not ...
12
votes
2answers
157 views

Respond to an answer?

I've asked a question and someone answered it. But inside the answer, there are some questionings, like "I'm not sure I understand your code here...". Should I attempt to answer the questions of the ...
12
votes
1answer
89 views

Tips for writing better answers

I was writing an answer to a question the other day and after I had finished it I wished I had some feedback as to what could make the answer better. How could I write it better. What headings could ...
12
votes
1answer
190 views

Multiple answers and unanswerable questions

I have a concern regarding the Code Review site: It seems to me that when a question is posted for code review that there really can be multiple correct answers. In fact, the FAQ states: You ...
12
votes
1answer
161 views

What makes for a good answer?

I found myself looking for some place to point a new user on why his answer wasn't a good answer. I couldn't find anything except the fairly unhelpful Help page's "How do I write a good answer". So, ...
11
votes
4answers
2k views

Code Hunt : Perfect score means not-so-perfect coding

With a recent question I went to Code Hunt and played there a little bit. At one moment I get this result as question : ...
11
votes
3answers
266 views

Is it acceptable for an answer to contain fully rewritten code?

Often when I am reviewing code on Code Review I focus on readability of code, SRP, testing and things of that nature. For example, as I am writing an answer, I point out bad variable, function and/or ...
11
votes
8answers
309 views

Best of Code Review 2014 - Exterminator category

Please post your nominations for the Best of Code Review 2014 - Exterminator category. Answer that points out the most interesting obscure bug in the original code. In your nomination post, please ...
11
votes
4answers
189 views

Reviewing Programming Challenge requirements and givens

As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions ...