Questions tagged [broken-code]
The broken-code tag has no usage guidance.
28
questions
11
votes
2answers
153 views
Reviewing non-working code when author thinks it's working?
I came across a pretty simple question where the author explicitly states:
The function returns the correct output, and all known edge cases have been accounted for.
I took this at face value and ...
4
votes
1answer
79 views
Review one-by-one feature?
I am writing a library. It is mostly ready, but there are known bugs and ToDo stuff (including for example missing const specifiers for member functions which do ...
4
votes
0answers
43 views
Is a question on topic if the code works locally but errors when submitted to a coding site? [duplicate]
This is about a recently posted question: Codejam 2018 - Getting confusing runtime error
The OP claims it works for him locally, but generates a Runtime Error on the Google Code Jam website itself.
...
8
votes
1answer
181 views
Posting a question where part of the code contains a known bug
There is a particular requirement that has two versions. The first version has proven to be more challenging than the subsequent version to both describe the specification and compose; and also ...
15
votes
1answer
219 views
PSA: Excel going “Not Responding” isn't broken code
Some VBA questions mention the host application (e.g. Excel) is going "not responding" while their macro is running.
Is it ok to vote to close these questions as "broken code"?
14
votes
2answers
228 views
Code that handles n% of test cases but not all
I've started noticing recently questions like this one (66%, not well received) or that one (50%, well received) where the author states something like this:
I am trying to solve this problem on ...
8
votes
2answers
142 views
Why was my edit to fix an answer rejected, even though it was approved by the author?
I suggested an edit to this answer.
The edit came after I suggested the said changes in the comments (with 4 upvotes for the comment) and the author of the post told me it's better if I do it. So I ...
16
votes
5answers
240 views
Are questions with undiscovered bugs allowed?
Re: Connect 4 in C++
Situation: The OP, a beginner posted code with several bugs in it. They said they thought the code worked okay, because they hadn't discovered the bugs during their testing, ...
-3
votes
1answer
50 views
“Count maximum number of thieves that can be caught” question should be reopened
The following question was closed as off-topic:
https://codereview.stackexchange.com/questions/176469/count-maximum-number-of-thieves-that-can-be-caught
The code seems complete to me and the ...
12
votes
2answers
249 views
I think my code might have a bug, but I am not sure if it actually does, is it broken code?
I have some C++ code that I am executing from C# dotnet core 2. In my C++, I am using a third party library. My code builds and runs, but after being executed a few million times (2.5 mil last time) I ...
-1
votes
2answers
59 views
“How get all id from the db insert” question closed as “not ready for review”
I just got my question closed
How get all id from the db insert
Accordingly to message my question isn't on topic because my code doesn't work. But my code does work I just don't want to send so ...
7
votes
3answers
222 views
Made a code-review of broken code, but flagged it as well
I answered this question this morning on code review, mainly because I had the idea there were some things that could be good for a code review, however the code that was given wasn't working as ...
14
votes
2answers
170 views
Why was this question closed as off-topic after a bug was discovered by the answers?
TL;DR
Please clarify: is a previously unknown bug a reason to close a question as off-topic?
Yesterday I was interested to answer this question, where an already written answer pointed out the ...
-5
votes
1answer
112 views
Asking a question to understand why code is broken gets closed
I am trying to understand the compiler's reasoning about a certain implementation involving a default method and an abstract one with this question.
If you see the initial version, it explains that a ...
19
votes
2answers
197 views
Can I edit broken code if I'm sure I'm recreating OP's original code?
I know, I know: "Never edit the code, leave it for the review!". But please, hear me out before answering.
What should I do if I encounter a code that doesn't work, but I'm 99.99% sure it's because ...
16
votes
3answers
283 views
Is our “broken” wording broken?
"Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. After the question has been edited to contain working code, we ...
5
votes
1answer
59 views
What to do with question with compiler warnings/errors due to copy & paste error
Unfortunately in this question I posted some broken code due a copy-n-paste mistake without realizing. I've contemplated closing it but two answers have picked up on it and they also suggest other ...
16
votes
2answers
148 views
How broken does code have to be to for a question to be closed?
I recently voted to close this question:
The longest subsequence with specified difference between min and max
Originally I thought the code was really bad because the OP claimed a linear solution, ...
7
votes
1answer
86 views
Working code vs. working program
I have a feeling that our guidances should be worded better. Take this excerpt from the Help Center:
To the best of my knowledge, does the code work?
I believe this question is incorrect, as seen ...
5
votes
3answers
112 views
The close reason for this question seems vague
Correct User Input - x86 Linux Assembly was closed for being "off topic", but looking at what's on topic, I noticed the likely reason was vaguely stated:
To the best of my knowledge, does the code ...
8
votes
3answers
109 views
Close reasons and migrations (and stats?)
One of the close reasons that exists is:
Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. Such questions may be ...
12
votes
4answers
2k views
What exactly does it mean for code to be “Working Code”?
Why is it that Code Review's definition of "working code" is so misaligned with so many people's expectations?
@rolfl
Well, we've had a lot of discussion about broken code on meta, but we don't seem ...
15
votes
3answers
180 views
Are code snippets with known memory leaks broken?
As part of our check-list for questions on CodeReview, we require that code is working to the best of the askers knowledge.
Does code with a known memory leak qualify is broken per this rule?
On the ...
17
votes
2answers
107 views
May another user fix broken code in a question to make it on-topic?
If we find that a question contains obviously broken code, our standard procedure is to close the question, sending the author back to the drawing board.
But is it acceptable for another user to edit ...
12
votes
2answers
302 views
OP says it works, the contest engine says it doesn't
What do we do when OP says his solution works, but the contest engine says it doesn't? Should we give it the benefit of the doubt, as "It works to the best of my knowledge.", or close it as broken ...
12
votes
4answers
163 views
Can working code be: off-topic -> not-working?
This question here: Shortest possible way of printing a specific board
Summary:
The code requirement is to print out a grid of text.
The code does in fact print the grid
The way it does that, is ...
13
votes
3answers
116 views
What do you do when an answer is upvoted but is broken?
This answer:
File Async writer using Tasks or new features of .Net 4.5?
The code in the answer doesn't log until program termination -> lost items in the log. You cannot execute parallel code ...
10
votes
1answer
217 views
Should mostly working but a little bit broken code stay or be deleted?
I posted the question Parsing structured text in Java
At first I thought it was working, later I have found a bug in the code. Should it stay or should it be deleted?
Update: I have fixed the bug in ...
