Questions tagged [broken-code]

The tag has no usage guidance.

Filter by
Sorted by
Tagged with
13
votes
4answers
3k views

What exactly does it mean for code to be “Working Code”?

Why is it that Code Review's definition of "working code" is so misaligned with so many people's expectations? @rolfl Well, we've had a lot of discussion about broken code on meta, but we ...
13
votes
2answers
239 views

Code that handles n% of test cases but not all

I've started noticing recently questions like this one (66%, not well received) or that one (50%, well received) where the author states something like this: I am trying to solve this problem on ...
15
votes
3answers
297 views

Is our “broken” wording broken?

"Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. After the question has been edited to contain working code, ...
16
votes
5answers
274 views

Are questions with undiscovered bugs allowed?

Re: Connect 4 in C++ Situation: The OP, a beginner posted code with several bugs in it. They said they thought the code worked okay, because they hadn't discovered the bugs during their testing, ...
15
votes
3answers
204 views

Are code snippets with known memory leaks broken?

As part of our check-list for questions on CodeReview, we require that code is working to the best of the askers knowledge. Does code with a known memory leak qualify is broken per this rule? On the ...
12
votes
4answers
175 views

Can working code be: off-topic -> not-working?

This question here: Shortest possible way of printing a specific board Summary: The code requirement is to print out a grid of text. The code does in fact print the grid The way it does that, is ...
10
votes
1answer
223 views

Should mostly working but a little bit broken code stay or be deleted?

I posted the question Parsing structured text in Java At first I thought it was working, later I have found a bug in the code. Should it stay or should it be deleted? Update: I have fixed the bug in ...
16
votes
2answers
157 views

How broken does code have to be to for a question to be closed?

I recently voted to close this question: The longest subsequence with specified difference between min and max Originally I thought the code was really bad because the OP claimed a linear solution, ...
12
votes
2answers
259 views

I think my code might have a bug, but I am not sure if it actually does, is it broken code?

I have some C++ code that I am executing from C# dotnet core 2. In my C++, I am using a third party library. My code builds and runs, but after being executed a few million times (2.5 mil last time) I ...
19
votes
2answers
203 views

Can I edit broken code if I'm sure I'm recreating OP's original code?

I know, I know: "Never edit the code, leave it for the review!". But please, hear me out before answering. What should I do if I encounter a code that doesn't work, but I'm 99.99% sure it's because ...
17
votes
2answers
116 views

May another user fix broken code in a question to make it on-topic?

If we find that a question contains obviously broken code, our standard procedure is to close the question, sending the author back to the drawing board. But is it acceptable for another user to edit ...
15
votes
1answer
246 views

PSA: Excel going “Not Responding” isn't broken code

Some VBA questions mention the host application (e.g. Excel) is going "not responding" while their macro is running. Is it ok to vote to close these questions as "broken code"?
12
votes
2answers
329 views

OP says it works, the contest engine says it doesn't

What do we do when OP says his solution works, but the contest engine says it doesn't? Should we give it the benefit of the doubt, as "It works to the best of my knowledge.", or close it as broken ...
8
votes
1answer
197 views

Posting a question where part of the code contains a known bug

There is a particular requirement that has two versions. The first version has proven to be more challenging than the subsequent version to both describe the specification and compose; and also ...