Code Review

Questions tagged [close-reasons]

Ask Question

This tag is for instructions and guidance on closing or migrating questions, and the reasons for those closures.

63 questions
Newest
Active
Unanswered
Frequent
Filter by
Sorted by
Tagged with
13
votes
1answer
142 views

Let's not close fixable posts without explanation

There's one thing that's hooked me to CR more than on other sites and it's the fact that the community is really great. But recently I've noticed (I don't have any data to back it up) that we have ...
12
votes
1answer
151 views

What is “lacks concrete context” exactly?

Context Recently I've seen an increase in people voting for LCC when I don't agree this is the correct reason. These all seem to be getting LCC VTC because they're lacking description. https://...
2
votes
0answers
38 views

Add the word “readability” to the off topic close reason

Today we have this close reason: Code not implemented or not working as intended: Code Review is a community where programmers peer-review your working code to address issues such as security, ...
15
votes
1answer
193 views

Can we have a guide to wonderland? (includes v1)

Request Can we have a 'guide to wonderland' meta. 'Wonderland' is all our rules which mostly consists of lots of different rabbit holes. Rationale When I started on Code Review I spent a good ...
10
votes
2answers
210 views

What is “best to the author's knowledge”?

The question has been put on hold with the reason code not implemented or not working as intended. It is a curious case: in fact, the code is implemented, and does work as intended. The OP just didn'...
6
votes
2answers
88 views

Should we close a question of a non existing user? [duplicate]

There is this question in haskell that was originally posted on Stack Overflow but got migrated. The thing is, the user doesn't appear to exist or has been banned. It seems to me that the post will ...
2
votes
1answer
90 views

The problem with insufficient context

The new (well, not that new now) Insufficient Context close reason has a problem. People see the name and think it is about the text surrounding the code. The text context for the code. But the ...
1
vote
1answer
84 views

Wouldn't it be better to edit this question instead of closing it?

This question: Frequency Queries hackerrank … got closed for this reason: Code not implemented or not working as intended … … as the author wrote: However, on hackerrank it says the wrong ...
6
votes
1answer
157 views

Need clarification on my close reason interpretation for a specific close reason

The question Does this method guarantee that cells in a CSV will be correctly partitioned? is a duplicate of this one (10k+ and mods only) which asks whether a singular function properly 'escapes' ...
5
votes
1answer
132 views

Clarification on close reason

This question was closed per the Authorship of code reason. However nothing in the question seems to suggest that it is not written by the OP. Were there maybe (now deleted) comments that made clear ...
12
votes
2answers
129 views

What more context can you provide about a one-liner macro?

The question about NOT macro: is this bad practice has been closed for not providing concrete context. But what else could OP have written to make it on-topic? OP also explained why he likes this ...
0
votes
4answers
83 views

Confusing phrasing of the “off-topic” close reason

Before asking my last question, I've double checked what counts as off-topic and on-topic in this SE. According to my findings: We require that the code be working correctly, to the best of the ...
9
votes
2answers
167 views

“unclear what you're asking” vs “Lacks concrete context”

Aren't these two close reasons too similar? Since the Lacks concrete context exists I cannot remember using the unclear what you're asking anymore. unclear what you're asking Please clarify your ...
1
vote
3answers
75 views

Wouldn't it be more useful to notify OPs automatically about close votes, instead of having (stock) comments all the time?

I frequently see users (most probably close voting, or flagging for closure) leaving stock(?) comments like1 Welcome to Code Review! I'm afraid this question does not match what this site is about. ...
11
votes
3answers
246 views

“Who Wrote This?” and What Do We Actually Consider Authorship?

As I was working through the Close Votes Review Queue, I came upon a question beginning like this: I just cloned (Github clone, not literal clone) someone's Tic-Tac-Toe game and I was originally ...
1
vote
2answers
53 views

Why don't we have a close reason like “off-topic because of asking to find a 3rd party resource” like SO has? Or at least a “Blatantly off-topic”?

I recently came over this question I am trying to implement duplicate file finder in visual C++. I followed this link Successful implementation of Duplicate Files Finder in C++ But it don't ...
20
votes
4answers
510 views

How should we revisit our standard close reasons?

We have some history, shown below, with our close reasons, there are some problems we have with them. And there has been a consensus to rework them for a while now. The latest I heard about this was ...
7
votes
1answer
61 views

Insecure links in custom close reasons should be HTTPS

In the comments on this meta answer, a person said: When I click on your link, Chrome says "Attackers might be trying to steal your information". The link in question was from this quote: ...
14
votes
2answers
170 views

Why was this question closed as off-topic after a bug was discovered by the answers?

TL;DR Please clarify: is a previously unknown bug a reason to close a question as off-topic? Yesterday I was interested to answer this question, where an already written answer pointed out the ...
3
votes
1answer
58 views

When is a question too broad?

I wish to bring this question before the Code Review site. In the past, we have had this question: What makes a question too broad for code review?, which asks how to use the "Too Broad" close vote ...
1
vote
0answers
71 views

Can we do away with “someone else's code” wording? [duplicate]

The other day we got the question Python - Print the average of a list which is a value in a dictionary [on hold]. When I came across this question it was being closed for a custom close reason, I can'...
-7
votes
3answers
221 views

Please reconsider the rule: Pseudocode, hypothetical code, or stub code should be replaced by a concrete example?

Related: Why is hypothetical example code off-topic for Code Review? Is pseudo-code alright when asking about performance? The gray areas of Code Review: Hypothetical / Example code My concrete ...
10
votes
4answers
196 views

Rewriting specific parts of the code

This question got closed. Initial close comment: I'm voting to close this question as off-topic because it's asking for a feature request, not for a Code Review. 3 counts on that and 2 for broken ...
8
votes
2answers
66 views

Is this question off-topic because of being a copy/paste of another homework assignment?

For this question: https://codereview.stackexchange.com/questions/95474/circular-queue-program one of the answers noted that the code in the question appears to be copy/pasted from this homework ...
8
votes
4answers
85 views

Close Reason > Unclear What You're Asking

What does 'Unclear What You're Asking' define, and are we using it correctly? What makes a question unclear and close vote worthy?
9
votes
2answers
123 views

Why was the question too vague?

I'm reasonably new here but wondered why this question got put on hold? The OP asks for a review of the code he had provided as the answer to another post on this site. (He includes a link to the ...
14
votes
6answers
150 views

Closing a question because the posted code was produced quickly

I came across this question in my "close votes" review queue: Block_breaker clone in pygame with simple edge detection And noted that the close reason given was: Other: I'm voting to close this ...
26
votes
6answers
825 views

How should we revise the standard off-topic reasons, if we can have up to five?

Note: For chat-like discussions of this subject, let's use this Discuss Close Reasons chat room Code Review currently has three standard off-topic reasons: Questions containing broken code or asking ...
5
votes
1answer
113 views

Should the “broken code” close reason be reworded?

Here are our current close reasons: As @rolfl explains here, the gist of each of these three close reasons can be roughly summarized as the opposites of: your code works as intended it is ...
12
votes
2answers
196 views

Should we do away with “someone else's code” wording?

This has recently been brought up that we should improve this off-topic/close reason. While we can agree that this VTC reason is less than ideal (perhaps too broad, should be two separate reasons) ...
1
vote
6answers
175 views

Should there be evidence for a provided reason when a question is put on hold?

It is easy to say about code that it is written by someone else. It is fine if it is based on concrete facts by providing a link to that code of which they think that it is written by someone else. It ...
6
votes
4answers
264 views

What to do with bitter disappointment?

put on hold as off-topic by 200_success♦ 15 mins ago This question appears to be off-topic for this site. While what’s on- and off-topic is not always intuitive, you can learn more about it by ...
8
votes
3answers
109 views

Close reasons and migrations (and stats?)

One of the close reasons that exists is: Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. Such questions may be ...
12
votes
4answers
2k views

What exactly does it mean for code to be “Working Code”?

Why is it that Code Review's definition of "working code" is so misaligned with so many people's expectations? @rolfl Well, we've had a lot of discussion about broken code on meta, but we don't seem ...
13
votes
2answers
140 views

Rewording close reason “Explanation of code”

Inspired by this question: Custom Close Reason Post-Mortem. Can we alter Questions must involve real code that you own or maintain. Questions seeking an explanation of someone else's code are off-...
4
votes
1answer
70 views

Custom Close Reason Post-Mortem

Why does this Python maze-solver NOT get stuck? [closed] This question was closed using the custom close reason. The comment posted with the custom close reason was: This question appears to be ...
4
votes
1answer
56 views

Is this close reason right?

Linked list vs array performance for RemoveAt() function [closed] This question was closed with a custom close reason. The comment left for the custom close reason was: This question appears to ...
8
votes
2answers
64 views

Does a good posted answer make the question on topic regardless of content?

There exists a relatively well defined set of rules in the Help Center that help guide us to deciding what sorts of questions are on-topic and should remain open versus what sorts of questions are off-...
6
votes
1answer
93 views

Do we need to update the link in the “own or maintain” close reason?

This is the close reason I'm talking about: Currently, the "you own or maintain" link points to this meta question, but we've recently made a slight modification to the policy, per this meta question:...
8
votes
2answers
132 views

Is a bad approach for a problem a good reason to close a question?

Related meta question, regarding the inverse of this question: Is solely suggesting another solution a bad answer? See Accelerate OpenGL 2D on Python3 and Finding Primes in Java. These questions ...
8
votes
2answers
78 views

Questions about code translation

Translate C++ code to Haskell This question was put on hold and then deleted by the user. And for this specific question, I think that is fine. It was off-topic as it didn't include the translated ...
15
votes
3answers
252 views

What to do if the asker's code contains bugs?

Based on this question: WPF Calculator Code The question's code... works, according to the author. However, I quickly spotted multiple bugs. I know that Code Review is not there for fixing bugs. A ...
5
votes
1answer
93 views

Should this question be left open?

When I posted the question "Mobile touch menu" I was counting on someone else's report that they'd tested it and found it working on iPhone. But then after konijn's comment I asked that it be ...
4
votes
2answers
92 views

Should we close this one-liner ternary as “unclear what you're asking”?

This question looks like OP is worried about DRY and perhaps readability of a one-liner ternary. I have a bias against one-liners and other narrowed-down questions, but there's a consensus about them ...
3
votes
2answers
69 views

Are code-only questions off-topic? [duplicate]

I was browsing through the beginner tag and saw this question. It looks functional and is certainly review-able, but OP posted absolutely nothing besides the code. No hint about what it does, or what ...
5
votes
3answers
178 views

Are SSCCEs off-topic?

I was recently reviewing a question, which (if I had paid better attention to the question from the beginning, I may have noticed before answering) had a SSCCE as its primary code example. At first ...
8
votes
2answers
117 views

Revising list of closure reasons

Following up on a past discussions, I'd like to tweak our list of off-topic close reasons. We may have up to three canned reasons. Currently, they are: Questions asking for code to be written ...
13
votes
2answers
153 views

Migrating to Software Engineering - v2

Inspired by this off-topic question as an example, this is a follow-up question to this answer. If it's true that that we won't (can but won't) ask for another close reason, should we modify this ...
11
votes
3answers
180 views

Could incomplete or not-quite-working code be suitable for review?

I've noticed that sometimes I end up reviewing code despite the question's violation of our policy that it must contain working code. I bring this issue up because it is related to Changing wording ...
8
votes
1answer
98 views

Changing wording of the code-to-be-written and working-code off-topic reasons

Current wording: Questions asking for code to be written to solve a specific problem are off-topic here as there is no code to review. However, some of these questions actually have some code in ...

1 2