Questions tagged [close-reasons]

This tag is for instructions and guidance on closing or migrating questions, and the reasons for those closures.

Filter by
Sorted by
Tagged with
11
votes
1answer
207 views

Is a memory leak and a lack of concurrent safety enough to make code unreviewable?

There is this question which has one close vote and three down-votes. The only comments are The code is broken because it doesn't deallocate memory (and because it uses a global variable although ...
15
votes
5answers
693 views

The context of “Lacks concrete context”: let's fix it

Early 2018 we changed the close reasons on Code Review. This was necessary, but now almost 2 years later it's perfectly clear there's a growing discontent with one of them: "Lacks concrete context". ...
3
votes
3answers
98 views

Wouldn't it be more useful to notify OPs automatically about close votes, instead of having (stock) comments all the time?

I frequently see users (most probably close voting, or flagging for closure) leaving stock(?) comments like1 Welcome to Code Review! I'm afraid this question does not match what this site is about. ...
9
votes
2answers
234 views

“unclear what you're asking” vs “Lacks concrete context”

Aren't these two close reasons too similar? Since the Lacks concrete context exists I cannot remember using the unclear what you're asking anymore. unclear what you're asking Please clarify your ...
7
votes
2answers
162 views

Review a piece of code bought from someone else

In How can I speed up this serialized array generation php script? the OP states, that they "bought one [...] script" from someone else. Since I could not identify if the script in question was also ...
9
votes
3answers
230 views

How do we train our self-moderators?

Over the past few months I have found myself voting to Leave Open many questions that someone else voted to close as not concrete. A case in point is this question. While this question could have been ...
9
votes
2answers
146 views

Why was the question too vague?

I'm reasonably new here but wondered why this question got put on hold? The OP asks for a review of the code he had provided as the answer to another post on this site. (He includes a link to the ...
29
votes
1answer
683 views

Let's not close fixable posts without explanation

There's one thing that's hooked me to CR more than on other sites and it's the fact that the community is really great. But recently I've noticed (I don't have any data to back it up) that we have ...
13
votes
1answer
197 views

What is “lacks concrete context” exactly?

Context Recently I've seen an increase in people voting for LCC when I don't agree this is the correct reason. These all seem to be getting LCC VTC because they're lacking description. https://...
2
votes
0answers
40 views

Add the word “readability” to the off topic close reason

Today we have this close reason: Code not implemented or not working as intended: Code Review is a community where programmers peer-review your working code to address issues such as security, ...
16
votes
1answer
206 views

Can we have a guide to wonderland? (includes v1)

Request Can we have a 'guide to wonderland' meta. 'Wonderland' is all our rules which mostly consists of lots of different rabbit holes. Rationale When I started on Code Review I spent a good ...
10
votes
2answers
247 views

What is “best to the author's knowledge”?

The question has been put on hold with the reason code not implemented or not working as intended. It is a curious case: in fact, the code is implemented, and does work as intended. The OP just didn'...
6
votes
2answers
94 views

Should we close a question of a non existing user? [duplicate]

There is this question in haskell that was originally posted on Stack Overflow but got migrated. The thing is, the user doesn't appear to exist or has been banned. It seems to me that the post will ...
2
votes
1answer
94 views

The problem with insufficient context

The new (well, not that new now) Insufficient Context close reason has a problem. People see the name and think it is about the text surrounding the code. The text context for the code. But the ...
1
vote
1answer
92 views

Wouldn't it be better to edit this question instead of closing it?

This question: Frequency Queries hackerrank … got closed for this reason: Code not implemented or not working as intended … … as the author wrote: However, on hackerrank it says the wrong ...
6
votes
1answer
163 views

Need clarification on my close reason interpretation for a specific close reason

The question Does this method guarantee that cells in a CSV will be correctly partitioned? is a duplicate of this one (10k+ and mods only) which asks whether a singular function properly 'escapes' ...
5
votes
1answer
139 views

Clarification on close reason

This question was closed per the Authorship of code reason. However nothing in the question seems to suggest that it is not written by the OP. Were there maybe (now deleted) comments that made clear ...
-7
votes
3answers
229 views

Please reconsider the rule: Pseudocode, hypothetical code, or stub code should be replaced by a concrete example?

Related: Why is hypothetical example code off-topic for Code Review? Is pseudo-code alright when asking about performance? The gray areas of Code Review: Hypothetical / Example code My concrete ...
11
votes
2answers
138 views

What more context can you provide about a one-liner macro?

The question about NOT macro: is this bad practice has been closed for not providing concrete context. But what else could OP have written to make it on-topic? OP also explained why he likes this ...
0
votes
4answers
86 views

Confusing phrasing of the “off-topic” close reason

Before asking my last question, I've double checked what counts as off-topic and on-topic in this SE. According to my findings: We require that the code be working correctly, to the best of the ...
11
votes
3answers
263 views

“Who Wrote This?” and What Do We Actually Consider Authorship?

As I was working through the Close Votes Review Queue, I came upon a question beginning like this: I just cloned (Github clone, not literal clone) someone's Tic-Tac-Toe game and I was originally ...
21
votes
4answers
563 views

How should we revisit our standard close reasons?

We have some history, shown below, with our close reasons, there are some problems we have with them. And there has been a consensus to rework them for a while now. The latest I heard about this was ...
0
votes
2answers
57 views

Why don't we have a close reason like “off-topic because of asking to find a 3rd party resource” like SO has? Or at least a “Blatantly off-topic”?

I recently came over this question I am trying to implement duplicate file finder in visual C++. I followed this link Successful implementation of Duplicate Files Finder in C++ But it don't ...
7
votes
1answer
63 views

Insecure links in custom close reasons should be HTTPS

In the comments on this meta answer, a person said: When I click on your link, Chrome says "Attackers might be trying to steal your information". The link in question was from this quote: ...
13
votes
2answers
177 views

Why was this question closed as off-topic after a bug was discovered by the answers?

TL;DR Please clarify: is a previously unknown bug a reason to close a question as off-topic? Yesterday I was interested to answer this question, where an already written answer pointed out the ...
3
votes
1answer
69 views

When is a question too broad?

I wish to bring this question before the Code Review site. In the past, we have had this question: What makes a question too broad for code review?, which asks how to use the "Too Broad" close vote ...
13
votes
2answers
154 views

Migrating to Software Engineering - v2

Inspired by this off-topic question as an example, this is a follow-up question to this answer. If it's true that that we won't (can but won't) ask for another close reason, should we modify this ...
25
votes
6answers
842 views

How should we revise the standard off-topic reasons, if we can have up to five?

Note: For chat-like discussions of this subject, let's use this Discuss Close Reasons chat room Code Review currently has three standard off-topic reasons: Questions containing broken code or asking ...
1
vote
0answers
73 views

Can we do away with “someone else's code” wording? [duplicate]

The other day we got the question Python - Print the average of a list which is a value in a dictionary [on hold]. When I came across this question it was being closed for a custom close reason, I can'...
15
votes
1answer
136 views

Handling Asker not learning from previous reviews

Recently, a certain user has asked three times for code reviews in quick succession, for different parts of a project he is doing. This in itself is perfectly fine. However, he does not seem to have ...
10
votes
4answers
217 views

Rewriting specific parts of the code

This question got closed. Initial close comment: I'm voting to close this question as off-topic because it's asking for a feature request, not for a Code Review. 3 counts on that and 2 for broken ...
11
votes
2answers
204 views

Should we do away with “someone else's code” wording?

This has recently been brought up that we should improve this off-topic/close reason. While we can agree that this VTC reason is less than ideal (perhaps too broad, should be two separate reasons) ...
8
votes
4answers
90 views

Close Reason > Unclear What You're Asking

What does 'Unclear What You're Asking' define, and are we using it correctly? What makes a question unclear and close vote worthy?
7
votes
2answers
73 views

Is this question off-topic because of being a copy/paste of another homework assignment?

For this question: https://codereview.stackexchange.com/questions/95474/circular-queue-program one of the answers noted that the code in the question appears to be copy/pasted from this homework ...
14
votes
6answers
155 views

Closing a question because the posted code was produced quickly

I came across this question in my "close votes" review queue: Block_breaker clone in pygame with simple edge detection And noted that the close reason given was: Other: I'm voting to close this ...
1
vote
6answers
183 views

Should there be evidence for a provided reason when a question is put on hold?

It is easy to say about code that it is written by someone else. It is fine if it is based on concrete facts by providing a link to that code of which they think that it is written by someone else. It ...
5
votes
1answer
116 views

Should the “broken code” close reason be reworded?

Here are our current close reasons: As @rolfl explains here, the gist of each of these three close reasons can be roughly summarized as the opposites of: your code works as intended it is ...
6
votes
1answer
97 views

Do we need to update the link in the “own or maintain” close reason?

This is the close reason I'm talking about: Currently, the "you own or maintain" link points to this meta question, but we've recently made a slight modification to the policy, per this meta question:...
6
votes
4answers
271 views

What to do with bitter disappointment?

put on hold as off-topic by 200_success♦ 15 mins ago This question appears to be off-topic for this site. While what’s on- and off-topic is not always intuitive, you can learn more about it by ...
13
votes
2answers
143 views

Rewording close reason “Explanation of code”

Inspired by this question: Custom Close Reason Post-Mortem. Can we alter Questions must involve real code that you own or maintain. Questions seeking an explanation of someone else's code are off-...
8
votes
3answers
111 views

Close reasons and migrations (and stats?)

One of the close reasons that exists is: Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. Such questions may be ...
13
votes
4answers
3k views

What exactly does it mean for code to be “Working Code”?

Why is it that Code Review's definition of "working code" is so misaligned with so many people's expectations? @rolfl Well, we've had a lot of discussion about broken code on meta, but we don't seem ...
4
votes
1answer
75 views

Custom Close Reason Post-Mortem

Why does this Python maze-solver NOT get stuck? [closed] This question was closed using the custom close reason. The comment posted with the custom close reason was: This question appears to be ...
4
votes
1answer
62 views

Is this close reason right?

Linked list vs array performance for RemoveAt() function [closed] This question was closed with a custom close reason. The comment left for the custom close reason was: This question appears to ...
8
votes
2answers
70 views

Does a good posted answer make the question on topic regardless of content?

There exists a relatively well defined set of rules in the Help Center that help guide us to deciding what sorts of questions are on-topic and should remain open versus what sorts of questions are off-...
8
votes
2answers
141 views

Is a bad approach for a problem a good reason to close a question?

Related meta question, regarding the inverse of this question: Is solely suggesting another solution a bad answer? See Accelerate OpenGL 2D on Python3 and Finding Primes in Java. These questions ...
8
votes
2answers
86 views

Questions about code translation

Translate C++ code to Haskell This question was put on hold and then deleted by the user. And for this specific question, I think that is fine. It was off-topic as it didn't include the translated ...
15
votes
3answers
265 views

What to do if the asker's code contains bugs?

Based on this question: WPF Calculator Code The question's code... works, according to the author. However, I quickly spotted multiple bugs. I know that Code Review is not there for fixing bugs. A ...
5
votes
1answer
100 views

Should this question be left open?

When I posted the question "Mobile touch menu" I was counting on someone else's report that they'd tested it and found it working on iPhone. But then after konijn's comment I asked that it be ...
4
votes
2answers
98 views

Should we close this one-liner ternary as “unclear what you're asking”?

This question looks like OP is worried about DRY and perhaps readability of a one-liner ternary. I have a bias against one-liners and other narrowed-down questions, but there's a consensus about them ...