Questions tagged [discussion]
The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.
-1
votes
1answer
17 views
Create Tag Clean Code
My reputation is too low to create the tag clean-code. I really miss this tag since clean code is a major aspect of code reviews (just nowadays more than in the ...
7
votes
1answer
91 views
Asker deletes question after posting an answer
Yesterday I answered this question. Today when on my profile I noticed my answer was deleted.
This was not a DMCA takedown, and so this meta and this one don't help in this situation.
This meta, ...
5
votes
1answer
101 views
Should I continue answering a frequent poster that consistently accepts my answers?
Over the past month or two a user has been frequently posting questions and I, for want of a real life, have been posting reviews to most of them.
However the user seams to be predominately accepting ...
5
votes
1answer
63 views
Should a question poster include the Boost Software License?
In an edit to this question the poster added the Boost Software License text. I think the code subject to the license is in the poster's GitHub repo and not included in the question (it is only ...
5
votes
2answers
107 views
Is an answer that doesn't provide any code review, only how to unit test on-topic?
I ran across this answer which gives no code review feedback only how to write unit tests. If there were some unit tests provided, then they would be fair game for a code review also. In this case it ...
6
votes
4answers
141 views
The ethics of answering a homework question before it is handed in
I just read through a question that wasn't tagged as homework, however, it asked if it was good enough to show the professor. I added the homework tag and a comment that they shouldn't post the ...
0
votes
0answers
35 views
Merge example code, stub code and insufficient context reasoning into one?
When expanding the guide to wonderland, I'm trying to explain what example code, stub code and context are.
When trying to explain why example code is off-topic all I can think of is something like:
...
2
votes
1answer
43 views
Should I ask architectural questions on CodeReview?
In a scenario when I have lots of code or even when I don't have much yet, but the sole problem concerns the code architecture or design pattern etc. should I then ask such question?
1
vote
3answers
65 views
Do we have a blurry scope?
When building the base of 'the guide to wonderland', I've looked through the scope and site-policy tags. But I don't really know what the difference is, and I'm unsure why a significant amount of them ...
15
votes
1answer
187 views
Can we have a guide to wonderland? (includes v1)
Request
Can we have a 'guide to wonderland' meta.
'Wonderland' is all our rules which mostly consists of lots of different rabbit holes.
Rationale
When I started on Code Review I spent a good ...
-1
votes
2answers
83 views
Knowledge-based authentication using Domain-driven Design belongs to Software Engineering
I find the question Knowledge-based authentication using Domain-driven Design in C# should be moved to Software Engineering because the only code that OP has posted is clearly hypothetical, OP even ...
7
votes
1answer
195 views
April Fools' Joke background is bugged
If you check a website, like, Ask Ubuntu, you have the following background:
However, on Code Review, you have the following:
Would be nice if the background was the same, nice, tiled version :(
9
votes
1answer
105 views
Collecting good comments on Unanswered Questions into a Community Wiki answer
While looking through the list of unanswered questions I found some similar to this one, where the comments provide some well thought insights into the code as well as suggestions for improvement.
In ...
10
votes
1answer
179 views
When is explaining code to its author on topic?
The question Python: My program is unable to perform addition correctly which asked for an explanation as to why the code was buggy was closed as off-topic; I don't know about the last two close ...
9
votes
2answers
202 views
What is “best to the author's knowledge”?
The question has been put on hold with the reason code not implemented or not working as intended.
It is a curious case: in fact, the code is implemented, and does work as intended. The OP just didn'...
10
votes
1answer
149 views
Should I answer my own question with the improved code?
More to the point, should I delete this answer? I went through the help center pretty thoroughly and searched on here on Meta and couldn't really find anything that answers that question.
The answer ...
12
votes
3answers
151 views
Hot Network Questions Policy
As of recently, moderators have the ability to remove a CR question from the HNQ list.
There are times when the hotness formula selects a question that a site would rather not have featured. Up ...
8
votes
1answer
51 views
Proposal to clarify “on-topic” help page
The on-topic help page for Code Review is already fairly clear, but I would edit the following bullet point to make it clearer:
Best practices and design pattern usage
With the current ...
8
votes
1answer
134 views
Does a question with (a lot of) OP response to a posted review qualify for a rollback?
I'm not really sure whether this question where OP has added a lot of feedback about one of the reviews actually qualifies for a rollback.
The code is not changed and OP also hasn't added any ...
4
votes
1answer
63 views
How many questions with same script can I ask, if code not only merged reviews but adds new functionality [duplicate]
How many questions with same script can I ask, if code not only merged reviews but adds new functionality?
Can I submit part of code(fully working part with new code) together with full code or ...
45
votes
1answer
595 views
25 at twenty-five!
As well as reaching a personal landmark, it's also a site landmark when I became the 25th member to hit 25k reputation yesterday (narrowly beaten to the line by two others - you know who you are).
I ...
6
votes
2answers
88 views
Should we close a question of a non existing user? [duplicate]
There is this question in haskell that was originally posted on Stack Overflow but got migrated.
The thing is, the user doesn't appear to exist or has been banned. It seems to me that the post will ...
6
votes
1answer
104 views
Given CR's question title policy, how to title a second question about the same program?
Originally asked in 2nd Monitor
If we're asking a second CR question involving the same software, is it acceptable to give it nearly the same title? What is best practice for naming these questions?
2
votes
1answer
55 views
I found a (trivial) solution to my problem after submitting it
About Counting primes in a range whose digits are all prime.
My code had a bug, the bug was an edge case that only manifested in literally one of the test cases, (I identified it by completing the ...
12
votes
3answers
173 views
Thanking someone for a good code review
Is it appropriate to comment on a good Code Review answer to one of my posts with a "Thank you"?
2
votes
1answer
35 views
Should there be a tag for Python library [requests]?
I recently asked a question where I was interested in if I used the Requests library correctly. To my surprise, when I was adding tags, I didn't see the one for this library. Googling ...
8
votes
5answers
125 views
Optimize our meta tags?
First off I should say I'm ignoring the following meta tags: beginner, homework, reinventing-the-wheel, and most with less than 100 views.
A short overview of the discussions around these tags is ...
20
votes
3answers
238 views
Found a serious bug in my question after posting it
What is the correct way to go after I found a bug in a question that I posted?
Shall I delete the question, vote to close it or flag it as off-topic?
18
votes
1answer
152 views
Are machine-learning questions a good fit for CR?
I'm aware of When are Machine Learning questions on-topic?, but I think maybe there's room for discussion regarding the machine-learning tag.
I've made a search on the ML tag (because I do not have ...
0
votes
1answer
52 views
Is it ok to post code that didn't work out as intended?
I recently tried to optimize some code by using parallel processing, putting two cores to work on the problem instead of one.
For whatever reason, it didn't work. I don't know why, but I doubt much ...
2
votes
1answer
73 views
Why did this js Fizzbuzz question get so many more views than others?
Why did this recent question: FizzBuzz in Javascript get so many views and, presumably, many more votes (than would be normal)?
My initial theory was that it contains the tags fizzbuzz and that tag ...
4
votes
2answers
73 views
Good format to post code for review
I have a project that I used to try out in-memory databases. After fighting it for a few days, I'm code blind and need to have it reviewed. I haven't been on this particular site much (I'm well ...
12
votes
4answers
184 views
Community Promotion Ads — 2019
2019 is here! And with the new year, as usual, comes a new iteration of Community Promotion Ads! Let’s refresh these for the coming year :)
What are Community Promotion Ads?
Community Promotion Ads ...
4
votes
1answer
78 views
Review one-by-one feature?
I am writing a library. It is mostly ready, but there are known bugs and ToDo stuff (including for example missing const specifiers for member functions which do ...
7
votes
1answer
122 views
Question about “Polymorphic implementation of == with CRTP” on hold as off topic
I have a question about my Code Review Stack Exchange post: Polymorphic implementation for == with CRTP. It was put on hold as off topic stating (mainly) that the use case is theoretic or not ...
12
votes
2answers
242 views
Unnecessary comments
Should I keep my comments or remove them if they are wrong or no longer serve a purpose under an answer/question?
When I remove my comment(s), the other comments (by others) become meaningless. If ...
20
votes
0answers
125 views
2018: a year in moderation
It's New Year's Day in Stack Exchange land...
A distinguishing characteristic of these sites is how they are moderated:
We designed the Stack Exchange network engine to be mostly self-regulating, ...
0
votes
0answers
56 views
Is it possible to get a code review of scripts while obfuscating sensitive information? [duplicate]
Namely, I wrote a Python script to handle Cloudflare-based Dynamic DNS updates for a system, but I need to obfuscate my CloudFlare creds and some API keys, for fairly obvious reasons. Would there be ...
4
votes
2answers
92 views
Should we allow answer invalidation for otherwise off-topic questions? [duplicate]
We recently had a question with un-compilable code. The question was answered and the answerer pointed out the broken code. The user has since edited the question to fix the code. It was rolled-back.
...
11
votes
2answers
157 views
Flagging users who select “No Action Needed” in First Posts review queue
A while back I was directed to read the accepted community wiki answer to this First Post Review question (and of course heeded the advice).
In Jamal's answer to this question about reviewing a ...
4
votes
0answers
42 views
Is a question on topic if the code works locally but errors when submitted to a coding site? [duplicate]
This is about a recently posted question: Codejam 2018 - Getting confusing runtime error
The OP claims it works for him locally, but generates a Runtime Error on the Google Code Jam website itself.
...
8
votes
1answer
180 views
Posting a question where part of the code contains a known bug
There is a particular requirement that has two versions. The first version has proven to be more challenging than the subsequent version to both describe the specification and compose; and also ...
-6
votes
4answers
109 views
Closing of questions citing “off-topic” as reason where user-defined code and standardized code is clearly equivalent
See From the below javascript code snippet which one is considered to be most appropriate? [on hold]
Scenario 1:
...
45
votes
0answers
355 views
Code Review questions must contain code
As requested by Kaz and approved by the voters here on meta, questions asked on Code Review that do not contain code are now blocked.
I've configured this initially as a three-line minimum (or three ...
2
votes
1answer
113 views
What is immoral about reviewing someone else's code? [duplicate]
The Help Center says:
For licensing, moral, and procedural reasons, we cannot review code written by other programmers.
Can somebody explain what is immoral about reviewing someone else's code?
...
11
votes
0answers
115 views
What's the [api] tag for?
The taginfo for api describes what an Application Programming Interface is, but doesn't give any guidance as to what kind of question it applies to.
Given that the majority of code here is at ...
7
votes
1answer
81 views
Acceptability of questions about checking for race conditions
Is it acceptable for users to post questions in this community and have their code evaluated by others to check for race conditions? Or do these types of questions fall under the banner of 'broken ...
9
votes
1answer
195 views
Does Stack Overflow count as a third party site?
I had a question that was placed on hold with a link to this:
Can I put my code on a third party site and link to the site in my question?
The code I asked for review of was on Stack Overflow, and ...
5
votes
2answers
230 views
Is “How does this algorithm work?” a good question here?
If I have a question about the algorithm that I can't understand the logic behind, how and where should I ask the question?
2
votes
1answer
83 views
The problem with insufficient context
The new (well, not that new now) Insufficient Context close reason has a problem. People see the name and think it is about the text surrounding the code. The text context for the code. But the ...
