Questions tagged [discussion]
The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.
1,487
questions
0
votes
0answers
39 views
On nature and size of code generally dealt with here at CRSE
I've got a slightly big but also not big-as-Linux-kernel C project which is ~1200 lines of code , ~20 functions , 3 files, and so on.
I'm new to this site, and was curious to know if this site is for ...
2
votes
1answer
31 views
I missed that a question was for a subset of the language. Next steps?
I recently answered a Python review question. Unfortunately, I had missed that the question was for MicroPython; a subset of Python with reduced features. As a result, 1/2 to 2/3 of my suggestions are ...
-4
votes
1answer
92 views
1
vote
1answer
97 views
Should I kill my own account?
I have some poorly received posts. Should I kill my account? Should I make all my posts say user227432 with no link?
-2
votes
5answers
139 views
Overly aggressive moderation on Alloy tag
Alloy is a lightweight formal specification language. Such languages are completely different in style and way of thinking than programming languages. We've been using SO to answer many questions.
...
7
votes
1answer
103 views
The [Salesforce] ecosystem
While hunting for my next zombie to take down, I encountered the following question: Patient Appointment CSV to insert records using simple_salesforce
A question that seemed well written, almost ...
0
votes
1answer
49 views
Are sanity checks allowed?
There are times when I have written code that looks insane when I step back from it. It is during those times where I might need a sanity check. So, is asking for a sanity check allowed?
For example, ...
8
votes
1answer
111 views
Can I ask a question about a custom scripting language?
I recently asked a question and was reminded that pseudocode is not allowed on this site; I translated it because I felt the original code would have been confusing. The reason being that the ...
7
votes
2answers
122 views
How do we differentiate “language-agnostic” from “pseudocode”?
I understand the policy that we do not allow pseudocode in the question. That said, if an OP indicates it, would answers whose language diverges from the language of the post be on-topic?
The ...
-8
votes
4answers
113 views
moderators limited, downvoting abuse on new users
For any reason moderator are declining flags from me i have send it 2 time.
about donwvoting my question, and donwvoting user not give any type o feedback/comment/edit.
https://codereview....
7
votes
1answer
109 views
Are questions mostly unrelated to the presented code on-topic?
So we had an argument whether this question is on topic:
RESTful movie shop
I see this question as off-topic although it seems to satisfy most rules.
There's code. It works. It's real...
But the ...
1
vote
0answers
56 views
How should I ask on the main site without getting too many downvotes to a piece of code that was a P vs NP attempt? [closed]
I wanted to find out my mistakes in the code that could shorten it all together.
I would love to figure out how to address bad variable names
Use enumerate instead of python's range
Use a better ...
56
votes
4answers
712 views
Phrancis: A final review of a good member
On May 22, 2020, I received a message from the roommate of one of our cherished members, Phrancis (Francis Veilleux-Gaboury). She was reaching out and using his account to inform me that he had passed ...
15
votes
4answers
563 views
Let's update the modal for new askers
The Issue
There are many posts on CR that are off-topic for various reasons... Sometimes 10-20 per day! Apparently many users don't read/heed the text on the right side (i.e. "Your question must ...
8
votes
2answers
123 views
How to deal with reviews of Jupyter notebooks?
There is currently a question in the python tag which asks as the main question for a review of an (externally linked) Jupyter notebook. In order to not be off-topic the OP also included the most ...
1
vote
2answers
63 views
Unifying “Is {language} on-topic?” questions under one tag scheme
Please can we unify all "is {language} on-topic?" questions to one tag scheme.
Since there are, with my counting at least, 35 such questions if we were to make this a tag then it would have more ...
1
vote
2answers
58 views
What do we do with low-quality questions that already have answers?
This question is a terrific mess. The question itself seems to me clearly off-topic due to being a snippet and the OP graciously agreed in the comments; but in the meantime it has attracted answers of ...
11
votes
3answers
251 views
Community Promotion Ads ā 2020
2020 has come! Butā¦ oops, where did the time go? Itās already March! Belated as it is, itās time for a refresh of Community Promotion Ads!
What are Community Promotion Ads?
Community Promotion Ads ...
10
votes
1answer
129 views
How long should you leave a question before you accept an answer?
I don't like to leave questions open for so long it looks dead, but I want people to still think that I want more feedback and I can't find a good middle ground. Any opinions?
-1
votes
2answers
106 views
Negative engagement, ganging up, question closing, downvoting
I am relatively new to Code Review, so I don't know if this Stack Exchange site suffers particularly from counter-productive interaction by negatively critical senior users but I'm certainly seeing it ...
2
votes
1answer
54 views
Syntax highlighting for vba just changed
It looks like the syntax highlighting has recently changed for VBA (I would post a sample but I don't think meta does code highlighting...)
Here's an image to preserve what I'm seeing, tagged with ...
14
votes
1answer
159 views
Clarifying Code Review Scope
I just checked the How to Ask, What types of questions should I avoid asking? and What topics can I ask about here?, but I'm confused about the working code part.
Quoting from What topics can I ask ...
3
votes
1answer
54 views
Understanding closed question concerns
I'm still in the process of figuring out many aspects of stackexchange, and a recent question of mine got closed after I responded to comments provided. I'm hoping to understand more about the ...
2
votes
1answer
53 views
Should I change the question's title or body, and/or create another question?
In this question (What is the best practice between second assignment or dict's value call?), I first ask for the best solution between second assignment or dict's value call.
But, after few days I ...
11
votes
1answer
211 views
Is a memory leak and a lack of concurrent safety enough to make code unreviewable?
There is this question which has one close vote and three down-votes. The only comments are
The code is broken because it doesn't deallocate memory (and because it uses a global variable although ...
-3
votes
2answers
105 views
"Lacks concrete contextā, et al - drivng in the wrong direction
Over the last 2 months I have seen a significant proportion of questions closed, or marooned/abandoned by the threat of being closed. I understand the official figures are in region of 20-40% (about ...
2
votes
1answer
68 views
Improving a question - when to post a new question
I'm new to the code review site (but not to SE in general). I posted my first question in earnest after reading the "about" page and noting that code must be working.
The code I posted worked locally,...
15
votes
1answer
137 views
2019: a year in moderation
It's New Year's Day in Stack Exchange land...
A distinguishing characteristic of these sites is how they are moderated:
We designed the Stack Exchange network engine to be mostly self-regulating, ...
2
votes
1answer
74 views
Where can I find an expert opinion on a large codebase?
I am a self taught developer that codes for fun, and I created a project that almost certainly has terrible code in it, but I would like someone who knows what they're doing (i.e. not me) to help me ...
7
votes
3answers
106 views
Titles that reference external resources
A couple of us disagreed (in comments) on whether titles that are nothing more than external references, such as "Advent of Code 2019 Day 3, Part 3" and "Project Euler nĀŗ 5", are reasonable.
I ...
9
votes
1answer
121 views
Vote to close and unclear titles
We usually VTC questions with titles that don't reflect the goal of the code. Examples of said titles:
"How do I make this better?"
"My code is not fast enough"
"I'd like my code to be more pythonic"
...
9
votes
2answers
140 views
Is GraphQL Reviewable?
This question was posted recently, and presents a GraphQL schema for review.
Arguably, GraphQL doesn't do much, and we've closed plain Java and C# posts before where all reviewers had to chew on was ...
7
votes
1answer
104 views
Should we improve the code to be reviewed in an edit?
I noticed this suggest edit:
This suggested edit does two things:
Replace using namespace std;, which is considered bad practice in C++, with ...
7
votes
2answers
106 views
Collection of small unrelated methods
I have a file that contains a multitude of methods that are solutions to some common interview questions. None of these methods are related in any way, shape or form. I have been debating on the two ...
15
votes
5answers
698 views
The context of “Lacks concrete context”: let's fix it
Early 2018 we changed the close reasons on Code Review. This was necessary, but now almost 2 years later it's perfectly clear there's a growing discontent with one of them: "Lacks concrete context".
...
5
votes
1answer
275 views
My CR karma raised about 6000 points, what happened?
My karma in Code Review was two days ago around 16400+. Now it is 22700+. What happened here? I received my 8th golden badge; might it be responsible for that? Also, there is no any indication from ...
7
votes
3answers
172 views
How can year reputation be higher than total reputation?
Looking at the 2019 user reputation league, this year's highest-ranked user is dfhwze (deservedly so, having put a lot of work into code reviewing this year).
There's a strange anomaly, though: at ...
6
votes
2answers
114 views
How do we handle answers that pertain solely to other answers?
Most of us are (or should be) familiar with this section of the Help Center Page How do I write a good answer?:
What goes into an answer
Every answer must make at least one insightful ...
-3
votes
1answer
61 views
Is editing code whitespace allowed? [duplicate]
EDIT: An edit dispute answered by rolfl is related, but dates back to 2015 and was answered by one moderator. I feel like there should be an official verdict.
This applies to edits/questions in ...
4
votes
1answer
85 views
Changed question code - what to do?
As seen in This meta post, questions aren't supposed to change their code beyond copy/paste errors or minor syntax problems which aren't the subject of Code Review anyway.
It did happen here. How ...
7
votes
2answers
163 views
Review a piece of code bought from someone else
In How can I speed up this serialized array generation php script? the OP states, that they "bought one [...] script" from someone else. Since I could not identify if the script in question was also ...
11
votes
4answers
198 views
Are we voting to close too quickly?
With the kerfuffle on SE, I've decided to try & contribute a bit more again.
So I started with the vote close queue, and this one irked me:
https://codereview.stackexchange.com/review/close/...
0
votes
1answer
54 views
Is it on topic here for questions not about specific code but rather how to manage the code?
Title explains it: I want to ask a question about maintaining branches of a single project and I'm not sure if it's on topic. If not, is there anywhere that it would be on topic?
30
votes
2answers
744 views
That's it for now
I'll make it short because I think the more I say the more likely it is that it'll offend someone.
As a reaction to the latest events on MSE concerning the CoC and especially the Official FAQ on ...
33
votes
4answers
1k views
Mat's back, blame the monkey
When I put down my mug 18 months ago, I promised I'd stick around, and I did. I've been keeping a distant eye on CR and meta, while remaining in our Rubberducking dev chat, and monitoring vba posts on ...
132
votes
6answers
3k views
It is with disappointment that I hereby resign as a moderator
Note the updates at the end: In short, my resignation is now in full effect.
A moderator is a person trusted by both Stack Exchange, and the community as a whole, to objectively and fairly deal with ...
5
votes
1answer
145 views
Requesting a comparative review of own code with third-party code
A user recently posted this question which-set-of-code-is-more-accurate where they ask for a comparative review between their code and code written by a third-party, hosted on GitHub. My question is ...
6
votes
2answers
149 views
What to do with a post that feels like a blog entry?
I've been following this question pretty closely, reading comments and everything because the "reasoning part" seemed... blog-ish.
By reading this answer and the comments under it + the way the ...
11
votes
4answers
207 views
Reviewing Programming Challenge requirements and givens
As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions ...
9
votes
2answers
194 views
May I ask about repo usability/general feedback?
I have written a library. It compiles. It has basic unit tests. - One could say it works.
However, I would like to improve the usability of the API and get general feedback.
Am I allowed to open a ...
