Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
7
votes
3answers
71 views

Titles that reference external resources

A couple of us disagreed (in comments) on whether titles that are nothing more than external references, such as "Advent of Code 2019 Day 3, Part 3" and "Project Euler nº 5", are reasonable. I ...
9
votes
1answer
109 views

Vote to close and unclear titles

We usually VTC questions with titles that don't reflect the goal of the code. Examples of said titles: "How do I make this better?" "My code is not fast enough" "I'd like my code to be more pythonic" ...
9
votes
2answers
113 views

Is GraphQL Reviewable?

This question was posted recently, and presents a GraphQL schema for review. Arguably, GraphQL doesn't do much, and we've closed plain Java and C# posts before where all reviewers had to chew on was ...
7
votes
1answer
86 views

Should we improve the code to be reviewed in an edit?

I noticed this suggest edit: This suggested edit does two things: Replace using namespace std;, which is considered bad practice in C++, with ...
7
votes
2answers
96 views

Collection of small unrelated methods

I have a file that contains a multitude of methods that are solutions to some common interview questions. None of these methods are related in any way, shape or form. I have been debating on the two ...
15
votes
5answers
546 views

The context of “Lacks concrete context”: let's fix it

Early 2018 we changed the close reasons on Code Review. This was necessary, but now almost 2 years later it's perfectly clear there's a growing discontent with one of them: "Lacks concrete context". ...
5
votes
1answer
261 views

My CR karma raised about 6000 points, what happened?

My karma in Code Review was two days ago around 16400+. Now it is 22700+. What happened here? I received my 8th golden badge; might it be responsible for that? Also, there is no any indication from ...
7
votes
3answers
166 views

How can year reputation be higher than total reputation?

Looking at the 2019 user reputation league, this year's highest-ranked user is dfhwze (deservedly so, having put a lot of work into code reviewing this year). There's a strange anomaly, though: at ...
6
votes
2answers
107 views

How do we handle answers that pertain solely to other answers?

Most of us are (or should be) familiar with this section of the Help Center Page How do I write a good answer?: What goes into an answer Every answer must make at least one insightful ...
-3
votes
1answer
49 views

Is editing code whitespace allowed? [duplicate]

EDIT: An edit dispute answered by rolfl is related, but dates back to 2015 and was answered by one moderator. I feel like there should be an official verdict. This applies to edits/questions in ...
4
votes
1answer
75 views

Changed question code - what to do?

As seen in This meta post, questions aren't supposed to change their code beyond copy/paste errors or minor syntax problems which aren't the subject of Code Review anyway. It did happen here. How ...
7
votes
2answers
157 views

Review a piece of code bought from someone else

In How can I speed up this serialized array generation php script? the OP states, that they "bought one [...] script" from someone else. Since I could not identify if the script in question was also ...
11
votes
4answers
190 views

Are we voting to close too quickly?

With the kerfuffle on SE, I've decided to try & contribute a bit more again. So I started with the vote close queue, and this one irked me: https://codereview.stackexchange.com/review/close/...
0
votes
1answer
43 views

Is it on topic here for questions not about specific code but rather how to manage the code?

Title explains it: I want to ask a question about maintaining branches of a single project and I'm not sure if it's on topic. If not, is there anywhere that it would be on topic?
30
votes
2answers
704 views

That's it for now

I'll make it short because I think the more I say the more likely it is that it'll offend someone. As a reaction to the latest events on MSE concerning the CoC and especially the Official FAQ on ...
34
votes
4answers
1k views

Mat's back, blame the monkey

When I put down my mug 18 months ago, I promised I'd stick around, and I did. I've been keeping a distant eye on CR and meta, while remaining in our Rubberducking dev chat, and monitoring vba posts on ...
135
votes
6answers
3k views

It is with disappointment that I hereby resign as a moderator

Note the updates at the end: In short, my resignation is now in full effect. A moderator is a person trusted by both Stack Exchange, and the community as a whole, to objectively and fairly deal with ...
5
votes
1answer
130 views

Requesting a comparative review of own code with third-party code

A user recently posted this question which-set-of-code-is-more-accurate where they ask for a comparative review between their code and code written by a third-party, hosted on GitHub. My question is ...
6
votes
2answers
143 views

What to do with a post that feels like a blog entry?

I've been following this question pretty closely, reading comments and everything because the "reasoning part" seemed... blog-ish. By reading this answer and the comments under it + the way the ...
11
votes
4answers
196 views

Reviewing Programming Challenge requirements and givens

As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions ...
9
votes
2answers
185 views

May I ask about repo usability/general feedback?

I have written a library. It compiles. It has basic unit tests. - One could say it works. However, I would like to improve the usability of the API and get general feedback. Am I allowed to open a ...
0
votes
1answer
76 views

What do we do with out-of-sync questions?

This question is now in somewhat of a bad state. The OP did significant rewrites of their question, and then received an answer. Not realizing the sequence of events, I rolled the question back to ...
0
votes
1answer
32 views

Is hacking/cracking on-topic? [duplicate]

Login to website behind captcha seeks to circumvent a captcha. I think that white-hat hacking or penetration testing for the purpose of security improvement might be OK, but this is clearly in the ...
10
votes
2answers
154 views

Is a changeset reviewable?

I'm looking at Java refactoring - reduce cognitive complexity by extracting private methods (note: the question has been edited since I wrote this. At that time, I was looking at Revision 4) and in ...
11
votes
3answers
143 views

Why is the [beginner] tag appropriate here as opposed to e.g. Stack Overflow?

I'm sure many of us have seen the blog post about the death of meta-tags on Stack Overflow. One of the tags included in the aforementioned blog post is beginner. However, this tag seems to be ...
16
votes
1answer
137 views

Is simply telling someone to use an API an appropriate code review?

I recently viewed a question where the only answer was simply telling the OP to use a provided API instead of scraping data themselves. Is this considered an appropriate answer on Code Review? My ...
-1
votes
2answers
57 views

A “The answer's author agreed to this edit in question” button which could be used only if code was expanded

In this question I added a segment to the code scope only after describing the essential addition before the answerer in comments and getting his consent to make this addition in a reply comment. I ...
3
votes
1answer
71 views

Was this rollback justified?

The rollback in question: https://codereview.stackexchange.com/posts/216088/revisions I was told to contest the rollback here by the reviser and I believe the point of contention is about ...
-8
votes
1answer
43 views

Shouldn't [random] be renamed to [randomness]?

The tag random evokes the idea of a "random" post, something which is categorically disallowed on Stack Exchange.
2
votes
1answer
108 views

Dealing with defamation and site-policy

Yesterday I got two separate accounts of defamation against me. The first one Find the rotation point of a sorted array that is "rotated" accused me of using multiple accounts to down-vote their ...
10
votes
3answers
224 views

How do we train our self-moderators?

Over the past few months I have found myself voting to Leave Open many questions that someone else voted to close as not concrete. A case in point is this question. While this question could have been ...
2
votes
1answer
46 views

Is the review of vocabulary/ontology use (e.g., for HTML structured data) on-topic?

In HTML, structured data is typically added with the syntaxes JSON-LD, Microdata or RDFa. The review of the syntax use is clearly on-topic, just like the use of plain HTML is. But what about the ...
6
votes
1answer
123 views

Alternate solution - what counts as an insightful observation?

One of our latest HNQ's has drawn the attention of alternate solutions. Soon after the question was posted I answered it with an alternate solution, and got quite a few upvotes. My first version ...
-1
votes
1answer
31 views

Synonym request for tag [animations], proposed synonym [easing]

Synonym Request I came across this question screen-transition-effect-like-in-final-fantasy-games where OP makes their custom easing function in order to smoothly transition a color over an image. I ...
16
votes
2answers
132 views

Advice without knowledge of specific language

I'm here for a little more than one year now but still very new to the how-to of the place, and a recent comment in this post made me think that maybe I was ...
0
votes
1answer
30 views

Can questions request only specific kinds of review guidance? [duplicate]

In other words: if a CR question asks only for performance feedback, or only for OOP structure feedback, etc., is that valid? And would answers providing review feedback on other aspects of the code ...
11
votes
2answers
125 views

How to handle a VTC as duplicate that goes the wrong way around?

I encountered this review today, where a question was to be closed as duplicate of another, older question. However, the dupe target was closed, at -5 and unanswered. The quality was much lower than ...
10
votes
6answers
150 views

(Follow-up) Possible Solution for Zombies : The Brainstorm

This is a follow-up to this post. We currently have 6022 unanswered questions + some others with zero score answers. In order to find ideas, I propose that we post ideas here on how to reduce the ...
29
votes
1answer
673 views

Let's not close fixable posts without explanation

There's one thing that's hooked me to CR more than on other sites and it's the fact that the community is really great. But recently I've noticed (I don't have any data to back it up) that we have ...
3
votes
2answers
83 views

Answer made on suggested comment, not on initial question

I came across the following answer: dynamically-add-remove-fields-on-input and don't know the site policy for this specific scenario. Scenario OP asks for the following: The following code allows ...
6
votes
1answer
66 views

Review that targets code that makes the question off-topic, then question is updated

I was looking around for zombies and fell on this question : Importing text into PANDAS and counting certain words The review is basically pointing runtime errors in the code that would've made the ...
7
votes
2answers
113 views

On/off-topicness of “conclusions” added to the original question

I wonder what is your opinion about on/off-topicness of conclusions added to the original question like it has be done here at the bottom? Should such edits be rejected and a self-answer posted ...
0
votes
0answers
45 views

Are Nix expressions without any logic on topic? [duplicate]

I've written a configuration.nix file for my systems, and it would be very useful to have it reviewed. Nix expressions are code, very similarly to Puppet or Chef, but are declarative, so I wonder if ...
15
votes
1answer
138 views

Small portion of reviewable code isn't mine, but credited

I recently asked this question. I looked around, but it doesn't look like my problem has been asked here: A small (9 SLOC) portion of my code is an equation from a user on Stackoverflow. I credit the ...
2
votes
1answer
39 views

Why were comments removed that reported bugs in my question code?

The comments on my question here appear to have been removed. Some of these comments reported bugs in the original code. Given that question code can't be updated, and new questions or selfie answers ...
5
votes
1answer
73 views

Multiple related question titles

I am creating a programming language, Linny, and have asked two questions (First Question Here, Second Question Here). As I continue to improve the language, I intend on asking more questions to ...
6
votes
1answer
110 views

Why was this answer for “Add and Search Word” deleted without any comments?

I'm wondering why a perfectly valid answer with two upvotes for the Add and Search Word question has been deleted? There is no comment explaining this strage action. From a regular user's point of ...
11
votes
2answers
157 views

Reviewing non-working code when author thinks it's working?

I came across a pretty simple question where the author explicitly states: The function returns the correct output, and all known edge cases have been accounted for. I took this at face value and ...
7
votes
1answer
82 views

Is it okay to post questions that don't contain a full program/library?

For example, say I wanted to ask a question about memory efficiency regarding two versions of a structure I have in a specific language, but I'm only concerned about that one section of the program. ...
12
votes
2answers
232 views

Possible Solution for Zombies (unanswered questions)

Would it be possible for Code Review to award bounties on good questions that have remained unanswered for more than 6 months? When I was working through zombies I found a few questions I couldn't ...