Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
20
votes
1answer
78 views

Phrancis: A final review of a good member

On May 22, 2020, I received a message from the roommate of one of our cherished members, Phrancis (Francis Veilleux-Gaboury). She was reaching out and using his account to inform me that he had passed ...
8
votes
3answers
122 views

Let's update the modal for new askers

The Issue There are many posts on CR that are off-topic for various reasons... Sometimes 10-20 per day! Apparently many users don't read/heed the text on the right side (i.e. "Your question must ...
38
votes
18answers
4k views

Frequently Posted Comments

On Code Review we often encounter questions with the same kind of problem over and over again. Some of us are using the auto comments script which allows you to maintain a list of comments to post. ...
20
votes
3answers
379 views

Is it okay to add someone else's linked code to the question?

Some questions link to the code they want reviewed, which is against site policy. Should one edit the code into the question in these cases? The problem I see is that all content on Stack Exchange ...
8
votes
2answers
109 views

How to deal with reviews of Jupyter notebooks?

There is currently a question in the python tag which asks as the main question for a review of an (externally linked) Jupyter notebook. In order to not be off-topic the OP also included the most ...
12
votes
2answers
142 views

Are requests for review of language design on topic?

This is the question that prompts this meta: Is my language easy/hard enough? How badly is it designed?. Paraphrased: I am thinking about making a language somewhat based on macros, and looking ...
-1
votes
0answers
20 views

Is asking about syntax for a new language ok? [duplicate]

So, I have recently been working on making my own programming language. I am planning to include lots of unique syntax; however, I am not sure about whether or not that syntax is actually good. Is ...
1
vote
2answers
54 views

Unifying “Is {language} on-topic?” questions under one tag scheme

Please can we unify all "is {language} on-topic?" questions to one tag scheme. Since there are, with my counting at least, 35 such questions if we were to make this a tag then it would have more ...
1
vote
2answers
51 views

What do we do with low-quality questions that already have answers?

This question is a terrific mess. The question itself seems to me clearly off-topic due to being a snippet and the OP graciously agreed in the comments; but in the meantime it has attracted answers of ...
23
votes
2answers
534 views

How should we deal with askers fixing off-topic questions when an answer has been posted?

I did a quick search to see if this has been asked, but it didn't seem to be. The intent behind this question is from how this question was handled, but is not limited to it. The situation is an ...
13
votes
5answers
266 views

Are requests to analyze the complexity of code on-topic?

Here is an example of a question that asks for a big-O analysis of a function (to count the number of ways to make change): What is the run time of this algorithm? Here is my algorithm ...
11
votes
3answers
236 views

Community Promotion Ads — 2020

2020 has come! But… oops, where did the time go? It’s already March! Belated as it is, it’s time for a refresh of Community Promotion Ads! What are Community Promotion Ads? Community Promotion Ads ...
5
votes
0answers
44 views

How can I improve this question about asyncio?

I recently asked this question on Code Review which was ill-received and got 4 close votes for being off-topic. I believe the main problem to be that I used a dummy function for a third party API ...
7
votes
0answers
239 views

Use a font family which has an actual italic variant (instead of oblique)

In the new design there was a change to the CSS that determines the fonts used for posts. This is what it is using now, based on my research: ...
10
votes
1answer
118 views

How long should you leave a question before you accept an answer?

I don't like to leave questions open for so long it looks dead, but I want people to still think that I want more feedback and I can't find a good middle ground. Any opinions?
-1
votes
2answers
98 views

Negative engagement, ganging up, question closing, downvoting

I am relatively new to Code Review, so I don't know if this Stack Exchange site suffers particularly from counter-productive interaction by negatively critical senior users but I'm certainly seeing it ...
2
votes
1answer
54 views

Syntax highlighting for vba just changed

It looks like the syntax highlighting has recently changed for VBA (I would post a sample but I don't think meta does code highlighting...) Here's an image to preserve what I'm seeing, tagged with ...
13
votes
1answer
153 views

Clarifying Code Review Scope

I just checked the How to Ask, What types of questions should I avoid asking? and What topics can I ask about here?, but I'm confused about the working code part. Quoting from What topics can I ask ...
3
votes
1answer
51 views

Understanding closed question concerns

I'm still in the process of figuring out many aspects of stackexchange, and a recent question of mine got closed after I responded to comments provided. I'm hoping to understand more about the ...
2
votes
1answer
43 views

Should I change the question's title or body, and/or create another question?

In this question (What is the best practice between second assignment or dict's value call?), I first ask for the best solution between second assignment or dict's value call. But, after few days I ...
11
votes
1answer
206 views

Is a memory leak and a lack of concurrent safety enough to make code unreviewable?

There is this question which has one close vote and three down-votes. The only comments are The code is broken because it doesn't deallocate memory (and because it uses a global variable although ...
16
votes
2answers
279 views

Can answers to questions contain code written in a different language?

This is in regards to Solving the Lazy Hobo Riddle. Is it acceptable to have answers that have code written in a different language than the OP's? The OP has since accepted an answer, but others are ...
-3
votes
2answers
100 views

"Lacks concrete context”, et al - drivng in the wrong direction

Over the last 2 months I have seen a significant proportion of questions closed, or marooned/abandoned by the threat of being closed. I understand the official figures are in region of 20-40% (about ...
2
votes
1answer
67 views

Improving a question - when to post a new question

I'm new to the code review site (but not to SE in general). I posted my first question in earnest after reading the "about" page and noting that code must be working. The code I posted worked locally,...
54
votes
5answers
936 views

Code Review is getting boring

Boring I find that Code Review is getting pretty boring and unprofessional. The reason why I think this way is that many good questions about real-world problems don't get very much attention. ...
2
votes
1answer
69 views

Where can I find an expert opinion on a large codebase?

I am a self taught developer that codes for fun, and I created a project that almost certainly has terrible code in it, but I would like someone who knows what they're doing (i.e. not me) to help me ...
15
votes
1answer
130 views

2019: a year in moderation

It's New Year's Day in Stack Exchange land... A distinguishing characteristic of these sites is how they are moderated: We designed the Stack Exchange network engine to be mostly self-regulating, ...
15
votes
5answers
693 views

The context of “Lacks concrete context”: let's fix it

Early 2018 we changed the close reasons on Code Review. This was necessary, but now almost 2 years later it's perfectly clear there's a growing discontent with one of them: "Lacks concrete context". ...
-6
votes
1answer
104 views

Please reopen “Trick circumvents [position: sticky] restriction to parent”?

Trick circumvents [position: sticky] restriction to parent My question was put on hold. Please vote to reopen it.
10
votes
2answers
175 views

Is a changeset reviewable?

I'm looking at Java refactoring - reduce cognitive complexity by extracting private methods (note: the question has been edited since I wrote this. At that time, I was looking at Revision 4) and in ...
0
votes
1answer
53 views

Is it on topic here for questions not about specific code but rather how to manage the code?

Title explains it: I want to ask a question about maintaining branches of a single project and I'm not sure if it's on topic. If not, is there anywhere that it would be on topic?
10
votes
3answers
256 views

Request to re-open “Find out relation between Devices…” question

I had sought out review for a question about some proprietary code that I am working on. The code in question retrieves information from a list of one-to-many mappings and seeks to build a ...
-5
votes
3answers
109 views

Question closures under PHP tag and and thin pretexts

Recently a question has been closed, with a reason "Code not implemented or not working as intended". However, the code (however as silly as it is) is fully implemented and working the OP asked ...
8
votes
1answer
153 views

Should vote to close for Code Review comments be flagged?

In The accepted answer by durron597 to A guide to Code Review for Stack Overflow users, it is prescribed: Please do not vote to close with a custom reason that "it belongs on Code Review". Some ...
17
votes
3answers
259 views

Making great content more visible

I often browse older questions on CR and while there are many good and helpful answers, every so often I come across great answers. Those are eloquent and full of helpful tips and general information. ...
12
votes
3answers
195 views

Why should I be able to answer my own question in the question's editor on Code Review?

I don't get why I am allowed to post an answer to my question in the question's editor: I know from Stack Overflow that this feature exists on Stack Exchange websites. It seems relevant for Stack ...
0
votes
2answers
161 views

Accepting without upvoting

What could be the reason for accepting an answer but not upvoting it? Situations: Accepting own answer - ok, no upvote on self-answers OP not having 15 reputation cannot upvote. I think that OP ...
7
votes
3answers
103 views

Titles that reference external resources

A couple of us disagreed (in comments) on whether titles that are nothing more than external references, such as "Advent of Code 2019 Day 3, Part 3" and "Project Euler nº 5", are reasonable. I ...
9
votes
2answers
234 views

“unclear what you're asking” vs “Lacks concrete context”

Aren't these two close reasons too similar? Since the Lacks concrete context exists I cannot remember using the unclear what you're asking anymore. unclear what you're asking Please clarify your ...
9
votes
1answer
121 views

Vote to close and unclear titles

We usually VTC questions with titles that don't reflect the goal of the code. Examples of said titles: "How do I make this better?" "My code is not fast enough" "I'd like my code to be more pythonic" ...
9
votes
2answers
132 views

Is GraphQL Reviewable?

This question was posted recently, and presents a GraphQL schema for review. Arguably, GraphQL doesn't do much, and we've closed plain Java and C# posts before where all reviewers had to chew on was ...
7
votes
1answer
99 views

Should we improve the code to be reviewed in an edit?

I noticed this suggest edit: This suggested edit does two things: Replace using namespace std;, which is considered bad practice in C++, with ...
7
votes
2answers
105 views

Collection of small unrelated methods

I have a file that contains a multitude of methods that are solutions to some common interview questions. None of these methods are related in any way, shape or form. I have been debating on the two ...
5
votes
1answer
275 views

My CR karma raised about 6000 points, what happened?

My karma in Code Review was two days ago around 16400+. Now it is 22700+. What happened here? I received my 8th golden badge; might it be responsible for that? Also, there is no any indication from ...
19
votes
2answers
199 views

Are machine-learning questions a good fit for CR?

I'm aware of When are Machine Learning questions on-topic?, but I think maybe there's room for discussion regarding the machine-learning tag. I've made a search on the ML tag (because I do not have ...
33
votes
4answers
1k views

Mat's back, blame the monkey

When I put down my mug 18 months ago, I promised I'd stick around, and I did. I've been keeping a distant eye on CR and meta, while remaining in our Rubberducking dev chat, and monitoring vba posts on ...
16
votes
4answers
297 views

Edit dispute - Indentation on questions

This suggested edit was rejected. As it should be - rolfl here has the correct reason: Whitespace "fixes" should be part of an answer, not an edit. Please do not fix code problems in the question. ...
6
votes
2answers
112 views

How do we handle answers that pertain solely to other answers?

Most of us are (or should be) familiar with this section of the Help Center Page How do I write a good answer?: What goes into an answer Every answer must make at least one insightful ...
7
votes
2answers
161 views

Review a piece of code bought from someone else

In How can I speed up this serialized array generation php script? the OP states, that they "bought one [...] script" from someone else. Since I could not identify if the script in question was also ...
11
votes
4answers
197 views

Are we voting to close too quickly?

With the kerfuffle on SE, I've decided to try & contribute a bit more again. So I started with the vote close queue, and this one irked me: https://codereview.stackexchange.com/review/close/...

1
2 3 4 5
30