Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

12
votes
3answers
174 views

Thanking someone for a good code review

Is it appropriate to comment on a good Code Review answer to one of my posts with a "Thank you"?
6
votes
2answers
88 views

Should we close a question of a non existing user? [duplicate]

There is this question in haskell that was originally posted on Stack Overflow but got migrated. The thing is, the user doesn't appear to exist or has been banned. It seems to me that the post will ...
5
votes
4answers
112 views

Are minor edits to old meta questions useful?

That's a view from the "active" page on the Code Review meta. The edits are mostly minor. And some of them are coming from quite old questions, even questions with the status-completed tag. Like ...
2
votes
1answer
56 views

I found a (trivial) solution to my problem after submitting it

About Counting primes in a range whose digits are all prime. My code had a bug, the bug was an edge case that only manifested in literally one of the test cases, (I identified it by completing the ...
18
votes
1answer
152 views

Are machine-learning questions a good fit for CR?

I'm aware of When are Machine Learning questions on-topic?, but I think maybe there's room for discussion regarding the machine-learning tag. I've made a search on the ML tag (because I do not have ...
20
votes
3answers
242 views

Found a serious bug in my question after posting it

What is the correct way to go after I found a bug in a question that I posted? Shall I delete the question, vote to close it or flag it as off-topic?
2
votes
1answer
35 views

Should there be a tag for Python library [requests]?

I recently asked a question where I was interested in if I used the Requests library correctly. To my surprise, when I was adding tags, I didn't see the one for this library. Googling ...
27
votes
26answers
2k views

Tools for format and error checking in your programming language

Lints and Hints: What tools are available for checking and correcting the conventions, style and common errors in my language (lint tools), and are there tools that can automatically fix them (hint ...
8
votes
5answers
131 views

Optimize our meta tags?

First off I should say I'm ignoring the following meta tags: beginner, homework, reinventing-the-wheel, and most with less than 100 views. A short overview of the discussions around these tags is ...
19
votes
4answers
389 views

Punny/Playful Titles Policy

Related: How can we avoid redundant titles? When you ask a question on the main site, the watermarked instructions say: State the task that your code accomplishes. Make your title distinctive. This ...
4
votes
2answers
73 views

Good format to post code for review

I have a project that I used to try out in-memory databases. After fighting it for a few days, I'm code blind and need to have it reviewed. I haven't been on this particular site much (I'm well ...
2
votes
1answer
73 views

Why did this js Fizzbuzz question get so many more views than others?

Why did this recent question: FizzBuzz in Javascript get so many views and, presumably, many more votes (than would be normal)? My initial theory was that it contains the tags fizzbuzz and that tag ...
0
votes
1answer
52 views

Is it ok to post code that didn't work out as intended?

I recently tried to optimize some code by using parallel processing, putting two cores to work on the problem instead of one. For whatever reason, it didn't work. I don't know why, but I doubt much ...
4
votes
1answer
79 views

Review one-by-one feature?

I am writing a library. It is mostly ready, but there are known bugs and ToDo stuff (including for example missing const specifiers for member functions which do ...
7
votes
1answer
123 views

Question about “Polymorphic implementation of == with CRTP” on hold as off topic

I have a question about my Code Review Stack Exchange post: Polymorphic implementation for == with CRTP. It was put on hold as off topic stating (mainly) that the use case is theoretic or not ...
12
votes
2answers
243 views

Unnecessary comments

Should I keep my comments or remove them if they are wrong or no longer serve a purpose under an answer/question? When I remove my comment(s), the other comments (by others) become meaningless. If ...
15
votes
2answers
245 views

Can answers to questions contain only code not the same language?

This is in regards to Solving the Lazy Hobo Riddle. Is it acceptable to have answers that have code written in a different language than the OP's? The OP has since accepted an answer, but others are ...
0
votes
0answers
56 views

Is it possible to get a code review of scripts while obfuscating sensitive information? [duplicate]

Namely, I wrote a Python script to handle Cloudflare-based Dynamic DNS updates for a system, but I need to obfuscate my CloudFlare creds and some API keys, for fairly obvious reasons. Would there be ...
20
votes
0answers
125 views

2018: a year in moderation

It's New Year's Day in Stack Exchange land... A distinguishing characteristic of these sites is how they are moderated: We designed the Stack Exchange network engine to be mostly self-regulating, ...
4
votes
2answers
99 views

Should we allow answer invalidation for otherwise off-topic questions? [duplicate]

We recently had a question with un-compilable code. The question was answered and the answerer pointed out the broken code. The user has since edited the question to fix the code. It was rolled-back. ...
11
votes
2answers
160 views

Flagging users who select “No Action Needed” in First Posts review queue

A while back I was directed to read the accepted community wiki answer to this First Post Review question (and of course heeded the advice). In Jamal's answer to this question about reviewing a ...
4
votes
0answers
42 views

Is a question on topic if the code works locally but errors when submitted to a coding site? [duplicate]

This is about a recently posted question: Codejam 2018 - Getting confusing runtime error The OP claims it works for him locally, but generates a Runtime Error on the Google Code Jam website itself. ...
8
votes
1answer
180 views

Posting a question where part of the code contains a known bug

There is a particular requirement that has two versions. The first version has proven to be more challenging than the subsequent version to both describe the specification and compose; and also ...
-6
votes
4answers
110 views

Closing of questions citing “off-topic” as reason where user-defined code and standardized code is clearly equivalent

See From the below javascript code snippet which one is considered to be most appropriate? [on hold] Scenario 1: ...
23
votes
3answers
179 views

What criteria do you use to upvote a question?

This site is very unique in that 2 people can't come and say I had the same problem, since all questions have working code. Having said that, I see a lot of answerers not upvoting the questions they ...
46
votes
0answers
366 views

Code Review questions must contain code

As requested by Kaz and approved by the voters here on meta, questions asked on Code Review that do not contain code are now blocked. I've configured this initially as a three-line minimum (or three ...
2
votes
1answer
88 views

The problem with insufficient context

The new (well, not that new now) Insufficient Context close reason has a problem. People see the name and think it is about the text surrounding the code. The text context for the code. But the ...
2
votes
1answer
114 views

What is immoral about reviewing someone else's code? [duplicate]

The Help Center says: For licensing, moral, and procedural reasons, we cannot review code written by other programmers. Can somebody explain what is immoral about reviewing someone else's code? ...
11
votes
0answers
115 views

What's the [api] tag for?

The taginfo for api describes what an Application Programming Interface is, but doesn't give any guidance as to what kind of question it applies to. Given that the majority of code here is at ...
7
votes
1answer
82 views

Acceptability of questions about checking for race conditions

Is it acceptable for users to post questions in this community and have their code evaluated by others to check for race conditions? Or do these types of questions fall under the banner of 'broken ...
9
votes
1answer
195 views

Does Stack Overflow count as a third party site?

I had a question that was placed on hold with a link to this: Can I put my code on a third party site and link to the site in my question? The code I asked for review of was on Stack Overflow, and ...
7
votes
2answers
154 views

How do we handle stated restrictions around coding challenge sites' legalese?

I see things like the following on a certain coding challenge site: Copyright 2009–2018 by Codility Limited. All Rights Reserved. Unauthorized copying, publication or disclosure prohibited. I ...
5
votes
2answers
230 views

Is “How does this algorithm work?” a good question here?

If I have a question about the algorithm that I can't understand the logic behind, how and where should I ask the question?
51
votes
5answers
3k views

Checklist for how to write a good Code Review question

Many questions of new users lack some parts or common style of the site. There already are some meta questions that aggregate tips on this issue but letting new users walk through all of them is ...
49
votes
5answers
748 views

Code Review is getting boring

Boring I find that Code Review is getting pretty boring and unprofessional. The reason why I think this way is that many good questions about real-world problems don't get very much attention. ...
0
votes
2answers
143 views

Accepting without upvoting

What could be the reason for accepting an answer but not upvoting it? Situations: Accepting own answer - ok, no upvote on self-answers OP not having 15 reputation cannot upvote. I think that OP shold ...
12
votes
4answers
82 views

“What's beta” in Help Center: Do we still need it?

I was looking through the help center recently, and noticed the What's beta? page. Is it even necessary anymore? I understand that we have not completely graduated yet, but we are not in beta any more....
3
votes
1answer
216 views

Announcement: New chat room CRCQR

As some of the regulars at the SE Code Review site already noticed we have a new chat room to request and discuss question closures: SE Code Review Close Questions room I've setup that room due to ...
5
votes
3answers
194 views

Why do some users have HTTP response codes in their display names?

I know I could ask this in the 2nd monitor but figure this might be better here for posterity... and this site is for questions... I noticed a while back that there are a couple users who have HTTP ...
7
votes
1answer
152 views

Does [ascii-art] mean only ASCII?

I'm looking at the ascii-art excerpt, which says: ASCII Art is a graphic design technique that uses 93 of the 128 printable ACSII characters to create images. Whilst this is almost true (it uses ...
0
votes
2answers
232 views

To serve, what is it to ask for review?

Food for thought. There are times when questions come along which demonstrate a student's query, and with that comes the student's ill fated attempt to pose an "on topic" question without much ...
3
votes
0answers
22 views

Can I ask about my CloudFormation infrastructure template?

I have a template for some infrastructure using AWS CloudFormation that I'd like reviewed. However, I'm not sure if it's on-topic here; it's YAML that's describing infrastructure, not a program per se....
3
votes
2answers
99 views

I broke your code, therefore your code doesn't work: NAA discussion

Let's say the OP had code like this (imagine there's actual code here, I'm just making a generalized example for meta): ...
13
votes
2answers
319 views

My code is too long. How do I trim it down when code posted here is expected to function?

The code I would like to have reviewed, found here, is more than 30,000 characters long. I don't feel like that in and of itself makes it off topic, but removing code from it so that it can be posted ...
3
votes
1answer
457 views

How many lines of code are too much? [duplicate]

I've built an ASP.Net component, for example, which consists of a base class with 670 lines of code, a sub class with 180 lines, plus some code to illustrate it's usage. I think this is a perfect ...
21
votes
2answers
204 views

Can we enhance the favicon on a dark background?

In Chrome on Max osx, at least, the favicon in the tab title kind of disappears when having a dark main background on the window. Can this be enhanced somehow? The image shows top part of window with ...
7
votes
4answers
492 views

Code Review's updated site theme is now live for everyone

Update - the theme and layout is now live for everyone. Thanks for your feedback in this process. If there's additional feedback, please feel free to add to the answers below. As part of ...
0
votes
1answer
47 views

Post was put on hold stating that code is not working

I have a question about my Code Review Stack Exchange post: Filling-values-for-dictionary-of-dictionaries Post was put on hold stating that code is not working but it's working and I had posted the ...
6
votes
2answers
150 views

Are practical user-created languages suitable for a tag creation?

I recently created a language, and was wondering (As many others may be) if a user is allowed to create a tag for their language and post a few example questions. The following things should be ...
0
votes
1answer
56 views

Why is my SPOJ question receiving downvotes?

SPOJ- CPP: Gap in output What is the purpose of so many downvotes? And what does it mean that the code should be "embedded directly"?