Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
2
votes
0answers
60 views

What is the upper bound for size of the code I can post on Code Review? [duplicate]

Suppose I'm writing a library and there are parts of it which I wish to be reviewed. What is the upper bound for size of the codebase (in characters, classes for example) which is considered to be ...
3
votes
1answer
101 views

Should quick fixes to non-working code go into comments only?

I've started thinking about this after seeing the answer for this question. Of course, non-working code shouldn't be posted here. However, there are times where someone addresses such issues in an ...
8
votes
3answers
201 views

Should be focus on solving OPs problem or more general analysis

I couldn't come up with a better title so bear with me. Preface (please read): The private beta is slowly coming to an end so i'd like to have discuss a little about that topic since onces public ...
6
votes
1answer
74 views

What if OP has doubts about the code being working?

I was browsing questions and found this question. In this the OP states that the code is working according to him but someone told him that it isn't working. What kind of review should be done in ...
4
votes
2answers
116 views

Off topic reason for questions that don't include code?

Currently, one of the two custom off topic reasons for CR is: Questions must contain working code for us to review it here. For questions regarding specific problems encountered while coding, try ...
16
votes
0answers
172 views

Meaningful question titles [duplicate]

I visited Code Review the first time and noticed that many question titles are meaningless. For example I found the following titles on the front page. How can I make this program a bit more ...
6
votes
2answers
107 views

Advice for reviewing edits

I just became eligible to approve pending edits and would like some advice. At the time of writing, this post has a pending edit: Finding similarities between images The edit changes the code ...
11
votes
1answer
247 views

How long is long code

I usually hang out at the JavaScript tag, with a mix of jQuery, HTML and CSS where the code reviewed are usually snippets, which run around 100 lines and code that needs micro-optimizations. These are ...
11
votes
1answer
122 views

Would it be on topic to request a review of a stackoverflow answer I gave?

A stackoverflow answer I gave prompted a downvote from the very beginning plus snide remarks about my skills and so forth. The downvote I can handle, the snide remarks are unfair in my opinion, but ...
4
votes
1answer
97 views

Move to SO or Programers

I can find it with a quick search; But: But there must already be a question here on meta about moving off-topic posts to SO or Programmers.stackexchange.com ore automatic. Like: Off-Topic move to ...
7
votes
1answer
155 views

Are questions about how to further golf a program on-topic here?

I have a simple algorithm that I'm using for code golf, and I'm hoping to find ways to golf it further. The algorithm is somewhat golfed in Python already, and works flawlessly. I asked on meta....
6
votes
1answer
107 views

Is it appropriate to post 1k+ lines of code?

I recently asked a question on CR, and got an interesting suggestion that I'd like to look into. However, due to the class that the method is part of, and me still being green, I'm having a hard time ...
-5
votes
2answers
151 views

The opportunity to post an anonymised code. To have no problems at the place where you work

[This is in respect of this question on Code Review, which contained anonymised proprietary code, and which was closed as discussed here.] My feature-request to make is possible to post the ...
3
votes
2answers
61 views

Review of code reviews?

I'm just wondering if there is any need to change the 'review' label here or (much worse) change the name of this site, since review in the title bar means something very different from review in the ...
5
votes
0answers
80 views

Redundant thank you notes in questions

Would it be wise to consider such posts as a subject for "auto" edit or add to the faq? It seems redundant to ask for review or little personal notes on the site which purpose is to review the code ...
5
votes
1answer
140 views

Does Community Evaluation make sense for Code Review?

A “Community Evaluation” queue just appeared on the review page. It seems one of the main reasons for that queue is to compare each question with other sources on the internet for that same question: ...
12
votes
2answers
133 views

Is it valid to reask (many) question on same script?

I have asked a question about a Python script a few months ago. Now I have developed that script furthermore fixing the issues described in the answer of that question. Now I have another questions ...
9
votes
1answer
79 views

Flagging closed questions for deletion

I've flagged two questions recently: https://codereview.stackexchange.com/questions/7491/c-how-to-take-file-ownership-to-the-current-user-using-win32-api https://codereview.stackexchange.com/...
2
votes
1answer
58 views

Why are these two questions not closed as exact duplicates (and merged)?

This question was asked on Code Review: https://codereview.stackexchange.com/q/19022/3973 This question was migrated to Code Review (by me, from Stack Overflow), which is an exact duplicate (word-...
5
votes
1answer
56 views

Getting feedback on functionality and not code

I am writing a Template Engine, I don't really want my code reviewed, but I would like people to test it and give me feedback about what they think what I could add/remove/change. Would something like ...
4
votes
1answer
69 views

Should different questions be made for style and functional questions?

Ongoing example: functional, style. As far as I know, focusing on any aspect of the code is fair game in a review. Do we want to allow such specialised-duplicates and request reviewers to answer in ...
4
votes
0answers
76 views

How to choose a correct answer in Code Review? [duplicate]

Possible Duplicate: Which answer to accept? Just discovered Code Review and I think it's great. I posted my first question and got two answers full of great advice. What advice do you have ...
14
votes
2answers
294 views

Code remove after question answered

If the user that posted the question deletes the code to which the question belongs to, after accepting an answer, should one restore the code or simply notify the user or moderator?
18
votes
0answers
290 views

Do not prematurely accept answers

With the voting debate going on, I'd like to make a related point: Please do not prematurely accept answers. As much as I love getting the tick mark, it is a signal that tells the community that a ...
10
votes
3answers
332 views

Are reviews of code in Stack Overflow answers in scope?

Say you spent some time on a code answer to a SO question (example). Is it OK to forward the same code to Code Review or should any comments be left to happen in SO? If it's OK to ask for a review, ...
7
votes
1answer
121 views

Why was a question suitable for Stack Overflow closed, instead of being migrated

Yesterday, Jessica Burnett asked this question: https://codereview.stackexchange.com/questions/14209/css-set-string-content-properties. Since the question is about code that does not work (as opposed ...
2
votes
1answer
68 views

Before getting started

Well this question may b a perfect fit in meta. So, I want to know a bit more about this sister site of stack overflow. I have been looking for a site like this since long, and this being a stack ...
4
votes
1answer
102 views

Are badges with a negative connotation useful?

This is a very minor point. I'm just curious to see what the thoughts might be on this. I just "earned" a tumbleweed badge. In the past I associated badges with good things but it seems this is not ...
10
votes
1answer
229 views

Code review for learning purposes

I just found this site (New to stack exchange in general), and I am working on teaching myself c#. Would it be acceptable to post working code for people to pick apart and suggest better ways of doing ...
5
votes
1answer
151 views

Interview questions

It this a good site to ask others to review my interview question practice code? Or are you trying to keep it to "real world" questions?
14
votes
1answer
229 views

Should I attempt to have a large amount of code reviewed?

I'd love it if someone out there was willing to critique my code base on a larger scale - the thing is I can't imagine why anyone would actually want to. Do you think I'm wrong about this? Should I ...
9
votes
1answer
222 views

Are UML diagram reviews on-topic for CodeReview?

I would like to post a UML diagram for review on StackExchange. The response to the question I asked on Meta Stack Overflow seems to point to CodeReview being the place to ask, but the answer was ...
2
votes
0answers
31 views

Is it intentional that there's no mention of copyright in the FAQ? [duplicate]

Possible Duplicate: Put in FAQ: Will submitted code be licensed under the copyleft CC-BY_SA? Surely it's important for users to know whether code contributed to this site is freely available for ...
1
vote
0answers
81 views

Stack Overflow Worldwide Meetups 2012: You're invited!

We're having a Stack Overflow meetup to get together with fellow programming, web, and other technology enthusiasts. But not all of our programmers and technology enthusiasts live on Stack Overflow, ...
2
votes
2answers
120 views

Is it generally a good idea to post proprietary code?

I'm sorry, before I asked any questions, I needed to have this one answered, but I couldn't post on meta (not enough rep). I would like to ask a question about my JavaScript Node program, but I'm ...
8
votes
0answers
111 views

New Beta Theme Launched

Your site looks a bit different today. Yes, we are getting rid of the 'Sketchy' look and replacing it with a more-polished and finished design for sites in beta. You can read more about the redesign ...
4
votes
2answers
106 views

General guidelines for language references

This question is a follow-up to Create a reference for newbie common mistakes. I'm trying to understand/outline how these language references should look like. What do you think should be put in ...
3
votes
1answer
45 views

Is it permissible to solicit techincal feedback for a blog entry on coding

I find myself answering a lot of questions on StackOverflow about sockets and network programming. I typically answer a lot questions from developers who are new to sockets and network coding - and ...
7
votes
1answer
182 views

Practical Best Practice Questions

There are a number of questions of similar type that get asked here: How many conditions in an "if clause" is acceptable? https://codereview.stackexchange.com/questions/5804/using-catching-...
2
votes
2answers
40 views

Are questions that ask for profiling tools considered on-topic?

This question was originally only asking for performance measurement tools. It has since been modified somewhat to ask for something closer to a review, but neither of the answers address this. So: ...
6
votes
1answer
109 views

Is it appropriate to prune code blocks by editing out irrelevant Javadoc comments?

I've just did a compulsive edit on this question, essentially removing @author, @version and ...
1
vote
1answer
445 views

Why not codereview.stackoverflow.com?

Is it possible codereview.stackexhcange.com to be codereview.stackoverflow.com? reasons: I have seen some questions on stackoverflow.com implicitly asked to review code. Both websites about ...
5
votes
1answer
54 views

Tag synonyms (refactor -> refactoring)

I think we should make refactor a synonym of refactoring.
5
votes
1answer
70 views

Tag synonyms (optimize -> optimization)

I can't propose tag synonyms so I'm just posting here. I think we should make optimize a synonym of optimization. Also, the only existing synonym for it, effeciency, is misspelled.
4
votes
1answer
95 views

What does a piece of code need to satisfy to be a “real project” by itself?

Currently, the FAQ provides the following guidelines: Code Review - Stack Exchange is for sharing code from projects you are working on for peer review. You should only ask practical, answerable ...
10
votes
1answer
808 views

Online Contest Questions

A number of questions get posted here by people trying to solve problems from sites like interviewstreet.com. The site is intended to test programmer ability. Can you figure out the efficient ...
12
votes
3answers
247 views

Shoud this site focus on reviwing peoples code or how to review code

I think that code review, especially peer review, is essential in improving quality, decreasing maintenance costs, etc. So, should this site strive to help people promote this philosophy or merely ...
1
vote
0answers
60 views

undocumented effects of indentation on sub-lists

What's the actual rule for sub-list nesting? The documented rules say to indent this sublist entry by 4 spaces, but any indentation from 1 to 7 SEEMS to work. Code block formatting works as ...
7
votes
1answer
81 views

The CodeReview FAQ needs clarification of its intent around “best practices” questions

The CodeReview FAQ is confusing to me regarding best practices as a topic because on the one hand it says: If you are looking for specific feedback about… Best practices and design pattern ...
4
votes
1answer
97 views

How is “Application UI” within the scope of this site?

I just noticed Code Review's FAQ includes "Application UI" in the "If your question is about..." section. What exactly is meant by that? User Experience is the site for UI/UX issues, though UX.SE is ...