Stack Exchange Network

Stack Exchange network consists of 175 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

34
votes
1answer
1k views

Welcome to The 2nd Monitor!

So, you have found your way to the Code Review main chat room, The 2nd Monitor, perhaps for one of these reasons: You were invited or "pinged" by a site moderator or other user to discuss a post on ...
6
votes
2answers
149 views

Need clarification on my close reason interpretation for a specific close reason

The question Does this method guarantee that cells in a CSV will be correctly partitioned? is a duplicate of this one (10k+ and mods only) which asks whether a singular function properly 'escapes' ...
3
votes
2answers
99 views

How to prevent people from answering off-topic questions?

Assume a person is asking about their broken code and someone suffering from FGITW-syndrome immediately answers it. Then maybe the answer and/or even the question gets upvoted. This completely ...
3
votes
2answers
64 views

Why is my second “Form maximum date/time from some digits” question being down voted?

My question here is getting down votes: Code Vita 7: Form the maximum possible date time in the MM/DD HH:MM format using any eight of twelve given single digits which is a follow up to my previous ...
-5
votes
1answer
71 views

Please reopen “Trick circumvents [position: sticky] restriction to parent”?

Trick circumvents [position: sticky] restriction to parent My question was put on hold. Please vote to reopen it!
5
votes
2answers
132 views

How much context is the required minimum?

This question got sparked by a recent discussion in the 2nd Monitor about this question: Golang Map-Reduce Master - Channels. The problem is: How much context is needed to actually review the code in ...
10
votes
1answer
98 views

If porting code, should I also post the original?

Is it on-topic (or acceptable practice) here to post code written in one language, and ported code in another for review ? I am learning scala and in doing so I am translating some code I wrote (in C++...
7
votes
2answers
93 views

How should question bodies be organized?

The format that I know for question bodies is: Intro, often explaining where the problem originated. A problem statement explaining what the code is supposed to do. Perhaps a little more ...
4
votes
1answer
92 views

Closure of finding the longest word in a string

Recently we got the question Finding the longest word in a String. (10k required) This question looked like it was off-topic, because of the following results: ...
12
votes
6answers
128 views

Performance checking tools

Performance checkers: What tools are available for attaining the metrics necessary to perform a performance review? Bench-marking is often not easily done by hand after all. This is a follow-up to ...
32
votes
2answers
253 views

Do people read other reviews for learning?

I was looking for posts about self-answering my own code review question, and I saw this post: Why should I be able to answer my own question in the question's editor on Code Review? 3 days ago I ...
4
votes
1answer
154 views

Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)

I am new to this specific Q&A site and I got my rep off of association bonuses, and I wanted to ask how to fix my code to work for another version of python. I noticed the text "Post code that is ...
12
votes
3answers
178 views

Why should I be able to answer my own question in the question's editor on Code Review?

I don't get why I am allowed to post an answer to my question in the question's editor: I know from Stack Overflow that this feature exists on Stack Exchange websites. It seems relevant for Stack ...
16
votes
2answers
152 views

Should I leave in documentation in code for review?

I'm surprised I can't find this as a question already, so I'm taking a shot and posting... I document my code. I don't not document my code before considering myself done for the day. Most of the ...
10
votes
2answers
194 views

Is it allowed to edit code if there is no answer?

If I have kept working on the code, and there are no answers (say one week after the original post), am I allowed to edit the code to reflect the changes I have made to it? I believe this question is ...
4
votes
1answer
112 views

Technology review without code

I developed a new blockchain technology. I have white papers and my code is under development. I would like to ask a question about my technology idea and not providing actual code. Is that kind of ...
15
votes
1answer
218 views

PSA: Excel going “Not Responding” isn't broken code

Some VBA questions mention the host application (e.g. Excel) is going "not responding" while their macro is running. Is it ok to vote to close these questions as "broken code"?
0
votes
1answer
81 views

When to create a generator or return simply a list, closed for missing context

The other day we got the question: When to create a generator or return simply a list in Python? This question has a generic title, some code which contains enough code to be reviewed. And a couple ...
2
votes
1answer
29 views

Clojure tag not sorting first

I've noticed that all language tags are sorted first but clojure tag. Is this by design or is there some setting that this tag is missing?
2
votes
0answers
25 views

Posting multiple questions for the same code at different points in the development [duplicate]

Here's the scenario: I have posted a question on Code Review and received feedback (but not a refactored code). I improve my code based on the advice I was given in this question and added new ...
2
votes
3answers
63 views

Why did this question get closed?

There is a review history for the question where it can be seen that it has been closed several hours after the OP fixed the issue. Why people kept voting if they could see that the reason is not ...
15
votes
3answers
243 views

Making great content more visible

I often browse older questions on CR and while there are many good and helpful answers, every so often I come across great answers. Those are eloquent and full of helpful tips and general information. ...
1
vote
1answer
147 views

has the site became less welcoming…?

I raised a question earlier. Here is a screenshot of it: and the Comments I'd be honest, it is not the best question I've asked so far. But to have a minus 4 for that question? That's weird for a ...
12
votes
3answers
220 views

Should we bother old off-topic questions?

Recently I've found some old questions which do not contain any code (usually just a link). Some of them have an accepted answer. Since these questions are off-topic (according to the FAQ), should I ...
5
votes
1answer
125 views

Clarification on close reason

This question was closed per the Authorship of code reason. However nothing in the question seems to suggest that it is not written by the OP. Were there maybe (now deleted) comments that made clear ...
6
votes
5answers
499 views

What's the best way to change how my code looks?

A long time ago the question avoiding Python multiline string indentation was asked. The question was well received with a score of 66 and 16 favourites. It was even answered by one of our previous ...
22
votes
8answers
591 views

How much idle chatter do we tolerate in The 2nd Monitor?

Related but not a duplicate: How far off-topic can we get in 'the 2nd monitor'? Today was a complicated day in the history of The 2nd Monitor. On one side there appears to be consensus something ...
6
votes
2answers
159 views

Make constexpr synonym to a new tag, constant-expression

I'm proposing creating a new tag, constant-expression, and then making constexpr a synonym for constant-expression, rather than constants. Constant expression in C++ requires different usage of ...
2
votes
2answers
97 views

Answering questions in comments

On Code Review SE, users should avoid answering questions in comments, because that's not what comments are for: Do not provide suggestions for improvements in a comment, even if your suggestion ...
2
votes
1answer
50 views

“Password validation” question appears to have been wrongfully closed

I want to question the closing of this question: Password Validation in Python 3.6 The reason given is "Code not implemented or not working as intended". I can see no evidence that the code is ...
3
votes
2answers
142 views

Unmodified question looks modified

This is maybe the fourth time I noticed this scenario since the start of this year, so I am curious to know if you have an explanation: When I clicked on Questions, I saw this: But when I clicked to ...
26
votes
0answers
420 views

Playing our home-made games!

As developers we know that it's not always easy to get people to play the games that we make. We also know that it's not always easy to find motivation to work on the games you want to make. This is ...
8
votes
1answer
134 views

Should vote to close for Code Review comments be flagged?

In The accepted answer by durron597 to A guide to Code Review for Stack Overflow users, it is prescribed: Please do not vote to close with a custom reason that "it belongs on Code Review". Some ...
2
votes
2answers
83 views

Not notified of unwanted edits to question

I was surprised to see one of my questions being changed that much that the intent of the question was removed from it. As C++ is evolving rapidly, I was experimenting with one of its features: ...
4
votes
1answer
70 views

Duplicate answers - clean them up?

This question (originially from Stack Overflow) has heaps of duplicate answers. Many users suggested the exact same changes to the code, presumably while the question was not yet migrated; most of the ...
26
votes
11answers
427 views

Should we bring back the fun?

Since we've not had any fun in a little while, I thought maybe it'd be a good idea to 'bring back' the fun. In the past this has been in the form of Winterbash, community challenges, best of Code ...
5
votes
4answers
324 views

Poor mans count, is it off-topic?

Recently we had the question "Project Euler Problem #12 - Highly divisible triangular number" It was closed as the OP included how to use the function with the function's code. The code as posted ...
19
votes
3answers
217 views

Should we censor rude language in comments/strings of posted code?

What I’m refering to mostly started with this edit where strong language that possibly originated as a joke from the OP was flagged as rude and removed from the question entirely. The code in the ...
11
votes
4answers
182 views

Handling things that seemingly *every* new writer of a language gets wrong

I've noticed that, for whatever reason, seemingly every new user of Clojure tries to use def to create local variables. I've noticed it here, and on Stack Overflow, ...
2
votes
1answer
51 views

I changed my question after comments

I closed an earlier post asking for code-feedback on the Click CLI framework I wrote for my scripts. I reopened the question simply about my approach to templating scripts. I rewrote the post as an ...
6
votes
1answer
94 views

How should we review code written around a template?

It is fairly common for review requests to be for homework or interview practice questions. For example there's a fairly steady stream of python tic-tac-toe games which I'm basically convinced fall ...
7
votes
1answer
136 views

Can I include problem statements when posting exercise solutions to Code Review?

I have several books of programming exercises that I am working through. I would like to post some of my solutions to Code Review. Can I include problem statements along with my solutions without ...
15
votes
1answer
75 views

Can we replace the misleading [unity] tag with a more distinct tag?

Some unity3d (game engine) questions are being accidentally tagged as unity (Microsoft dependency injection container). Can we rename unity to unity-container, and create a tag synonym for unity and ...
-7
votes
3answers
214 views

Please reconsider the rule: Pseudocode, hypothetical code, or stub code should be replaced by a concrete example?

Related: Why is hypothetical example code off-topic for Code Review? Is pseudo-code alright when asking about performance? The gray areas of Code Review: Hypothetical / Example code My concrete ...
29
votes
3answers
730 views

Should you edit someone else's code in a question?

I have seen several (suggested) reviews lately, where someone edits the code in the original poster's question. Should such edits be allowed? The edits in question are mostly minor. Some add spaces ...
11
votes
4answers
191 views

Can you show me how to apply a specific strategy to my working code to improve it

As brought up here, I'm not sure when the last time we (as a site) discussed how to determine if questions are on- or off- topic. A lot of questions currently fails the "any or all facets of the ...
2
votes
0answers
41 views

Posting very simple questions as exemplars [duplicate]

I noticed a couple things that have been pointed out repeatedly. Having an exemplar of that single issue (not a bunch of issues in a long piece of code) can be pointed back to along with a simple ...
14
votes
2answers
226 views

Code that handles n% of test cases but not all

I've started noticing recently questions like this one (66%, not well received) or that one (50%, well received) where the author states something like this: I am trying to solve this problem on ...
5
votes
1answer
53 views

Can I ask for code review of a relatively small open source project I created on GitHub? [duplicate]

I created a small project on GitHub for creating a mask for a 3D UV resin printer (using DLP technique) to have a homogenously light intensity across the build area. Although it is small, I like to ...
2
votes
1answer
55 views

When is a question considered too hypothetical / lacking context?

The reason I'm asking is because I recently encountered this question, and I can't make my mind up if it's off-topic here or not. I asked OP to include the imports so I could run the program, but ...