Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

17
votes
1answer
175 views

Is it appropriate to record the review process and upload it to YouTube?

The video is of-course supplement to an answer. The link will be in the comments. The actual answer will be written during the video itself. Motivations There is a user named sehe on SO, who ...
16
votes
2answers
148 views

How broken does code have to be to for a question to be closed?

I recently voted to close this question: The longest subsequence with specified difference between min and max Originally I thought the code was really bad because the OP claimed a linear solution, ...
3
votes
1answer
183 views

What is the reason for the downvotes on my answer to “Country Guessing Game”?

I feel like I have a scenario like this, but recently I gave an answer which received a down-vote, as did one other answer to the same question, and then mine got a second down-vote, yet there were no ...
11
votes
1answer
173 views

What's your angle on desynonymizing [Angular] and [Angular.js]?

As we should know from ""Angular" (Angular is not Angular.js)", Angular is not AngularJS - Angular is Angular2+. Wikipedia also says they're different things: Angular - "Angular (commonly referred ...
3
votes
2answers
168 views

Should the phrase “passing a parameter” be corrected from posts?

This is a question about nomenclature, which I hope is on-topic here on meta. I believe it is: since my last question it became clear to me that answerers here are, above all, educators ("we're ...
31
votes
6answers
399 views

On the huge amount of work needed for a CR answer

I'm a regular at Stack Overflow, and I just recently discovered Code Review, where I answered some questions with the d3.js tag. We all know that CR is quite different from SO: by its very nature, ...
8
votes
2answers
211 views

Help a new user avoid being off-topic

I am new to Code Review (but not new to Stack Exchange in general). I'm puzzled by the reasoning for putting this question on hold and would like some advice on how to be on-topic in this and future ...
2
votes
2answers
94 views

Should complexity formatted as code be updated to use MathJax?

I saw a post that mentions algorithmic complexity and formats such complexity values using inline code spans (e.g. O(n)). Should that post be updated to use MathJax ...
11
votes
3answers
440 views

Asking questions - including full code

In my first CR question, I was looking for feedback about my implementation of a graph data structure and an algorithm for depth first traversal, as I am studying these at the moment. Although I ...
17
votes
1answer
295 views

Is this question popularity normal?

I was on Code Review, asking a question for the first time. I thought my question was good, but it never crossed my mind that it would become popular enough to make it to the hot list. It did, and I ...
25
votes
1answer
2k views

CODE REVIEW 2017 Challenge: Entries

Update: no one entered on time, but as I've seen at least one question on main site meeting the requirements, I'll be extending the entry date to the end of this week (23:59:59 UTC+0000 on 8 December ...
0
votes
2answers
52 views

Code typed in from a non-text source or converted from another language and isn't working - is this in the scope here?

I recently typed in code from a scan in a PDF is pseudocode or in another language to make a JavaScript version. The code was implementing things of a mathematical nature beyond my math abilities ...
35
votes
5answers
756 views

What is the appropriate length of a Code Review question?

While Stack Overflow questions often contain segments of pseudocode or purposely abbreviated code in order to make the question more palatable to other readers, for something like a Code Review, the ...
47
votes
5answers
401 views

2015 Community Moderator Election Results

Code Review's first moderator election has come to a close, the votes have been tallied, and the 4 new moderators are: Please thank them for volunteering, and share your assistance and advice ...
4
votes
1answer
122 views

Could I have made my question “fast responsive navigation in CSS & jQuery” more attractive/better?

I would carefully like to ask, what (if at all) I could have done to make my question "fast responsive navigation in CSS & jQuery" more attractive and/or interesting for the community? Or is CSS ...
18
votes
5answers
421 views

Code Review Community on GitHub: where is it going?

Almost four years ago, Code Review community went to GitHub. In these past four years, what have we accomplished with this GitHub community? There are five repositories in the community, four if you ...
7
votes
2answers
114 views

Attribution and Copyright of Problems

How should it be handled if a user asks a question where the original problem is from some website and under copyright? For example this question quotes a problem from a website which says at the ...
-1
votes
2answers
76 views

Why was “Check if a variable is one of a set of valid strings” put on hold?

They said: Questions must involve real code that you own or maintain. Pseudocode, hypothetical code, or stub code should be replaced by a concrete implementation. Questions seeking an explanation ...
15
votes
5answers
219 views

Game tag - When to create own tag for games?

I have just created the minesweeper tag and the rock-paper-scissors tag. The reasoning for this was: Rock Paper Scissors (Lizard Spock) is popular enough to deserve its own tag. (37 questions seem ...
20
votes
1answer
167 views

Should I include my testing code?

I recently posted a large chunk of code. It feels like a tall order to code review. I've written a bunch of tests to test my code. Would those tests be useful to the reviewer? I'm not looking for ...
8
votes
2answers
183 views

How should we handle answers on non-code questions?

Recently I've come across a question that didn't contain any code. The questioner instead asked for code, as some new users do. So far same business as usual, but a user went ahead and posted a ...
13
votes
1answer
148 views

How long should we wait before asking for an iterative review?

In my search for the gory details of the Dos and Don'ts of iterative reviews, I saw that we should always ask another question with our follow-up. However, I haven't found anything about how long we ...
-4
votes
3answers
140 views

What about questions which demands expert opinion and design feedback

This has been an issue here since a long time and I see a lot of people just to get brownie points jump in and copy paste the answers which can be as generic as possible for example: Use linter Bad ...
9
votes
1answer
151 views

Multiple similar questions from the same user

After answering this question, I noticed the user posted the same question 3 times in a row today. Now I kinda wish I didn't answer at all, because it feels like cheating to me. You have the issue of ...
-9
votes
2answers
99 views

Change the licensing of code in Code Review contributions to GNU GPL

It seems that one of the community's main aversions to changing from the current CC license, to a more permissive MIT license, is the idea that people seem to not want to simply give code away. ...
11
votes
1answer
178 views

How can I fix a question in order to make it adhere to Code Review guidelines?

This was triggered by the handling of the following questions: Simulation of interacting particles Simulating a system of moving points The first one had broken code and thus got put on hold, and ...
2
votes
1answer
38 views

Shall we keep shelling out questions for [shell]?

We have a shell tag, but we also have more specific shell tags such as sh and bash. Many tags with shell also include these specific tags, so it almost looks redundant. I could see that there are ...
2
votes
1answer
57 views

How should I fix a problem in my code (which is not addressed in existing answers)?

Some time ago I posted a series of two questions: On Knuth's "Algorithm L" to generate permutations in lexicographic order Sequence-based enumeration of permutations in lexicographic ...
2
votes
0answers
27 views

Is proposing an alternative approach instead of code improvements a valid answer? [duplicate]

I remember seeing a question which caused me to ask myself: "Why even bother writing all that code if XYZ would reliably solve that problem in a few lines?" Would it be a relevant answer if I ...
125
votes
3answers
15k views

For an iterative review, is it okay to edit my own question to include revised code?

Is it okay to edit the question to include the improved code? I would like to do so for the following reasons: To share the improved code with others To show the answering persons that I take their ...
3
votes
0answers
30 views

How can I improve this question about asyncio?

I recently asked this question on Code Review which was ill-received and got 4 close votes for being off-topic. I believe the main problem to be that I used a dummy function for a third party API ...
16
votes
3answers
190 views

Asking about code in a pull request to my code base

I want to do something that is a little unusual, but not obviously off-topic. As a result, I thought I'd post here first. I got a pull request into a code base I (professionally) maintain. I'd like ...
3
votes
2answers
77 views

Flag declined after edit has been made

Short introduction: I wanted to flag this question but was alerted that I have 1 declined flag, and should flag with more care. After reviewing what flag was declined, I noticed the similarities. ...
11
votes
2answers
173 views

.net to the core

An entity-framework-core tag was recently created. Tag asp.net-core was created some 8 months ago. I can see a pattern here: do we really want a -core version of every single .net-related technology ...
-3
votes
1answer
49 views

“Count maximum number of thieves that can be caught” question should be reopened

The following question was closed as off-topic: https://codereview.stackexchange.com/questions/176469/count-maximum-number-of-thieves-that-can-be-caught The code seems complete to me and the ...
6
votes
0answers
264 views

Can I legally post my solution to a company's coding test?

I had to do a coding test as part of the interview process for a job. The company didn't give me any feedback, though, and just told me they wouldn't be proceeding with my application. Can I legally ...
1
vote
0answers
47 views

How do I get people to “review my review”? [duplicate]

I wrote a review yesterday for somebody's code. However, since it is out of my specific area of expertise, I would like someone else to give it the once-over, just to make sure I haven't misdirected ...
-3
votes
1answer
52 views

Why is my post still on hold after several edits?

Following the procedure states here, I'm creating this post to bring to your attention to my post that is still on hold since two days without any further information despite my several edit. Div ...
12
votes
2answers
249 views

I think my code might have a bug, but I am not sure if it actually does, is it broken code?

I have some C++ code that I am executing from C# dotnet core 2. In my C++, I am using a third party library. My code builds and runs, but after being executed a few million times (2.5 mil last time) I ...
0
votes
0answers
36 views

Can I ask a Code Review question about a Linux kernel patch made by someone else? [duplicate]

I've been following another developer who fixed a bug in the Linux kernel. The developer has posted a patch series hoping it would get reviewed/merged, but he got no response so far. The patches have ...
36
votes
4answers
2k views

CODE REVIEW 2017 Challenge

I want to introduce the Community Oriented Development Extravaganza, Requiring Extreme Vigor Inciting Extraordinary Winners (or CODE REVIEW) 2017 Challenge. Traditionally our Community Challenges are ...
2
votes
1answer
47 views

Links in snippets

I have a post on a multi-search-bar that just recently got marked as on-hold for broken code. I looked through it and it's considered broken code because I can't link to websites. I have two ...
2
votes
2answers
85 views

Is the quality of my posts declining?

Recently (around three months, but especially last month) I noticed that my vote/post ratio was gradually going down. Could you please give feedback, on order of decreasing importance, on those things:...
15
votes
2answers
503 views

Why are alternative solutions not welcome?

I skipped reviewing this answer because I am not sure what to do with it after I read the comment posted below it: Welcome to Code Review! You have presented an alternative solution, but haven't ...
21
votes
6answers
417 views

Is there a limit to the number of answers a user can post to one single question?

Example situation1 We have a user that finds a question and posts an answer for each and every change they would make - commonly being a single low-hanging fruit point, but not limited to it. It ...
9
votes
1answer
60 views

Should we forever deconstruct [data-structures]?

This tag was recreated today and was probably also recreated some time ago since its burnination as part of our massive tag purging. We already have separate tags for the most common data structures, ...
8
votes
1answer
195 views

Peer review a code review?

I recently made a for me, somewhat extensive code review and going through all the details I am unsure if I didn't lose myself a bit to much in reviewing. Can we ask in someway to peer review a code ...
8
votes
1answer
128 views

What other “shortcuts” but [Answer] does Code Review support?

In this comment OP wanted to share some SQL and one of the tables was called [Answer] but it was turned into a link to the How to Answer page. I tried it myself and ...
9
votes
1answer
63 views

beautiful-soup vs beautifulsoup

For some reason, CR has a tag for the BeautifulSoup library named as beautiful-soup, with a hyphen even though there is no ...
0
votes
1answer
41 views

Clarify edit review screen

The pending edit screen is very confusing to me as someone who has never seen it before: It says I have 0 edits rejected. The rejection notice on the second line uses "this" vaguely. This question? ...