Stack Exchange Network

Stack Exchange network consists of 174 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

20
votes
3answers
158 views

What criteria do you use to upvote a question?

This site is very unique in that 2 people can't come and say I had the same problem, since all questions have working code. Having said that, I see a lot of answerers not upvoting the questions they ...
24
votes
0answers
101 views

Code Review questions must contain code

As requested by Kaz and approved by the voters here on meta, questions asked on Code Review that do not contain code are now blocked. I've configured this initially as a three-line minimum (or three ...
2
votes
1answer
67 views

The problem with insufficient context

The new (well, not that new now) Insufficient Context close reason has a problem. People see the name and think it is about the text surrounding the code. The text context for the code. But the ...
181
votes
1answer
8k views

A guide to Code Review for Stack Overflow users

You're on Stack Overflow and you've found a question that seems to be about improving code. You are trying to be helpful, and you put a comment in the question: You should try asking on CodeReview....
4
votes
1answer
82 views

What is immoral about reviewing someone else's code? [duplicate]

The Help Center says: For licensing, moral, and procedural reasons, we cannot review code written by other programmers. Can somebody explain what is immoral about reviewing someone else's code? ...
9
votes
0answers
85 views

What's the [api] tag for?

The taginfo for api describes what an Application Programming Interface is, but doesn't give any guidance as to what kind of question it applies to. Given that the majority of code here is at ...
6
votes
1answer
73 views

Acceptability of questions about checking for race conditions

Is it acceptable for users to post questions in this community and have their code evaluated by others to check for race conditions? Or do these types of questions fall under the banner of 'broken ...
10
votes
1answer
183 views

Does Stack Overflow count as a third party site?

I had a question that was placed on hold with a link to this: Can I put my code on a third party site and link to the site in my question? The code I asked for review of was on Stack Overflow, and ...
7
votes
2answers
151 views

How do we handle stated restrictions around coding challenge sites' legalese?

I see things like the following on a certain coding challenge site: Copyright 2009–2018 by Codility Limited. All Rights Reserved. Unauthorized copying, publication or disclosure prohibited. I ...
4
votes
2answers
223 views

Is “How does this algorithm work?” a good question here?

If I have a question about the algorithm that I can't understand the logic behind, how and where should I ask the question?
51
votes
5answers
3k views

Checklist for how to write a good Code Review question

Many questions of new users lack some parts or common style of the site. There already are some meta questions that aggregate tips on this issue but letting new users walk through all of them is ...
46
votes
5answers
670 views

Code Review is getting boring

Boring I find that Code Review is getting pretty boring and unprofessional. The reason why I think this way is that many good questions about real-world problems don't get very much attention. ...
-1
votes
0answers
18 views

Generalised examples, library related questions, error prone solutions in question of improvement [duplicate]

I am unsure whenever this is the right platform for problems with real code, where it's very unpractical to include the whole context and it's major points can be very easy generalised. For example ...
38
votes
17answers
4k views

Frequently Posted Comments

On Code Review we often encounter questions with the same kind of problem over and over again. Some of us are using the auto comments script which allows you to maintain a list of comments to post. ...
-1
votes
2answers
132 views

Accepting without upvoting

What could be the reason for accepting an answer but not upvoting it? Situations: Accepting own answer - ok, no upvote on self-answers OP not having 15 reputation cannot upvote. I think that OP shold ...
10
votes
4answers
79 views

“What's beta” in Help Center: Do we still need it?

I was looking through the help center recently, and noticed the What's beta? page. Is it even necessary anymore? I understand that we have not completely graduated yet, but we are not in beta any more....
4
votes
1answer
193 views

Announcement: New chat room CRCQR

As some of the regulars at the SE Code Review site already noticed we have a new chat room to request and discuss question closures: SE Code Review Close Questions room I've setup that room due to ...
6
votes
3answers
191 views

Why do some users have HTTP response codes in their display names?

I know I could ask this in the 2nd monitor but figure this might be better here for posterity... and this site is for questions... I noticed a while back that there are a couple users who have HTTP ...
7
votes
1answer
149 views

Does [ascii-art] mean only ASCII?

I'm looking at the ascii-art excerpt, which says: ASCII Art is a graphic design technique that uses 93 of the 128 printable ACSII characters to create images. Whilst this is almost true (it uses ...
1
vote
2answers
219 views

To serve, what is it to ask for review?

Food for thought. There are times when questions come along which demonstrate a student's query, and with that comes the student's ill fated attempt to pose an "on topic" question without much ...
2
votes
0answers
21 views

Can I ask about my CloudFormation infrastructure template?

I have a template for some infrastructure using AWS CloudFormation that I'd like reviewed. However, I'm not sure if it's on-topic here; it's YAML that's describing infrastructure, not a program per se....
2
votes
2answers
92 views

I broke your code, therefore your code doesn't work: NAA discussion

Let's say the OP had code like this (imagine there's actual code here, I'm just making a generalized example for meta): ...
12
votes
2answers
307 views

My code is too long. How do I trim it down when code posted here is expected to function?

The code I would like to have reviewed, found here, is more than 30,000 characters long. I don't feel like that in and of itself makes it off topic, but removing code from it so that it can be posted ...
2
votes
1answer
357 views

How many lines of code are too much? [duplicate]

I've built an ASP.Net component, for example, which consists of a base class with 670 lines of code, a sub class with 180 lines, plus some code to illustrate it's usage. I think this is a perfect ...
21
votes
2answers
202 views

Can we enhance the favicon on a dark background?

In Chrome on Max osx, at least, the favicon in the tab title kind of disappears when having a dark main background on the window. Can this be enhanced somehow? The image shows top part of window with ...
6
votes
4answers
488 views

Code Review's updated site theme is now live for everyone

Update - the theme and layout is now live for everyone. Thanks for your feedback in this process. If there's additional feedback, please feel free to add to the answers below. As part of ...
1
vote
1answer
43 views

Post was put on hold stating that code is not working

I have a question about my Code Review Stack Exchange post: Filling-values-for-dictionary-of-dictionaries Post was put on hold stating that code is not working but it's working and I had posted the ...
28
votes
5answers
5k views

My question was closed as being off-topic. What are my options?

I can understand that sometimes questions are closed as being too opinionated, too broad, or unclear, but my question was closed as being off-topic. I have read the On-Topic Help Center page for Code ...
78
votes
34answers
7k views

What's a Zombie? And what are the many other memes of Code Review?

What is a Zombie? Why are Code Reviewers so violent and talking about killing Zombies all the time? And what ammo are they talking about? What is a TS? What does RSA mean? And what other Code Review-...
7
votes
2answers
146 views

Are practical user-created languages suitable for a tag creation?

I recently created a language, and was wondering (As many others may be) if a user is allowed to create a tag for their language and post a few example questions. The following things should be ...
1
vote
1answer
51 views

Why is my SPOJ question receiving downvotes?

SPOJ- CPP: Gap in output What is the purpose of so many downvotes? And what does it mean that the code should be "embedded directly"?
10
votes
2answers
177 views

Removing a question I don't like anymore

I recently posted a question which I think is decent enough, but I have since decided that the code in question is flawed/ has some issues. It is not that the code is buggy or incorrect which would be ...
5
votes
1answer
172 views

Posting code that violates Google's TOS

For a quick project, I thought it would be cool to make a crawler that goes over Google results, finding and recording sites that are scraping and impersonating Stack Exchange sites. The problem is, ...
2
votes
1answer
81 views

Wouldn't it be better to edit this question instead of closing it?

This question: Frequency Queries hackerrank … got closed for this reason: Code not implemented or not working as intended … … as the author wrote: However, on hackerrank it says the wrong ...
-2
votes
1answer
46 views

JavaScript concepts applying to JSX posts

Many posts are tagged with jsx as well as javascript and sometimes ecmascript-6, but then those latter tags are often removed by others. While I understand that jsx is not syntactically valid ...
34
votes
1answer
1k views

Welcome to The 2nd Monitor!

So, you have found your way to the Code Review main chat room, The 2nd Monitor, perhaps for one of these reasons: You were invited or "pinged" by a site moderator or other user to discuss a post on ...
6
votes
2answers
145 views

Need clarification on my close reason interpretation for a specific close reason

The question Does this method guarantee that cells in a CSV will be correctly partitioned? is a duplicate of this one (10k+ and mods only) which asks whether a singular function properly 'escapes' ...
3
votes
2answers
91 views

How to prevent people from answering off-topic questions?

Assume a person is asking about their broken code and someone suffering from FGITW-syndrome immediately answers it. Then maybe the answer and/or even the question gets upvoted. This completely ...
3
votes
2answers
63 views

Why is my second “Form maximum date/time from some digits” question being down voted?

My question here is getting down votes: Code Vita 7: Form the maximum possible date time in the MM/DD HH:MM format using any eight of twelve given single digits which is a follow up to my previous ...
-5
votes
1answer
66 views

Please reopen “Trick circumvents [position: sticky] restriction to parent”?

Trick circumvents [position: sticky] restriction to parent My question was put on hold. Please vote to reopen it!
5
votes
2answers
130 views

How much context is the required minimum?

This question got sparked by a recent discussion in the 2nd Monitor about this question: Golang Map-Reduce Master - Channels. The problem is: How much context is needed to actually review the code in ...
10
votes
1answer
97 views

If porting code, should I also post the original?

Is it on-topic (or acceptable practice) here to post code written in one language, and ported code in another for review ? I am learning scala and in doing so I am translating some code I wrote (in C++...
7
votes
2answers
93 views

How should question bodies be organized?

The format that I know for question bodies is: Intro, often explaining where the problem originated. A problem statement explaining what the code is supposed to do. Perhaps a little more ...
4
votes
1answer
88 views

Closure of finding the longest word in a string

Recently we got the question Finding the longest word in a String. (10k required) This question looked like it was off-topic, because of the following results: ...
12
votes
6answers
123 views

Performance checking tools

Performance checkers: What tools are available for attaining the metrics necessary to perform a performance review? Bench-marking is often not easily done by hand after all. This is a follow-up to ...
31
votes
2answers
237 views

Do people read other reviews for learning?

I was looking for posts about self-answering my own code review question, and I saw this post: Why should I be able to answer my own question in the question's editor on Code Review? 3 days ago I ...
3
votes
1answer
148 views

Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)

I am new to this specific Q&A site and I got my rep off of association bonuses, and I wanted to ask how to fix my code to work for another version of python. I noticed the text "Post code that is ...
12
votes
3answers
177 views

Why should I be able to answer my own question in the question's editor on Code Review?

I don't get why I am allowed to post an answer to my question in the question's editor: I know from Stack Overflow that this feature exists on Stack Exchange websites. It seems relevant for Stack ...
16
votes
2answers
150 views

Should I leave in documentation in code for review?

I'm surprised I can't find this as a question already, so I'm taking a shot and posting... I document my code. I don't not document my code before considering myself done for the day. Most of the ...
10
votes
2answers
185 views

Is it allowed to edit code if there is no answer?

If I have kept working on the code, and there are no answers (say one week after the original post), am I allowed to edit the code to reflect the changes I have made to it? I believe this question is ...