Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

34
votes
11answers
894 views

Best of Code Review 2015

As 2015 comes to an end, let's kick off Best of Code Review 2015! All Code Review users will be invited to nominate (link to) the best questions and answers from this year, and showcase them as ...
26
votes
6answers
820 views

How should we revise the standard off-topic reasons, if we can have up to five?

Note: For chat-like discussions of this subject, let's use this Discuss Close Reasons chat room Code Review currently has three standard off-topic reasons: Questions containing broken code or asking ...
26
votes
9answers
661 views

Let's Make Community Ads!

Last I heard, Community Ads were something graduated sites could do... but recently I stumbled upon this meta-PCG post, so here's a shamelessly stolen meta-post :) It's simple: you make an ad, and ...
22
votes
3answers
275 views

Should one person have multiple answers?

This question came up in regards to my comment on this post. If somebody has two different approaches for reviewing a piece of code, should they combine them into one answer, or have separate answers?...
18
votes
1answer
350 views

Checklist or general directions on how to write a good CR-ish answer

This question is intended to be the counterpart of Checklist for how to write a good Code Review question. Getting started with Code Review: New users often seem to have problems to understand, what ...
25
votes
5answers
313 views

Do one-liners and other narrowed-down code qualify for a code review?

Every once in a blue moon, a question gets posted (often as a new user's first post) where the OP is asking a quite specific question about very minimalistic code, for example: ...
12
votes
3answers
475 views

Does my code example need to be compilable/runnable?

I'm thinking of posting a question here, but am unsure how I should do so. The question is about comparing the performance of a piece of pure Python code vs a hybrid Python/C++ piece of code, glued ...
10
votes
5answers
1k views

Weekend Challenge #3

One single proposal per answer, most upvoted as of 2013-12-14 (12:00AM UTC) becomes our next challenge! The winning entry shall be marked as the accepted answer. index | previous challenge | next ...
7
votes
2answers
573 views

Weekend Challenge #5

One single proposal per answer, most upvoted as of 2013-12-28 (12:00AM UTC) becomes our next challenge! The winning entry shall be marked as the accepted answer. This one is a little special. Let's ...
6
votes
4answers
397 views

Weekend Challenge #4

One single proposal per answer, most upvoted as of 2013-12-21 (12:00AM UTC) becomes our next challenge! The winning entry shall be marked as the accepted answer. index | previous challenge | next ...
23
votes
3answers
914 views

April 2015 Community Challenge

Last time we created and reviewed Simon Says games, and that was a lot of fun. So, what should we do this time? Feel free to resubmit non-winning ideas from previous rounds, although new ideas are ...
16
votes
1answer
293 views

How long can code be?

First of all before, I hate the typical "codez plz" homework question. I hope this has nothing to do with that, but it is actually a class assignment. I won't post my code until it is completely ...
16
votes
3answers
190 views

Can we review spreadsheet formulas?

So, this question has been bothering me for a long time now. It is asking for a review of one line of "code" which is really a spreadsheet formula. Actually, it's not even asking for a review in my ...
11
votes
1answer
358 views

Is pseudo-code alright when asking about performance?

The FAQ states: Is it actual code from a project rather then pseudo-code or example code? But oftentimes pseudo-code is a lot more straight forward and easy to evaluate. It also applies to a ...
27
votes
26answers
2k views

Tools for format and error checking in your programming language

Lints and Hints: What tools are available for checking and correcting the conventions, style and common errors in my language (lint tools), and are there tools that can automatically fix them (hint ...
68
votes
12answers
814 views

New design & branding for Code Review

My name is Paweł, I’m a product designer at Stack Exchange. As all of you know, you’ve already undergone the first phase of graduation. I’m pleased to announce that we’re just about ready for you to ...
65
votes
9answers
583 views

Should line numbers for code snippets be added?

I recall seeing a request for this in meta SO in the pass, but for various reasons that escape me at the moment, there were no plans to do that. Should this be reconsidered for code review considering ...
60
votes
17answers
2k views

What would you say is the biggest problem Code Review is facing as a site as of June 2015?

Hopefully, by raising concerns, we may generate some ideas for improving the site!
43
votes
0answers
801 views

Call of Duty II - We're still on a mission

Briefing. November 16, 2013. In response to a not-so-shiny Stack Exchange Community Managers' review of our favorite Stack Exchange site and seeing that about 10% of the site's content consisted of ...
42
votes
4answers
940 views

Code Review Graduation

I am pleased to announce that effective from September 22, Code Review has graduated! It has taken a bit of time for this announcement to filter through the red tape, so, today was the day we found ...
21
votes
3answers
4k views

Weekend-Challenge Reboot

In December 2013 we held a bunch of weekly weekend-challenge events, which was fun, and generated posts that made it to the site's newsletter, week after week. One may want to tweak this query so as ...
40
votes
5answers
698 views

2014: What a ride!

Here we are, with another year [almost] behind us. 2014 has been very, very special on Code Review, and that has been completely because of you. 2014 was ...glittering. We've put Code Review on the ...
24
votes
11answers
1k views

Community Promotion Ads - 2016 [duplicate]

It's 2016 now, and we've made some changes to the sidebar size. As such, we can now restart the Community Promotion Ads for 2016! Keep in mind, we have updated some of the guidelines compared to ...
22
votes
13answers
430 views

Code Review Blog - Phase 3 - Recruit contributors

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
21
votes
5answers
949 views

Is [lolcode] reviewable?

Down with FizzBuzz created a lolcode tag. Some (cough) brainfuck (cough) are even further down the esoteric alley. Given our current site rules, I'd tend to agree. I don't think allowing lolcode ...
29
votes
6answers
637 views

What are the advantages of graduation?

I've seen a lot of activity about graduation recently. What are the (possible) benefits (and disadvantages) of a graduated site?
15
votes
2answers
603 views

“Time Limit Exceeded” and programming challenges

Lately I've seen many questions pertaining to Project Euler and similar that have problems with time limit exceeded. And this prompted the question, are these questions on topic? I mean, the code, ...
12
votes
4answers
2k views

What exactly does it mean for code to be “Working Code”?

Why is it that Code Review's definition of "working code" is so misaligned with so many people's expectations? @rolfl Well, we've had a lot of discussion about broken code on meta, but we don't seem ...
9
votes
2answers
150 views

“unclear what you're asking” vs “Lacks concrete context”

Aren't these two close reasons too similar? Since the Lacks concrete context exists I cannot remember using the unclear what you're asking anymore. unclear what you're asking Please clarify your ...
40
votes
6answers
2k views

April 2017 Community Challenge

It's that time of year again! I want to get a head-start on the 2017 community challenge, we have a lot of new faces over the winter and it would be great to get everyone participating again! For ...
14
votes
1answer
231 views

How should one deal with code asking “Is this correct?” when it is in fact correct?

I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Code Review is about. However, when the code is ...
12
votes
5answers
212 views

Questions about interfaces, protocols, and APIs

Are questions about interfaces/protocols and APIs on-topic for Code Review? And when I say "protocol", I mean this in the Objective-C/Swift (and potentially other languages) version of the word, ...
10
votes
3answers
229 views

Are database design reviews in scope?

See this question: Can you peer review my database design for a school system?
20
votes
9answers
895 views

May 2015 Community Challenge

Last month's community-challenge spawned a lot of Calculators. April is history and the success of last month definitely asks for a new challenge. What should we do this time? Feel free to resubmit ...
15
votes
2answers
221 views

Are we allowed to ask questions about just regular expressions?

Are we allowed to ask questions just about regular expressions?
15
votes
5answers
219 views

Game tag - When to create own tag for games?

I have just created the minesweeper tag and the rock-paper-scissors tag. The reasoning for this was: Rock Paper Scissors (Lizard Spock) is popular enough to deserve its own tag. (37 questions seem ...
10
votes
3answers
275 views

Should we sign up for Winter Bash 2013?

Is Winter Bash happening in Code Review? Many beta sites are going to participate in Winter Bash (AV.SE and Movies.SE site's moderators are receiving email from Stack Exchange). Have any of CR's ...
10
votes
4answers
264 views

Down Voting Discussion

I am going to link Vote Early, Vote Often because this question/discussion has a lot to do with the whole voting scenario. The question: do you think we have a problem with people not down voting for ...
8
votes
2answers
117 views

Revising list of closure reasons

Following up on a past discussions, I'd like to tweak our list of off-topic close reasons. We may have up to three canned reasons. Currently, they are: Questions asking for code to be written ...
7
votes
7answers
280 views

“Code not yet written” clarification: Are unimplemented interfaces on- or off-topic?

I would like to know what exactly it means. The reason for asking is my question which was recently put on hold: https://codereview.stackexchange.com/questions/60108/async-task-queue-design Can ...
7
votes
2answers
227 views

Is it okay to edit part(s) of code not yet reviewed?

In this question of mine, the one answerer so far has only reviewed a part of my code. However, I've made changes on other parts of my code, but I don't want to somehow invalidate that answer. Would ...
2
votes
3answers
195 views

Preventing the ability to re-open off-topic questions by explaining how it's broken in an answer

Earlier this year I posted an answer to a question, saying that it's broken in a way that OP don't think, explaining it a bit, and then wrote a comment saying it's off-topic, and voted to close. ...
16
votes
2answers
256 views

Stop mentioning major concerns in title

On the Ask a Question page, users are currently faced with this: state the purpose of your code, and mention any major concerns. I have recently started commenting on many questions with this ...
15
votes
3answers
247 views

Edit dispute - Indentation on questions

This suggested edit was rejected. As it should be - rolfl here has the correct reason: Whitespace "fixes" should be part of an answer, not an edit. Please do not fix code problems in the question. ...
15
votes
2answers
339 views

Review for large chunks of code

I am migrating from small pieces of code to larger applications. All my code is public on github or simillar. As I am in the middle of this transition, I am not very intrested in reviewing chunks of ...
13
votes
2answers
139 views

Rewording close reason “Explanation of code”

Inspired by this question: Custom Close Reason Post-Mortem. Can we alter Questions must involve real code that you own or maintain. Questions seeking an explanation of someone else's code are off-...
12
votes
2answers
196 views

Should we do away with “someone else's code” wording?

This has recently been brought up that we should improve this off-topic/close reason. While we can agree that this VTC reason is less than ideal (perhaps too broad, should be two separate reasons) ...
10
votes
1answer
183 views

Code Review Blog - Phase 4 - Plan a Schedule

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
7
votes
2answers
177 views

Answering your own review

As a piece of code is subjected to peer review, the author should also be looking at ways to improve his code. Sometimes a problem pointed out by others will direct his attention to another issue in ...
6
votes
2answers
919 views

(pascal) vs (free-pascal) vs (delphi) vs (delphi-xe) vs (object-pascal)

Recently, the free-pascal tag was created by me. Due to fragmentation issues (see the discussion), i.e., there is 1 question under this tag and at least 2 more that explicitly states the Free Pascal ...