Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
16
votes
4answers
765 views

August 2015 Community Challenge

The top-voted answer is Racetrack: "In the game of Racetrack, cars race around a track bounded by two concentric closed loops drawn on a square grid. Implement a program that plays this game." It's ...
16
votes
4answers
202 views

Self-accepting own answer when competing answers exist

It came up in chat that one particular user seemed to be in the habit of: Posting a good question; Receiving good answers; Posting his/her refactored code as community answer, after adapting some ...
15
votes
3answers
180 views

Are code snippets with known memory leaks broken?

As part of our check-list for questions on CodeReview, we require that code is working to the best of the askers knowledge. Does code with a known memory leak qualify is broken per this rule? On the ...
15
votes
1answer
115 views

action = ([ternary-operator] == bad_tag ? “burninate” : “keep”)

Currently, there's 17 tagged questions for this tag, either being superfluous (use every tag I can) kinda questions, or very complex ternaries replaced a potentially large ...
15
votes
2answers
154 views

How to share an API Key to potential reviewers?

I'm cooking up a question where I use a GET method to download a CSV file and do some stuff with it (no spoilers for now). The GET method requires an API key. I do not want to embed it in the ...
13
votes
2answers
136 views

Suggested edit attempts to format code

This suggested edit attempts to format the code in the question. Since this meta post states that it would be better to leave formatting advice as part of answer, I am inclined to reject this ...
13
votes
4answers
608 views

Project Euler Solutions

I was thinking that some of my python solutions to project Euler problems might be good candidates for code review - pretty short little programs that I've tried to write well, but would love to get ...
12
votes
1answer
215 views

Should we just put an end to [optimization]?

This is probably one of CR's oldest tags, next to refactoring and best-practice, both of which have already been removed. I recall similar discussion mentioning that specific optimization tags would ...
12
votes
2answers
219 views

Possible Solution for Zombies (unanswered questions)

Would it be possible for Code Review to award bounties on good questions that have remained unanswered for more than 6 months? When I was working through zombies I found a few questions I couldn't ...
11
votes
8answers
309 views

Best of Code Review 2014 - Exterminator category

Please post your nominations for the Best of Code Review 2014 - Exterminator category. Answer that points out the most interesting obscure bug in the original code. In your nomination post, please ...
11
votes
2answers
127 views

Does getting OutOfMemoryError really mean broken code?

This concerns this currently deleted question.(*) My opinion is that a program getting out of memory after 3 hours is basically working. It may not be good enough for what's required, but it's exactly ...
11
votes
3answers
448 views

Asking questions - including full code

In my first CR question, I was looking for feedback about my implementation of a graph data structure and an algorithm for depth first traversal, as I am studying these at the moment. Although I ...
11
votes
2answers
201 views

Time limit exceeded and performance: what's the difference?

We currently have two tags that have quite a large amount of overlap in their definitions: performance Performance is a subset of Optimization: performance is the goal when you want the execution ...
10
votes
5answers
166 views

Should we merge multiple answers from the same person? [duplicate]

Today, I ran across this question which had already been answered by Malachi 3 times before I looked at it. I decided that since he answered in multiple answers, I might as well do the same thing. I ...
10
votes
5answers
206 views

Are vectorization requests on-topic?

Currently, there are 62 questions tagged vectorization, nearly all of which say "The performance sucks; how can I vectorize this code?". Recently, How to efficiently apply correction to a time series ...
9
votes
3answers
150 views

Does the plain-English part of a question even matter?

Does the plain-English part of a question even matter? I'm not recommending that the plain-English part doesn't help make questions better, but given the approach we've taken towards answers on ...
8
votes
1answer
108 views

Tagging categories - Which are most useful?

TL;DR: I have categorized ~140 tags. I believe some categories should be used more and some categories should be used less. Goal is to make it possible to use tags to find related questions, as well ...
8
votes
3answers
201 views

Should be focus on solving OPs problem or more general analysis

I couldn't come up with a better title so bear with me. Preface (please read): The private beta is slowly coming to an end so i'd like to have discuss a little about that topic since onces public ...
6
votes
3answers
118 views

Can we suggest a review of a reviewer, or an evaluation of a person using the review queue heavily?

On this review, the user selected No Action Needed... @rolfl edited this question after the review was done so evidently, action was needed. Here you can see the amount of times this user has used ...
6
votes
5answers
506 views

What's the best way to change how my code looks?

A long time ago the question avoiding Python multiline string indentation was asked. The question was well received with a score of 66 and 16 favourites. It was even answered by one of our previous ...
5
votes
1answer
126 views

Migrating to Software Engineering

Looking at migrated questions shows how a "migrate to Software Engineering" closing reason is sorely missing. The problem is that many askers see the the "Review" part of the site, but not the "Code", ...
4
votes
2answers
106 views

General guidelines for language references

This question is a follow-up to Create a reference for newbie common mistakes. I'm trying to understand/outline how these language references should look like. What do you think should be put in ...
57
votes
3answers
867 views

Congratulations! Code Review is undergoing design-independent graduation!

It's a big day. You've been cleared for graduation by the Stack Exchange Community Team! Code Review has already met our threshold for graduation-worthy sites, and today joins in the new design-...
20
votes
3answers
176 views

A code review without the code

Recently, I wrote a review that discussed certain points in the OP's code, but did not contain any code in the review itself. Are answers like these discouraged?
18
votes
4answers
224 views

Making a tag for a Code Review community project

Last year, two community projects were born. One of them has been, according to some Github statistics, one of them is a lot more active than the other. Perhaps most importantly, the Rubberduck ...
17
votes
2answers
346 views

Code Review Blog - Post One Contest

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
16
votes
2answers
148 views

How broken does code have to be to for a question to be closed?

I recently voted to close this question: The longest subsequence with specified difference between min and max Originally I thought the code was really bad because the OP claimed a linear solution, ...
15
votes
2answers
142 views

How should the [beginner] tag be used?

This could be due to my blanket novice status, but I find myself using this tag quite regularly; practically associating it with use of the site itself. The beginner tag description specifies its ...
15
votes
3answers
253 views

What to do if the asker's code contains bugs?

Based on this question: WPF Calculator Code The question's code... works, according to the author. However, I quickly spotted multiple bugs. I know that Code Review is not there for fixing bugs. A ...
15
votes
1answer
162 views

Can I ask for review for something specific without posting too much context?

I'm working on an Angular2 application and I think one very small, specific function (list filtering) needs improvement and I would welcome reviews. Essentially I iterate more times than I think is ...
15
votes
1answer
113 views

What makes a question too broad for code review?

I was pondering the close reason today and I can't think of an instance where a question that is on-topic for Code Review is too broad. When is a question too broad? How could a too-broad question be ...
14
votes
3answers
282 views

Tackling overwhelmingly long questions

I'm wondering how some users handle huge amounts of code. There's a vba question out there right now that I would really like to review. However, as stated in the question - it's 1400 lines. I know ...
14
votes
1answer
87 views

Do we want site-specific editing guidance?

With our newly reached "graduated" (I really shouldn't put that in quotes) status, I expect a significant influx of new users, be it through migration or otherwise being drawn in by the thrill of a ...
14
votes
5answers
277 views

Community Promotion Ads - 2017 [duplicate]

It is a bit late into this new year, being that we're already in the second month, but we are now cycling the Community Promotion Ads for 2017! What are Community Promotion Ads? Community Promotion ...
14
votes
2answers
223 views

Are Scratch questions okay on Code Review?

I want to post a scratch project on codereview for people to give feedback at, but im worried that it would get downvoted and flagged for being off topic. So are scratch projects allowed? And if not, ...
14
votes
2answers
140 views

Self-answering questions without other answers

I posted a question, and after it had been up a couple hours, I realized how some of the code could be improved, so I posted an answer myself. After I did so, though, I wasn't sure if I had done the ...
13
votes
3answers
258 views

Can you have an answer without any code in the question?

I was doing some reviewing earlier when I came across this question, which in my view doesn't have sufficient code to constitute a reviewable question. It essentially consists of a data structure <...
13
votes
2answers
321 views

My code is too long. How do I trim it down when code posted here is expected to function?

The code I would like to have reviewed, found here, is more than 30,000 characters long. I don't feel like that in and of itself makes it off topic, but removing code from it so that it can be posted ...
12
votes
1answer
158 views

Do we need “acronym tags” ([dry], [solid], etc.)?

We have various "acronym tags" related to software principles: dry solid srp The problem is, they can still be used as meta tags, especially dry, for reducing code repetition. However, they're not ...
12
votes
1answer
117 views

“Obsolete” comment flags

I've recently started using the "Obsolete" comment flag for comments that add no value to a post, but that are intended at notifying a user of something - like a "Thank you!" comment, for example. My ...
12
votes
2answers
249 views

I think my code might have a bug, but I am not sure if it actually does, is it broken code?

I have some C++ code that I am executing from C# dotnet core 2. In my C++, I am using a third party library. My code builds and runs, but after being executed a few million times (2.5 mil last time) I ...
12
votes
2answers
358 views

Pascal / Delphi / Pascal Script tags

I have a concern about the tags delphi, pascal-script, pascal that I'm not sure how it can be solved properly. A short summary about the different things: Pascal is the original language, created in ...
12
votes
3answers
168 views

Is it time to start broadening the definition of duplicates?

sql-injection is commonly a concern in PHP, and it is a common request to ask when presenting code for a Code Review here. There are only so many ways you can propose a question that relates to SQL ...
11
votes
2answers
206 views

Lisp-like DSL code review

I am the main designer and implementor of GCC MELT, a Lisp-like domain specific language -which I call MELT- to customize the GCC compiler, implemented by a bootstrapped meta-plugin for GCC. GCC and ...
11
votes
2answers
140 views

Navigating between question-answers parts

Is there any limit to the number of follow up questions one can ask for a certain problem? In a scenario where a user posts questions according to guidelines, then assuming this goes on for about 20 ...
10
votes
2answers
213 views

What is “best to the author's knowledge”?

The question has been put on hold with the reason code not implemented or not working as intended. It is a curious case: in fact, the code is implemented, and does work as intended. The OP just didn'...
10
votes
2answers
56 views

Dispose of [idisposable]?

There are 3 questions tagged idisposable, one closed as off-topic, the other two featuring an IDisposable implementation. I don't think we need a tag for any ...
10
votes
2answers
133 views

Should we retain unanswered questions from deleted users?

Background We've had a user who asked many questions, mainly follow-up questions, some of which lacked sufficient detail and a review request. Due to some issues stemming from issues of the user and ...
10
votes
1answer
134 views

Questions that ask for you to e-mail them to get the code

What is the appropriate way to handle a question that doesn't post the code to review, but posts an e-mail address that you can I assume e-mail and get the code? A (now-deleted) example is: ...
10
votes
3answers
332 views

Are reviews of code in Stack Overflow answers in scope?

Say you spent some time on a code answer to a SO question (example). Is it OK to forward the same code to Code Review or should any comments be left to happen in SO? If it's OK to ask for a review, ...