Stack Exchange Network

Stack Exchange network consists of 175 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

11
votes
2answers
121 views

Does getting OutOfMemoryError really mean broken code?

This concerns this currently deleted question.(*) My opinion is that a program getting out of memory after 3 hours is basically working. It may not be good enough for what's required, but it's exactly ...
10
votes
5answers
165 views

Should we merge multiple answers from the same person? [duplicate]

Today, I ran across this question which had already been answered by Malachi 3 times before I looked at it. I decided that since he answered in multiple answers, I might as well do the same thing. I ...
9
votes
3answers
150 views

Does the plain-English part of a question even matter?

Does the plain-English part of a question even matter? I'm not recommending that the plain-English part doesn't help make questions better, but given the approach we've taken towards answers on ...
8
votes
3answers
200 views

Should be focus on solving OPs problem or more general analysis

I couldn't come up with a better title so bear with me. Preface (please read): The private beta is slowly coming to an end so i'd like to have discuss a little about that topic since onces public ...
8
votes
1answer
106 views

Tagging categories - Which are most useful?

TL;DR: I have categorized ~140 tags. I believe some categories should be used more and some categories should be used less. Goal is to make it possible to use tags to find related questions, as well ...
6
votes
3answers
118 views

Can we suggest a review of a reviewer, or an evaluation of a person using the review queue heavily?

On this review, the user selected No Action Needed... @rolfl edited this question after the review was done so evidently, action was needed. Here you can see the amount of times this user has used ...
6
votes
5answers
500 views

What's the best way to change how my code looks?

A long time ago the question avoiding Python multiline string indentation was asked. The question was well received with a score of 66 and 16 favourites. It was even answered by one of our previous ...
5
votes
1answer
123 views

Migrating to Software Engineering

Looking at migrated questions shows how a "migrate to Software Engineering" closing reason is sorely missing. The problem is that many askers see the the "Review" part of the site, but not the "Code", ...
4
votes
2answers
106 views

General guidelines for language references

This question is a follow-up to Create a reference for newbie common mistakes. I'm trying to understand/outline how these language references should look like. What do you think should be put in ...
57
votes
3answers
867 views

Congratulations! Code Review is undergoing design-independent graduation!

It's a big day. You've been cleared for graduation by the Stack Exchange Community Team! Code Review has already met our threshold for graduation-worthy sites, and today joins in the new design-...
20
votes
3answers
176 views

A code review without the code

Recently, I wrote a review that discussed certain points in the OP's code, but did not contain any code in the review itself. Are answers like these discouraged?
18
votes
4answers
224 views

Making a tag for a Code Review community project

Last year, two community projects were born. One of them has been, according to some Github statistics, one of them is a lot more active than the other. Perhaps most importantly, the Rubberduck ...
18
votes
3answers
251 views

Reviews of code not stored here

This question is inspired by a question I just saw: Review website done after one week of learning HTML and CSS How do we want to handle these issues? We wanted to avoid pastebins since having the ...
17
votes
2answers
345 views

Code Review Blog - Post One Contest

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
16
votes
2answers
148 views

How broken does code have to be to for a question to be closed?

I recently voted to close this question: The longest subsequence with specified difference between min and max Originally I thought the code was really bad because the OP claimed a linear solution, ...
16
votes
3answers
283 views

Is our “broken” wording broken?

"Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. After the question has been edited to contain working code, we ...
15
votes
1answer
113 views

What makes a question too broad for code review?

I was pondering the close reason today and I can't think of an instance where a question that is on-topic for Code Review is too broad. When is a question too broad? How could a too-broad question be ...
15
votes
3answers
247 views

What to do if the asker's code contains bugs?

Based on this question: WPF Calculator Code The question's code... works, according to the author. However, I quickly spotted multiple bugs. I know that Code Review is not there for fixing bugs. A ...
15
votes
2answers
140 views

How should the [beginner] tag be used?

This could be due to my blanket novice status, but I find myself using this tag quite regularly; practically associating it with use of the site itself. The beginner tag description specifies its ...
14
votes
2answers
222 views

Are Scratch questions okay on Code Review?

I want to post a scratch project on codereview for people to give feedback at, but im worried that it would get downvoted and flagged for being off topic. So are scratch projects allowed? And if not, ...
14
votes
2answers
140 views

Self-answering questions without other answers

I posted a question, and after it had been up a couple hours, I realized how some of the code could be improved, so I posted an answer myself. After I did so, though, I wasn't sure if I had done the ...
14
votes
3answers
280 views

Tackling overwhelmingly long questions

I'm wondering how some users handle huge amounts of code. There's a vba question out there right now that I would really like to review. However, as stated in the question - it's 1400 lines. I know ...
14
votes
5answers
277 views

Community Promotion Ads - 2017 [duplicate]

It is a bit late into this new year, being that we're already in the second month, but we are now cycling the Community Promotion Ads for 2017! What are Community Promotion Ads? Community Promotion ...
14
votes
4answers
222 views

Tags for [optimization], [performance], [speed]

There is currently a suggestion to make performance a synonym for optimization. I don't think that's right, for two reasons: You can optimize code for several criteria, such as maximum execution ...
14
votes
1answer
86 views

Do we want site-specific editing guidance?

With our newly reached "graduated" (I really shouldn't put that in quotes) status, I expect a significant influx of new users, be it through migration or otherwise being drawn in by the thrill of a ...
13
votes
3answers
256 views

Can you have an answer without any code in the question?

I was doing some reviewing earlier when I came across this question, which in my view doesn't have sufficient code to constitute a reviewable question. It essentially consists of a data structure <...
13
votes
2answers
319 views

My code is too long. How do I trim it down when code posted here is expected to function?

The code I would like to have reviewed, found here, is more than 30,000 characters long. I don't feel like that in and of itself makes it off topic, but removing code from it so that it can be posted ...
12
votes
1answer
156 views

Do we need “acronym tags” ([dry], [solid], etc.)?

We have various "acronym tags" related to software principles: dry solid srp The problem is, they can still be used as meta tags, especially dry, for reducing code repetition. However, they're not ...
12
votes
2answers
216 views

Should answers to clearly off-topic questions be encouraged or discouraged?

This question is clearly off-topic on Code Review. However, it did receive an answer which essentially points out the problem and makes some suggestions. The problem this potentially causes is that it ...
12
votes
3answers
167 views

Is it time to start broadening the definition of duplicates?

sql-injection is commonly a concern in PHP, and it is a common request to ask when presenting code for a Code Review here. There are only so many ways you can propose a question that relates to SQL ...
12
votes
2answers
249 views

I think my code might have a bug, but I am not sure if it actually does, is it broken code?

I have some C++ code that I am executing from C# dotnet core 2. In my C++, I am using a third party library. My code builds and runs, but after being executed a few million times (2.5 mil last time) I ...
12
votes
2answers
353 views

Pascal / Delphi / Pascal Script tags

I have a concern about the tags delphi, pascal-script, pascal that I'm not sure how it can be solved properly. A short summary about the different things: Pascal is the original language, created in ...
12
votes
4answers
147 views

Can working code be: off-topic -> not-working?

This question here: Shortest possible way of printing a specific board Summary: The code requirement is to print out a grid of text. The code does in fact print the grid The way it does that, is ...
11
votes
2answers
138 views

Navigating between question-answers parts

Is there any limit to the number of follow up questions one can ask for a certain problem? In a scenario where a user posts questions according to guidelines, then assuming this goes on for about 20 ...
11
votes
2answers
206 views

Lisp-like DSL code review

I am the main designer and implementor of GCC MELT, a Lisp-like domain specific language -which I call MELT- to customize the GCC compiler, implemented by a bootstrapped meta-plugin for GCC. GCC and ...
10
votes
2answers
56 views

Dispose of [idisposable]?

There are 3 questions tagged idisposable, one closed as off-topic, the other two featuring an IDisposable implementation. I don't think we need a tag for any ...
10
votes
3answers
332 views

Are reviews of code in Stack Overflow answers in scope?

Say you spent some time on a code answer to a SO question (example). Is it OK to forward the same code to Code Review or should any comments be left to happen in SO? If it's OK to ask for a review, ...
10
votes
1answer
161 views

Does the question “Testing current, new or friends firms as max output and least effort” lack code to be reviewable?

I came across "Testing current, new or friends firms as max output and least effort" the other day, and have been thinking it's off-topic. There is too little information to do more than a 'lint ...
10
votes
3answers
108 views

Can I ask the same question with a different language?

I am wondering if it would be bad to ask for the same code review, just under a different language. For example: Hypothetically I post a question asking for a code review of my Ruby "Hello World" ...
10
votes
3answers
207 views

Are “What does this code do?” questions on-topic here?

Example (now deleted): https://stackoverflow.com/questions/4917334/what-does-the-below-codes-do
10
votes
4answers
153 views

Should we burn [Google]?

Recently some others and I began to clean up google a bit. This started with retagging a number of question with google-apps-script. Then we hit a wall. All of the questions that should have been ...
10
votes
1answer
89 views

Non-OP edits to change the original question to make it on-topic

I feel that this topic is ambiguous at the current time, and I would like some clarification. When I see a question that is obviously, or at least appears to be off-topic based on how it is worded, my ...
9
votes
2answers
98 views

Do we need a [payment-system] tag?

We currently have 26 credit card questions questions and 47 payment questions. I'm not sure how much overlap there is between the two. At least some of the credit card questions could be tagged with ...
9
votes
1answer
221 views

Are UML diagram reviews on-topic for CodeReview?

I would like to post a UML diagram for review on StackExchange. The response to the question I asked on Meta Stack Overflow seems to point to CodeReview being the place to ask, but the answer was ...
8
votes
2answers
53 views

Do we need this [crud]?

crud seems like a meta tag to me. Can we burn it? From its cruddy wiki entry: The four basic operations for a data management system: Create, Read, Update, Delete It is used on just 14 questions ...
8
votes
1answer
195 views

Peer review a code review?

I recently made a for me, somewhat extensive code review and going through all the details I am unsure if I didn't lose myself a bit to much in reviewing. Can we ask in someway to peer review a code ...
8
votes
1answer
92 views

What are the Stack Exchange limits on chatbots?

For weekend-challenge #4, I posted a suggestion about creating an IRC bot, and suggesting that some people could deviate from this and create an automated bot to respond to certain messages in the ...
8
votes
2answers
136 views

Having an entire project reviewed

I have a small project I'm working on in an area I'm not comfortable with (web development). I would like someone to review my code. I can try to split it up, but I would prefer if someone looked at ...
7
votes
1answer
182 views

Practical Best Practice Questions

There are a number of questions of similar type that get asked here: How many conditions in an "if clause" is acceptable? https://codereview.stackexchange.com/questions/5804/using-catching-...
7
votes
1answer
193 views

Can I correct an error in my own code?

In creating a MVCE for my code review (I cannot directly post my code for issues of legality, not to mention there's cruft in there that isn't necessary) I left an important part of the performance ...