Stack Exchange Network

Stack Exchange network consists of 174 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

2
votes
5answers
85 views

Inline review format

What are your thoughts on writing reviews fully as inline code? We all take time out of our day to do these reviews but writing good reviews takes time, looking at the posted code, switching editors, ...
5
votes
1answer
190 views

Why does the Community bot have 5 reputation?

The community bot has 5 reputation: why is this? Also, its Main User has 1 reputation, and only the Meta user has 5 reputation, which doesn't usually happen; even with people. Is this a bug?
10
votes
3answers
233 views

Request to re-open “Find out relation between Devices…” question

I had sought out review for a question about some some proprietary code that I am working on. The code in question retrieves information from a list of one-to-many mappings and seeks to build a ...
19
votes
6answers
1k views

Community Promotion Ads - 2018

It's almost February in 2018, which isn't supposed to be the proper time to cycle these, but for this year it'll be once again, so we'll be refreshing the Community Promotion Ads for this year now! ...
1
vote
1answer
101 views

Is the “I downvoted because…” site something that is useful here?

When we have a bad question, pasting one of the appropriate questions from this site may help, specifically this in a comment.
14
votes
1answer
184 views

Incorrect suggested edit review - how to educate users?

The scenario: An asker posts a question. A low rep user notices some improvements to the questions code, and edits them into the question. The edit gets accepted in the review queues. Another user ...
1
vote
2answers
46 views

Why don't we have a close reason like “off-topic because of asking to find a 3rd party resource” like SO has? Or at least a “Blatantly off-topic”?

I recently came over this question I am trying to implement duplicate file finder in visual C++. I followed this link Successful implementation of Duplicate Files Finder in C++ But it don't ...
9
votes
4answers
140 views

Is a BNF grammar for a language acceptable for review as concrete code?

Syntax for a simple scripting language is a question asking for a review of a grammar of a C-like language. The grammar specification isn't an input for any specific parser generator tool: I wrote ...
2
votes
3answers
130 views

Is it OK to ask the same question using a different account?

Is it OK for a user to post a question, receive an answer and then repost the question using a different account? This question was asked yesterday by user 158322. This question with a similar title ...
6
votes
1answer
113 views

Major edits made to my question about using a string or array to index object in JavaScript

I have a question about my post: Dynamic way to use string/array as index of object in javascript I see that my first attempt at this question was outside the scope of what I should ask at Code ...
1
vote
1answer
29 views

Completed class definition put on hold as broken code or code not yet written

I asked a question yesterday here. It has been put on hold for the following reason: "Questions containing broken code or asking for advice about code not yet written are off-topic, as the code ...
16
votes
5answers
208 views

Are questions with undiscovered bugs allowed?

Re: Connect 4 in C++ Situation: The OP, a beginner posted code with several bugs in it. They said they thought the code worked okay, because they hadn't discovered the bugs during their testing, ...
20
votes
4answers
474 views

How should we revisit our standard close reasons?

We have some history, shown below, with our close reasons, there are some problems we have with them. And there has been a consensus to rework them for a while now. The latest I heard about this was ...
3
votes
1answer
183 views

What is the reason for the downvotes on my answer to “Country Guessing Game”?

I feel like I have a scenario like this, but recently I gave an answer which received a down-vote, as did one other answer to the same question, and then mine got a second down-vote, yet there were no ...
17
votes
1answer
174 views

Is it appropriate to record the review process and upload it to YouTube?

The video is of-course supplement to an answer. The link will be in the comments. The actual answer will be written during the video itself. Motivations There is a user named sehe on SO, who ...
3
votes
2answers
167 views

Should the phrase “passing a parameter” be corrected from posts?

This is a question about nomenclature, which I hope is on-topic here on meta. I believe it is: since my last question it became clear to me that answerers here are, above all, educators ("we're ...
8
votes
2answers
208 views

Help a new user avoid being off-topic

I am new to Code Review (but not new to Stack Exchange in general). I'm puzzled by the reasoning for putting this question on hold and would like some advice on how to be on-topic in this and future ...
31
votes
6answers
390 views

On the huge amount of work needed for a CR answer

I'm a regular at Stack Overflow, and I just recently discovered Code Review, where I answered some questions with the d3.js tag. We all know that CR is quite different from SO: by its very nature, ...
17
votes
1answer
294 views

Is this question popularity normal?

I was on Code Review, asking a question for the first time. I thought my question was good, but it never crossed my mind that it would become popular enough to make it to the hot list. It did, and I ...
2
votes
2answers
94 views

Should complexity formatted as code be updated to use MathJax?

I saw a post that mentions algorithmic complexity and formats such complexity values using inline code spans (e.g. O(n)). Should that post be updated to use MathJax ...
0
votes
2answers
50 views

Code typed in from a non-text source or converted from another language and isn't working - is this in the scope here?

I recently typed in code from a scan in a PDF is pseudocode or in another language to make a JavaScript version. The code was implementing things of a mathematical nature beyond my math abilities ...
4
votes
1answer
120 views

Could I have made my question “fast responsive navigation in CSS & jQuery” more attractive/better?

I would carefully like to ask, what (if at all) I could have done to make my question "fast responsive navigation in CSS & jQuery" more attractive and/or interesting for the community? Or is CSS ...
-1
votes
2answers
75 views

Why was “Check if a variable is one of a set of valid strings” put on hold?

They said: Questions must involve real code that you own or maintain. Pseudocode, hypothetical code, or stub code should be replaced by a concrete implementation. Questions seeking an explanation ...
18
votes
5answers
414 views

Code Review Community on GitHub: where is it going?

Almost four years ago, Code Review community went to GitHub. In these past four years, what have we accomplished with this GitHub community? There are five repositories in the community, four if you ...
20
votes
1answer
166 views

Should I include my testing code?

I recently posted a large chunk of code. It feels like a tall order to code review. I've written a bunch of tests to test my code. Would those tests be useful to the reviewer? I'm not looking for ...
8
votes
2answers
179 views

How should we handle answers on non-code questions?

Recently I've come across a question that didn't contain any code. The questioner instead asked for code, as some new users do. So far same business as usual, but a user went ahead and posted a ...
13
votes
1answer
145 views

How long should we wait before asking for an iterative review?

In my search for the gory details of the Dos and Don'ts of iterative reviews, I saw that we should always ask another question with our follow-up. However, I haven't found anything about how long we ...
-4
votes
3answers
130 views

What about questions which demands expert opinion and design feedback

This has been an issue here since a long time and I see a lot of people just to get brownie points jump in and copy paste the answers which can be as generic as possible for example: Use linter Bad ...
9
votes
1answer
149 views

Multiple similar questions from the same user

After answering this question, I noticed the user posted the same question 3 times in a row today. Now I kinda wish I didn't answer at all, because it feels like cheating to me. You have the issue of ...
2
votes
1answer
54 views

How should I fix a problem in my code (which is not addressed in existing answers)?

Some time ago I posted a series of two questions: On Knuth's "Algorithm L" to generate permutations in lexicographic order Sequence-based enumeration of permutations in lexicographic ...
2
votes
0answers
26 views

Is proposing an alternative approach instead of code improvements a valid answer? [duplicate]

I remember seeing a question which caused me to ask myself: "Why even bother writing all that code if XYZ would reliably solve that problem in a few lines?" Would it be a relevant answer if I ...
2
votes
1answer
38 views

Shall we keep shelling out questions for [shell]?

We have a shell tag, but we also have more specific shell tags such as sh and bash. Many tags with shell also include these specific tags, so it almost looks redundant. I could see that there are ...
11
votes
1answer
177 views

How can I fix a question in order to make it adhere to Code Review guidelines?

This was triggered by the handling of the following questions: Simulation of interacting particles Simulating a system of moving points The first one had broken code and thus got put on hold, and ...
3
votes
0answers
30 views

How can I improve this question about asyncio?

I recently asked this question on Code Review which was ill-received and got 4 close votes for being off-topic. I believe the main problem to be that I used a dummy function for a third party API ...
3
votes
2answers
73 views

Flag declined after edit has been made

Short introduction: I wanted to flag this question but was alerted that I have 1 declined flag, and should flag with more care. After reviewing what flag was declined, I noticed the similarities. ...
11
votes
1answer
170 views

What's your angle on desynonymizing [Angular] and [Angular.js]?

As we should know from ""Angular" (Angular is not Angular.js)", Angular is not AngularJS - Angular is Angular2+. Wikipedia also says they're different things: Angular - "Angular (commonly referred ...
11
votes
2answers
172 views

.net to the core

An entity-framework-core tag was recently created. Tag asp.net-core was created some 8 months ago. I can see a pattern here: do we really want a -core version of every single .net-related technology ...
-3
votes
1answer
47 views

“Count maximum number of thieves that can be caught” question should be reopened

The following question was closed as off-topic: https://codereview.stackexchange.com/questions/176469/count-maximum-number-of-thieves-that-can-be-caught The code seems complete to me and the ...
16
votes
3answers
186 views

Asking about code in a pull request to my code base

I want to do something that is a little unusual, but not obviously off-topic. As a result, I thought I'd post here first. I got a pull request into a code base I (professionally) maintain. I'd like ...
1
vote
0answers
47 views

How do I get people to “review my review”? [duplicate]

I wrote a review yesterday for somebody's code. However, since it is out of my specific area of expertise, I would like someone else to give it the once-over, just to make sure I haven't misdirected ...
6
votes
0answers
263 views

Can I legally post my solution to a company's coding test?

I had to do a coding test as part of the interview process for a job. The company didn't give me any feedback, though, and just told me they wouldn't be proceeding with my application. Can I legally ...
-3
votes
1answer
52 views

Why is my post still on hold after several edits?

Following the procedure states here, I'm creating this post to bring to your attention to my post that is still on hold since two days without any further information despite my several edit. Div ...
12
votes
2answers
245 views

I think my code might have a bug, but I am not sure if it actually does, is it broken code?

I have some C++ code that I am executing from C# dotnet core 2. In my C++, I am using a third party library. My code builds and runs, but after being executed a few million times (2.5 mil last time) I ...
0
votes
0answers
32 views

Can I ask a Code Review question about a Linux kernel patch made by someone else? [duplicate]

I've been following another developer who fixed a bug in the Linux kernel. The developer has posted a patch series hoping it would get reviewed/merged, but he got no response so far. The patches have ...
25
votes
1answer
2k views

CODE REVIEW 2017 Challenge: Entries

Update: no one entered on time, but as I've seen at least one question on main site meeting the requirements, I'll be extending the entry date to the end of this week (23:59:59 UTC+0000 on 8 December ...
2
votes
1answer
44 views

Links in snippets

I have a post on a multi-search-bar that just recently got marked as on-hold for broken code. I looked through it and it's considered broken code because I can't link to websites. I have two ...
21
votes
6answers
408 views

Is there a limit to the number of answers a user can post to one single question?

Example situation1 We have a user that finds a question and posts an answer for each and every change they would make - commonly being a single low-hanging fruit point, but not limited to it. It ...
9
votes
1answer
58 views

Should we forever deconstruct [data-structures]?

This tag was recreated today and was probably also recreated some time ago since its burnination as part of our massive tag purging. We already have separate tags for the most common data structures, ...
2
votes
2answers
84 views

Is the quality of my posts declining?

Recently (around three months, but especially last month) I noticed that my vote/post ratio was gradually going down. Could you please give feedback, on order of decreasing importance, on those things:...
8
votes
1answer
125 views

What other “shortcuts” but [Answer] does Code Review support?

In this comment OP wanted to share some SQL and one of the tables was called [Answer] but it was turned into a link to the How to Answer page. I tried it myself and ...