Stack Exchange Network

Stack Exchange network consists of 174 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

5
votes
3answers
101 views

Is it OK to put a lengthy comment on an answer in another answer?

I posted some code the other week, and got a very good answer. Some of the answer was totally new to me, some of it I found difficult at first sight. So, I went googling to try and understand. In ...
3
votes
0answers
41 views

Are questions without “?” valid in codereview? [duplicate]

I'm more active on superuser, but sometimes check vba questions also here. I've noticed that sometimes questions contains description of the code and the code itself, but no actual question is ...
14
votes
5answers
275 views

Community Promotion Ads - 2017 [duplicate]

It is a bit late into this new year, being that we're already in the second month, but we are now cycling the Community Promotion Ads for 2017! What are Community Promotion Ads? Community Promotion ...
7
votes
1answer
223 views

Why were two very similar questions posted by possibly the same user?

This morning I filtered for the Java tag and found the two questions in the picture below as the first result: Could these be bots? Maybe these are the same user, but why should one post the same ...
3
votes
2answers
94 views

Should this question be on hold because of non-real code?

This question had been put on hold with the reason: "Questions must involve real code that you own or maintain. Pseudocode, hypothetical code, or stub code should be replaced by a concrete ...
15
votes
2answers
612 views

Is it ok to conceal the origin of a programming challenge?

I'd appreciate some input on this question, where I have a disagreement with the poster. Background: Google has a semi-secret recruitment program for software developers known as the "Foobar ...
0
votes
1answer
99 views

Can I ask to check my code here? Or did I get this wrong?

If so, i will post some of my website mr2ndopinion.com. I'm looking for peer help to improve the experience of the site, i want it to be professional. Unlike my video's which are mostly made for ...
7
votes
1answer
90 views

Missing questions and answers in Best of Code Review 2016 query results

I noticed that some of my questions and answers from 2016 failed to appear in the query results for Best of Code Review 2016. For example, this query returned only one of my questions, while I asked ...
0
votes
0answers
45 views

Posting Malicious Code for Review [duplicate]

I recently redirected my studies to the field of security. For learning purposes, I took a virus that we wrote as part of an assignment last year and improved it so it actually does something instead ...
0
votes
2answers
28 views

Answer deleted/converted to comment- can't fathom why

This is on the Code Review site. Someone posted their code for building a SQL Connection String. My answer points them to the Microsoft class whose purpose is to do this exactly: Prompting user for ...
11
votes
2answers
411 views

Best of Code Review 2016 - Night and Day category

Please post your nominations for the Best of Code Review 2016 - Night and Day category. The most dramatic improvement (nominate both the question with the most hopeless code and the answer that ...
9
votes
1answer
275 views

Best of Code Review 2016 - Exterminator category

Please post your nominations for the Best of Code Review 2016 - Exterminator category. Answer that points out the most interesting obscure bug in the original code. In your nomination post, please ...
10
votes
4answers
379 views

Best of Code Review 2016 - Best Title category

Please post your nominations for the Best of Code Review 2016 - Best Title category. The question with the best title. In your nomination post, please make sure to include a link to the revision ...
8
votes
1answer
433 views

Best of Code Review 2016 - Diplomat category

Please post your nominations for the Best of Code Review 2016 - Diplomat category. Tough advice in an answer, delivered in the most tactful manner. In your nomination post, please make sure to ...
10
votes
5answers
411 views

Best of Code Review 2016 - Best Newcomer (question) category

Please post your nominations for the Best of Code Review 2016 - Best Newcomer (question) category. Best question by a user who had not posted a question before 2016. In your nomination post, ...
10
votes
6answers
464 views

Best of Code Review 2016 - Best Newcomer (answer) category

Please post your nominations for the Best of Code Review 2016 - Best Newcomer (answer) category. Best answer by a user who had not posted an answer before 2016. In your nomination post, please ...
44
votes
11answers
491 views

What is the motivation to spend time doing a code review?

I have only recently started browsing CR and have done 3 so far. I spent about 30 minutes on the first one, and 2 hours each on the others. Sadly, because I am reviewing Ruby code (not as popular as ...
1
vote
0answers
29 views

What to do if there's not much space for improvement on a question? [duplicate]

I've been coming over this question unordered_multimap approach to adjacency list and graph search which specifically asks about I'm looking for suggestions on how to improve the usage of modern ...
8
votes
1answer
119 views

I think I've answered a borderline off-topic question, is that answer still valid?

I've just written up an answer for this question Scattergories program After scanning through the code and writing up my points to improve, I noticed that OP asked how to make that working as ...
14
votes
2answers
163 views

Why was this question closed as off-topic after a bug was discovered by the answers?

TL;DR Please clarify: is a previously unknown bug a reason to close a question as off-topic? Yesterday I was interested to answer this question, where an already written answer pointed out the ...
37
votes
8answers
1k views

Best of Code Review 2016

As 2016 comes to an end, let's kick off Best of Code Review 2016! All Code Review users will be invited to nominate (link to) the best questions and answers from this year, and showcase them as ...
15
votes
1answer
154 views

If in doubt, post the question on Meta first?

Not for lack of trying, I get downvotes on some questions. And on those questions I nevertheless often get answers. So if I try to delete the question to approach it differently, I get the warning ...
27
votes
3answers
225 views

Is asking for a review of boiler plate for a minimal repro okay?

For asking and answering questions on Stack Overflow with certain frameworks and libraries I have boilerplate lying around for a minimal repro. I would be interested in getting feedback on my WCF ...
-5
votes
1answer
109 views

Asking a question to understand why code is broken gets closed

I am trying to understand the compiler's reasoning about a certain implementation involving a default method and an abstract one with this question. If you see the initial version, it explains that a ...
0
votes
0answers
53 views

Why was I told to include a programming language tag for an [nginx] question?

It already had the tag nginx which is the configuration language at hand. The person that answered the question did a fine job and obviously knew what the question was about. Unduplicating prox_pass ...
13
votes
3answers
252 views

Can you have an answer without any code in the question?

I was doing some reviewing earlier when I came across this question, which in my view doesn't have sufficient code to constitute a reviewable question. It essentially consists of a data structure <...
3
votes
0answers
179 views

Why the hate on this HTML/CSS question?

I am curious to hear the reasoning behind why Simple Business Card Website is still closed. It has a title describing what the code does It requests a code review It contains the code that needs to ...
11
votes
2answers
207 views

How should I post literate code?

Suppose I have a project that is written in a literate format (e.g., emacs org-mode), and I would like to have that code reviewed. What is the preferred way to post the code? Some options that come ...
4
votes
1answer
104 views

Are hard questions forbidden?

I asked this question and it was closed. Before I asked that question I asked on meta.stackexchange.com which community would be suitable to ask the question here. I don't understand what is unclear ...
3
votes
1answer
56 views

When is a question too broad?

I wish to bring this question before the Code Review site. In the past, we have had this question: What makes a question too broad for code review?, which asks how to use the "Too Broad" close vote ...
36
votes
3answers
479 views

Should we stay opted-in for Winter Bash 2016?

It's that time of year again! This year's event will run from December 19th to January 8th. More information on this and individual hat-earning progress will eventually be posted here. Once again, ...
6
votes
1answer
130 views

Ads on Code Review

Looks like Code Review was selected for enabling ads. Does anyone know when this goes live? Right now I run adblock, but I might as well turn it off when this comes.
9
votes
2answers
205 views

How should I improve my flags?

I came across a question that was using odd tabbing and I suspected it to be a copy and paste error. I commented on the post to ask if this were the case. This lead to roughly the following comments: ...
3
votes
1answer
48 views

Is it possible for me to get a review of my language? [duplicate]

I'm currently designing a stack-based language intended for scripting. I'm wondering if it's possible for me to have its syntax evaluated by this community, e.g., I'd describe the language and how it ...
9
votes
3answers
525 views

Downvotes on an answer which answers the question

I answered a question, followed the rules, then it gets downvoted and two other answers which are pretty much the same (you decide) don't. I feel the loss of the points. I think one of the downvoters ...
15
votes
2answers
369 views

How should we deal with askers fixing off-topic questions when an answer has been posted?

I done a quick search to see if this has been asked, but it didn't seem to be. The intent behind this question is from how this question was handled, but is not limited to it. The situation is an ...
10
votes
3answers
136 views

Should the “new questions” feed be made into a drop-down feed instead of one-boxing feed?

To quote @Vogel612 in chat today, with regards to CaptainObvious, the new questions feed in the main chat: so many bot posts... at this point I think we should consider turning CaptainObvious into ...
4
votes
2answers
77 views

Should we [join] this tag with the other burninated ones?

I've just again realized that we have a join tag, which corresponds to SQL. It doesn't appear that the questions have anything else in common, either. Do we still need it?
-6
votes
2answers
136 views

Can I submit invalid and funny code on Code Review?

I found some cool functions in some really old code that I have to maintain. I think it could be useful to review them. For fun, and to understand what they're supposed to do. Finding what it is ...
-9
votes
2answers
94 views

Change the licensing of code in Code Review contributions to GNU GPL

It seems that one of the community's main aversions to changing from the current CC license, to a more permissive MIT license, is the idea that people seem to not want to simply give code away. ...
10
votes
1answer
155 views

Should tag wikis contain frequently suggested style points?

Over in rust, there are a set of style points that come up in almost every review of substance. I've found myself becoming more and more terse when raising those issues, which is ultimately a ...
-5
votes
2answers
107 views

Change the licensing of code in Code Review contributions to MIT

One of several problems of having a creative commons (CC) license for code generated on Code Review, is that it is incompatible with major software licenses. Your project would have to either have to ...
7
votes
0answers
66 views

Tags “Types” and their Usage

This is a question spawned from @Mat's Mug's comment on a question I had about a tag removal. It seems that there is some consensus among the more senior users here about the way some tags should be ...
21
votes
1answer
267 views

Why are tags [functional-programming] and [haskell] mutually exclusive?

An edit was recently made on my question to remove the functional-programming tag. The edit comment was that [functional-programming] is redundant with Haskell I don't understand this, as I ...
1
vote
4answers
259 views

Is it really necessary to explain trivial answers? [closed]

OP: How do I rewrite x = a + 1 + b - 1? Me: x = a + b. Community: hey, you didn't explain how you did that! Take 5 ...
11
votes
1answer
118 views

Normalizing [data-structures]?

I feel that something should be done about data-structures. For instance, this question appears to include the tag just because it uses data structures. Also, we already have many specific tags for ...
4
votes
1answer
70 views

Feedback on closing 'Separation of concerns in graph theory project'

Separation of concerns in graph theory project This question is odd: It has tons of code removed, making it hard to review (it sure does not run) "I am having problems with separating the concerns" ...
8
votes
2answers
158 views

(Optionally) add Python sub tags to questions

The lack of version tags on some Python questions leads to reviewers having to 'pre-scan' the code to find out if it's Python2.7, Python3, both or neither. This seems strange as, I'd have thought that ...
19
votes
3answers
247 views

Can I have a question “series” for a major project?

I'm about to start my senior computer science project, which involves a web REST API (Rails or Node.js) as well as an Android app. I don't imagine that I'll have a ton of questions, but there could be ...
0
votes
0answers
21 views

Is it ok to post HTML code I made from free PSD templates I found on the internet? [duplicate]

I want to practice my HTML and I was thinking about coding some free templates I found on the internet. Can I post the template and the HTML I wrote so you can review it?