Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
0
votes
2answers
102 views

Readability oriented coding conventions

I think it would greatly help reviewers if we decide upon and adopt guidelines on readability oriented coding conventions. A few examples: Blocks One space between arguments, no new line braces <...
0
votes
2answers
35 views

Are mods allowed to answer non-meta questions?

This may seem like a very simple question with a very simple answer, but it’s been bugging me. Having looked through hundreds of answers on questions on the regular site, I only see answers from ...
0
votes
2answers
144 views

Accepting without upvoting

What could be the reason for accepting an answer but not upvoting it? Situations: Accepting own answer - ok, no upvote on self-answers OP not having 15 reputation cannot upvote. I think that OP shold ...
0
votes
1answer
70 views

Is it OK to ask how to revise a golfed function?

After reading through a few question on here I found out that asking questions about refining code golf code is not on topic. However in this case I'm not asking for the code to be golfed but re-...
0
votes
3answers
98 views

Reviewing Inexperience vs Reviewing Style

I just recently Posted a Review Question and got some fantastic feedback. Exactly the point of this site. Although IMO I processed 3 separate 'types' of review points. You Missed X, (In my case an ...
0
votes
1answer
47 views

Is this tag bad [form] for this site?

Quoting the Tag-Wiki: An HTML form is a section of a document containing normal content, markup, special elements called controls (checkboxes, radio buttons, menus, etc.), and labels on those ...
0
votes
1answer
52 views

Is it ok to post code that didn't work out as intended?

I recently tried to optimize some code by using parallel processing, putting two cores to work on the problem instead of one. For whatever reason, it didn't work. I don't know why, but I doubt much ...
0
votes
1answer
41 views

Clarify edit review screen

The pending edit screen is very confusing to me as someone who has never seen it before: It says I have 0 edits rejected. The rejection notice on the second line uses "this" vaguely. This question? ...
0
votes
1answer
39 views

Posting code with different licence [duplicate]

Can I post a question about some of my code that I want to have a different licence under? Say I want someone to review my code but have it posted so that a license covers it for not to be re-used or ...
0
votes
1answer
33 views

Are questions asking for opinion regarding all edge cases on topic?

I have been away from code review for some time and not sure on the scope agreed upon in the community. So is this question on topic or off topic? Basically the below is on topic or not? Will the ...
0
votes
2answers
52 views

Code typed in from a non-text source or converted from another language and isn't working - is this in the scope here?

I recently typed in code from a scan in a PDF is pseudocode or in another language to make a JavaScript version. The code was implementing things of a mathematical nature beyond my math abilities ...
0
votes
1answer
35 views

Would code review be a good place to ask for a review of a presentation?

I have a presentation on AMD and I need a few good reviews on it. Would this type of "review" be a good fit for the site?
0
votes
1answer
27 views

Synonym request for tag [animations], proposed synonym [easing]

Synonym Request I came across this question screen-transition-effect-like-in-final-fantasy-games where OP makes their custom easing function in order to smoothly transition a color over an image. I ...
0
votes
1answer
56 views

Why is my SPOJ question receiving downvotes?

SPOJ- CPP: Gap in output What is the purpose of so many downvotes? And what does it mean that the code should be "embedded directly"?
0
votes
1answer
99 views

Can I ask to check my code here? Or did I get this wrong?

If so, i will post some of my website mr2ndopinion.com. I'm looking for peer help to improve the experience of the site, i want it to be professional. Unlike my video's which are mostly made for ...
0
votes
1answer
29 views

Can questions request only specific kinds of review guidance? [duplicate]

In other words: if a CR question asks only for performance feedback, or only for OOP structure feedback, etc., is that valid? And would answers providing review feedback on other aspects of the code ...
0
votes
1answer
82 views

When to create a generator or return simply a list, closed for missing context

The other day we got the question: When to create a generator or return simply a list in Python? This question has a generic title, some code which contains enough code to be reviewed. And a couple ...
0
votes
1answer
57 views

Are implemented API reviews without code on-topic?

I've been reading through the various questions asking whether or not API reviews are on topic, but they've left me a bit confused. In particular "Are questions about public interface (API) on topic?"...
0
votes
1answer
77 views

The snippet to review is good, no better answer found

There was no better solution to my code snippet: Highlight input if empty. What should I do? I want to mark this entry as "done". But since there is no answer, I can't accept any.
0
votes
1answer
48 views

Post was put on hold stating that code is not working

I have a question about my Code Review Stack Exchange post: Filling-values-for-dictionary-of-dictionaries Post was put on hold stating that code is not working but it's working and I had posted the ...
0
votes
1answer
48 views

Edit a question to add comments to the code?

In this question, an edit to the code (by other than the asker) added this block of comments to the code: ...
0
votes
1answer
45 views

Sharing code over a lot of files [duplicate]

I'm working on a multithreaded server and have a few questions regarding it, especially the best way of going around decoupling the server module (that manages the connections) from the application ...
0
votes
3answers
249 views

Should [interview-questions] be burninated?

The tag interview-questions seems to be useless - should it be burninated?
0
votes
1answer
164 views

Could Code Review be used to create a community library?

Here is the elevator pitch: Using Code Review to assemble a collection of extension methods for .NET and extracting a library out of it. Originally I created a separate SE site proposal to achieve ...
0
votes
1answer
30 views

How can I ask for a review of the same item after making an update? [duplicate]

Suppose, I submit a code for review, and some reviewers suggest some corrections. Suppose I then want to update my code and show it to the same reviewers. How should I do it? Should I edit my ...
0
votes
0answers
44 views

Are Nix expressions without any logic on topic? [duplicate]

I've written a configuration.nix file for my systems, and it would be very useful to have it reviewed. Nix expressions are code, very similarly to Puppet or Chef, but are declarative, so I wonder if ...
0
votes
0answers
41 views

Merge example code, stub code and insufficient context reasoning into one?

When expanding the guide to wonderland, I'm trying to explain what example code, stub code and context are. When trying to explain why example code is off-topic all I can think of is something like: ...
0
votes
0answers
56 views

Is it possible to get a code review of scripts while obfuscating sensitive information? [duplicate]

Namely, I wrote a Python script to handle Cloudflare-based Dynamic DNS updates for a system, but I need to obfuscate my CloudFlare creds and some API keys, for fairly obvious reasons. Would there be ...
0
votes
0answers
37 views

Can I ask a Code Review question about a Linux kernel patch made by someone else? [duplicate]

I've been following another developer who fixed a bug in the Linux kernel. The developer has posted a patch series hoping it would get reviewed/merged, but he got no response so far. The patches have ...
0
votes
0answers
35 views

It it acceptable to ask questions that have arisen from another answer [duplicate]

It it acceptable to ask questions that have arisen from another answer, repeatedly. For example... I post working code and ask to have it reviewed. Someone answers with some suggestions. I re-write ...
0
votes
0answers
25 views

Ok to repost code after incorporating suggestions? [duplicate]

If I've had a piece of code reviewed here, what's the consensus about posting the update for another review? Also, assuming it's ok, should it be an edit to the existing question, or a new post? (...
0
votes
0answers
45 views

Posting Malicious Code for Review [duplicate]

I recently redirected my studies to the field of security. For learning purposes, I took a virus that we wrote as part of an assignment last year and improved it so it actually does something instead ...
0
votes
0answers
53 views

Why was I told to include a programming language tag for an [nginx] question?

It already had the tag nginx which is the configuration language at hand. The person that answered the question did a fine job and obviously knew what the question was about. Unduplicating prox_pass ...
0
votes
0answers
22 views

Is it ok to post HTML code I made from free PSD templates I found on the internet? [duplicate]

I want to practice my HTML and I was thinking about coding some free templates I found on the internet. Can I post the template and the HTML I wrote so you can review it?
0
votes
0answers
33 views

Is it ok to ask for code review of a git repository that I have developed? [duplicate]

I was wondering if it is ok to ask for code review of a git repository that I have developed? I have developed a library for circuit breaker pattern for async functions in C# and I wanted to submit ...
0
votes
0answers
58 views

Can I ask for a Review over a GitHub project - if I'm looking for review over the overall architecture? [duplicate]

Very Related Question : Can I put my code on a third party site and link to the site in my question? I plan on moving my project to GitHub, and I was wondering if I would be able to ask for a Code ...
-1
votes
3answers
111 views

Discouraging gigantic headers in answers?

-~- Your Yearly Airing Of The Grievances -~- A lot of answers follow the template of: Avoid X Description of why X is bad Do Y Description of why Y is good and better than what OP ...
-1
votes
4answers
269 views

Is it time for the [python] to become extinct?

Every time a post involves Python code, it has the Python tag AND the Python version tag that suits the version of Python that the post is using. I think that is a little repetitive, and we should ...
-1
votes
2answers
133 views

Should Code Review serve as a refactoring cookbook?

NB. It's not an argument against "keeping the original code intact". I understand the point, I agree with the benefits and I realize the issues that may arise should we digress. I'd like to hear the ...
-1
votes
2answers
119 views

Should minor broken code be reviewed?

Translating array pointer access from C++ to Delphi I agree that the question should not be deleted for minor problems like that (Should mostly working but a little bit broken code stay or be deleted?...
-1
votes
2answers
59 views

Code review of YouTube video

I have a YouTube playlist that I have created showing my iterative approach on a subject ("C# CUSTOM Script Language Creation"). I know that sites like this one have some limitations as to what is ...
-1
votes
1answer
47 views

Is ROBLOX Lua allowed on code review?

I've recently gotten more interest in roblox lua, and I was wondering if code review allows it. Here's an example piece of code I want to share, but I fear that it could be closed as off-topic. ...
-1
votes
2answers
330 views

HeadFirst - Design-Patterns: Porting from Java to C# and C++ for reviewing

I am learning design patterns once more. The book mentioned above offers the examples in java, and I read them, write them and follow the book, I really like their kind of writing. But I gave myself ...
-1
votes
2answers
86 views

Knowledge-based authentication using Domain-driven Design belongs to Software Engineering

I find the question Knowledge-based authentication using Domain-driven Design in C# should be moved to Software Engineering because the only code that OP has posted is clearly hypothetical, OP even ...
-1
votes
1answer
45 views

Can I ask here for a blog post about programming review?

Can I ask here for a blog post about programming review? (I'm totally new to Code Review)
-1
votes
2answers
37 views

Is it more proper to use gcc or g++ while compiling a question in the C Language tag?

I answer a question with a C language tag and got down-voted for using #define rather than const or static for defining constants. One of the constants is defined in terms of the other constants. When ...
-1
votes
2answers
78 views

Why was “Check if a variable is one of a set of valid strings” put on hold?

They said: Questions must involve real code that you own or maintain. Pseudocode, hypothetical code, or stub code should be replaced by a concrete implementation. Questions seeking an explanation ...
-2
votes
2answers
64 views

Questions should not be locked when off-topic comments are moved to chat for the first time

I my opinion, it's to early to lock a question when moving off-topic comments to the chat for the first time. It's understandable when it repeats two or three times... and it certainly did in the ...
-2
votes
2answers
55 views

Is it off-topic to ask for test cases (“use cases”)?

May I ask if you can come up with tests if I have functional code or do I have to develop good tests myself? I did develop a test that works but only with static libraries (which I might consider a ...
-2
votes
1answer
78 views

The case for [python-typing]

PEP 483 and PEP 484 finally introduced semantics for function annotations, and adds a new typing module to the standard library that provides important types, ...