Stack Exchange Network

Stack Exchange network consists of 175 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

25
votes
1answer
2k views

CODE REVIEW 2017 Challenge: Entries

Update: no one entered on time, but as I've seen at least one question on main site meeting the requirements, I'll be extending the entry date to the end of this week (23:59:59 UTC+0000 on 8 December ...
24
votes
11answers
1k views

Community Promotion Ads - 2016 [duplicate]

It's 2016 now, and we've made some changes to the sidebar size. As such, we can now restart the Community Promotion Ads for 2016! Keep in mind, we have updated some of the guidelines compared to ...
24
votes
4answers
573 views

Must the code be “clean”?

I have working code that I want reviewed, but it is not clean. It made the correct output but there are comments and bad names. Is it not ready for review, and must the code be clean to get reviewed ...
24
votes
4answers
708 views

Should pedantry be discouraged?

I'm taking about this answer which is essentially pedantry about two variable names, which seems to be meant as a funny remark. I mentioned (in the first comment) that such an answer contributes far ...
24
votes
6answers
382 views

Should we have a Code Review Blog?

Super User, Server Fault, Programmers, InfoSec, Apple, DBA, Science Fiction & Fantasy and a bunch more sites all have Community Blogs that are contributed to and maintained by community members. ...
24
votes
2answers
176 views

Can I use CR as an environment to foster an open source project?

Let's suppose that I have a personal project which I think might interest more people, and given my low position in the learning curve, want to make it open source. Besides posting pieces of code in ...
24
votes
4answers
461 views

Reviewing “design”

It has been said in various comments that on Code Review we review code and not design. I find this statement not very clear though. Obviously, if someone has an UML and not any written code, that's ...
24
votes
2answers
228 views

What is the best way to exchange a dialogue following a code review?

For most SE sites, a simple comment is sufficient to exchange a little additional dialogue about a solution. For code review though, it seems like one question can spawn a huge list of suggested ...
23
votes
8answers
361 views

2018 Moderator Election Q&A - Question Collection

So... there might be some kind of news stirring. Stuff and things and such. In light of these recent events, Code Review is scheduled for an election next week, March 26th. In connection with that, we ...
23
votes
6answers
2k views

Code Prettify - Choose your favorite or make your own!

We all like code, let's face it. And with Code Review's upcoming graduation "colors" I'm sure that many would like for the large amount of code that is posted daily in questions and answers to look ...
23
votes
6answers
231 views

If SO had a standard off-topic reason for code review requests, how should it be worded?

We have long been fighting a battle against Stack Overflow users who vote to close questions with custom reasons like I'm voting to close this question as off-topic because it belongs on Code ...
23
votes
3answers
914 views

April 2015 Community Challenge

Last time we created and reviewed Simon Says games, and that was a lot of fun. So, what should we do this time? Feel free to resubmit non-winning ideas from previous rounds, although new ideas are ...
23
votes
3answers
179 views

What criteria do you use to upvote a question?

This site is very unique in that 2 people can't come and say I had the same problem, since all questions have working code. Having said that, I see a lot of answerers not upvoting the questions they ...
23
votes
4answers
181 views

RoboSanta the pimp

Regular visitors of the 2nd monitor chat room may be familiar with @RoboSanta, a friendly bot, pimping posts that are hopefully upvote-worthy. Currently RoboSanta posts one Naruto answer per day (...
22
votes
13answers
430 views

Code Review Blog - Phase 3 - Recruit contributors

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
22
votes
8answers
591 views

How much idle chatter do we tolerate in The 2nd Monitor?

Related but not a duplicate: How far off-topic can we get in 'the 2nd monitor'? Today was a complicated day in the history of The 2nd Monitor. On one side there appears to be consensus something ...
22
votes
5answers
704 views

Should we do something about our meta tags?

We have a decent selection of language and technology tags, but we also have many meta tags, such as refactoring. A meta tag, at least on here, specifies the OP's request(s) in a review, and not much ...
22
votes
2answers
221 views

Is “You're doing it wrong” a review?

This question sparked a thought in me. To me, the author is not doing this for exercise (not tagged with reinventing-the-wheel and no mention of the sort) so I assume it is done for production. I ...
22
votes
4answers
841 views

September 2015 Community Challenge

It's time to choose a community-challenge for September 2015. Post your challenge as an answer to this question. Feel free to resubmit non-winning ideas from previous months. Vote for those answers ...
22
votes
3answers
275 views

Should one person have multiple answers?

This question came up in regards to my comment on this post. If somebody has two different approaches for reviewing a piece of code, should they combine them into one answer, or have separate answers?...
21
votes
9answers
254 views

Help spot deficiencies in our Help Center

Regular participants will be familiar with procedures and practices on Code Review. For example, we have rules against asking hypothetical questions appending to or modifying the question after ...
21
votes
6answers
421 views

Community Promotion Ads - 2015

Now that your community has entered into design independent graduation, I can co-opt this existing thread and turn it into an official Community Ads thread. Please note that there have been some ...
21
votes
6answers
204 views

Does Code Review systematically prefer the least important code, and what can we do about it?

There are already a large number of intrinsic hurdles before production code can get reviewed; it can be against company policy, paid developers are likely less open to criticisms and new coders are ...
21
votes
18answers
431 views

What should our elevator pitch be?

In one sentence, how will we describe Code Review to the world?
21
votes
5answers
2k views

September 2016 Community Challenge

We've just gotten the August 2016 Community Challenge going, so it's time to pick one for September. It's time to choose a community-challenge for September 2016. Post your challenge as an answer to ...
21
votes
5answers
1k views

Code-Challenge #2

(what's this all about?) Post-Mortem In February 2014, we rebooted weekend-challenge and created a code-challenge tag. Here are some stats (as of 2014-03-02): First entry was posted on 2014-02-02 (...
21
votes
5answers
160 views

Should we sign up for Winter Bash 2015?

Winter Bash 2015 is approaching! We signed up for it last year, and it was a really big hit. We all had a lot of fun earning and showing our hats to the rest of the world. Now after we have ...
21
votes
5answers
947 views

Is [lolcode] reviewable?

Down with FizzBuzz created a lolcode tag. Some (cough) brainfuck (cough) are even further down the esoteric alley. Given our current site rules, I'd tend to agree. I don't think allowing lolcode ...
21
votes
3answers
4k views

Weekend-Challenge Reboot

In December 2013 we held a bunch of weekly weekend-challenge events, which was fun, and generated posts that made it to the site's newsletter, week after week. One may want to tweak this query so as ...
21
votes
6answers
417 views

Is there a limit to the number of answers a user can post to one single question?

Example situation1 We have a user that finds a question and posts an answer for each and every change they would make - commonly being a single low-hanging fruit point, but not limited to it. It ...
21
votes
4answers
246 views

Justify your review!

The same problems come up over and over again in code reviews and it can get a bit tiresome wheeling out the same basic items of advice. If it were a code review at work, you'd be quite within your ...
21
votes
7answers
1k views

CR Weekend Challenge

Those of you that weren't following what's going on in the chat room might have been taken by surprise by a recent avalanche of Rock Paper Scissors Lizard Spock posts. This is how it started: OK, ...
21
votes
1answer
268 views

Why are tags [functional-programming] and [haskell] mutually exclusive?

An edit was recently made on my question to remove the functional-programming tag. The edit comment was that [functional-programming] is redundant with Haskell I don't understand this, as I ...
21
votes
1answer
208 views

Complete code rewrite

I came across this question today: Count the ways to partition an array into two equal sets This question can be interpreted in a way, that it asks for a complete rewrite of the code, and indeed ...
21
votes
1answer
429 views

The Guiding Principles of Code Review

What do you believe are the Guiding Principles of Code Review? What are the purpose and mission of the site? Recently (and not so recently) a lot of effort and hair-pulling has gone into discussing ...
21
votes
1answer
127 views

Crediting the Code Review site or linking from source code to a specific question or answer

If I submit code for review, and then improve that code based on the answers submitted, is there a preferred way of thanking the Code Review site and/or reviewer in the source code? I'm thinking ...
21
votes
2answers
204 views

Can we enhance the favicon on a dark background?

In Chrome on Max osx, at least, the favicon in the tab title kind of disappears when having a dark main background on the window. Can this be enhanced somehow? The image shows top part of window with ...
20
votes
9answers
893 views

May 2015 Community Challenge

Last month's community-challenge spawned a lot of Calculators. April is history and the success of last month definitely asks for a new challenge. What should we do this time? Feel free to resubmit ...
20
votes
11answers
580 views

2015 Moderator Election Q&A - Questionnaire

In connection with the moderator elections, we are holding a Q&A thread for the candidates. Questions collected from an earlier thread have been compiled into this one, which shall now serve as ...
20
votes
3answers
355 views

Is it okay to add someone else's linked code to the question?

Some questions link to the code they want reviewed, which is against site policy. Should one edit the code into the question in these cases? The problem I see is that all content on Stack Exchange ...
20
votes
7answers
464 views

Let's draft better Help Center pages!

To follow up on Help spot deficiencies in our Help Center, let's collaboratively draft better Help Center pages. For each Help Center page to be modified, post a Community Wiki "answer" containing ...
20
votes
3answers
176 views

A code review without the code

Recently, I wrote a review that discussed certain points in the OP's code, but did not contain any code in the review itself. Are answers like these discouraged?
20
votes
5answers
381 views

Is it too easy to post your code for review?

Our current situation: We are getting 34 questions per day We are getting more and more unanswered questions We are still on a mission I feel that we multiple times per day get questions that are a ...
20
votes
3answers
242 views

Found a serious bug in my question after posting it

What is the correct way to go after I found a bug in a question that I posted? Shall I delete the question, vote to close it or flag it as off-topic?
20
votes
1answer
167 views

Should I include my testing code?

I recently posted a large chunk of code. It feels like a tall order to code review. I've written a bunch of tests to test my code. Would those tests be useful to the reviewer? I'm not looking for ...
20
votes
2answers
199 views

Should code be forcibly translated into English?

In Sieve prime generator C++, a user translated some French strings into English, and the edit got approved. In toBase64 encoder, the author replaced Russian strings and comments with English in ...
20
votes
4answers
506 views

How should we revisit our standard close reasons?

We have some history, shown below, with our close reasons, there are some problems we have with them. And there has been a consensus to rework them for a while now. The latest I heard about this was ...
20
votes
2answers
270 views

How do we define duplicate questions?

This QA site doesn't quite take the form that others do. Here, we have fairly specific questions. But I already see two Project Euler #1 questions that are similar. Are these duplicates?
20
votes
1answer
298 views

How can I make my question get more attention?

I have written a question that hasn't gotten an answer in several days, and there's not much activity on my question (votes, views, comments). What can I do to draw more attention to my question?
20
votes
0answers
125 views

2018: a year in moderation

It's New Year's Day in Stack Exchange land... A distinguishing characteristic of these sites is how they are moderated: We designed the Stack Exchange network engine to be mostly self-regulating, ...