Stack Exchange Network

Stack Exchange network consists of 174 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

181
votes
1answer
8k views

A guide to Code Review for Stack Overflow users

You're on Stack Overflow and you've found a question that seems to be about improving code. You are trying to be helpful, and you put a comment in the question: You should try asking on CodeReview....
121
votes
3answers
14k views

For an iterative review, is it okay to edit my own question to include revised code?

Is it okay to edit the question to include the improved code? I would like to do so for the following reasons: To share the improved code with others To show the answering persons that I take their ...
103
votes
1answer
943 views

New Site Design!

As you can see the new design just went live. Congratulations! Thank you for your valuable design feedback. We have also themed the twitter account and newsletter template for this site, and ...
95
votes
10answers
3k views

Code Review SE is graduating!

Many of you have already seen announcements both on main and on meta announcing this site's graduation. At the request of a few of you who were skeptical (or perhaps merely in shocked disbelief), I'm ...
78
votes
34answers
7k views

What's a Zombie? And what are the many other memes of Code Review?

What is a Zombie? Why are Code Reviewers so violent and talking about killing Zombies all the time? And what ammo are they talking about? What is a TS? What does RSA mean? And what other Code Review-...
68
votes
12answers
801 views

New design & branding for Code Review

My name is Paweł, I’m a product designer at Stack Exchange. As all of you know, you’ve already undergone the first phase of graduation. I’m pleased to announce that we’re just about ready for you to ...
67
votes
4answers
6k views

How to get the best value out of Code Review - Asking Questions

I have a project I am working on, and I would like some, or all of it reviewed, how can I ask for this review on Code Review in a way that produces the best possible value? This is not about a ...
65
votes
9answers
574 views

Should line numbers for code snippets be added?

I recall seeing a request for this in meta SO in the pass, but for various reasons that escape me at the moment, there were no plans to do that. Should this be reconsidered for code review considering ...
65
votes
2answers
618 views

Graduation update: it's election season!

I'll start off by addressing the elephant in the room. It's been the better part of a year since the announcement that Code Review was graduating. In all those months, there haven't been any visible ...
60
votes
17answers
2k views

What would you say is the biggest problem Code Review is facing as a site as of June 2015?

Hopefully, by raising concerns, we may generate some ideas for improving the site!
57
votes
3answers
862 views

Congratulations! Code Review is undergoing design-independent graduation!

It's a big day. You've been cleared for graduation by the Stack Exchange Community Team! Code Review has already met our threshold for graduation-worthy sites, and today joins in the new design-...
51
votes
5answers
3k views

Checklist for how to write a good Code Review question

Many questions of new users lack some parts or common style of the site. There already are some meta questions that aggregate tips on this issue but letting new users walk through all of them is ...
51
votes
4answers
3k views

Call of Duty - We're on a mission

This is a direct reply to Grace Note's recent CR review, more precisely the following part: (emphasis mine) Unanswered Tying in to all of the above is one of the most pressing concerns about ...
51
votes
2answers
1k views

Code Review — Top User Swag!

If your name is on the first two pages of this page as of Site Graduation you'll be hearing from me soon... but that's good news! this time We want to send you a little care package, as a token of our ...
48
votes
3answers
409 views

Which answer to accept?

I can imagine this situation coming up frequently on this site. What should we do when there are multiple helpful valid answers? Accept the one we think is most helpful? Accept the one that was ...
47
votes
7answers
4k views

How is this site different from Stack Overflow? [duplicate]

I've decided to check this site out since it was tweeted by the great Jeff Atwood himself. The first question I saw was "Advice on making ruby code more ruby-like", which is the kind of question I see ...
47
votes
5answers
378 views

2015 Community Moderator Election Results

Code Review's first moderator election has come to a close, the votes have been tallied, and the 4 new moderators are: Please thank them for volunteering, and share your assistance and advice ...
47
votes
6answers
1k views

How is Code Review doing right now?

I’m Grace Note, a Community Manager at Stack Exchange. Normally for most sites we run a community site evaluation, as explained in this Meta Stack Overflow post under Public Beta sites. However, these ...
46
votes
5answers
670 views

Code Review is getting boring

Boring I find that Code Review is getting pretty boring and unprofessional. The reason why I think this way is that many good questions about real-world problems don't get very much attention. ...
45
votes
19answers
1k views

What should our logo and site design look like?

What should our logo and site design look like?
44
votes
11answers
491 views

What is the motivation to spend time doing a code review?

I have only recently started browsing CR and have done 3 so far. I spent about 30 minutes on the first one, and 2 hours each on the others. Sadly, because I am reviewing Ruby code (not as popular as ...
43
votes
12answers
752 views

What would Clippy say?

We have a question closure rate of ~30%. That's a significant burden on moderators and users who help triage the questions. While some questions can indeed be very difficult to triage, there are ...
43
votes
5answers
793 views

Should “your code seems fine” answers be acceptable?

I want to ask your opinion on how we should handle submitted question with code that is "fine". I assume that will be the case for very view of the submitted review requests since everyone likes and ...
43
votes
0answers
795 views

Call of Duty II - We're still on a mission

Briefing. November 16, 2013. In response to a not-so-shiny Stack Exchange Community Managers' review of our favorite Stack Exchange site and seeing that about 10% of the site's content consisted of ...
42
votes
4answers
927 views

Code Review Graduation

I am pleased to announce that effective from September 22, Code Review has graduated! It has taken a bit of time for this announcement to filter through the red tape, so, today was the day we found ...
42
votes
2answers
925 views

Once upon a time in Stackland

Uh question, why have you folks not graduated yet? - jul 13 at 21:18 by Undo It's been quite a while since the 100 days later update, which was posted around the 100th day after our last site review, ...
41
votes
9answers
512 views

Putting down my mug

I joined CR in May 2013, but only started living here in September of that year. I remember very well then, the site had been in beta for almost 1000 days, and I kept thinking that was a shame, CR was ...
40
votes
5answers
696 views

2014: What a ride!

Here we are, with another year [almost] behind us. 2014 has been very, very special on Code Review, and that has been completely because of you. 2014 was ...glittering. We've put Code Review on the ...
40
votes
6answers
2k views

April 2017 Community Challenge

It's that time of year again! I want to get a head-start on the 2017 community challenge, we have a lot of new faces over the winter and it would be great to get everyone participating again! For ...
40
votes
5answers
406 views

Nothing fishy going on here! Nope, not at all

Following Mat's resignation as moderator yesterday, I, too, have informed the Stack Exchange community that I am yielding my position as moderator. I know that it may be natural for many of you to ...
39
votes
2answers
1k views

Jack of All Trades, Master of None - Let's work together to offer ultimately better content, faster

Nhgrif pointed out a great idea: Teamwork "I think it's probably best if the question instead has several good answers that each address a specific topic. The result will be that no single ...
38
votes
17answers
4k views

Frequently Posted Comments

On Code Review we often encounter questions with the same kind of problem over and over again. Some of us are using the auto comments script which allows you to maintain a list of comments to post. ...
38
votes
2answers
1k views

Can I put my code on a third party site and link to the site in my question?

Is it OK if I write a question and include a link to GitHub/Pastebin/other similar site instead of putting the code here on Code Review?
38
votes
22answers
1k views

Tracking Graduation Progress

Moderator Note: This question has been identified a number of times as being a candidate for migration to Meta.SE - the main meta site. This question is really about tracking Code Review's ...
37
votes
8answers
1k views

Best of Code Review 2016

As 2016 comes to an end, let's kick off Best of Code Review 2016! All Code Review users will be invited to nominate (link to) the best questions and answers from this year, and showcase them as ...
37
votes
7answers
662 views

Would you like to test design-independent graduation?

It's been over a month since the last graduation update and your new mods are settled in. Time for more news! First, a quick recap. As many of you know, we on the SE team approved Code Review for ...
36
votes
16answers
809 views

Hi! What brings you here today?

On 2013-11-15, we were given a review about our beta progress. On 2014-04-10, we also got some feedback from Stack Exchange Community Managers @GraceNote and @Pops. One of the concerns that was ...
36
votes
8answers
1k views

Short answers and code-only answers

What should we do with: Short answers (for example, "I suggest you use [hyperlink to this standard API] instead.") Code-only answers (for example, an improved version of the code in the OP) Such ...
36
votes
3answers
363 views

Election epilogue: one slight moddification

It's been a while since your first election ended. Your new mods have had some time to settle in, think about how they work together, and figure out the overall state of the Code Review stack. After ...
36
votes
3answers
479 views

Should we stay opted-in for Winter Bash 2016?

It's that time of year again! This year's event will run from December 19th to January 8th. More information on this and individual hat-earning progress will eventually be posted here. Once again, ...
36
votes
3answers
1k views

June 2016 Community Challenge

I don't see one of these yet, so here's the question for the proposals for the June 2016 Community Challenge! (I skipped May, as there wasn't enough time to get a good pool of suggestions.) It's time ...
36
votes
1answer
1k views

How to post a follow-up question?

Sometimes I stumble upon follow-up questions, where code is being posted again after having gone through a review (or two). Examples of possible sets of follow up questions: Find missing numbers - ...
36
votes
4answers
2k views

CODE REVIEW 2017 Challenge

I want to introduce the Community Oriented Development Extravaganza, Requiring Extreme Vigor Inciting Extraordinary Winners (or CODE REVIEW) 2017 Challenge. Traditionally our Community Challenges are ...
36
votes
1answer
307 views

Your vote matters!

For a few months now I've been collecting specific data on the metrics of all SE sites throughout the network, and there's a disturbing fact that has arisen. This data isn't yet public on my end, but ...
35
votes
24answers
1k views

Stack Exchange Data Explorer is up. What now, Wonderland?

If you didn't know already, the Stack Exchange Data Explorer (SEDE) now includes Code Review and all public StackExchange beta sites. Bookmark: http://data.stackexchange.com/codereview/queries ...
35
votes
7answers
619 views

Should we adopt “Stack Snippets” (runnable code snippets in posts)?

Stack Overflow is implementing a new feature whereby the question (and answers) can contain runnable code snippets: Feedback requested: Runnable code snippets in questions and answers Today we'...
35
votes
4answers
593 views

Code Review vs. Help me solve my problem

A question that asks: I don't know how to best solve problem X, can you suggest a way? ... is clearly off-topic on Code Review. A question that asks: I have solved problem X, and this is how I ...
35
votes
3answers
595 views

Posting Code Review questions on code shaming sites

I recently noticed a number of articles from here ending up on a popular code shaming website, codecrap.com. Now, I imagine no harm is meant, but I would just like to urge people against doing this. ...
35
votes
5answers
716 views

What is the appropriate length of a Code Review question?

While Stack Overflow questions often contain segments of pseudocode or purposely abbreviated code in order to make the question more palatable to other readers, for something like a Code Review, the ...
34
votes
13answers
910 views

Best of Code Review 2014

As 2014 comes to an end, let's kick off Best of Code Review 2014! All Code Review users will be invited to nominate (link to) the best questions and answers from this year, and showcase them as ...