Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
-5 votes
2 answers
198 views

Bad experience on codereview.stackexchange.com

I had bad experience on codereview.stackexchange.com. Someone told me "You have been told to do this ..." as if that guy is a master and I am a servant. To avoid all this in future, I have ...
39 votes
18 answers
5k views

Frequently Posted Comments

On Code Review we often encounter questions with the same kind of problem over and over again. Some of us are using the auto comments script which allows you to maintain a list of comments to post. ...
3 votes
1 answer
104 views

How do I make my code more readable?

I've often come across the same kind of question: - How do I make my code more readable? - How can I improve my code? And usually the answers are similar - regardless of language or problem. That's ...
0 votes
1 answer
42 views

Synonym request for tag [animations], proposed synonym [easing]

Synonym Request I came across this question screen-transition-effect-like-in-final-fantasy-games where OP makes their custom easing function in order to smoothly transition a color over an image. I ...
6 votes
1 answer
46 views

Tag synonym request: [lexical-analysis] and [lexer]

The lexical-analysis tag was created in February 2016 and currently has 36 questions. lexer was created in January 2019 and has 31 questions. A few questions are tagged with both. Don't these tags ...
17 votes
2 answers
358 views

Code Review Blog - Post One Contest

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
10 votes
1 answer
186 views

Code Review Blog - Phase 4 - Plan a Schedule

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the authors ...
22 votes
13 answers
436 views

Code Review Blog - Phase 3 - Recruit contributors

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
9 votes
7 answers
485 views

Code Review Blog - Phase 2 - Define the Scope

On Hold SE Community Devs: The short of it is, it's kinda on us to make something that works, and we don't really do that. There isn't any real proper integration between the systems and the ...
19 votes
3 answers
443 views

StackOverflow questions being incorrectly sent to Code Review

I've noticed a couple of questions where the poster originally posted on Stackoverflow and then was sent here. However, its not a proper code review question because the code doesn't actually work. ...
2 votes
1 answer
76 views

Is it possible to get feedback on the structure of an application (with code posted)?

I've recently completed a (to a certain version, anyway) project in Python and am looking to get feedback on it. Problem is that I want feedback on how the project and the different components are ...
29 votes
3 answers
491 views

Close-vote threshold lowered from five to three

There is a comment on the MSO post We’re lowering the close/reopen vote threshold from 5 to 3 for good Other sites can have whatever threshold is most appropriate for them, @gnat – Shog9 Dec 3 '19 at ...
4 votes
2 answers
76 views

Updating the "code not implemented or not working as intended" community-specific close reason to use the new five-field close reason system

As part of the updates to the closing system that took place last year, the community-specific close reasons (off-topic sub-reasons) gained a new five-field format, which displays different text in ...
1 vote
0 answers
78 views

Can we have the first VTC post a comment?

I quite often encounter questions with at least one vote to close (VTC), but no comment or down vote. This means the OP doesn't know there is anything wrong with the question. Would it be possible for ...
1 vote
2 answers
35 views

Does improving scalability and mentioning the improvement count as sufficient justification?

A recent VB.NET AES File Encryption answer was posted with, mostly, the following text: I'm enclosing a program I wrote to help you along the way. It is very effective and will encrypt whatever you ...
2 votes
0 answers
53 views

What is the minimum code necessary to provide review context?

I am currently attempting to reduce the number of unanswered questions on the Code Review Community. I’m doing this because I am concerned that we have dropped below 90% of questions answered and have ...
7 votes
1 answer
27 views

Tag synonym request: [encryption] → [cryptography]

The encryption tag got created sometime in the last year. The cryptography tag completely covers the same topic, and it makes little sense to distinguish the two skills, especially when it comes to ...
64 votes
5 answers
4k views

Checklist for how to write a good Code Review question

Many questions of new users lack some parts or common style of the site. There already are some meta questions that aggregate tips on this issue but letting new users walk through all of them is ...
9 votes
1 answer
166 views

Is Code Review an appropriate place to get feedback on a library?

Most of the posts I see on Code Review involve short code sniplets. Is it appropriate to elicit feedback on an entire (albeit small) library? Specific example: I've quietly developed this over the ...
2 votes
1 answer
39 views

How do I post code which is reliant on large file IO operations?

I have code which does IO operations (read and process) on large files (multi GB or sometimes TB). It is not practical for me to post real examples to stackexchange and I would not want to post code ...
8 votes
3 answers
193 views

What interesting uses of MathJax are there, other than mathematical typesetting?

What interesting uses of MathJax are there, other than mathematical typesetting, that might be useful for Code Review?
4 votes
3 answers
127 views

Blocking an anonymous user from proposing edits

I, and several other reviewers, have repeatedly rejected this edit. It's ungrammatical (easier is an adjective; it can't modify legible, another adjective; it needs an adverb, like "more easily&...
10 votes
0 answers
61 views

2021: a year in moderation

As we say goodbye to the old year and welcome the new one, we have a tradition of sharing moderation stats for the preceding calendar year. As most of you here are aware, sites on the Stack Exchange ...
9 votes
3 answers
116 views

Should I include code or a link to a test project for the code being reviewed?

I have some code (a library) of about 25,000 characters (~1000 lines) that I would like to have reviewed. I have a test project (Windows project with Windows Forms) for that code. Is it a good idea ...
13 votes
1 answer
124 views

Are Advent Of Code questions on topic once we receive no points for them?

I'm trying to learn Rust via Advent of Code 2021, and am obviously hitting various roadblocks and solving them via Google. It would be great if someone could review my code to see how to make it fit ...
4 votes
0 answers
46 views

What should our help centre say about rewrite requests?

Requests to re-write code in a different idiom or using different libraries are problematic. Like all Stack Exchange sites, askers are expected to have attempted to solve their own problem before ...
29 votes
4 answers
2k views

Why is hypothetical example code off-topic for Code Review?

As stated in the Help Center, one of the criteria for a question to be on topic is: Is it actual code from a project rather than pseudo-code or hypothetical code? Details matter! In order to give ...
1 vote
1 answer
58 views

When is question deletion vandalism?

In the past (I have no examples on hand), sometimes when an OP deletes a question it's un-deleted, with the rationale that the content offers value to StackExchange and deleting it thus constitutes ...
18 votes
3 answers
253 views

What are our answer editing guidelines?

On this site, we have a well-known policy on editing code in questions: Don't do it. After all, that code is up for review, in all its glorious ugliness and buginess. But clearly, such reasoning ...
87 votes
35 answers
8k views

What's a Zombie? And what are the many other memes of Code Review?

What is a Zombie? Why are Code Reviewers so violent and talking about killing Zombies all the time? And what ammo are they talking about? What is a TS? What does RSA mean? And what other Code Review-...
14 votes
2 answers
198 views

Do we need "acronym tags" ([dry], [solid], etc.)?

We have various "acronym tags" related to software principles: dry solid srp The problem is, they can still be used as meta tags, especially dry, for reducing code repetition. However, they're not ...
21 votes
4 answers
507 views

Do we want accepted answers unpinned on Code Review?

Stack Overflow changed the way they sort answers: We no longer pin the accepted answer (with the green checkmark) to the top of the list of answers. By default, we now sort strictly by votes (...
8 votes
2 answers
307 views

Community Ads for 2021

September update: Community Ads are now live network-wide. All ads with a score of 6 or higher, or with a score of 4 or higher and no downvotes will be displayed (except for any that have a note from ...
10 votes
2 answers
137 views

Is "Hope this was helpful!" too chatty in an answer?

In general, we remove "chatty" phrases like "Thanks in advance" in questions as unnecessary for the site. Should we apply the same standard to answers and remove things like "...
-3 votes
1 answer
81 views

JavaScript concepts applying to JSX posts

Many posts are tagged with jsx as well as javascript and sometimes ecmascript-6, but then those latter tags are often removed by others. While I understand that jsx is not syntactically valid ...
15 votes
1 answer
192 views

Let's update the tour- what should be added?

Last year we updated the modal for new users. There are many comments left on posts, especially new posts, asking OPs to "take the tour" (especially when a post is off-topic). The tour has ...
38 votes
5 answers
7k views

My question was closed as being off-topic. What are my options?

I can understand that sometimes questions are closed as being too opinionated, too broad, or unclear, but my question was closed as being off-topic. I have read the On-Topic Help Center page for Code ...
11 votes
4 answers
215 views

Are we blind upvoting answers based on answerer reputation or are my answers no good?

Admittedly, Objective-C isn't very popular on Code Review. There certainly aren't a whole lot of answerers. I am basically the only regular Objective-C answerer. I'd like to think that my answers to ...
2 votes
2 answers
71 views

Should we automatically close old zombies?

There are a few views of "unanswered" questions on Code Review: https://codereview.stackexchange.com/questions?tab=Unanswered ("Questions" on left sidebar, "unanswered" ...
1 vote
1 answer
94 views

Academic interviews/surveys about code reviews?

I am conducting several academic studies on how developers perform code reviews. The studies involve interviews and/or surveys. Would it be appropriate to post a link to a survey form/interview ...
1 vote
4 answers
137 views

Confusing phrasing of the "off-topic" close reason

Before asking my last question, I've double checked what counts as off-topic and on-topic in this SE. According to my findings: We require that the code be working correctly, to the best of the ...
10 votes
1 answer
150 views

How to best motivate posters to migrate their question to another site?

It often happens that people post a question that is not suitable for the site they posted it on, but should rather go to another Stack Exchange site. Sometimes this is made easy using some of the ...
-2 votes
1 answer
67 views

Codereview building blocks [duplicate]

There are some unfortunate habits most beginners — and even some experienced! — programmers make. For example, in Python it is common to not know about PEP8 ...
5 votes
1 answer
58 views

What makes a CSS question opinion based or not?

Since CSS is about the aesthetical layout of a web page, I guess it's easy to ask opinion based questions. I guess that asking about reusability of some CSS code would not be opinion-based. On the ...
7 votes
1 answer
126 views

Can I ask a question about overall architecture without much specific code?

I have code, but my question is about overall design patterns. Ideally, I would ask a question describing the design decisions made in my project but would have minimal actual code samples. Is this ...
27 votes
3 answers
379 views

2021 Community Moderator Election Results

Code Review's third moderator election has come to a close, the votes have been tallied, and the two new moderators are: They'll be joining the existing crew shortly — please thank them for ...
8 votes
2 answers
142 views

Are responses to specific interview questions on-topic?

Tangentially related to the unanswered Can I legally post my solution to a company's coding test? I realize that generic interview prep questions are on-topic - that's why we have the interview-...
16 votes
5 answers
778 views

The context of "Lacks concrete context": let's fix it

Early 2018 we changed the close reasons on Code Review. This was necessary, but now almost 2 years later it's perfectly clear there's a growing discontent with one of them: "Lacks concrete ...
21 votes
2 answers
331 views

Request to add an extra moderator given the 2021 election results

Given we just had the election, after seeing how close the final results were (the final elimination was a margin of 0.04%), I would like to formally request that Mast be instated as a moderator. ...
11 votes
0 answers
173 views

2021 Community Moderator Election

The 2021 Community Moderator Election is now underway! Community moderator elections have three phases: Nomination phase Primary phase Election phase Most elections take between two and three weeks, ...

1
2 3 4 5
31