Questions tagged [discussion]
The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.
1,559
questions
219
votes
1
answer
12k
views
A guide to Code Review for Stack Overflow users
You're on Stack Overflow and you've found a question that seems to be about improving code. You are trying to be helpful, and you put a comment in the question:
You should try asking on CodeReview....
136
votes
2
answers
18k
views
For an iterative review, is it okay to edit my own question to include revised code?
Is it okay to edit the question to include the improved code?
I would like to do so for the following reasons:
To share the improved code with others
To show the answering persons that I take their ...
134
votes
6
answers
3k
views
It is with disappointment that I hereby resign as a moderator
Note the updates at the end: In short, my resignation is now in full effect.
A moderator is a person trusted by both Stack Exchange, and the community as a whole, to objectively and fairly deal with ...
- 97.3k
101
votes
10
answers
4k
views
Code Review SE is graduating!
Many of you have already seen announcements both on main and on meta announcing this site's graduation. At the request of a few of you who were skeptical (or perhaps merely in shocked disbelief), I'm ...
- 101
100
votes
1
answer
973
views
New Site Design!
As you can see the new design just went live. Congratulations! Thank you for your valuable design feedback.
We have also themed the twitter account and newsletter template for this site, and ...
- 101
88
votes
35
answers
9k
views
What's a Zombie? And what are the many other memes of Code Review?
What is a Zombie? Why are Code Reviewers so violent and talking about killing Zombies all the time? And what ammo are they talking about? What is a TS? What does RSA mean?
And what other Code Review-...
85
votes
4
answers
9k
views
How to get the best value out of Code Review - Asking Questions
I have a project I am working on, and I would like some, or all of it
reviewed, how can I ask for this review on Code Review in a way that
produces the best possible value?
This is not about a ...
70
votes
12
answers
877
views
New design & branding for Code Review
My name is Paweł, I’m a product designer at Stack Exchange. As all of you know, you’ve already undergone the first phase of graduation. I’m pleased to announce that we’re just about ready for you to ...
- 101
68
votes
9
answers
667
views
Should line numbers for code snippets be added?
I recall seeing a request for this in meta SO in the pass, but for various reasons that escape me at the moment, there were no plans to do that. Should this be reconsidered for code review considering ...
- 1,874
64
votes
5
answers
4k
views
Checklist for how to write a good Code Review question
Many questions of new users lack some parts or common style of the site. There already are some meta questions that aggregate tips on this issue but letting new users walk through all of them is ...
63
votes
2
answers
649
views
Graduation update: it's election season!
I'll start off by addressing the elephant in the room. It's been the better part of a year since the announcement that Code Review was graduating. In all those months, there haven't been any visible ...
- 101
60
votes
2
answers
919
views
Why is Code Review still in beta?
Code Review has been in beta for 1041 days, so nearly 3 years (Area 51).
I was wondering: why is it still in beta and will it ever graduate?
Update: Just graduated... ;)
- 123
58
votes
17
answers
2k
views
What would you say is the biggest problem Code Review is facing as a site as of June 2015?
Hopefully, by raising concerns, we may generate some ideas for improving the site!
- 144k
55
votes
4
answers
784
views
Phrancis: A final review of a good member
On May 22, 2020, I received a message from the roommate of one of our cherished members, Phrancis (Francis Veilleux-Gaboury). She was reaching out and using his account to inform me that he had passed ...
- 20.1k
55
votes
3
answers
890
views
Congratulations! Code Review is undergoing design-independent graduation!
It's a big day. You've been cleared for graduation by the Stack Exchange Community Team! Code Review has already met our threshold for graduation-worthy sites, and today joins in the new design-...
- 101
54
votes
5
answers
1k
views
Code Review is getting boring
Boring
I find that Code Review is getting pretty boring and unprofessional. The reason why I think this way is that many good questions about real-world problems don't get very much attention. Instead,...
- 44.1k
54
votes
4
answers
3k
views
Call of Duty - We're on a mission
This is a direct reply to Grace Note's recent CR review, more precisely the following part:
(emphasis mine)
Unanswered
Tying in to all of the above is one of the most pressing concerns about ...
53
votes
3
answers
514
views
Which answer to accept?
I can imagine this situation coming up frequently on this site. What should we do when there are multiple helpful valid answers?
Accept the one we think is most helpful?
Accept the one that was ...
- 897
50
votes
2
answers
1k
views
Code Review — Top User Swag!
If your name is on the first two pages of this page as of Site Graduation you'll be hearing from me soon... but that's good news! this time
We want to send you a little care package, as a token of our ...
- 101
50
votes
0
answers
418
views
Code Review questions must contain code
As requested by Kaz and approved by the voters here on meta, questions asked on Code Review that do not contain code are now blocked.
I've configured this initially as a three-line minimum (or three ...
- 101
49
votes
7
answers
4k
views
How is this site different from Stack Overflow? [duplicate]
I've decided to check this site out since it was tweeted by the great Jeff Atwood himself. The first question I saw was "Advice on making ruby code more ruby-like", which is the kind of question I see ...
- 101
48
votes
6
answers
1k
views
How is Code Review doing right now?
I’m Grace Note, a Community Manager at Stack Exchange. Normally for most sites we run a community site evaluation, as explained in this Meta Stack Overflow post under Public Beta sites. However, these ...
- 101
47
votes
5
answers
458
views
2015 Community Moderator Election Results
Code Review's first moderator election has come to a close, the votes have been tallied, and the 4 new moderators are:
Please thank them for volunteering, and share your assistance and advice ...
46
votes
2
answers
2k
views
Can I put my code on a third party site and link to the site in my question?
Is it OK if I write a question and include a link to GitHub/Pastebin/other similar site instead of putting the code here on Code Review?
44
votes
19
answers
1k
views
44
votes
9
answers
701
views
Putting down my mug
I joined CR in May 2013, but only started living here in September of that year. I remember very well then, the site had been in beta for almost 1000 days, and I kept thinking that was a shame, CR was ...
- 75k
44
votes
1
answer
704
views
25 at twenty-five!
As well as reaching a personal landmark, it's also a site landmark when I became the 25th member to hit 25k reputation yesterday (narrowly beaten to the line by two others - you know who you are).
I ...
- 72k
43
votes
12
answers
960
views
What would Clippy say?
We have a question closure rate of ~30%. That's a significant burden on moderators and users who help triage the questions.
While some questions can indeed be very difficult to triage, there are ...
- 144k
43
votes
11
answers
600
views
What is the motivation to spend time doing a code review?
I have only recently started browsing CR and have done 3 so far. I spent about 30 minutes on the first one, and 2 hours each on the others.
Sadly, because I am reviewing Ruby code (not as popular as ...
- 335
43
votes
2
answers
1k
views
How to post a follow-up question?
Sometimes I stumble upon follow-up questions, where code is being posted again after having gone through a review (or two).
Examples of possible sets of follow up questions:
Find missing numbers - ...
- 59.1k
43
votes
0
answers
815
views
Call of Duty II - We're still on a mission
Briefing.
November 16, 2013. In response to a not-so-shiny Stack Exchange Community Managers' review of our favorite Stack Exchange site and seeing that about 10% of the site's content consisted of ...
- 75k
42
votes
5
answers
982
views
Should "your code seems fine" answers be acceptable?
I want to ask your opinion on how we should handle submitted question with code that is "fine".
I assume that will be the case for very view of the submitted review requests since everyone likes and ...
- 1,546
42
votes
2
answers
959
views
Once upon a time in Stackland
Uh question, why have you folks not graduated yet? - jul 13 at 21:18 by Undo
It's been quite a while since the 100 days later update, which was posted around the 100th day after our last site review, ...
- 75k
41
votes
48
answers
905
views
Let's pick t-shirt tagline!
As you all know, we're very close to sending SWAG to some of you! One of items you'll get is this awesome T-shirt!
As you can see, below the logo we placed a very short tagline: "Making code slightly ...
- 101
41
votes
5
answers
7k
views
My question was closed as being off-topic. What are my options?
I can understand that sometimes questions are closed as being too opinionated, too broad, or unclear, but my question was closed as being off-topic. I have read the On-Topic Help Center page for Code ...
41
votes
4
answers
990
views
Code Review Graduation
I am pleased to announce that effective from September 22, Code Review has graduated! It has taken a bit of time for this announcement to filter through the red tape, so, today was the day we found ...
41
votes
5
answers
486
views
Nothing fishy going on here! Nope, not at all
Following Mat's resignation as moderator yesterday, I, too, have informed the Stack Exchange community that I am yielding my position as moderator.
I know that it may be natural for many of you to ...
- 144k
40
votes
18
answers
5k
views
Frequently Posted Comments
On Code Review we often encounter questions with the same kind of problem over and over again.
Some of us are using the auto comments script which allows you to maintain a list of comments to post.
...
40
votes
5
answers
711
views
2014: What a ride!
Here we are, with another year [almost] behind us. 2014 has been very, very special on Code Review, and that has been completely because of you.
2014 was ...glittering. We've put Code Review on the ...
- 75k
40
votes
5
answers
914
views
What is the appropriate length of a Code Review question?
While Stack Overflow questions often contain segments of pseudocode or purposely abbreviated code in order to make the question more palatable to other readers, for something like a Code Review, the ...
- 1,470
39
votes
8
answers
2k
views
Short answers and code-only answers
What should we do with:
Short answers (for example, "I suggest you use [hyperlink to this standard API] instead.")
Code-only answers (for example, an improved version of the code in the OP)
Such ...
- 12.9k
39
votes
6
answers
2k
views
April 2017 Community Challenge
It's that time of year again! I want to get a head-start on the 2017 community challenge, we have a lot of new faces over the winter and it would be great to get everyone participating again!
For ...
- 20.1k
39
votes
22
answers
1k
views
Tracking Graduation Progress
Moderator Note:
This question has been identified a number of times as being a
candidate for migration to Meta.SE - the main meta site.
This question is really about tracking Code Review's ...
38
votes
2
answers
2k
views
Jack of All Trades, Master of None - Let's work together to offer ultimately better content, faster
Nhgrif pointed out a great idea: Teamwork
"I think it's probably best if the question instead has several good
answers that each address a specific topic. The result will be that no
single ...
user73428
37
votes
16
answers
846
views
Hi! What brings you here today?
On 2013-11-15, we were given a review about our beta progress. On 2014-04-10, we also got some feedback from Stack Exchange Community Managers @GraceNote and @Pops.
One of the concerns that was ...
- 144k
37
votes
2
answers
1k
views
Why is only my own written code on-topic?
I tend to disagree with point #2 on the Help Center:
Did I write that code?
I believe any code, written by one self or anyone else should be eligible for code review. Many a times, you're ...
37
votes
4
answers
625
views
Code Review vs. Help me solve my problem
A question that asks:
I don't know how to best solve problem X, can you suggest a way?
... is clearly off-topic on Code Review.
A question that asks:
I have solved problem X, and this is how I ...
37
votes
1
answer
1k
views
Welcome to The 2nd Monitor!
So, you have found your way to the Code Review main chat room, The 2nd Monitor, perhaps for one of these reasons:
You were invited or "pinged" by a site moderator or other user to discuss a post on ...
36
votes
3
answers
1k
views
June 2016 Community Challenge
I don't see one of these yet, so here's the question for the proposals for the June 2016 Community Challenge! (I skipped May, as there wasn't enough time to get a good pool of suggestions.)
It's time ...
- 20.1k
35
votes
24
answers
2k
views
Stack Exchange Data Explorer is up. What now, Wonderland?
If you didn't know already, the Stack Exchange Data Explorer (SEDE) now includes Code Review and all public Stack Exchange beta sites.
Bookmark: http://data.stackexchange.com/codereview/queries
This ...