Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
3
votes
0answers
29 views

Can I ask about my CloudFormation infrastructure template?

I have a template for some infrastructure using AWS CloudFormation that I'd like reviewed. However, I'm not sure if it's on-topic here; it's YAML that's describing infrastructure, not a program per se....
3
votes
2answers
110 views

I broke your code, therefore your code doesn't work: NAA discussion

Let's say the OP had code like this (imagine there's actual code here, I'm just making a generalized example for meta): ...
13
votes
2answers
329 views

My code is too long. How do I trim it down when code posted here is expected to function?

The code I would like to have reviewed, found here, is more than 30,000 characters long. I don't feel like that in and of itself makes it off topic, but removing code from it so that it can be posted ...
3
votes
1answer
624 views

How many lines of code are too much? [duplicate]

I've built an ASP.Net component, for example, which consists of a base class with 670 lines of code, a sub class with 180 lines, plus some code to illustrate it's usage. I think this is a perfect ...
21
votes
2answers
210 views

Can we enhance the favicon on a dark background?

In Chrome on Max osx, at least, the favicon in the tab title kind of disappears when having a dark main background on the window. Can this be enhanced somehow? The image shows top part of window with ...
7
votes
4answers
494 views

Code Review's updated site theme is now live for everyone

Update - the theme and layout is now live for everyone. Thanks for your feedback in this process. If there's additional feedback, please feel free to add to the answers below. As part of ...
0
votes
1answer
56 views

Post was put on hold stating that code is not working

I have a question about my Code Review Stack Exchange post: Filling-values-for-dictionary-of-dictionaries Post was put on hold stating that code is not working but it's working and I had posted the ...
6
votes
2answers
166 views

Are practical user-created languages suitable for a tag creation?

I recently created a language, and was wondering (As many others may be) if a user is allowed to create a tag for their language and post a few example questions. The following things should be ...
0
votes
1answer
62 views

Why is my SPOJ question receiving downvotes?

SPOJ- CPP: Gap in output What is the purpose of so many downvotes? And what does it mean that the code should be "embedded directly"?
11
votes
2answers
200 views

Removing a question I don't like anymore

I recently posted a question which I think is decent enough, but I have since decided that the code in question is flawed/ has some issues. It is not that the code is buggy or incorrect which would be ...
5
votes
1answer
184 views

Posting code that violates Google's TOS

For a quick project, I thought it would be cool to make a crawler that goes over Google results, finding and recording sites that are scraping and impersonating Stack Exchange sites. The problem is, ...
1
vote
1answer
92 views

Wouldn't it be better to edit this question instead of closing it?

This question: Frequency Queries hackerrank … got closed for this reason: Code not implemented or not working as intended … … as the author wrote: However, on hackerrank it says the wrong ...
-4
votes
1answer
55 views

JavaScript concepts applying to JSX posts

Many posts are tagged with jsx as well as javascript and sometimes ecmascript-6, but then those latter tags are often removed by others. While I understand that jsx is not syntactically valid ...
33
votes
1answer
1k views

Welcome to The 2nd Monitor!

So, you have found your way to the Code Review main chat room, The 2nd Monitor, perhaps for one of these reasons: You were invited or "pinged" by a site moderator or other user to discuss a post on ...
6
votes
1answer
163 views

Need clarification on my close reason interpretation for a specific close reason

The question Does this method guarantee that cells in a CSV will be correctly partitioned? is a duplicate of this one (10k+ and mods only) which asks whether a singular function properly 'escapes' ...
3
votes
2answers
133 views

How to prevent people from answering off-topic questions?

Assume a person is asking about their broken code and someone suffering from FGITW-syndrome immediately answers it. Then maybe the answer and/or even the question gets upvoted. This completely ...
3
votes
2answers
68 views

Why is my second “Form maximum date/time from some digits” question being down voted?

My question here is getting down votes: Code Vita 7: Form the maximum possible date time in the MM/DD HH:MM format using any eight of twelve given single digits which is a follow up to my previous ...
5
votes
2answers
143 views

How much context is the required minimum?

This question got sparked by a recent discussion in the 2nd Monitor about this question: Golang Map-Reduce Master - Channels. The problem is: How much context is needed to actually review the code in ...
10
votes
1answer
101 views

If porting code, should I also post the original?

Is it on-topic (or acceptable practice) here to post code written in one language, and ported code in another for review ? I am learning scala and in doing so I am translating some code I wrote (in C++...
7
votes
2answers
99 views

How should question bodies be organized?

The format that I know for question bodies is: Intro, often explaining where the problem originated. A problem statement explaining what the code is supposed to do. Perhaps a little more ...
4
votes
1answer
105 views

Closure of finding the longest word in a string

Recently we got the question Finding the longest word in a String. (10k required) This question looked like it was off-topic, because of the following results: ...
13
votes
6answers
145 views

Performance checking tools

Performance checkers: What tools are available for attaining the metrics necessary to perform a performance review? Bench-marking is often not easily done by hand after all. This is a follow-up to ...
32
votes
2answers
281 views

Do people read other reviews for learning?

I was looking for posts about self-answering my own code review question, and I saw this post: Why should I be able to answer my own question in the question's editor on Code Review? 3 days ago I ...
4
votes
1answer
160 views

Can you post code that works on one version of a interpreter (ex:Python 2) but not on another (ex:Python 3)

I am new to this specific Q&A site and I got my rep off of association bonuses, and I wanted to ask how to fix my code to work for another version of python. I noticed the text "Post code that is ...
17
votes
2answers
164 views

Should I leave in documentation in code for review?

I'm surprised I can't find this as a question already, so I'm taking a shot and posting... I document my code. I don't not document my code before considering myself done for the day. Most of the ...
10
votes
2answers
220 views

Is it allowed to edit code if there is no answer?

If I have kept working on the code, and there are no answers (say one week after the original post), am I allowed to edit the code to reflect the changes I have made to it? I believe this question is ...
4
votes
1answer
121 views

Technology review without code

I developed a new blockchain technology. I have white papers and my code is under development. I would like to ask a question about my technology idea and not providing actual code. Is that kind of ...
15
votes
1answer
236 views

PSA: Excel going “Not Responding” isn't broken code

Some VBA questions mention the host application (e.g. Excel) is going "not responding" while their macro is running. Is it ok to vote to close these questions as "broken code"?
0
votes
1answer
92 views

When to create a generator or return simply a list, closed for missing context

The other day we got the question: When to create a generator or return simply a list in Python? This question has a generic title, some code which contains enough code to be reviewed. And a couple ...
2
votes
1answer
33 views

Clojure tag not sorting first

I've noticed that all language tags are sorted first but clojure tag. Is this by design or is there some setting that this tag is missing?
2
votes
0answers
26 views

Posting multiple questions for the same code at different points in the development [duplicate]

Here's the scenario: I have posted a question on Code Review and received feedback (but not a refactored code). I improve my code based on the advice I was given in this question and added new ...
2
votes
3answers
71 views

Why did this question get closed?

There is a review history for the question where it can be seen that it has been closed several hours after the OP fixed the issue. Why people kept voting if they could see that the reason is not ...
1
vote
1answer
153 views

has the site became less welcoming…?

I raised a question earlier. Here is a screenshot of it: and the Comments I'd be honest, it is not the best question I've asked so far. But to have a minus 4 for that question? That's weird for a ...
12
votes
3answers
226 views

Should we bother old off-topic questions?

Recently I've found some old questions which do not contain any code (usually just a link). Some of them have an accepted answer. Since these questions are off-topic (according to the FAQ), should I ...
5
votes
1answer
139 views

Clarification on close reason

This question was closed per the Authorship of code reason. However nothing in the question seems to suggest that it is not written by the OP. Were there maybe (now deleted) comments that made clear ...
6
votes
5answers
530 views

What's the best way to change how my code looks?

A long time ago the question avoiding Python multiline string indentation was asked. The question was well received with a score of 66 and 16 favourites. It was even answered by one of our previous ...
21
votes
8answers
618 views

How much idle chatter do we tolerate in The 2nd Monitor?

Related but not a duplicate: How far off-topic can we get in 'the 2nd monitor'? Today was a complicated day in the history of The 2nd Monitor. On one side there appears to be consensus something ...
6
votes
2answers
162 views

Make constexpr synonym to a new tag, constant-expression

I'm proposing creating a new tag, constant-expression, and then making constexpr a synonym for constant-expression, rather than constants. Constant expression in C++ requires different usage of ...
2
votes
2answers
134 views

Answering questions in comments

On Code Review SE, users should avoid answering questions in comments, because that's not what comments are for: Do not provide suggestions for improvements in a comment, even if your suggestion ...
2
votes
1answer
56 views

“Password validation” question appears to have been wrongfully closed

I want to question the closing of this question: Password Validation in Python 3.6 The reason given is "Code not implemented or not working as intended". I can see no evidence that the code is ...
3
votes
2answers
148 views

Unmodified question looks modified

This is maybe the fourth time I noticed this scenario since the start of this year, so I am curious to know if you have an explanation: When I clicked on Questions, I saw this: But when I clicked to ...
25
votes
0answers
428 views

Playing our home-made games!

As developers we know that it's not always easy to get people to play the games that we make. We also know that it's not always easy to find motivation to work on the games you want to make. This is ...
2
votes
2answers
90 views

Not notified of unwanted edits to question

I was surprised to see one of my questions being changed that much that the intent of the question was removed from it. As C++ is evolving rapidly, I was experimenting with one of its features: ...
4
votes
1answer
72 views

Duplicate answers - clean them up?

This question (originially from Stack Overflow) has heaps of duplicate answers. Many users suggested the exact same changes to the code, presumably while the question was not yet migrated; most of the ...
25
votes
11answers
460 views

Should we bring back the fun?

Since we've not had any fun in a little while, I thought maybe it'd be a good idea to 'bring back' the fun. In the past this has been in the form of Winterbash, community challenges, best of Code ...
5
votes
4answers
339 views

Poor mans count, is it off-topic?

Recently we had the question "Project Euler Problem #12 - Highly divisible triangular number" It was closed as the OP included how to use the function with the function's code. The code as posted ...
11
votes
4answers
189 views

Handling things that seemingly *every* new writer of a language gets wrong

I've noticed that, for whatever reason, seemingly every new user of Clojure tries to use def to create local variables. I've noticed it here, and on Stack Overflow, ...
2
votes
1answer
54 views

I changed my question after comments

I closed an earlier post asking for code-feedback on the Click CLI framework I wrote for my scripts. I reopened the question simply about my approach to templating scripts. I rewrote the post as an ...
6
votes
1answer
97 views

How should we review code written around a template?

It is fairly common for review requests to be for homework or interview practice questions. For example there's a fairly steady stream of python tic-tac-toe games which I'm basically convinced fall ...
6
votes
1answer
144 views

Can I include problem statements when posting exercise solutions to Code Review?

I have several books of programming exercises that I am working through. I would like to post some of my solutions to Code Review. Can I include problem statements along with my solutions without ...

1
3 4
5
6 7
30