Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
35
votes
3answers
604 views

Posting Code Review questions on code shaming sites

I recently noticed a number of articles from here ending up on a popular code shaming website, codecrap.com. Now, I imagine no harm is meant, but I would just like to urge people against doing this. ...
35
votes
3answers
1k views

June 2016 Community Challenge

I don't see one of these yet, so here's the question for the proposals for the June 2016 Community Challenge! (I skipped May, as there wasn't enough time to get a good pool of suggestions.) It's time ...
35
votes
4answers
2k views

CODE REVIEW 2017 Challenge

I want to introduce the Community Oriented Development Extravaganza, Requiring Extreme Vigor Inciting Extraordinary Winners (or CODE REVIEW) 2017 Challenge. Traditionally our Community Challenges are ...
35
votes
2answers
407 views

I was the shield that guarded the flags of users

I became a moderator in the first election four years ago but it is now time to step down. I came here to Code Review in November 2013, after browsing the site for a few days I posted my first ...
34
votes
2answers
1k views

Why is only my own written code on-topic?

I tend to disagree with point #2 on the Help Center: Did I write that code? I believe any code, written by one self or anyone else should be eligible for code review. Many a times, you're ...
34
votes
1answer
315 views

Your vote matters!

For a few months now I've been collecting specific data on the metrics of all SE sites throughout the network, and there's a disturbing fact that has arisen. This data isn't yet public on my end, but ...
33
votes
13answers
921 views

Best of Code Review 2014

As 2014 comes to an end, let's kick off Best of Code Review 2014! All Code Review users will be invited to nominate (link to) the best questions and answers from this year, and showcase them as ...
33
votes
13answers
949 views

Let's make More Community Ads!

Back in April we got together and put together a shortlist of community ads that can be posted to other graduated sites. That was a very successful campaign with probably a thousand or two "click ...
33
votes
11answers
900 views

Best of Code Review 2015

As 2015 comes to an end, let's kick off Best of Code Review 2015! All Code Review users will be invited to nominate (link to) the best questions and answers from this year, and showcase them as ...
33
votes
5answers
520 views

Migration paths to other sites

If you can cast close votes, you now have a new privilege! Up until recently, only moderators could migrate an off-topic question to Stack Overflow or Programmers.SE - if you haven't noticed yet, the ...
33
votes
5answers
1k views

Let the CR Games begin!

June is about to end. Summer's here (well, if you're in the northern hemisphere, that is.. otherwise, ... yay, winter!), and with it, vacations. We need a new community-challenge. Let's play. I mean, ...
33
votes
3answers
543 views

How well is “malicious” code accepted here?

I recently asked a question that could possibly be used for malicious purposes. I tried to whittle the code down as much as I could to a "base" program so that a script kiddie wouldn't stumble across ...
33
votes
3answers
329 views

Please welcome your new moderators!

I'm Pops, a Community Manager at Stack Exchange. Though it saddens me to say it, not just one but two of your existing moderators are stepping down for personal reasons. Over the past week and a half, ...
33
votes
4answers
1k views

Mat's back, blame the monkey

When I put down my mug 18 months ago, I promised I'd stick around, and I did. I've been keeping a distant eye on CR and meta, while remaining in our Rubberducking dev chat, and monitoring vba posts on ...
33
votes
2answers
487 views

Vote Early, Vote Often

Lack of voting has already been identified as an issue that prevents the site from graduating. I'm shamelessly stealing this post from Meta Biblical Hermeneutics, hoping it will inspire all of us to ...
33
votes
1answer
1k views

Welcome to The 2nd Monitor!

So, you have found your way to the Code Review main chat room, The 2nd Monitor, perhaps for one of these reasons: You were invited or "pinged" by a site moderator or other user to discuss a post on ...
32
votes
6answers
525 views

Is code ever clean enough? - Can there be too many follow-up questions?

Some posts can at times have several follow-up questions, sometimes a couple of follow-up questions on the same day. All this brings us to the question of Can there be too many follow-up questions? ...
32
votes
2answers
280 views

Do people read other reviews for learning?

I was looking for posts about self-answering my own code review question, and I saw this post: Why should I be able to answer my own question in the question's editor on Code Review? 3 days ago I ...
32
votes
1answer
702 views

First Post Review Queue — what is it? Why is it a bad idea to click “No Action Needed”?

When you pass 500 reputation you gain access to the Review Queues. One of them is the "First Post" queue. What is this queue, what purpose does it serve, and how should I process items in that queue?
32
votes
2answers
735 views

100 days later: what's up?

November 15, 2013. 6:30AM UTC. Community Manager Grace Note posted How is Code Review doing right now?. We are 100+ days later. Rewind Since mid-November 2013, a number of things have happened: A ...
31
votes
4answers
1k views

How can I be a nice reviewer?

From Remove Nth Node from End of Linked List: Bug: n < 0 leads to you removing the last node. Your solution should have comments: I have NO idea how it ...
31
votes
2answers
363 views

Distributing “welcome votes” to first posts

When I review first posts in the first posts part of the review queues (found in the top right corner for some users), I will often upvote a first post from a new user if it is good enough. For ...
31
votes
6answers
657 views

Is Code Review useful for external users?

Let me first take Stack Overflow as an example. After collecting a database with thousands of questions and answers, SO can get many redirects from Google whenever somebody asks Google something like '...
31
votes
1answer
690 views

These mysterious $A framework questions

I've been seeing a lot of these questions lately: object.Storage.js - creates a namespace for Storage https://codereview.stackexchange.com/q/127923/11919 https://codereview.stackexchange.com/q/127853/...
30
votes
6answers
423 views

On the huge amount of work needed for a CR answer

I'm a regular at Stack Overflow, and I just recently discovered Code Review, where I answered some questions with the d3.js tag. We all know that CR is quite different from SO: by its very nature, ...
30
votes
2answers
740 views

That's it for now

I'll make it short because I think the more I say the more likely it is that it'll offend someone. As a reaction to the latest events on MSE concerning the CoC and especially the Official FAQ on ...
30
votes
1answer
380 views

Should you refrain from answering questions that are likely to get closed?

Sometimes a question may look highly suspicious that it might get closed, very commonly: looks broken looks hypothetical unclear what OP is asking These suspicions aside, what if you have a genius ...
29
votes
6answers
646 views

What are the advantages of graduation?

I've seen a lot of activity about graduation recently. What are the (possible) benefits (and disadvantages) of a graduated site?
29
votes
6answers
794 views

2018 Moderator Election Q&A - Questionnaire

In connection with the moderator elections, we are holding a Q&A thread for the candidates. Questions collected from an earlier thread have been compiled into this one, which shall now serve as ...
29
votes
3answers
786 views

Should you edit someone else's code in a question?

I have seen several (suggested) reviews lately, where someone edits the code in the original poster's question. Should such edits be allowed? The edits in question are mostly minor. Some add spaces ...
29
votes
3answers
702 views

The race has started. Are you running?

PCG.SE is going on a mission. And so the race begins. For Code Review!! -- syb0rg 2 days ago Let's see: Programming Puzzles and Code Golf Voting & Activity PCG.SE Voting and ...
29
votes
4answers
1k views

Why is hypothetical example code off-topic for Code Review?

As stated in the Help Center, one of the criteria for a question to be on topic is: Is it actual code from a project rather than pseudo-code or example code? What is the rationale for that ...
29
votes
2answers
247 views

2018 Community Moderator Election Results

Code Review's second moderator election has come to a close, the votes have been tallied, and the 3 new moderators are: They'll be joining the existing crew shortly — please thank them for ...
29
votes
1answer
683 views

Let's not close fixable posts without explanation

There's one thing that's hooked me to CR more than on other sites and it's the fact that the community is really great. But recently I've noticed (I don't have any data to back it up) that we have ...
28
votes
9answers
301 views

2015 Moderator Election Q&A - Question Collection

In connection with the moderator elections, we will be holding a Q&A with the candidates. This will be an opportunity for members of the community to pose questions to the candidates on the topic ...
28
votes
26answers
2k views

Tools for format and error checking in your programming language

Lints and Hints: What tools are available for checking and correcting the conventions, style and common errors in my language (lint tools), and are there tools that can automatically fix them (hint ...
28
votes
4answers
267 views

What to do when user insists you spoon feed them?

It has happened a few times that I have answered a question where the author is doing things in a round-about and complicated way. I tell author that there is a better way and show them how using a ...
28
votes
7answers
897 views

New answers on old questions using new language features

Times and technologies advance, and, as a consequence, code that was up for review 'years ago' would be done differently using current technology. Is it OK on Code Review to add answers to old ...
27
votes
7answers
417 views

'Canonical' questions to help address common issues

Short Version I believe it would be valuable to create a 'canonical' question/answer of sorts for each language, and I am hoping to get others' thoughts on this. These questions and answers would ...
27
votes
1answer
476 views

What makes a good question? [duplicate]

I think it would be a good idea to compile a list of guidelines on how to ask good question. What information should be present, how to structure it, etc.
26
votes
11answers
635 views

Code Review Secret Santa 2015: Show off your gifts

Now that some of the gifts have been sent and begin to arrive, you can show off your awesome christmas swag in here and write a "Thank You" message to your giftee! Don't worry if your gift hasn't ...
26
votes
9answers
665 views

Let's Make Community Ads!

Last I heard, Community Ads were something graduated sites could do... but recently I stumbled upon this meta-PCG post, so here's a shamelessly stolen meta-post :) It's simple: you make an ad, and ...
26
votes
6answers
328 views

Should we sign up for Winter Bash 2014?

Winter Bash 2014 is approaching! We signed up for it last year, and it was a really big hit. I'm still posting this in order to get an official word from the community and to make new users aware of ...
26
votes
6answers
324 views

Pastebin thoughts

The odds of someone submitting a massive amount of code seems likely on this type of site. Whether or not this is permitted is the first hurdle. If it is permitted, then offloading the code to a ...
26
votes
3answers
840 views

Prebash Challenge - 2014 - Simon Says - Now Complete

In Memory of Ralph H. Baer - 1922-2014 - co-inventor of the "Simon" game. This round is now complete! Simon Says will be the challenge this time Simon Says: +17 score Resistor: +12 score ...
26
votes
4answers
375 views

Code Review Clippy

A while back, y'all asked for some warnings for folks asking questions here: What would Clippy say? After thorough review (mostly by animuson & JNat), we've determined that the following warnings ...
26
votes
4answers
593 views

Is “just reviewing the code” good enough of an answer?

Looking back at some of my last few answers (here and especially here), I started wondering if these answers were good enough. Allow me to expand: in these answers I went through the code almost line ...
26
votes
3answers
250 views

Is asking for a review of boiler plate for a minimal repro okay?

For asking and answering questions on Stack Overflow with certain frameworks and libraries I have boilerplate lying around for a minimal repro. I would be interested in getting feedback on my WCF ...
25
votes
11answers
458 views

Should we bring back the fun?

Since we've not had any fun in a little while, I thought maybe it'd be a good idea to 'bring back' the fun. In the past this has been in the form of Winterbash, community challenges, best of Code ...
25
votes
4answers
650 views

Must the code be “clean”?

I have working code that I want reviewed, but it is not clean. It made the correct output but there are comments and bad names. Is it not ready for review, and must the code be clean to get reviewed ...

1
2
3 4 5
30