Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
1
vote
0answers
58 views

Is it advisable to share the link of the entire project on Code Review? [duplicate]

I would like someone to review a small PHP project of mine - the entire source code of which has been uploaded on Github. Is it advisable to share the link of the entire project here on Code Review?
1
vote
0answers
36 views

What if there is nothing to review? [duplicate]

The title is self explanatory. Let's say there is the perfect code in a question and the OP is asking for review. Is it bound to become a zombie? Should we say the question is perfect and ask the OP ...
1
vote
1answer
38 views

Question closed with no link to reopen

I found this question marked as closed. It seemed to be asking a genuine question that seemed to be asking for best practices as defined in the scope. Any particular reason it was closed? Also, no ...
1
vote
0answers
81 views

Stack Overflow Worldwide Meetups 2012: You're invited!

We're having a Stack Overflow meetup to get together with fellow programming, web, and other technology enthusiasts. But not all of our programmers and technology enthusiasts live on Stack Overflow, ...
1
vote
0answers
60 views

undocumented effects of indentation on sub-lists

What's the actual rule for sub-list nesting? The documented rules say to indent this sublist entry by 4 spaces, but any indentation from 1 to 7 SEEMS to work. Code block formatting works as ...
0
votes
2answers
177 views

THE Shouting sitename

status-bydesign This is intended and will remain in current shape. The site name in the upper left is in capital letters CODE REVIEW which just isn't right. The same goes with meta. To clarify why ...
0
votes
4answers
85 views

Confusing phrasing of the “off-topic” close reason

Before asking my last question, I've double checked what counts as off-topic and on-topic in this SE. According to my findings: We require that the code be working correctly, to the best of the ...
0
votes
2answers
31 views

Answer deleted/converted to comment- can't fathom why

This is on the Code Review site. Someone posted their code for building a SQL Connection String. My answer points them to the Microsoft class whose purpose is to do this exactly: Prompting user for ...
0
votes
2answers
134 views

Dialog is difficult… why isn't there a linting tool? [closed]

I think this site needs a lot more work for it to become a good open-source code review platform. Otherwise, it will be blind-sided by something else soon enough! My biggest bug bears are: No sane ...
0
votes
2answers
51 views

Peculiar application of [reinventing-the-wheel] tag on my question

My question has been edited by a moderator to include the tag reinventing-the-wheel. Allthough I did state I am not relying on libraries like cats even if they might already provide solutions for ...
0
votes
2answers
76 views

Why has my suggested edit to rename some variables in an answer been rejected?

I have made an edit to this answer about 'Lissajous pattern simulator' to replace misleading names of two varables xStart and ...
0
votes
1answer
78 views

Why is my self answer being downvoted?

I have shown that my code works. I have corrected people that they were wrong when they said my code does not create valid Sudoku. I'm awaiting valid reasons why my answer is being downvoted. If you ...
0
votes
2answers
93 views

Are comments asking the applications purpose really relevant?

I've asked for a review on the way that I'm populating some comboboxes in a datagrid. One commenter asked what the purpose of the application was. Are those comments really relevant to a code review? ...
0
votes
2answers
88 views

Why am I getting downvotes for not working code when it's working code?

I've become a little frustrated with Code Review. They said my code does not output a valid Sudoku when it in fact does. Is it that people are confused of my code and don't realize that it's in fact ...
0
votes
2answers
56 views

An edit of mine was rolled back and the question locked

I asked this question: Templated division by a power of 2 and did not include an #include directive before my actual code. An answer noted the ...
0
votes
2answers
240 views

To serve, what is it to ask for review?

Food for thought. There are times when questions come along which demonstrate a student's query, and with that comes the student's ill fated attempt to pose an "on topic" question without much ...
0
votes
2answers
149 views

Accepting without upvoting

What could be the reason for accepting an answer but not upvoting it? Situations: Accepting own answer - ok, no upvote on self-answers OP not having 15 reputation cannot upvote. I think that OP ...
0
votes
1answer
57 views

Can I ask questions about where my code went wrong in algorithms and problem solving?

I have recently started solving problems with Python. Many of the programming problems involve complex algorithms and are hard to solve. I need help knowing if the code I've written produces wrong ...
0
votes
2answers
102 views

Readability oriented coding conventions

I think it would greatly help reviewers if we decide upon and adopt guidelines on readability oriented coding conventions. A few examples: Blocks One space between arguments, no new line braces <...
0
votes
2answers
40 views

Are mods allowed to answer non-meta questions?

This may seem like a very simple question with a very simple answer, but it’s been bugging me. Having looked through hundreds of answers on questions on the regular site, I only see answers from ...
0
votes
1answer
70 views

Is it OK to ask how to revise a golfed function?

After reading through a few question on here I found out that asking questions about refining code golf code is not on topic. However in this case I'm not asking for the code to be golfed but re-...
0
votes
3answers
98 views

Reviewing Inexperience vs Reviewing Style

I just recently Posted a Review Question and got some fantastic feedback. Exactly the point of this site. Although IMO I processed 3 separate 'types' of review points. You Missed X, (In my case an ...
0
votes
1answer
47 views

Is this tag bad [form] for this site?

Quoting the Tag-Wiki: An HTML form is a section of a document containing normal content, markup, special elements called controls (checkboxes, radio buttons, menus, etc.), and labels on those ...
0
votes
1answer
39 views

Is it on topic here for questions not about specific code but rather how to manage the code?

Title explains it: I want to ask a question about maintaining branches of a single project and I'm not sure if it's on topic. If not, is there anywhere that it would be on topic?
0
votes
1answer
52 views

Is it ok to post code that didn't work out as intended?

I recently tried to optimize some code by using parallel processing, putting two cores to work on the problem instead of one. For whatever reason, it didn't work. I don't know why, but I doubt much ...
0
votes
1answer
41 views

Clarify edit review screen

The pending edit screen is very confusing to me as someone who has never seen it before: It says I have 0 edits rejected. The rejection notice on the second line uses "this" vaguely. This question? ...
0
votes
1answer
39 views

Posting code with different licence [duplicate]

Can I post a question about some of my code that I want to have a different licence under? Say I want someone to review my code but have it posted so that a license covers it for not to be re-used or ...
0
votes
1answer
33 views

Are questions asking for opinion regarding all edge cases on topic?

I have been away from code review for some time and not sure on the scope agreed upon in the community. So is this question on topic or off topic? Basically the below is on topic or not? Will the ...
0
votes
1answer
76 views

What do we do with out-of-sync questions?

This question is now in somewhat of a bad state. The OP did significant rewrites of their question, and then received an answer. Not realizing the sequence of events, I rolled the question back to ...
0
votes
2answers
55 views

Why don't we have a close reason like “off-topic because of asking to find a 3rd party resource” like SO has? Or at least a “Blatantly off-topic”?

I recently came over this question I am trying to implement duplicate file finder in visual C++. I followed this link Successful implementation of Duplicate Files Finder in C++ But it don't ...
0
votes
2answers
52 views

Code typed in from a non-text source or converted from another language and isn't working - is this in the scope here?

I recently typed in code from a scan in a PDF is pseudocode or in another language to make a JavaScript version. The code was implementing things of a mathematical nature beyond my math abilities ...
0
votes
1answer
35 views

Would code review be a good place to ask for a review of a presentation?

I have a presentation on AMD and I need a few good reviews on it. Would this type of "review" be a good fit for the site?
0
votes
1answer
32 views

Is hacking/cracking on-topic? [duplicate]

Login to website behind captcha seeks to circumvent a captcha. I think that white-hat hacking or penetration testing for the purpose of security improvement might be OK, but this is clearly in the ...
0
votes
1answer
56 views

Why is my SPOJ question receiving downvotes?

SPOJ- CPP: Gap in output What is the purpose of so many downvotes? And what does it mean that the code should be "embedded directly"?
0
votes
1answer
99 views

Can I ask to check my code here? Or did I get this wrong?

If so, i will post some of my website mr2ndopinion.com. I'm looking for peer help to improve the experience of the site, i want it to be professional. Unlike my video's which are mostly made for ...
0
votes
1answer
30 views

Can questions request only specific kinds of review guidance? [duplicate]

In other words: if a CR question asks only for performance feedback, or only for OOP structure feedback, etc., is that valid? And would answers providing review feedback on other aspects of the code ...
0
votes
1answer
86 views

When to create a generator or return simply a list, closed for missing context

The other day we got the question: When to create a generator or return simply a list in Python? This question has a generic title, some code which contains enough code to be reviewed. And a couple ...
0
votes
1answer
77 views

The snippet to review is good, no better answer found

There was no better solution to my code snippet: Highlight input if empty. What should I do? I want to mark this entry as "done". But since there is no answer, I can't accept any.
0
votes
1answer
49 views

Post was put on hold stating that code is not working

I have a question about my Code Review Stack Exchange post: Filling-values-for-dictionary-of-dictionaries Post was put on hold stating that code is not working but it's working and I had posted the ...
0
votes
1answer
108 views

Is the “I downvoted because…” site something that is useful here?

When we have a bad question, pasting one of the appropriate questions from this site may help, specifically this in a comment.
0
votes
1answer
48 views

Edit a question to add comments to the code?

In this question, an edit to the code (by other than the asker) added this block of comments to the code: ...
0
votes
1answer
45 views

Sharing code over a lot of files [duplicate]

I'm working on a multithreaded server and have a few questions regarding it, especially the best way of going around decoupling the server module (that manages the connections) from the application ...
0
votes
3answers
249 views

Should [interview-questions] be burninated?

The tag interview-questions seems to be useless - should it be burninated?
0
votes
1answer
165 views

Could Code Review be used to create a community library?

Here is the elevator pitch: Using Code Review to assemble a collection of extension methods for .NET and extracting a library out of it. Originally I created a separate SE site proposal to achieve ...
0
votes
1answer
30 views

How can I ask for a review of the same item after making an update? [duplicate]

Suppose, I submit a code for review, and some reviewers suggest some corrections. Suppose I then want to update my code and show it to the same reviewers. How should I do it? Should I edit my ...
0
votes
0answers
45 views

Are Nix expressions without any logic on topic? [duplicate]

I've written a configuration.nix file for my systems, and it would be very useful to have it reviewed. Nix expressions are code, very similarly to Puppet or Chef, but are declarative, so I wonder if ...
0
votes
0answers
44 views

Merge example code, stub code and insufficient context reasoning into one?

When expanding the guide to wonderland, I'm trying to explain what example code, stub code and context are. When trying to explain why example code is off-topic all I can think of is something like: ...
0
votes
0answers
56 views

Is it possible to get a code review of scripts while obfuscating sensitive information? [duplicate]

Namely, I wrote a Python script to handle Cloudflare-based Dynamic DNS updates for a system, but I need to obfuscate my CloudFlare creds and some API keys, for fairly obvious reasons. Would there be ...
0
votes
0answers
37 views

Can I ask a Code Review question about a Linux kernel patch made by someone else? [duplicate]

I've been following another developer who fixed a bug in the Linux kernel. The developer has posted a patch series hoping it would get reviewed/merged, but he got no response so far. The patches have ...
0
votes
0answers
35 views

It it acceptable to ask questions that have arisen from another answer [duplicate]

It it acceptable to ask questions that have arisen from another answer, repeatedly. For example... I post working code and ask to have it reviewed. Someone answers with some suggestions. I re-write ...