Questions tagged [discussion]

The question you're asking is designed to solicit opinions or best-practices on a particular topic, with the goal of reaching community consensus.

Filter by
Sorted by
Tagged with
1
vote
2answers
48 views

Do I edit my question based on answers? [duplicate]

A very simple question, but I haven't seen whether this is acceptable behaviour here. I do see mention of 'iterative' code reviews, which I assume refers to "post, receive answer(s), edit, answers ...
1
vote
1answer
90 views

Self-answering on Code Review? [duplicate]

So, to me it seems like self-answers here at Code Review are bad form. At other SE sites, if you receive answers that help you to the correct answer, normally you'll give those the credit and post ...
1
vote
1answer
55 views

Reviewing unoptimized code in public repo. Are these type of question appropriate?

Currently I have a problem from a system that is not working properly (ref in Stack Overflow). It surely has many issues that might be related to both code optimization (PHP) as well as DB ...
1
vote
1answer
42 views

Authors 'final result' post showing the 'final result' after the answer/corrections/suggestions [duplicate]

The case: Somebody posts code for review then follows up with all the analysis and some of the answers is accepted. The suggestion: Some kind of finalization post by the dev who is asking the ...
1
vote
1answer
44 views

what should our slogan be? [duplicate]

In addition of the logo question I would raise the same question for a slogan. Give in one strong sentence the real meaning of our lovely CR community. One of the things the sentence could contain : ...
1
vote
1answer
177 views

Should we have a [free-pascal] tag?

For a pascal, delphi, pascal-script related question: Pascal / Delphi / Pascal Script tags For a discussion about how the pascal related tags should be organized (as synonymous, for example), please ...
1
vote
1answer
71 views

Further action needed for non-working code that gets fixed here anyway?

This is in regards to Problem in calculating prime numbers in python As you can see from the title, the post is only about a problem and not a code review. The issue at hand also seems to have been ...
1
vote
0answers
54 views

How should I ask on the main site without getting too many downvotes to a piece of code that was a P vs NP attempt? [closed]

I wanted to find out my mistakes in the code that could shorten it all together. I would love to figure out how to address bad variable names Use enumerate instead of python's range Use a better ...
1
vote
0answers
43 views

Posting very simple questions as exemplars [duplicate]

I noticed a couple things that have been pointed out repeatedly. Having an exemplar of that single issue (not a bunch of issues in a long piece of code) can be pointed back to along with a simple ...
1
vote
0answers
51 views

How do I get people to “review my review”? [duplicate]

I wrote a review yesterday for somebody's code. However, since it is out of my specific area of expertise, I would like someone else to give it the once-over, just to make sure I haven't misdirected ...
1
vote
2answers
98 views

Should this question be on hold because of non-real code?

This question had been put on hold with the reason: "Questions must involve real code that you own or maintain. Pseudocode, hypothetical code, or stub code should be replaced by a concrete ...
1
vote
0answers
51 views

“Reviewing” your own code - “minor” optimization change - no previous answer [duplicate]

Do you think is ok to answer your own question with a "minor" optimization? Note: this is a different case from that question because there is no previous answer and I am not aggregating suggestions. ...
1
vote
0answers
46 views

Unworkably slow algorithms and the scope of code review [duplicate]

Over on Stack Overflow, I frequently see exchanges like the following: Questioner: I have to do [algorithmically complex task]. I've written [unworkably naive algorithm that will need to be scrapped],...
1
vote
0answers
46 views

Capitalized i when using ###? [duplicate]

Someone edited my question to change **Some text containing an i** to ### Some text containing an i Which is completely ...
1
vote
0answers
73 views

Can we do away with “someone else's code” wording? [duplicate]

The other day we got the question Python - Print the average of a list which is a value in a dictionary [on hold]. When I came across this question it was being closed for a custom close reason, I can'...
1
vote
0answers
41 views

Are design questions (with actual code) on-topic? [duplicate]

Suppose I'm working on a particular module in my software. I have a proposed design (possibly already implemented or prototyped) that I want feedback on in a tangible format, such as a Java ...
1
vote
0answers
36 views

How should i mention the licence of my code? [duplicate]

When posting code to be reviewed (for instance code that already has been pushed on a github repo), how should I mention the licence of the code ? I definately can't put the licence notice in the ...
1
vote
0answers
37 views

How do we feel about canonical post for repeat review concepts? [duplicate]

I had started to write a question where I felt I was just going to repeat myself in reviews. Well I've been in the city since I was two and I certainly wouldn't say that I was stuck in a rut... stuck ...
1
vote
0answers
38 views

New design cache issues in chat

After a few days with the new design, some other users and I still experienced that the icons when clicking persons in the chat room experienced seeing the old icons. I snagged the followed image: ...
1
vote
0answers
26 views

Is it reasonable to link to a third-party site for review? [duplicate]

I've got a class I'd like to get reviewed but it's 820 lines, and the project where it's hosted at is in a better format than a question code block, I think. You can open it in your editor of choice. ...
1
vote
0answers
27 views

What are the rules on linking to code outside of the question? [duplicate]

Can the code that I want reviewed be linked somewhere else, or must it be contained within the question?
1
vote
0answers
63 views

Is it advisable to share the link of the entire project on Code Review? [duplicate]

I would like someone to review a small PHP project of mine - the entire source code of which has been uploaded on Github. Is it advisable to share the link of the entire project here on Code Review?
1
vote
0answers
41 views

What if there is nothing to review? [duplicate]

The title is self explanatory. Let's say there is the perfect code in a question and the OP is asking for review. Is it bound to become a zombie? Should we say the question is perfect and ask the OP ...
1
vote
1answer
40 views

Question closed with no link to reopen

I found this question marked as closed. It seemed to be asking a genuine question that seemed to be asking for best practices as defined in the scope. Any particular reason it was closed? Also, no ...
1
vote
0answers
84 views

Stack Overflow Worldwide Meetups 2012: You're invited!

We're having a Stack Overflow meetup to get together with fellow programming, web, and other technology enthusiasts. But not all of our programmers and technology enthusiasts live on Stack Overflow, ...
1
vote
0answers
61 views

undocumented effects of indentation on sub-lists

What's the actual rule for sub-list nesting? The documented rules say to indent this sublist entry by 4 spaces, but any indentation from 1 to 7 SEEMS to work. Code block formatting works as ...
0
votes
2answers
178 views

THE Shouting sitename

status-bydesign This is intended and will remain in current shape. The site name in the upper left is in capital letters CODE REVIEW which just isn't right. The same goes with meta. To clarify why ...
0
votes
4answers
86 views

Confusing phrasing of the “off-topic” close reason

Before asking my last question, I've double checked what counts as off-topic and on-topic in this SE. According to my findings: We require that the code be working correctly, to the best of the ...
0
votes
2answers
33 views

Answer deleted/converted to comment- can't fathom why

This is on the Code Review site. Someone posted their code for building a SQL Connection String. My answer points them to the Microsoft class whose purpose is to do this exactly: Prompting user for ...
0
votes
2answers
138 views

Dialog is difficult… why isn't there a linting tool? [closed]

I think this site needs a lot more work for it to become a good open-source code review platform. Otherwise, it will be blind-sided by something else soon enough! My biggest bug bears are: No sane ...
0
votes
2answers
58 views

Peculiar application of [reinventing-the-wheel] tag on my question

My question has been edited by a moderator to include the tag reinventing-the-wheel. Allthough I did state I am not relying on libraries like cats even if they might already provide solutions for ...
0
votes
2answers
78 views

Why has my suggested edit to rename some variables in an answer been rejected?

I have made an edit to this answer about 'Lissajous pattern simulator' to replace misleading names of two varables xStart and ...
0
votes
1answer
85 views

Why is my self answer being downvoted?

I have shown that my code works. I have corrected people that they were wrong when they said my code does not create valid Sudoku. I'm awaiting valid reasons why my answer is being downvoted. If you ...
0
votes
2answers
98 views

Are comments asking the applications purpose really relevant?

I've asked for a review on the way that I'm populating some comboboxes in a datagrid. One commenter asked what the purpose of the application was. Are those comments really relevant to a code review? ...
0
votes
2answers
94 views

Why am I getting downvotes for not working code when it's working code?

I've become a little frustrated with Code Review. They said my code does not output a valid Sudoku when it in fact does. Is it that people are confused of my code and don't realize that it's in fact ...
0
votes
2answers
60 views

An edit of mine was rolled back and the question locked

I asked this question: Templated division by a power of 2 and did not include an #include directive before my actual code. An answer noted the ...
0
votes
2answers
244 views

To serve, what is it to ask for review?

Food for thought. There are times when questions come along which demonstrate a student's query, and with that comes the student's ill fated attempt to pose an "on topic" question without ...
0
votes
1answer
65 views

Can I ask questions about where my code went wrong in algorithms and problem solving?

I have recently started solving problems with Python. Many of the programming problems involve complex algorithms and are hard to solve. I need help knowing if the code I've written produces wrong ...
0
votes
2answers
105 views

Readability oriented coding conventions

I think it would greatly help reviewers if we decide upon and adopt guidelines on readability oriented coding conventions. A few examples: Blocks One space between arguments, no new line braces <...
0
votes
2answers
44 views

Are mods allowed to answer non-meta questions?

This may seem like a very simple question with a very simple answer, but it’s been bugging me. Having looked through hundreds of answers on questions on the regular site, I only see answers from ...
0
votes
1answer
58 views

Is it ok to post code that didn't work out as intended?

I recently tried to optimize some code by using parallel processing, putting two cores to work on the problem instead of one. For whatever reason, it didn't work. I don't know why, but I doubt much ...
0
votes
3answers
101 views

Reviewing Inexperience vs Reviewing Style

I just recently Posted a Review Question and got some fantastic feedback. Exactly the point of this site. Although IMO I processed 3 separate 'types' of review points. You Missed X, (In my case an ...
0
votes
1answer
49 views

Is this tag bad [form] for this site?

Quoting the Tag-Wiki: An HTML form is a section of a document containing normal content, markup, special elements called controls (checkboxes, radio buttons, menus, etc.), and labels on those ...
0
votes
1answer
54 views

Is it on topic here for questions not about specific code but rather how to manage the code?

Title explains it: I want to ask a question about maintaining branches of a single project and I'm not sure if it's on topic. If not, is there anywhere that it would be on topic?
0
votes
1answer
42 views

Clarify edit review screen

The pending edit screen is very confusing to me as someone who has never seen it before: It says I have 0 edits rejected. The rejection notice on the second line uses "this" vaguely. This question? ...
0
votes
1answer
75 views

Is it OK to ask how to revise a golfed function?

After reading through a few question on here I found out that asking questions about refining code golf code is not on topic. However in this case I'm not asking for the code to be golfed but re-...
0
votes
1answer
42 views

Posting code with different licence [duplicate]

Can I post a question about some of my code that I want to have a different licence under? Say I want someone to review my code but have it posted so that a license covers it for not to be re-used or ...
0
votes
1answer
39 views

Are questions asking for opinion regarding all edge cases on topic?

I have been away from code review for some time and not sure on the scope agreed upon in the community. So is this question on topic or off topic? Basically the below is on topic or not? Will the ...
0
votes
1answer
79 views

What do we do with out-of-sync questions?

This question is now in somewhat of a bad state. The OP did significant rewrites of their question, and then received an answer. Not realizing the sequence of events, I rolled the question back to ...
0
votes
2answers
57 views

Why don't we have a close reason like “off-topic because of asking to find a 3rd party resource” like SO has? Or at least a “Blatantly off-topic”?

I recently came over this question I am trying to implement duplicate file finder in visual C++. I followed this link Successful implementation of Duplicate Files Finder in C++ But it don't ...