Questions tagged [editing]

Editing is a core, fundamental Stack Exchange value; we allow editing by registered and unregistered users (if peer reviewed).

Filter by
Sorted by
Tagged with
29
votes
3answers
789 views

Should you edit someone else's code in a question?

I have seen several (suggested) reviews lately, where someone edits the code in the original poster's question. Should such edits be allowed? The edits in question are mostly minor. Some add spaces ...
20
votes
2answers
218 views

Should code be forcibly translated into English?

In Sieve prime generator C++, a user translated some French strings into English, and the edit got approved. In toBase64 encoder, the author replaced Russian strings and comments with English in ...
19
votes
2answers
203 views

Can I edit broken code if I'm sure I'm recreating OP's original code?

I know, I know: "Never edit the code, leave it for the review!". But please, hear me out before answering. What should I do if I encounter a code that doesn't work, but I'm 99.99% sure it's because ...
18
votes
3answers
217 views

What are our answer editing guidelines?

On this site, we have a well-known policy on editing code in questions: Don't. After all, that code is up for review, in all its glorious ugliness and buginess. But clearly, such reasoning cannot ...
15
votes
2answers
130 views

Over-editing my own answer

It looks that I have just over-edited my own (first!) answer and got a comment: Please try to keep the edits down to a minimal now. Thanks! I was wondering what has just happened, searched a bit ...
14
votes
1answer
92 views

Do we want site-specific editing guidance?

With our newly reached "graduated" (I really shouldn't put that in quotes) status, I expect a significant influx of new users, be it through migration or otherwise being drawn in by the thrill of a ...
12
votes
3answers
105 views

Editing in missing #includes

The off-topic list at meta includes: Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review. So questions must compile ...
12
votes
3answers
238 views

Removing leading white space in question code blocks

I've made a couple of suggested edits to this question. The first one was rejected because it deviated from he original intent / it edited code. When I looked at the suggested edit, it did look like ...
12
votes
2answers
93 views

Regarding editing questions

I'm confused about several aspects of editing, specifically editing questions. I often see editors such as the speedy Jamal and others making relatively minor edits (such as changing "i" to "I"). ...
11
votes
2answers
173 views

Indentation in answers

I've noticed that on three occasions now (1, 2, 3) people have edited my answers and removed the indentation that I had left in quotes from OP's code and in suggested replacements. One went so far as ...
11
votes
1answer
108 views

Reviewing a question that doesn't belong

There is currently a question on hold, which really should never have been posted to Code Review, but I think it actually highlights a point that would be worth an answer. I started to edit the ...
11
votes
2answers
68 views

Is it okay to convert a question code block into a working snippet?

We tend to leave the source code alone as all aspects are valid for code review. But, questions like these are just asking to be converted to a snippet ( there's a link to JsFiddle even!) Just wanted ...
10
votes
3answers
138 views

Is it okay to modify code in a post if we've discovered a bug, before receiving an answer?

Assuming that I have a posted a question with working code, and I've discovered a bug in it without the help of an answer, is it okay to edit the code in the post with a fix?
10
votes
2answers
220 views

Is it allowed to edit code if there is no answer?

If I have kept working on the code, and there are no answers (say one week after the original post), am I allowed to edit the code to reflect the changes I have made to it? I believe this question is ...
10
votes
2answers
74 views

Editing closed/on-hold questions

I'm allergic to a number of things: Bad titles ("please review my code"), tags in title Wrong tags being used Typos and grammar issues Is it ok to edit questions for these reasons? When wouldn't it ...
10
votes
2answers
114 views

Can I edit parts of the code blocks that aren't part of the code itself?

First off, this question is related to several other meta posts, but as far as I can tell none of the questions cover it. First a list of similar questions and why they are different: Is it ...
10
votes
1answer
98 views

Non-OP edits to change the original question to make it on-topic

I feel that this topic is ambiguous at the current time, and I would like some clarification. When I see a question that is obviously, or at least appears to be off-topic based on how it is worded, my ...
10
votes
0answers
97 views

Removing tags in title [duplicate]

I just removed 5 (scheme) tags from 5 questions. Some examples: Before: (Scheme) [SICP ex. 1.30] Iterative Sum After: [SICP ex. 1.30] Iterative Sum They were all in the similar format: Before: (...
9
votes
3answers
160 views

Does the plain-English part of a question even matter?

Does the plain-English part of a question even matter? I'm not recommending that the plain-English part doesn't help make questions better, but given the approach we've taken towards answers on ...
9
votes
1answer
44 views

Updating cross-posts, where the author has done so, on a different site

The question I refer to is this one. It has been cross-posted from Stack Overflow, it hasn't received any reviews yet, however, it has been edited on SO, but not on CR. The edits made (indentation ...
8
votes
2answers
133 views

When is an edit considered enough to be acceptable?

A mod edited one of my questions I've made today (For the curious: Class Object to create objects of type Object, in a dynamic way, with magic methods). The changes are so minimal that I have no idea ...
8
votes
2answers
132 views

Why SED over sed?

I was browsing edits, and I noticed a change from sed to SED. This came in parallel with a change from awk to AWK. I follow the capitalization of AWK. Not sure that I agree, but AWK is an acronym ...
8
votes
1answer
142 views

Does a question with (a lot of) OP response to a posted review qualify for a rollback?

I'm not really sure whether this question where OP has added a lot of feedback about one of the reviews actually qualifies for a rollback. The code is not changed and OP also hasn't added any ...
8
votes
2answers
231 views

Increase number of edits before post becomes community wiki

According to this answer on meta.stackoverflow.com: Posts enter community wiki mode when one of the following happens: [...] The post has been edited ten (10) times by the original owner. Typical ...
8
votes
1answer
85 views

Questions containing false statements: Edit or Answer?

https://codereview.stackexchange.com/review/suggested-edits/24111 The asker posts a false statement: "This code runs in time complexity X." Should they be corrected in an answer or in an edit? ... or ...
7
votes
1answer
103 views

Should we improve the code to be reviewed in an edit?

I noticed this suggest edit: This suggested edit does two things: Replace using namespace std;, which is considered bad practice in C++, with ...
7
votes
2answers
121 views

On/off-topicness of “conclusions” added to the original question

I wonder what is your opinion about on/off-topicness of conclusions added to the original question like it has be done here at the bottom? Should such edits be rejected and a self-answer posted ...
7
votes
2answers
107 views

Is this edit okay?

A struct within a class, and this is the edit history: https://codereview.stackexchange.com/posts/60534/revisions The original code include this method: ...
7
votes
2answers
245 views

Is it okay to edit part(s) of code not yet reviewed?

In this question of mine, the one answerer so far has only reviewed a part of my code. However, I've made changes on other parts of my code, but I don't want to somehow invalidate that answer. Would ...
7
votes
2answers
266 views

Suggested edit breaks license due to pastebin

I am not a lawyer. I am reviewing a suggested edit where a user created a jsFiddle from the code in someone elses question. I believe this breaches the CC-BY-SA 3.0 license that the code in the ...
7
votes
2answers
99 views

How should question bodies be organized?

The format that I know for question bodies is: Intro, often explaining where the problem originated. A problem statement explaining what the code is supposed to do. Perhaps a little more ...
7
votes
1answer
60 views

Ability to edit self-deleted questions

I understand that preventing edits on deleted answers can help defeat FGITW (Fastest Gun In The West) problems on other sites (or here?), but it seems deleted questions cannot be edited either. This ...
7
votes
1answer
134 views

Good question, but OP didn't know how to ask it?

In Calculating Julian dates, the author asks a question that doesn't make sense: Refactor this code so that I don't have to insert the parameters any time I need to use one of the functions. [....
7
votes
0answers
69 views

Would it be possible to have the question closer to the answer field?

I find that when answering a question on Code Review, I'm constantly scrolling to the top of the page, copying some code, scrolling to the bottom, pasting it, then editing it. I do this over and over. ...
6
votes
2answers
112 views

Advice for reviewing edits

I just became eligible to approve pending edits and would like some advice. At the time of writing, this post has a pending edit: Finding similarities between images The edit changes the code ...
6
votes
3answers
125 views

Is it okay for OP to edit to include Benchmarking results?

The question is whether it should be allowed for the OP to edit to include timings of answers to a code related to benchmarking. Currently, there is a moderator who doesn't like this for this question....
6
votes
1answer
118 views

Major edits made to my question about using a string or array to index object in JavaScript

I have a question about my post: Dynamic way to use string/array as index of object in javascript I see that my first attempt at this question was outside the scope of what I should ask at Code ...
6
votes
2answers
99 views

Is adding a single tag enough to constitute a meaningful edit?

Just now, it appears that the Suggested Edits review queue is full to the brim with a single user adding the performance tag to a lot of questions while leaving the content otherwise untouched. I ...
6
votes
1answer
115 views

Is it appropriate to prune code blocks by editing out irrelevant Javadoc comments?

I've just did a compulsive edit on this question, essentially removing @author, @version and ...
5
votes
4answers
117 views

Are minor edits to old meta questions useful?

That's a view from the "active" page on the Code Review meta. The edits are mostly minor. And some of them are coming from quite old questions, even questions with the status-completed tag. Like ...
5
votes
1answer
55 views

Blockquotes and formatting

In many, many, many, many or my recent questions, I've [mis]used blockquotes to separate code files. I always do it like this: Identifier type of code file As in Foo class and IFoo interface I ...
5
votes
3answers
156 views

Can an OP add missing keyword(s) to code?

In Recursive conversion from ExpandoObject to Dictionary<string, object> the OP omitted the keyword private, and after ...
4
votes
2answers
43 views

Missing edit-tags rollover

I can't hover over the spot next to the tags for an "edit tags" button anymore: This used to work before the graduation, but now I have to click on edit and I am too lazy for that.
4
votes
1answer
66 views

Number list formatting followed by code formatting issue

On this question, I found that when I tried to edit the question and add a numbered list format, it sucked in the code formatting that followed, so I had to add ...
4
votes
2answers
48 views

Edits change the main topic of my question. Have I done things wrong?

Recently, I posted the following question on Code Review: Convert ES6 yield recursive method to a loop At the beginning I post a question with actual code, asking if there is a way to write the same ...
4
votes
2answers
119 views

Should we allow answer invalidation for otherwise off-topic questions? [duplicate]

We recently had a question with un-compilable code. The question was answered and the answerer pointed out the broken code. The user has since edited the question to fix the code. It was rolled-back. ...
4
votes
1answer
72 views

Duplicate answers - clean them up?

This question (originially from Stack Overflow) has heaps of duplicate answers. Many users suggested the exact same changes to the code, presumably while the question was not yet migrated; most of the ...
3
votes
3answers
101 views

Question author updated the code as a diff. Should I have applied the patch?

Project Euler, Challenge #12 in Swift If editing in the edit keeps the question clear, should we edit the edit into the question instead of leaving it as two separate blocks of code? It seemed ...
3
votes
2answers
119 views

Is it appropriate to edit excessive line breaks from code?

Some questions (2) have quite a few extra lines which are kind of unnecessary. I guess they could be attributed to "style" but in my opinion they make to more lines and less to readable code. For ...
3
votes
2answers
148 views

Unmodified question looks modified

This is maybe the fourth time I noticed this scenario since the start of this year, so I am curious to know if you have an explanation: When I clicked on Questions, I saw this: But when I clicked to ...