Questions tagged [scope]
Use this tag when examining what is on-topic or off-topic, and why.
287
questions
15
votes
3
answers
216
views
Are code snippets with known memory leaks broken?
As part of our check-list for questions on CodeReview, we require that code is working to the best of the askers knowledge.
Does code with a known memory leak qualify is broken per this rule?
On the ...
37
votes
4
answers
623
views
Code Review vs. Help me solve my problem
A question that asks:
I don't know how to best solve problem X, can you suggest a way?
... is clearly off-topic on Code Review.
A question that asks:
I have solved problem X, and this is how I ...
19
votes
3
answers
217
views
Reviewing AI based on how it performs
On Code Golf is is common to see a king-of-the-hill question where you have to implement an AI based on the rules given in the question.
So then I got to thinking - "If I developed an AI for one of ...
6
votes
1
answer
176
views
Is this slow-loading images question off-topic?
This question was closed for asking for code to be written, but I think it is really asking how to speed up the loading of images, which I would think is performance related, which is something that ...
12
votes
5
answers
240
views
Questions about interfaces, protocols, and APIs
Are questions about interfaces/protocols and APIs on-topic for Code Review?
And when I say "protocol", I mean this in the Objective-C/Swift (and potentially other languages) version of the word, ...
5
votes
1
answer
91
views
Questions about speed/memory comparisons
This question should be considered as an expansion discussion on the policy discussed in Should comparisons of code snippets be closed as "not seeking a code review"?
For comparative ...
9
votes
2
answers
73
views
Does a good posted answer make the question on topic regardless of content?
There exists a relatively well defined set of rules in the Help Center that help guide us to deciding what sorts of questions are on-topic and should remain open versus what sorts of questions are off-...
7
votes
7
answers
293
views
"Code not yet written" clarification: Are unimplemented interfaces on- or off-topic?
I would like to know what exactly it means. The reason for asking is my question which was recently put on hold:
https://codereview.stackexchange.com/questions/60108/async-task-queue-design
Can ...
10
votes
3
answers
169
views
Does the plain-English part of a question even matter?
Does the plain-English part of a question even matter?
I'm not recommending that the plain-English part doesn't help make questions better, but given the approach we've taken towards answers on ...
18
votes
1
answer
170
views
What's on and off topic in The 2nd Monitor chat room?
Exactly what is considered strictly off-topic there?
Anyone can assume the obvious: NSFW (Not Safe for Work) are off topic, and should be flagged.
Anything else?
12
votes
2
answers
335
views
OP says it works, the contest engine says it doesn't
What do we do when OP says his solution works, but the contest engine says it doesn't? Should we give it the benefit of the doubt, as "It works to the best of my knowledge.", or close it as broken ...
12
votes
3
answers
298
views
Are requests to diagnose a known security problem on-topic?
In PHP mail form is being abused, the question asks for help finding how an e-mail script got exploited.
Finding security problems is normally within the scope of Code Review, and we routinely point ...
16
votes
5
answers
407
views
Can we revisit "Did I write that code myself"?
Did I write that code myself?
This is one of the six questions the help center recommends users should be able to answer "Yes" to before posting their question.
I'm not sure I quite understand ...
8
votes
2
answers
149
views
Is a bad approach for a problem a good reason to close a question?
Related meta question, regarding the inverse of this question: Is solely suggesting another solution a bad answer?
See Accelerate OpenGL 2D on Python3 and Finding Primes in Java.
These questions ...
8
votes
2
answers
98
views
Questions about code translation
Translate C++ code to Haskell
This question was put on hold and then deleted by the user. And for this specific question, I think that is fine. It was off-topic as it didn't include the translated ...
8
votes
2
answers
173
views
Can we answer these Javascript/CSS3 performance questions?
I've seen that lately the amount of questions regarding performance issues when using Javascript, jQuery, CSS3, etc. has increased.
Question is: Can we actually review them?
I'm edging towards no, ...
9
votes
2
answers
130
views
Is it really off-topic to ask for the explanation of a "best practice"
This question was put on hold for being off-topic:
https://codereview.stackexchange.com/questions/58091/why-is-it-suggested-to-replace-temp-with-query
To refactor the code, it is suggested here to ...
12
votes
1
answer
302
views
"Enough reviewable code"
Passing Row Index of TableViewCell (custom) to another view controller
The following claim is made in the asker's question:
Pseudo Code: (pasted only necessary code)
Let's start with the ...
16
votes
3
answers
207
views
Can we review spreadsheet formulas?
So, this question has been bothering me for a long time now. It is asking for a review of one line of "code" which is really a spreadsheet formula.
Actually, it's not even asking for a review in my ...
7
votes
1
answer
126
views
Can I ask a question about overall architecture without much specific code?
I have code, but my question is about overall design patterns. Ideally, I would ask a question describing the design decisions made in my project but would have minimal actual code samples.
Is this ...
1
vote
1
answer
65
views
What is the relationship between "example code" and "example project?"
A handful of people seem to have formed the opinion that an example project is exempt from this topicality constraint:
Is it actual code from a project rather than pseudo-code or example code?
The ...
15
votes
3
answers
289
views
The gray areas of Code Review: Hypothetical / Example code
This is related to Why is hypothetical example code off-topic for Code Review?
Which is related to On-Topic question #3:
Is it actual code from a project rather than pseudo-code or example code?
...
9
votes
2
answers
128
views
Reviewing software, not only code
I'm looking for some people/community who are doing each others' software reviews, but not only code. Actually code is the least important. I would like somebody look at my software as a whole and ...
7
votes
1
answer
86
views
Asking for comparison of design of two code snippets giving same functionality
I had asked for the review of the part of a jQuery and as per the answer I made changes in the file. Now after making the changes (mainly moving from triggers to functions) I am not so sure whether I ...
12
votes
4
answers
111
views
Are Git workflow questions on-topic?
I recently started working part time in our organization's IT department and am working with one other person who has previously been the sole developer on several applications used in the office. We ...
24
votes
4
answers
538
views
Reviewing "design"
It has been said in various comments that on Code Review we review code and not design.
I find this statement not very clear though. Obviously, if someone has an UML and not any written code, that's ...
6
votes
3
answers
197
views
Are SSCCEs off-topic?
I was recently reviewing a question, which (if I had paid better attention to the question from the beginning, I may have noticed before answering) had a SSCCE as its primary code example.
At first ...
12
votes
4
answers
179
views
Can working code be: off-topic -> not-working?
This question here: Shortest possible way of printing a specific board
Summary:
The code requirement is to print out a grid of text.
The code does in fact print the grid
The way it does that, is ...
13
votes
4
answers
191
views
Off-topic questions that are still reviewable
There are some questions that are technically off-topic but still feel that the code really needs our help.
For example: https://codereview.stackexchange.com/questions/49347/tic-tac-toe-artificial-...
11
votes
2
answers
71
views
Multithreading issue freezes the system - working code?
This question was closed as non-working code, in spite of the following, from the OP:
THe [sic] problem is that this implementation makes the CPU of the machine where the service app is running go ...
9
votes
2
answers
71
views
Are reviews of protocols in scope here?
The rules for this 'exchange state quite clearly that discussion of
Higher-level architecture and design of software systems [...] is off-topic for this site.
However, I'm wondering if we might ...
18
votes
4
answers
374
views
Should comparisons of code snippets be closed as "not seeking a code review"?
I've been seeing some "A vs. B" questions for a while, and I'm not sure if they're considered on-topic for this site. Many of these questions are not asking for a review, but which code snippet is ...
29
votes
4
answers
2k
views
Why is hypothetical example code off-topic for Code Review?
As stated in the Help Center, one of the criteria for a question to be on topic is:
Is it actual code from a project rather than pseudo-code or hypothetical code?
Details matter! In order to give ...
9
votes
5
answers
149
views
Make the help center more explicit about what CR is NOT
There has been discussion recently, about how lots of Stack Overflow users carelessly refer OP over here (CR) whenever the question roughly looks like a wall of code and OP is asking for help nailing ...
9
votes
1
answer
71
views
Ask for review on JavaScript code style/structure, usage of patterns, and general quality of the solution
I have code I want to get reviews for. It's not a particular problem, and the code actually works wonders.
I just want to see what other experts can suggest in order to make it better, improve style,...
15
votes
4
answers
230
views
Code requiring a third-party pre-processor to make it work
In this Wolves, Goats and Cabbages in Java question (here is a link to the pre-edited version), Java code is presented to solve the problem.
The code requires pre-processing by a third-party tool in ...
17
votes
3
answers
228
views
Does this question belong on Code Review? Should it go to Code Golf?
I posted this question about how to rewrite a C# algorithm in fewer lines of code, preferably using extension methods, which prompted a discussion in the comments about whether it was appropriate for ...
11
votes
4
answers
209
views
Revising or removing the "Best practices" topicality rule
In the Help Center, under What topics can I ask about here?, one of the rules currently states:
However, if your question is not about a particular piece of code and instead is a generally ...
25
votes
5
answers
348
views
Do one-liners and other narrowed-down code qualify for a code review?
Every once in a blue moon, a question gets posted (often as a new user's first post) where the OP is asking a quite specific question about very minimalistic code, for example:
...
15
votes
4
answers
109
views
Questions about documentation
Are questions about writing/improving documentation appropriate and on-topic for Code Review? And if so, should there be a documentation tag?
Let's be clear--I'm not talking about questions seeking ...
10
votes
1
answer
132
views
What to do when working, non-example code is too much code?
In this question, I'm trying to ask about best practices for inner classes in Java, but it got closed because I only posted the code skeleton of the class structure and important methods.
The problem ...
14
votes
3
answers
159
views
"How secure..." questions - Code Review vs. Information Security SE
Recently I have seen a whole lot of questions in the form of "How secure is this hashing", "How secure is my keygen?", "How secure is my form?".
We do have a quite popular security tag, with 159 ...
6
votes
3
answers
90
views
Are questions on design only requiring minimal code off topic?
I asked this question which someone has flagged as off topic, referencing a question that referred to pseudo code as a reason. My question is in regards to the overall design and not changes to how ...
13
votes
1
answer
202
views
What does it take to make code your own?
This question is meant as a general question, but it is also specifically about this specific question:
https://codereview.stackexchange.com/questions/39228/original-factorial-method-in-java/
It is ...
6
votes
1
answer
59
views
Are these [performance] questions on-topic?
These two questions were posted by the same user, in August - the user joined CR around that time:
Capture with User32.dll or hook?
Encoding a screenshot to JPEG and saving it to a memorystream
Both ...
4
votes
2
answers
104
views
Is this grossly incomplete code okay?
Shortening code to create a JFrame
The user has working code (I assume), but they haven't even started writing the logic for their game. They've just instantiated Java's version of a main window/...
4
votes
1
answer
97
views
Does database normalization belong here?
As of today, we have four questions in the normalization-tag. One of these has already been closed, and the other three don't exactly look 100% on-topic to me as they don't include any SQL code but ...
15
votes
4
answers
674
views
Questions should include a description of what the code does
Related:
What criteria do you use to upvote a question?
What makes a good question?
I feel that it is currently too easy to copy some code that you have written and put it up for review here on Code ...
2
votes
1
answer
63
views
Reviewing unoptimized code in public repo. Are these type of question appropriate?
Currently I have a problem from a system that is not working properly (ref in Stack Overflow). It surely has many issues that might be related to both code optimization (PHP) as well as DB ...
5
votes
2
answers
83
views
How can I make my question on-topic?
Connecting to Oracle using ODP.NET
I was told in the comments that it is off-topic, and someone has also downvoted it without any explanation.
I have shown code that works fine and want it reviewed. ...