Questions tagged [site-policy]

Site-Policy is the way the main site is run and managed - processes, procedures, and routines that should be followed. Use this tag when you believe site-policy has not been applied correctly to a main-site question, or when you believe existing site policies should be modified, or new policies added.

Filter by
Sorted by
Tagged with
39
votes
2answers
1k views

Can I put my code on a third party site and link to the site in my question?

Is it OK if I write a question and include a link to GitHub/Pastebin/other similar site instead of putting the code here on Code Review?
34
votes
2answers
1k views

Why is only my own written code on-topic?

I tend to disagree with point #2 on the Help Center: Did I write that code? I believe any code, written by one self or anyone else should be eligible for code review. Many a times, you're ...
15
votes
4answers
550 views

Questions should include a description of what the code does

Related: What criteria do you use to upvote a question? What makes a good question? I feel that it is currently too easy to copy some code that you have written and put it up for review here on Code ...
1
vote
1answer
49 views

Reviewing unoptimized code in public repo. Are these type of question appropriate?

Currently I have a problem from a system that is not working properly (ref in Stack Overflow). It surely has many issues that might be related to both code optimization (PHP) as well as DB ...
5
votes
1answer
282 views

Is this appropriate for codereview.SE?

I had some confusions about a particular piece of code that I wrote: Thoughts on refactoring a generic DAO. I placed it on programmers.SE when I thought it was just a design thing. Now I am thinking ...
11
votes
3answers
180 views

Could incomplete or not-quite-working code be suitable for review?

I've noticed that sometimes I end up reviewing code despite the question's violation of our policy that it must contain working code. I bring this issue up because it is related to Changing wording ...
40
votes
1answer
1k views

How to post a follow-up question?

Sometimes I stumble upon follow-up questions, where code is being posted again after having gone through a review (or two). Examples of possible sets of follow up questions: Find missing numbers - ...
3
votes
5answers
287 views

Complaint about rollback policy / bug fixes

I posted some useful code on code review. One of the answers suggested an improvement to the code. I agreed and made the improvement to the code, and left the comment "Thanks, fixed". A moderator ...
6
votes
2answers
72 views

Is asking for correctness check on-topic or not?

As per this and this question on meta, asking about correctness is on-topic yet this question was closed. The comment given was: This question appears to be off-topic because it is about reviewing ...
3
votes
1answer
31 views

“SQL sometimes times out” - on or off topic?

No question similar to this came up in the fancy box, so I am going to ask it so that it can be referenced. Store Procedure Timing out sometimes? It gives code that sometimes times out for the user, ...
13
votes
2answers
137 views

Is asking for review of 3rd party code ok?

Most code people are posting here seems to be code they have written themselves. In this question the OP asked basically for a review of three 3rd party scripts. I'm not sure that this question is a ...
9
votes
1answer
124 views

Reviewing usefulness of code

I was wondering if, as part of asking for a review here, can I ask about how useful my code is? That is, getting feedback about what possible use-cases the code I have written has and if people would ...
12
votes
4answers
177 views

Do we need to revisit code-golf questions?

The question of the role of code-golf on CodeReview was raised back in April. There was very little discussion, but there seemed to be a strong consensus at the time among meta users that code golf ...
6
votes
3answers
91 views

Can I ask a question to review an FAQ written on a third-party site?

I wrote an FAQ on a third-party website related to Delphi and thread-protection of objects. I need some feedback if this content is adequate or not. I was wondering can I ask a question on Code Review ...
4
votes
1answer
86 views

Can pseudo code be used be used as a clarification to the problem in addition to the code you want reviewed?

So I believe in not submitting pseudo code to be reviewed or as an answer and it is clearly decided against here. I had a question about code where I knew of an alternative approach to solve the ...
18
votes
2answers
353 views

Should code block(s) as answers always require an explanation?

Here is a great example of this. Granted, that was that user's first post, but this is still common. UPDATE: That example has since been updated, so consult the original version. This type of ...
15
votes
1answer
134 views

Handling Asker not learning from previous reviews

Recently, a certain user has asked three times for code reviews in quick succession, for different parts of a project he is doing. This in itself is perfectly fine. However, he does not seem to have ...
9
votes
1answer
146 views

What's the proper way to ask for database review?

I'm currently designing a database that I wanted to get some input on. It's entirely theoretical at this point, I haven't written a single line of SQL. Would it be acceptable to just post the database ...
2
votes
0answers
96 views

Specific questions about design

I have some confusion whether specific question which are asking about design off-topic or on-topic? Specifically these 2 questions are confusing me Are private extension methods a bad thing to use? ...
15
votes
2answers
567 views

Should specific questions about example code be on-topic?

I've noticed some questions, like the following, come up: https://codereview.stackexchange.com/questions/30092/map-then-iterate-why Inheritance and forcing methods to be called inside another method ...
1
vote
1answer
66 views

Further action needed for non-working code that gets fixed here anyway?

This is in regards to Problem in calculating prime numbers in python As you can see from the title, the post is only about a problem and not a code review. The issue at hand also seems to have been ...
10
votes
1answer
217 views

Should mostly working but a little bit broken code stay or be deleted?

I posted the question Parsing structured text in Java At first I thought it was working, later I have found a bug in the code. Should it stay or should it be deleted? Update: I have fixed the bug in ...
0
votes
2answers
93 views

Are comments asking the applications purpose really relevant?

I've asked for a review on the way that I'm populating some comboboxes in a datagrid. One commenter asked what the purpose of the application was. Are those comments really relevant to a code review? ...
3
votes
1answer
101 views

Should quick fixes to non-working code go into comments only?

I've started thinking about this after seeing the answer for this question. Of course, non-working code shouldn't be posted here. However, there are times where someone addresses such issues in an ...
16
votes
4answers
335 views

Should a post with no specific question(s) imply a general review?

I've started thinking about this more after seeing this question. I'm sometimes tempted to vote such questions as not clear what you're asking, but I also feel that it's not quite needed for this ...
6
votes
1answer
74 views

What if OP has doubts about the code being working?

I was browsing questions and found this question. In this the OP states that the code is working according to him but someone told him that it isn't working. What kind of review should be done in ...
14
votes
3answers
204 views

Should name of programming language be in the title of a question?

Almost every question on the website has the name of the programming language in its title. Also words like feedback, review etc. are unneeded I think as that is this website's purpose. I wanted the ...
29
votes
3answers
737 views

Should you edit someone else's code in a question?

I have seen several (suggested) reviews lately, where someone edits the code in the original poster's question. Should such edits be allowed? The edits in question are mostly minor. Some add spaces ...
8
votes
1answer
381 views

Someone's code too bad to review

What if someone posted a code to review and he/she doesn't have the basic knowledge or logical approach of the programming language they are using and their code doesn't make any sense; should i 1) ...
7
votes
2answers
234 views

Is it okay to edit part(s) of code not yet reviewed?

In this question of mine, the one answerer so far has only reviewed a part of my code. However, I've made changes on other parts of my code, but I don't want to somehow invalidate that answer. Would ...
2
votes
1answer
64 views

Is it Acceptable to Ask questions Based Upon and Entire solution Uploaded to SkyDrive? [duplicate]

All, I am new to WPF and I have a basic application that I am using to learn MVVM etc. Now, I have an issue with data binding to a DataGrid but due to the verbosity ...
11
votes
2answers
137 views

Should we help others reinvent the wheel?

I've seen a lot of people asking us to review their DBAL, or MVC framework, or templating system, etc. While I totally support these people's efforts as a good way to learn, I think answering such ...
0
votes
1answer
35 views

Would code review be a good place to ask for a review of a presentation?

I have a presentation on AMD and I need a few good reviews on it. Would this type of "review" be a good fit for the site?
10
votes
1answer
134 views

Questions that ask for you to e-mail them to get the code

What is the appropriate way to handle a question that doesn't post the code to review, but posts an e-mail address that you can I assume e-mail and get the code? A (now-deleted) example is: ...
13
votes
2answers
214 views

Can graphical notation count as code or should questions with exclusively graphical notation be considered off topic?

As a community, are we willing to accept graphical notation as a form of code that is subject to code review? I recently answered a question that asked for review of a database model as presented in ...
14
votes
2answers
232 views

What if we have an entire (small) application we want reviewed?

I asked about this on Stack Overflow, and was referred here (to Code Review), though I still think it may be out of scope for CR. https://stackoverflow.com/questions/12749863/where-can-a-n00b-...
11
votes
1answer
359 views

Is pseudo-code alright when asking about performance?

The FAQ states: Is it actual code from a project rather then pseudo-code or example code? But oftentimes pseudo-code is a lot more straight forward and easy to evaluate. It also applies to a ...
3
votes
1answer
188 views

Why is pseudocode not allowed?

Re: C# code to derive tangential points between two circles to create a trapezoid I made the following comment, but since I will probably delete the OP (if I can), I'll post it here: "With all due ...
20
votes
3answers
356 views

Is it okay to add someone else's linked code to the question?

Some questions link to the code they want reviewed, which is against site policy. Should one edit the code into the question in these cases? The problem I see is that all content on Stack Exchange ...
14
votes
1answer
119 views

Code-correctness in the FAQ

As pointed by the poster of this question: https://codereview.stackexchange.com/questions/8609/dynamic-programming-algorithm-code-review, our FAQ states the following is on-topic: Code correctness ...
16
votes
1answer
279 views

Put into FAQ: “Will submitted code be licensed under the copyleft CC-BY-SA?”

Put into FAQ: Will submitted code be licensed under the copyleft Creative Commons Attribution-ShareAlike (CC-BY-SA) license? I really want to know this! Since the CC-BY-SA is a copyleft, viral ...
4
votes
2answers
119 views

Move insufficiently answered question to stackoverflow?

More than 3 weeks ago I posted a question on Code Review asking help with naming a module I created. I did not receive any answers, so I was wondering whether it would be okay to move it to ...
6
votes
1answer
95 views

Would Code Review be a good site to post architectural issues?

I have a question that involves some code, however it's more of an architectural question and I'm torn whether to post it on Code Review or Stack Overflow. I feel like it may be a bit of a grey area, ...
12
votes
2answers
131 views

Confused by FAQ

The FAQ states [emphasis mine]: Code Review - Stack Exchange is for sharing code from projects you are working on for peer review. If you are looking for specific feedback about… Code ...
16
votes
1answer
296 views

How long can code be?

First of all before, I hate the typical "codez plz" homework question. I hope this has nothing to do with that, but it is actually a class assignment. I won't post my code until it is completely ...
9
votes
1answer
152 views

Textbook questions on Code Review

I have answered to four Scheme-related code review requests on the site, which are for proposed solutions to exercises from a famous text book Structure and Interpretation of Computer Programs (...
5
votes
1answer
192 views

Which is the better fit — Code Review or Stack Overflow?

In the CR question "Terminating a C loop when maximum hardware limit reached" the use of a positive sum wrapping to a negative value is used to terminate the loop. The queston was posted to Code ...
8
votes
2answers
133 views

Can I ask for a review on a website?

Is this OK or not really? If I develop a website template, CSS/HTML/JS, is it acceptable to post that as a code sample to be reviewed as an external URL?
8
votes
1answer
239 views

Where do high-level architecture and design questions go?

The FAQ states this: your question is not about … Higher-level architecture and design of software systems So, where should a high-level design question go?
13
votes
4answers
609 views

Project Euler Solutions

I was thinking that some of my python solutions to project Euler problems might be good candidates for code review - pretty short little programs that I've tried to write well, but would love to get ...